)]}'
{"api-ref/source/v2/routers.inc":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"a73e4c290cb6394571e163f17a617d41a1952536","unresolved":false,"context_lines":[{"line_number":233,"context_line":"   - external_fixed_ips: router-external_fixed_ips"},{"line_number":234,"context_line":"   - router_id: router_id"},{"line_number":235,"context_line":"   - description: description-request"},{"line_number":236,"context_line":"   - routes: router-routes-request"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"Request Example"},{"line_number":239,"context_line":"---------------"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"5f2577a7_6749e989","line":236,"updated":"2017-09-12 20:45:44.000000000","message":"Should we mention that these show up only when the extraroute extension is enabled [1]?\n\n[1] https://github.com/openstack/neutron/blob/master/neutron/extensions/extraroute.py","commit_id":"62897aa70c27dbf9902d08df51d0b944f131b8b6"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"87a5d874390a5e0ad630d11a081e3629a6fc0f54","unresolved":false,"context_lines":[{"line_number":233,"context_line":"   - external_fixed_ips: router-external_fixed_ips"},{"line_number":234,"context_line":"   - router_id: router_id"},{"line_number":235,"context_line":"   - description: description-request"},{"line_number":236,"context_line":"   - routes: router-routes-request"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"Request Example"},{"line_number":239,"context_line":"---------------"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"5f2577a7_8166aec0","line":236,"in_reply_to":"5f2577a7_6749e989","updated":"2017-09-15 15:02:38.000000000","message":"Yeah good comment; I def overlooked that.","commit_id":"62897aa70c27dbf9902d08df51d0b944f131b8b6"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"e86aff8f94a2e84e9e66ebd2b15cfd8281922e91","unresolved":false,"context_lines":[{"line_number":11,"context_line":"This resource is provided when ``router`` extension is enabled."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Extra routes extension"},{"line_number":14,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"The extra route extension (``extraroute``) extends ``router`` resources adding"},{"line_number":17,"context_line":"a ``routes`` attribute that contains an array of route object. Each route"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"5f2577a7_e4d44a22","line":14,"in_reply_to":"","updated":"2017-09-17 20:03:49.000000000","message":"It would be good to add \"(extraroute)\" at the end of this line.","commit_id":"f99d89760075086e9c43270e5d447668c4b54e24"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"619510d1f5164d8d864994cf07503dd2539eefa9","unresolved":false,"context_lines":[{"line_number":11,"context_line":"This resource is provided when ``router`` extension is enabled."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Extra routes extension"},{"line_number":14,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"The extra route extension (``extraroute``) extends ``router`` resources adding"},{"line_number":17,"context_line":"a ``routes`` attribute that contains an array of route object. Each route"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"5f2577a7_351dd873","line":14,"in_reply_to":"5f2577a7_e4d44a22","updated":"2017-09-18 11:08:37.000000000","message":"It\u0027s on the next line, but OK.","commit_id":"f99d89760075086e9c43270e5d447668c4b54e24"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"208944c7d9a60d8195e74b5f5894f1cee76f59ee","unresolved":false,"context_lines":[{"line_number":14,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"The extra route extension (``extraroute``) extends ``router`` resources adding"},{"line_number":17,"context_line":"a ``routes`` attribute that contains an array of route object. Each route"},{"line_number":18,"context_line":"object has a ``destination`` and ``nexthop`` attribute representing the route."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"List routers"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"5f2577a7_c40b8ed3","line":17,"in_reply_to":"","updated":"2017-09-17 19:37:42.000000000","message":"\"an array of route objectS\"","commit_id":"f99d89760075086e9c43270e5d447668c4b54e24"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"619510d1f5164d8d864994cf07503dd2539eefa9","unresolved":false,"context_lines":[{"line_number":14,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"The extra route extension (``extraroute``) extends ``router`` resources adding"},{"line_number":17,"context_line":"a ``routes`` attribute that contains an array of route object. Each route"},{"line_number":18,"context_line":"object has a ``destination`` and ``nexthop`` attribute representing the route."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"List routers"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"5f2577a7_f512b061","line":17,"in_reply_to":"5f2577a7_c40b8ed3","updated":"2017-09-18 11:08:37.000000000","message":"Done","commit_id":"f99d89760075086e9c43270e5d447668c4b54e24"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"208944c7d9a60d8195e74b5f5894f1cee76f59ee","unresolved":false,"context_lines":[{"line_number":241,"context_line":"   - router_id: router_id"},{"line_number":242,"context_line":"   - description: description-request"},{"line_number":243,"context_line":"   - routes: router-routes-request"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"Request Example"},{"line_number":246,"context_line":"---------------"},{"line_number":247,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"5f2577a7_64fa9abd","line":244,"updated":"2017-09-17 19:37:42.000000000","message":"This covers PUT, but isn\u0027t it needed for POST as well ?","commit_id":"f99d89760075086e9c43270e5d447668c4b54e24"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"38b5290016aabed83284c818c940d78b875f2c94","unresolved":false,"context_lines":[{"line_number":241,"context_line":"   - router_id: router_id"},{"line_number":242,"context_line":"   - description: description-request"},{"line_number":243,"context_line":"   - routes: router-routes-request"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"Request Example"},{"line_number":246,"context_line":"---------------"},{"line_number":247,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"5f2577a7_98f601d7","line":244,"in_reply_to":"5f2577a7_382b8d83","updated":"2017-09-18 11:32:49.000000000","message":"I\u0027m surprised, but you are definitly right wrt. to what you be in this change.\n\nI\u0027m curious about why it\u0027s allowed in PUT but not POST though...","commit_id":"f99d89760075086e9c43270e5d447668c4b54e24"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"619510d1f5164d8d864994cf07503dd2539eefa9","unresolved":false,"context_lines":[{"line_number":241,"context_line":"   - router_id: router_id"},{"line_number":242,"context_line":"   - description: description-request"},{"line_number":243,"context_line":"   - routes: router-routes-request"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"Request Example"},{"line_number":246,"context_line":"---------------"},{"line_number":247,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"5f2577a7_382b8d83","line":244,"in_reply_to":"5f2577a7_64fa9abd","updated":"2017-09-18 11:08:37.000000000","message":"Unless I\u0027m missing something, POST isn\u0027t supported: https://github.com/openstack/neutron-lib/blob/master/neutron_lib/api/definitions/extraroute.py#L34","commit_id":"f99d89760075086e9c43270e5d447668c4b54e24"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"859ab4a83a8123f9839208b09bc45a83a90d88a3","unresolved":false,"context_lines":[{"line_number":241,"context_line":"   - router_id: router_id"},{"line_number":242,"context_line":"   - description: description-request"},{"line_number":243,"context_line":"   - routes: router-routes-request"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"Request Example"},{"line_number":246,"context_line":"---------------"},{"line_number":247,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"ff5d4b2f_d82aef8e","line":244,"in_reply_to":"5f2577a7_98f601d7","updated":"2017-09-19 14:44:40.000000000","message":"The way the code is written in extraroute_db.py it almost seems like it should support update. However I\u0027m not familiar with the history so I can\u0027t answer why POST isn\u0027t allowed.","commit_id":"f99d89760075086e9c43270e5d447668c4b54e24"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"a5c5698ad6d8c4d5fc266d6190d7afdd1e67bcd2","unresolved":false,"context_lines":[{"line_number":241,"context_line":"   - router_id: router_id"},{"line_number":242,"context_line":"   - description: description-request"},{"line_number":243,"context_line":"   - routes: router-routes-request"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"Request Example"},{"line_number":246,"context_line":"---------------"},{"line_number":247,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"ff5d4b2f_d8030f0f","line":244,"in_reply_to":"ff5d4b2f_d82aef8e","updated":"2017-09-19 14:45:51.000000000","message":"Ack. Thanks.","commit_id":"f99d89760075086e9c43270e5d447668c4b54e24"}]}
