)]}'
{"api-ref/source/v2/bgpvpn-bgpvpns.inc":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"ad8c17eca67796cedae4c98c5e4bd242282a3d52","unresolved":false,"context_lines":[{"line_number":187,"context_line":"   - route_targets: bgpvpn-route_targets"},{"line_number":188,"context_line":"   - import_targets: bgpvpn-import_targets"},{"line_number":189,"context_line":"   - export_targets: bgpvpn-export_targets"},{"line_number":190,"context_line":"   - vni: bgpvpn-vni"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"Request Example"},{"line_number":193,"context_line":"---------------"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"ff5d4b2f_7b666054","line":190,"updated":"2017-09-19 13:44:35.000000000","message":"Based on the api def, PUT isn\u0027t supported for the vni attr::\n\n   \u0027allow_put\u0027: False","commit_id":"b49513f47f7ab6d4242148136d83865b751b2182"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"23607875383afbd6d5d34139eaecf79895150f93","unresolved":false,"context_lines":[{"line_number":187,"context_line":"   - route_targets: bgpvpn-route_targets"},{"line_number":188,"context_line":"   - import_targets: bgpvpn-import_targets"},{"line_number":189,"context_line":"   - export_targets: bgpvpn-export_targets"},{"line_number":190,"context_line":"   - vni: bgpvpn-vni"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"Request Example"},{"line_number":193,"context_line":"---------------"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"bf57530f_837acd85","line":190,"in_reply_to":"ff5d4b2f_07f5becb","updated":"2017-09-20 08:36:16.000000000","message":"good catch, boden, thanks!","commit_id":"b49513f47f7ab6d4242148136d83865b751b2182"},{"author":{"_account_id":25171,"name":"Deepthi V V","email":"deepthi.v.v@ericsson.com","username":"deepthivv88"},"change_message_id":"2a834541a1a6dd8e22bb34994b43084099cc5c64","unresolved":false,"context_lines":[{"line_number":187,"context_line":"   - route_targets: bgpvpn-route_targets"},{"line_number":188,"context_line":"   - import_targets: bgpvpn-import_targets"},{"line_number":189,"context_line":"   - export_targets: bgpvpn-export_targets"},{"line_number":190,"context_line":"   - vni: bgpvpn-vni"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"Request Example"},{"line_number":193,"context_line":"---------------"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"ff5d4b2f_07f5becb","line":190,"in_reply_to":"ff5d4b2f_7b666054","updated":"2017-09-19 17:14:11.000000000","message":"Corrected. PUT is not supported.","commit_id":"b49513f47f7ab6d4242148136d83865b751b2182"}],"api-ref/source/v2/bgpvpn-overview.inc":[{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"4a3e26f86ad34e42b7351a97893ef2817c765197","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5f2577a7_1a911c4f","updated":"2017-09-14 19:20:21.000000000","message":"To be more complete, we should perhaps indicate that VNI is an admin-only parameter (for both reading and writing).","commit_id":"52e7b9b170da890b9e190d731db8883c57161f3e"},{"author":{"_account_id":25171,"name":"Deepthi V V","email":"deepthi.v.v@ericsson.com","username":"deepthivv88"},"change_message_id":"67d33f6ed78eef9658055e38124c54f05c0e39ae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5f2577a7_7549205e","in_reply_to":"5f2577a7_1a911c4f","updated":"2017-09-18 10:22:54.000000000","message":"Done","commit_id":"52e7b9b170da890b9e190d731db8883c57161f3e"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"4a3e26f86ad34e42b7351a97893ef2817c765197","unresolved":false,"context_lines":[{"line_number":50,"context_line":"- \u003c4-byte AS#\u003e:\u003c16bit-number\u003e"},{"line_number":51,"context_line":"- \u003c4-byte IPv4\u003e:\u003c16bit-number\u003e"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"On VNI"},{"line_number":54,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"VXLAN is one option among others that could be used for BGP E-VPNs for instance"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"5f2577a7_3ad4d847","line":53,"range":{"start_line":53,"start_character":3,"end_line":53,"end_character":6},"updated":"2017-09-14 19:20:21.000000000","message":"\"VXLAN VNI\"","commit_id":"52e7b9b170da890b9e190d731db8883c57161f3e"},{"author":{"_account_id":25171,"name":"Deepthi V V","email":"deepthi.v.v@ericsson.com","username":"deepthivv88"},"change_message_id":"67d33f6ed78eef9658055e38124c54f05c0e39ae","unresolved":false,"context_lines":[{"line_number":50,"context_line":"- \u003c4-byte AS#\u003e:\u003c16bit-number\u003e"},{"line_number":51,"context_line":"- \u003c4-byte IPv4\u003e:\u003c16bit-number\u003e"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"On VNI"},{"line_number":54,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"VXLAN is one option among others that could be used for BGP E-VPNs for instance"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"5f2577a7_ddfc7cb6","line":53,"range":{"start_line":53,"start_character":3,"end_line":53,"end_character":6},"in_reply_to":"5f2577a7_3ad4d847","updated":"2017-09-18 10:22:54.000000000","message":"Done","commit_id":"52e7b9b170da890b9e190d731db8883c57161f3e"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"77ee05449db59f9832870d50fcad1d373bb4ffb3","unresolved":false,"context_lines":[{"line_number":53,"context_line":"On VNI"},{"line_number":54,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"VXLAN is one option among others that could be used for BGP E-VPNs for instance"},{"line_number":57,"context_line":"in the context of E-VPN [draft-ietf-bess-evpn-overlay]_. When VXLAN is used on a"},{"line_number":58,"context_line":"hardware platforms the use of a locally-assigned id may not be always possible"},{"line_number":59,"context_line":"which introduce the need to configure a globally-assigned VXLAN VNI."}],"source_content_type":"text/x-c++src","patch_set":2,"id":"5f2577a7_bec42a92","line":56,"updated":"2017-09-15 12:43:08.000000000","message":"Is this feature actually implemented today?\nI know this patch contains the api-def, but if there\u0027s not backing implementation yet we might clarify that here somehow, for example by saying \"NOTE: this feature is under development in the Queens release\" or something. Once the feature is done, such text can be removed.\n\n\nThe reason I say this is because this api-ref will be published as a public doc and users today may see it and think this feature is working/ready.","commit_id":"52e7b9b170da890b9e190d731db8883c57161f3e"},{"author":{"_account_id":25171,"name":"Deepthi V V","email":"deepthi.v.v@ericsson.com","username":"deepthivv88"},"change_message_id":"67d33f6ed78eef9658055e38124c54f05c0e39ae","unresolved":false,"context_lines":[{"line_number":53,"context_line":"On VNI"},{"line_number":54,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"VXLAN is one option among others that could be used for BGP E-VPNs for instance"},{"line_number":57,"context_line":"in the context of E-VPN [draft-ietf-bess-evpn-overlay]_. When VXLAN is used on a"},{"line_number":58,"context_line":"hardware platforms the use of a locally-assigned id may not be always possible"},{"line_number":59,"context_line":"which introduce the need to configure a globally-assigned VXLAN VNI."}],"source_content_type":"text/x-c++src","patch_set":2,"id":"5f2577a7_15ef7c1e","line":56,"in_reply_to":"5f2577a7_5901e004","updated":"2017-09-18 10:22:54.000000000","message":"Done","commit_id":"52e7b9b170da890b9e190d731db8883c57161f3e"},{"author":{"_account_id":25171,"name":"Deepthi V V","email":"deepthi.v.v@ericsson.com","username":"deepthivv88"},"change_message_id":"67d33f6ed78eef9658055e38124c54f05c0e39ae","unresolved":false,"context_lines":[{"line_number":53,"context_line":"On VNI"},{"line_number":54,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"VXLAN is one option among others that could be used for BGP E-VPNs for instance"},{"line_number":57,"context_line":"in the context of E-VPN [draft-ietf-bess-evpn-overlay]_. When VXLAN is used on a"},{"line_number":58,"context_line":"hardware platforms the use of a locally-assigned id may not be always possible"},{"line_number":59,"context_line":"which introduce the need to configure a globally-assigned VXLAN VNI."}],"source_content_type":"text/x-c++src","patch_set":2,"id":"5f2577a7_35ecb828","line":56,"in_reply_to":"5f2577a7_bec42a92","updated":"2017-09-18 10:22:54.000000000","message":"Done","commit_id":"52e7b9b170da890b9e190d731db8883c57161f3e"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"45fd5781fe3d38b7b252d2878140474b037d34ea","unresolved":false,"context_lines":[{"line_number":53,"context_line":"On VNI"},{"line_number":54,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"VXLAN is one option among others that could be used for BGP E-VPNs for instance"},{"line_number":57,"context_line":"in the context of E-VPN [draft-ietf-bess-evpn-overlay]_. When VXLAN is used on a"},{"line_number":58,"context_line":"hardware platforms the use of a locally-assigned id may not be always possible"},{"line_number":59,"context_line":"which introduce the need to configure a globally-assigned VXLAN VNI."}],"source_content_type":"text/x-c++src","patch_set":2,"id":"5f2577a7_5901e004","line":56,"in_reply_to":"5f2577a7_bec42a92","updated":"2017-09-15 13:36:55.000000000","message":"Yes, as discussed during the PTG, this is a good idea.","commit_id":"52e7b9b170da890b9e190d731db8883c57161f3e"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"4a3e26f86ad34e42b7351a97893ef2817c765197","unresolved":false,"context_lines":[{"line_number":53,"context_line":"On VNI"},{"line_number":54,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"VXLAN is one option among others that could be used for BGP E-VPNs for instance"},{"line_number":57,"context_line":"in the context of E-VPN [draft-ietf-bess-evpn-overlay]_. When VXLAN is used on a"},{"line_number":58,"context_line":"hardware platforms the use of a locally-assigned id may not be always possible"},{"line_number":59,"context_line":"which introduce the need to configure a globally-assigned VXLAN VNI."},{"line_number":60,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"5f2577a7_da439412","line":57,"range":{"start_line":56,"start_character":67,"end_line":57,"end_character":23},"updated":"2017-09-14 19:20:21.000000000","message":"useless","commit_id":"52e7b9b170da890b9e190d731db8883c57161f3e"},{"author":{"_account_id":25171,"name":"Deepthi V V","email":"deepthi.v.v@ericsson.com","username":"deepthivv88"},"change_message_id":"67d33f6ed78eef9658055e38124c54f05c0e39ae","unresolved":false,"context_lines":[{"line_number":53,"context_line":"On VNI"},{"line_number":54,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"VXLAN is one option among others that could be used for BGP E-VPNs for instance"},{"line_number":57,"context_line":"in the context of E-VPN [draft-ietf-bess-evpn-overlay]_. When VXLAN is used on a"},{"line_number":58,"context_line":"hardware platforms the use of a locally-assigned id may not be always possible"},{"line_number":59,"context_line":"which introduce the need to configure a globally-assigned VXLAN VNI."},{"line_number":60,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"5f2577a7_b54d483f","line":57,"range":{"start_line":56,"start_character":67,"end_line":57,"end_character":23},"in_reply_to":"5f2577a7_da439412","updated":"2017-09-18 10:22:54.000000000","message":"Removed.","commit_id":"52e7b9b170da890b9e190d731db8883c57161f3e"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"45fd5781fe3d38b7b252d2878140474b037d34ea","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"VXLAN is one option among others that could be used for BGP E-VPNs for instance"},{"line_number":57,"context_line":"in the context of E-VPN [draft-ietf-bess-evpn-overlay]_. When VXLAN is used on a"},{"line_number":58,"context_line":"hardware platforms the use of a locally-assigned id may not be always possible"},{"line_number":59,"context_line":"which introduce the need to configure a globally-assigned VXLAN VNI."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"The optional ``vni`` attribute allows the admin to enforce the use of a"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"5f2577a7_7917fc46","line":58,"range":{"start_line":58,"start_character":9,"end_line":58,"end_character":18},"updated":"2017-09-15 13:36:55.000000000","message":"platform","commit_id":"52e7b9b170da890b9e190d731db8883c57161f3e"},{"author":{"_account_id":25171,"name":"Deepthi V V","email":"deepthi.v.v@ericsson.com","username":"deepthivv88"},"change_message_id":"67d33f6ed78eef9658055e38124c54f05c0e39ae","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"VXLAN is one option among others that could be used for BGP E-VPNs for instance"},{"line_number":57,"context_line":"in the context of E-VPN [draft-ietf-bess-evpn-overlay]_. When VXLAN is used on a"},{"line_number":58,"context_line":"hardware platforms the use of a locally-assigned id may not be always possible"},{"line_number":59,"context_line":"which introduce the need to configure a globally-assigned VXLAN VNI."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"The optional ``vni`` attribute allows the admin to enforce the use of a"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"5f2577a7_bdbd30d9","line":58,"range":{"start_line":58,"start_character":9,"end_line":58,"end_character":18},"in_reply_to":"5f2577a7_7917fc46","updated":"2017-09-18 10:22:54.000000000","message":"Done","commit_id":"52e7b9b170da890b9e190d731db8883c57161f3e"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"4a3e26f86ad34e42b7351a97893ef2817c765197","unresolved":false,"context_lines":[{"line_number":56,"context_line":"VXLAN is one option among others that could be used for BGP E-VPNs for instance"},{"line_number":57,"context_line":"in the context of E-VPN [draft-ietf-bess-evpn-overlay]_. When VXLAN is used on a"},{"line_number":58,"context_line":"hardware platforms the use of a locally-assigned id may not be always possible"},{"line_number":59,"context_line":"which introduce the need to configure a globally-assigned VXLAN VNI."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"The optional ``vni`` attribute allows the admin to enforce the use of a"},{"line_number":62,"context_line":"chosen globally-assigned VXLAN VNI for the said BGPVPN."}],"source_content_type":"text/x-c++src","patch_set":2,"id":"5f2577a7_dacef4b2","line":59,"range":{"start_line":59,"start_character":6,"end_line":59,"end_character":15},"updated":"2017-09-14 19:20:21.000000000","message":"introduces","commit_id":"52e7b9b170da890b9e190d731db8883c57161f3e"},{"author":{"_account_id":25171,"name":"Deepthi V V","email":"deepthi.v.v@ericsson.com","username":"deepthivv88"},"change_message_id":"67d33f6ed78eef9658055e38124c54f05c0e39ae","unresolved":false,"context_lines":[{"line_number":56,"context_line":"VXLAN is one option among others that could be used for BGP E-VPNs for instance"},{"line_number":57,"context_line":"in the context of E-VPN [draft-ietf-bess-evpn-overlay]_. When VXLAN is used on a"},{"line_number":58,"context_line":"hardware platforms the use of a locally-assigned id may not be always possible"},{"line_number":59,"context_line":"which introduce the need to configure a globally-assigned VXLAN VNI."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"The optional ``vni`` attribute allows the admin to enforce the use of a"},{"line_number":62,"context_line":"chosen globally-assigned VXLAN VNI for the said BGPVPN."}],"source_content_type":"text/x-c++src","patch_set":2,"id":"5f2577a7_9dc27458","line":59,"range":{"start_line":59,"start_character":6,"end_line":59,"end_character":15},"in_reply_to":"5f2577a7_dacef4b2","updated":"2017-09-18 10:22:54.000000000","message":"Done","commit_id":"52e7b9b170da890b9e190d731db8883c57161f3e"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"4a3e26f86ad34e42b7351a97893ef2817c765197","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"The default when no VNI is specified and the VXLAN encapsulation is used, is"},{"line_number":65,"context_line":"to let the backend choose the VNI in advertised routes, and use the VNI in"},{"line_number":66,"context_line":"received routes for transmitted traffic"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"If the ``vni`` attribute is set for a BGPVPN, the following is enforced:"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"5f2577a7_3a6298af","line":66,"updated":"2017-09-14 19:20:21.000000000","message":"add \" (the latter being simply conforming to E-VPN overlay specs)\".","commit_id":"52e7b9b170da890b9e190d731db8883c57161f3e"},{"author":{"_account_id":25171,"name":"Deepthi V V","email":"deepthi.v.v@ericsson.com","username":"deepthivv88"},"change_message_id":"67d33f6ed78eef9658055e38124c54f05c0e39ae","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"The default when no VNI is specified and the VXLAN encapsulation is used, is"},{"line_number":65,"context_line":"to let the backend choose the VNI in advertised routes, and use the VNI in"},{"line_number":66,"context_line":"received routes for transmitted traffic"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"If the ``vni`` attribute is set for a BGPVPN, the following is enforced:"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"5f2577a7_d5f454f3","line":66,"in_reply_to":"5f2577a7_3a6298af","updated":"2017-09-18 10:22:54.000000000","message":"Done","commit_id":"52e7b9b170da890b9e190d731db8883c57161f3e"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"77ee05449db59f9832870d50fcad1d373bb4ffb3","unresolved":false,"context_lines":[{"line_number":65,"context_line":"to let the backend choose the VNI in advertised routes, and use the VNI in"},{"line_number":66,"context_line":"received routes for transmitted traffic"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"If the ``vni`` attribute is set for a BGPVPN, the following is enforced:"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"* the routes announced by the backend will advertise the specified VNI (this"},{"line_number":71,"context_line":"  relates to traffic sent from this BGP VPN to a Network or Router)"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"5f2577a7_9e528edd","line":68,"updated":"2017-09-15 12:43:08.000000000","message":"I think we should be cautious about how much detail we put here in the api ref. Today it seems we keep pretty high level details here; obviously related to the API level/user.\n\n\nIMHO it seems like we are starting to dig pretty deep here and I might suggest considering if some/most of this can go into the devref/docs in the bgpvpn project rather than here.","commit_id":"52e7b9b170da890b9e190d731db8883c57161f3e"},{"author":{"_account_id":25171,"name":"Deepthi V V","email":"deepthi.v.v@ericsson.com","username":"deepthivv88"},"change_message_id":"67d33f6ed78eef9658055e38124c54f05c0e39ae","unresolved":false,"context_lines":[{"line_number":65,"context_line":"to let the backend choose the VNI in advertised routes, and use the VNI in"},{"line_number":66,"context_line":"received routes for transmitted traffic"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"If the ``vni`` attribute is set for a BGPVPN, the following is enforced:"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"* the routes announced by the backend will advertise the specified VNI (this"},{"line_number":71,"context_line":"  relates to traffic sent from this BGP VPN to a Network or Router)"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"5f2577a7_95c36c89","line":68,"in_reply_to":"5f2577a7_592a007f","updated":"2017-09-18 10:22:54.000000000","message":"I agree Thomas and boden. It makes sense to add the implementation details to networking-bgpvpn project. I have kept the lines till 66 as it would give quick info on the behavior when no VNI attribute is used.","commit_id":"52e7b9b170da890b9e190d731db8883c57161f3e"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"45fd5781fe3d38b7b252d2878140474b037d34ea","unresolved":false,"context_lines":[{"line_number":65,"context_line":"to let the backend choose the VNI in advertised routes, and use the VNI in"},{"line_number":66,"context_line":"received routes for transmitted traffic"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"If the ``vni`` attribute is set for a BGPVPN, the following is enforced:"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"* the routes announced by the backend will advertise the specified VNI (this"},{"line_number":71,"context_line":"  relates to traffic sent from this BGP VPN to a Network or Router)"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"5f2577a7_592a007f","line":68,"in_reply_to":"5f2577a7_9e528edd","updated":"2017-09-15 13:36:55.000000000","message":"This information is relevant for admin users, not only for developers, but I certainly agree that we can move it to the bgpvpn project documentation.\n\nWe could keep the text only up to line 62, and drop the rest from this change.","commit_id":"52e7b9b170da890b9e190d731db8883c57161f3e"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"4a3e26f86ad34e42b7351a97893ef2817c765197","unresolved":false,"context_lines":[{"line_number":70,"context_line":"* the routes announced by the backend will advertise the specified VNI (this"},{"line_number":71,"context_line":"  relates to traffic sent from this BGP VPN to a Network or Router)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"* the routes received by the backend and that would be used to send traffic to"},{"line_number":74,"context_line":"  the BGP VPN will not be used if they carry a different VNI than the VNI"},{"line_number":75,"context_line":"  specified for the BGPVPN (this relates to traffic sent from a Network or"},{"line_number":76,"context_line":"  Router to the BGP VPN)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"In the case of a Network or Router associated to multiple BGPVPNs, the check"},{"line_number":79,"context_line":"in the second bullet in the previous paragraph is done as follows:"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"* when a route is imported, for each BGPVPN associated to the Network or"},{"line_number":82,"context_line":"  Router and having a VNI defined:"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"  * the set of Route Targets of the route is intersected with the import_rts of"},{"line_number":85,"context_line":"    the BGPVPN"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"  * if this intersection is non-empty the ``vni`` of the BGPVPN is retained"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"* the route is used to establish connectivity to the destination in the"},{"line_number":90,"context_line":"  forwarding plane only if the advertised VNI is equal to all retained"},{"line_number":91,"context_line":"  VNIs in the previous step"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"The above check is applied similarly for a Router associated to multiple BGP"},{"line_number":94,"context_line":"VPN."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"The backend is expected provide troubleshooting information for the cases when"},{"line_number":97,"context_line":"a route ends up not being used because the VNI checked failed."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"Valid range for the ``vni`` attribute is [1, 2^24-1]."},{"line_number":100,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"5f2577a7_bad1e825","line":97,"range":{"start_line":73,"start_character":0,"end_line":97,"end_character":62},"updated":"2017-09-14 19:20:21.000000000","message":"This is something which indeed we had written in the past.\nI\u0027m still pondering whether this is the right thing or not, or if we should make this specific part and optional behavior controlled by another parameter (e.g. \u0027strict_vni\u0027).","commit_id":"52e7b9b170da890b9e190d731db8883c57161f3e"},{"author":{"_account_id":25171,"name":"Deepthi V V","email":"deepthi.v.v@ericsson.com","username":"deepthivv88"},"change_message_id":"67d33f6ed78eef9658055e38124c54f05c0e39ae","unresolved":false,"context_lines":[{"line_number":70,"context_line":"* the routes announced by the backend will advertise the specified VNI (this"},{"line_number":71,"context_line":"  relates to traffic sent from this BGP VPN to a Network or Router)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"* the routes received by the backend and that would be used to send traffic to"},{"line_number":74,"context_line":"  the BGP VPN will not be used if they carry a different VNI than the VNI"},{"line_number":75,"context_line":"  specified for the BGPVPN (this relates to traffic sent from a Network or"},{"line_number":76,"context_line":"  Router to the BGP VPN)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"In the case of a Network or Router associated to multiple BGPVPNs, the check"},{"line_number":79,"context_line":"in the second bullet in the previous paragraph is done as follows:"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"* when a route is imported, for each BGPVPN associated to the Network or"},{"line_number":82,"context_line":"  Router and having a VNI defined:"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"  * the set of Route Targets of the route is intersected with the import_rts of"},{"line_number":85,"context_line":"    the BGPVPN"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"  * if this intersection is non-empty the ``vni`` of the BGPVPN is retained"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"* the route is used to establish connectivity to the destination in the"},{"line_number":90,"context_line":"  forwarding plane only if the advertised VNI is equal to all retained"},{"line_number":91,"context_line":"  VNIs in the previous step"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"The above check is applied similarly for a Router associated to multiple BGP"},{"line_number":94,"context_line":"VPN."},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"The backend is expected provide troubleshooting information for the cases when"},{"line_number":97,"context_line":"a route ends up not being used because the VNI checked failed."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"Valid range for the ``vni`` attribute is [1, 2^24-1]."},{"line_number":100,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"5f2577a7_f53f5084","line":97,"range":{"start_line":73,"start_character":0,"end_line":97,"end_character":62},"in_reply_to":"5f2577a7_bad1e825","updated":"2017-09-18 10:22:54.000000000","message":"We will take it up in networking-bgpvpn code change review.","commit_id":"52e7b9b170da890b9e190d731db8883c57161f3e"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"8ec77f6457c2018375921850a4493b44a76c7f0a","unresolved":false,"context_lines":[{"line_number":53,"context_line":"On VXLAN VNI"},{"line_number":54,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"NOTE: this feature is under development in the Queens release"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"VXLAN is one option among others that could be used for BGP E-VPNs."},{"line_number":59,"context_line":"When VXLAN is used on a hardware platform the use of a locally-assigned id"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"5f2577a7_64160c4c","line":56,"range":{"start_line":56,"start_character":0,"end_line":56,"end_character":61},"updated":"2017-09-18 14:03:48.000000000","message":"Wops. We should use a sphinx note to make this pretty.","commit_id":"cec4829737c3d853eef8fecea600f0ed27913b5c"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"78b567f38e6f8039148276d8860ed25b30fa8516","unresolved":false,"context_lines":[{"line_number":53,"context_line":"On VXLAN VNI"},{"line_number":54,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"NOTE: this feature is under development in the Queens release"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"VXLAN is one option among others that could be used for BGP E-VPNs."},{"line_number":59,"context_line":"When VXLAN is used on a hardware platform the use of a locally-assigned id"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"5f2577a7_e471dca9","line":56,"range":{"start_line":56,"start_character":0,"end_line":56,"end_character":61},"in_reply_to":"5f2577a7_64160c4c","updated":"2017-09-18 14:06:30.000000000","message":"Like this:\n\n.. note:: this feature is under development in \n   the Queens release","commit_id":"cec4829737c3d853eef8fecea600f0ed27913b5c"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"cd09c198b5ba7cf1c18f8eb415e687ba2c7de2cb","unresolved":false,"context_lines":[{"line_number":69,"context_line":"received routes for transmitted traffic. The backend will conform to"},{"line_number":70,"context_line":"E-VPN overlay specs."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Valid range for the ``vni`` attribute is [1, 2^24-1]."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":75,"context_line":"BGP - MPLS VPN Caveats"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"bf57530f_83664d51","line":72,"range":{"start_line":72,"start_character":41,"end_line":72,"end_character":53},"updated":"2017-09-20 08:43:07.000000000","message":"This will be even more pretty:\n\n   Valid range for the ``vni`` attribute is [1, 2\\ :sup:`24`\\ -1].","commit_id":"58b3bb052bcf9a6600386693f2441e81c487ecae"},{"author":{"_account_id":25171,"name":"Deepthi V V","email":"deepthi.v.v@ericsson.com","username":"deepthivv88"},"change_message_id":"49328916970a7f8890e0cff3f64c3b5a3f26fc80","unresolved":false,"context_lines":[{"line_number":69,"context_line":"received routes for transmitted traffic. The backend will conform to"},{"line_number":70,"context_line":"E-VPN overlay specs."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"Valid range for the ``vni`` attribute is [1, 2^24-1]."},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":75,"context_line":"BGP - MPLS VPN Caveats"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"bf57530f_543a49e7","line":72,"range":{"start_line":72,"start_character":41,"end_line":72,"end_character":53},"in_reply_to":"bf57530f_83664d51","updated":"2017-09-20 12:30:25.000000000","message":"Done","commit_id":"58b3bb052bcf9a6600386693f2441e81c487ecae"}],"api-ref/source/v2/parameters.yaml":[{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"ac44043a5cfb51b28799427ed5b6f556f6ee8df4","unresolved":false,"context_lines":[{"line_number":830,"context_line":"  type: integer"},{"line_number":831,"context_line":"bgpvpn-vni-required:"},{"line_number":832,"context_line":"  description: |"},{"line_number":833,"context_line":"      The globally-assigned VXLAN ``vni`` for the BGP VPN."},{"line_number":834,"context_line":"  in: body"},{"line_number":835,"context_line":"  required: true"},{"line_number":836,"context_line":"  type: integer"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bf57530f_beb4c636","line":833,"range":{"start_line":833,"start_character":6,"end_line":833,"end_character":58},"updated":"2017-09-20 08:55:48.000000000","message":"this should be more details than description above","commit_id":"58b3bb052bcf9a6600386693f2441e81c487ecae"},{"author":{"_account_id":25171,"name":"Deepthi V V","email":"deepthi.v.v@ericsson.com","username":"deepthivv88"},"change_message_id":"49328916970a7f8890e0cff3f64c3b5a3f26fc80","unresolved":false,"context_lines":[{"line_number":830,"context_line":"  type: integer"},{"line_number":831,"context_line":"bgpvpn-vni-required:"},{"line_number":832,"context_line":"  description: |"},{"line_number":833,"context_line":"      The globally-assigned VXLAN ``vni`` for the BGP VPN."},{"line_number":834,"context_line":"  in: body"},{"line_number":835,"context_line":"  required: true"},{"line_number":836,"context_line":"  type: integer"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bf57530f_7d453170","line":833,"range":{"start_line":833,"start_character":6,"end_line":833,"end_character":58},"in_reply_to":"bf57530f_beb4c636","updated":"2017-09-20 12:30:25.000000000","message":"Tovin, are you referring to providing information about whether attribute is mandatory?","commit_id":"58b3bb052bcf9a6600386693f2441e81c487ecae"}],"api-ref/source/v2/samples/bgpvpn/bgpvpns/bgpvpn-create-request.json":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"ad8c17eca67796cedae4c98c5e4bd242282a3d52","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    \"export_targets\": \"64512:1666\","},{"line_number":7,"context_line":"    \"route_distinguishers\": [\"64512:1777\", \"64512:1888\", \"64512:1999\"],"},{"line_number":8,"context_line":"    \"type\": \"l3\","},{"line_number":9,"context_line":"    \"vni\": \"1000\""},{"line_number":10,"context_line":"  }"},{"line_number":11,"context_line":"}"}],"source_content_type":"application/json","patch_set":5,"id":"ff5d4b2f_db478cbc","line":9,"range":{"start_line":9,"start_character":12,"end_line":9,"end_character":16},"updated":"2017-09-19 13:44:35.000000000","message":"Based on the params and api def I think these should be int rather than string.","commit_id":"b49513f47f7ab6d4242148136d83865b751b2182"},{"author":{"_account_id":25171,"name":"Deepthi V V","email":"deepthi.v.v@ericsson.com","username":"deepthivv88"},"change_message_id":"2a834541a1a6dd8e22bb34994b43084099cc5c64","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    \"export_targets\": \"64512:1666\","},{"line_number":7,"context_line":"    \"route_distinguishers\": [\"64512:1777\", \"64512:1888\", \"64512:1999\"],"},{"line_number":8,"context_line":"    \"type\": \"l3\","},{"line_number":9,"context_line":"    \"vni\": \"1000\""},{"line_number":10,"context_line":"  }"},{"line_number":11,"context_line":"}"}],"source_content_type":"application/json","patch_set":5,"id":"ff5d4b2f_a736f2b3","line":9,"range":{"start_line":9,"start_character":12,"end_line":9,"end_character":16},"in_reply_to":"ff5d4b2f_db478cbc","updated":"2017-09-19 17:14:11.000000000","message":"Done","commit_id":"b49513f47f7ab6d4242148136d83865b751b2182"}],"api-ref/source/v2/samples/bgpvpn/bgpvpns/bgpvpn-create-response.json":[{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"23607875383afbd6d5d34139eaecf79895150f93","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    \"type\": \"l3\","},{"line_number":22,"context_line":"    \"id\": \"0f9d472a-908f-40f5-8574-b4e8a63ccbf0\","},{"line_number":23,"context_line":"    \"networks\": [],"},{"line_number":24,"context_line":"    \"vni\": \"1000\""},{"line_number":25,"context_line":"  }"},{"line_number":26,"context_line":"}"}],"source_content_type":"application/json","patch_set":5,"id":"bf57530f_233b21d2","line":24,"range":{"start_line":24,"start_character":11,"end_line":24,"end_character":17},"updated":"2017-09-20 08:36:16.000000000","message":"What boden spotted for create applies here as well: int.","commit_id":"b49513f47f7ab6d4242148136d83865b751b2182"},{"author":{"_account_id":25171,"name":"Deepthi V V","email":"deepthi.v.v@ericsson.com","username":"deepthivv88"},"change_message_id":"49328916970a7f8890e0cff3f64c3b5a3f26fc80","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    \"type\": \"l3\","},{"line_number":22,"context_line":"    \"id\": \"0f9d472a-908f-40f5-8574-b4e8a63ccbf0\","},{"line_number":23,"context_line":"    \"networks\": [],"},{"line_number":24,"context_line":"    \"vni\": \"1000\""},{"line_number":25,"context_line":"  }"},{"line_number":26,"context_line":"}"}],"source_content_type":"application/json","patch_set":5,"id":"bf57530f_147611da","line":24,"range":{"start_line":24,"start_character":11,"end_line":24,"end_character":17},"in_reply_to":"bf57530f_233b21d2","updated":"2017-09-20 12:30:25.000000000","message":"Done in patch set 6.","commit_id":"b49513f47f7ab6d4242148136d83865b751b2182"}],"api-ref/source/v2/samples/bgpvpn/bgpvpns/bgpvpn-show-response.json":[{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"23607875383afbd6d5d34139eaecf79895150f93","unresolved":false,"context_lines":[{"line_number":13,"context_line":"       \"networks\": ["},{"line_number":14,"context_line":"         \"a4f2b8df-cb42-4893-a333-d0b5c36ade17\""},{"line_number":15,"context_line":"       ],"},{"line_number":16,"context_line":"      \"vni\": \"1000\""},{"line_number":17,"context_line":"    }"},{"line_number":18,"context_line":"}"}],"source_content_type":"application/json","patch_set":5,"id":"bf57530f_03381dd1","line":16,"range":{"start_line":16,"start_character":14,"end_line":16,"end_character":18},"updated":"2017-09-20 08:36:16.000000000","message":"What boden spotted for create applies here as well: int.","commit_id":"b49513f47f7ab6d4242148136d83865b751b2182"},{"author":{"_account_id":25171,"name":"Deepthi V V","email":"deepthi.v.v@ericsson.com","username":"deepthivv88"},"change_message_id":"49328916970a7f8890e0cff3f64c3b5a3f26fc80","unresolved":false,"context_lines":[{"line_number":13,"context_line":"       \"networks\": ["},{"line_number":14,"context_line":"         \"a4f2b8df-cb42-4893-a333-d0b5c36ade17\""},{"line_number":15,"context_line":"       ],"},{"line_number":16,"context_line":"      \"vni\": \"1000\""},{"line_number":17,"context_line":"    }"},{"line_number":18,"context_line":"}"}],"source_content_type":"application/json","patch_set":5,"id":"bf57530f_f4725de3","line":16,"range":{"start_line":16,"start_character":14,"end_line":16,"end_character":18},"in_reply_to":"bf57530f_03381dd1","updated":"2017-09-20 12:30:25.000000000","message":"Done in patch set 6.","commit_id":"b49513f47f7ab6d4242148136d83865b751b2182"}],"api-ref/source/v2/samples/bgpvpn/bgpvpns/bgpvpn-update-response.json":[{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"23607875383afbd6d5d34139eaecf79895150f93","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    \"type\": \"l3\","},{"line_number":13,"context_line":"    \"id\": \"4d627abf-06dd-45ab-920b-8e61422bb984\","},{"line_number":14,"context_line":"    \"networks\": [],"},{"line_number":15,"context_line":"    \"vni\": \"1000\""},{"line_number":16,"context_line":"  }"},{"line_number":17,"context_line":"}"}],"source_content_type":"application/json","patch_set":5,"id":"bf57530f_a34cb176","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":17},"updated":"2017-09-20 08:36:16.000000000","message":"What boden spotted for create applies here as well: int.","commit_id":"b49513f47f7ab6d4242148136d83865b751b2182"},{"author":{"_account_id":25171,"name":"Deepthi V V","email":"deepthi.v.v@ericsson.com","username":"deepthivv88"},"change_message_id":"49328916970a7f8890e0cff3f64c3b5a3f26fc80","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    \"type\": \"l3\","},{"line_number":13,"context_line":"    \"id\": \"4d627abf-06dd-45ab-920b-8e61422bb984\","},{"line_number":14,"context_line":"    \"networks\": [],"},{"line_number":15,"context_line":"    \"vni\": \"1000\""},{"line_number":16,"context_line":"  }"},{"line_number":17,"context_line":"}"}],"source_content_type":"application/json","patch_set":5,"id":"bf57530f_b47ce5b5","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":17},"in_reply_to":"bf57530f_a34cb176","updated":"2017-09-20 12:30:25.000000000","message":"Done in patch set 6.","commit_id":"b49513f47f7ab6d4242148136d83865b751b2182"}],"api-ref/source/v2/samples/bgpvpn/bgpvpns/bgpvpns-list-response.json":[{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"23607875383afbd6d5d34139eaecf79895150f93","unresolved":false,"context_lines":[{"line_number":22,"context_line":"      \"type\": \"l3\","},{"line_number":23,"context_line":"      \"id\": \"0f9d472a-908f-40f5-8574-b4e8a63ccbf0\","},{"line_number":24,"context_line":"      \"networks\": [],"},{"line_number":25,"context_line":"      \"vni\": \"1000\""},{"line_number":26,"context_line":"    }"},{"line_number":27,"context_line":"  ]"},{"line_number":28,"context_line":"}"}],"source_content_type":"application/json","patch_set":5,"id":"bf57530f_8351ad11","line":25,"range":{"start_line":25,"start_character":18,"end_line":25,"end_character":19},"updated":"2017-09-20 08:36:16.000000000","message":"What boden spotted for create applies here as well: int.","commit_id":"b49513f47f7ab6d4242148136d83865b751b2182"},{"author":{"_account_id":25171,"name":"Deepthi V V","email":"deepthi.v.v@ericsson.com","username":"deepthivv88"},"change_message_id":"49328916970a7f8890e0cff3f64c3b5a3f26fc80","unresolved":false,"context_lines":[{"line_number":22,"context_line":"      \"type\": \"l3\","},{"line_number":23,"context_line":"      \"id\": \"0f9d472a-908f-40f5-8574-b4e8a63ccbf0\","},{"line_number":24,"context_line":"      \"networks\": [],"},{"line_number":25,"context_line":"      \"vni\": \"1000\""},{"line_number":26,"context_line":"    }"},{"line_number":27,"context_line":"  ]"},{"line_number":28,"context_line":"}"}],"source_content_type":"application/json","patch_set":5,"id":"bf57530f_344a3580","line":25,"range":{"start_line":25,"start_character":18,"end_line":25,"end_character":19},"in_reply_to":"bf57530f_8351ad11","updated":"2017-09-20 12:30:25.000000000","message":"Done in patch set 6.","commit_id":"b49513f47f7ab6d4242148136d83865b751b2182"}],"neutron_lib/api/definitions/bgpvpn_vni.py":[{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"4a3e26f86ad34e42b7351a97893ef2817c765197","unresolved":false,"context_lines":[{"line_number":48,"context_line":"API_PREFIX \u003d \u0027\u0027"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"# The description of the extension."},{"line_number":51,"context_line":"DESCRIPTION \u003d \"BGPVPN VNI Extension\""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"# A timestamp of when the extension was introduced."},{"line_number":54,"context_line":"UPDATED_TIMESTAMP \u003d \"2017-09-12T10:00:00-00:00\""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f2577a7_a311ce06","line":51,"range":{"start_line":51,"start_character":0,"end_line":51,"end_character":36},"updated":"2017-09-14 19:20:21.000000000","message":"I think we could, as a description, use \"BGPVPN VXLAN VNI extension\", so that people can find out in which scope the \u0027VNI\u0027 acronym needs to be resolved.","commit_id":"52e7b9b170da890b9e190d731db8883c57161f3e"},{"author":{"_account_id":25171,"name":"Deepthi V V","email":"deepthi.v.v@ericsson.com","username":"deepthivv88"},"change_message_id":"67d33f6ed78eef9658055e38124c54f05c0e39ae","unresolved":false,"context_lines":[{"line_number":48,"context_line":"API_PREFIX \u003d \u0027\u0027"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"# The description of the extension."},{"line_number":51,"context_line":"DESCRIPTION \u003d \"BGPVPN VNI Extension\""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"# A timestamp of when the extension was introduced."},{"line_number":54,"context_line":"UPDATED_TIMESTAMP \u003d \"2017-09-12T10:00:00-00:00\""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f2577a7_4278a9c2","line":51,"range":{"start_line":51,"start_character":0,"end_line":51,"end_character":36},"in_reply_to":"5f2577a7_a311ce06","updated":"2017-09-18 10:22:54.000000000","message":"Done","commit_id":"52e7b9b170da890b9e190d731db8883c57161f3e"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"a2c8d706238e1dad05f6ef1485f1d1a1799ff49c","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {"},{"line_number":58,"context_line":"    bgpvpn.COLLECTION_NAME: {"},{"line_number":59,"context_line":"        VNI: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":60,"context_line":"              \u0027convert_to\u0027: lib_converters.convert_to_int_if_not_none,"},{"line_number":61,"context_line":"              \u0027validate\u0027: {\u0027type:range_or_none\u0027: [constants.MIN_VXLAN_VNI,"},{"line_number":62,"context_line":"                                                  constants.MAX_VXLAN_VNI]"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f2577a7_c575ec65","line":59,"range":{"start_line":59,"start_character":47,"end_line":59,"end_character":51},"updated":"2017-09-15 01:40:02.000000000","message":"This is something that is worth discussing:\nfrom an implementation standpoint, it won\u0027t be that easy to change the vni of a BGPVPN implemented with linuxbridge, because the VNI of a VXLAN link is read-only, and removing/adding will have side effects.\n\nIs there a use case for making this attribute read-write ?","commit_id":"52e7b9b170da890b9e190d731db8883c57161f3e"},{"author":{"_account_id":25171,"name":"Deepthi V V","email":"deepthi.v.v@ericsson.com","username":"deepthivv88"},"change_message_id":"67d33f6ed78eef9658055e38124c54f05c0e39ae","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {"},{"line_number":58,"context_line":"    bgpvpn.COLLECTION_NAME: {"},{"line_number":59,"context_line":"        VNI: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":60,"context_line":"              \u0027convert_to\u0027: lib_converters.convert_to_int_if_not_none,"},{"line_number":61,"context_line":"              \u0027validate\u0027: {\u0027type:range_or_none\u0027: [constants.MIN_VXLAN_VNI,"},{"line_number":62,"context_line":"                                                  constants.MAX_VXLAN_VNI]"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f2577a7_c2325910","line":59,"range":{"start_line":59,"start_character":47,"end_line":59,"end_character":51},"in_reply_to":"5f2577a7_c575ec65","updated":"2017-09-18 10:22:54.000000000","message":"I agree Thomas. Will restrict the attribute to read-only.","commit_id":"52e7b9b170da890b9e190d731db8883c57161f3e"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"4a3e26f86ad34e42b7351a97893ef2817c765197","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    bgpvpn.COLLECTION_NAME: {"},{"line_number":59,"context_line":"        VNI: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":60,"context_line":"              \u0027convert_to\u0027: lib_converters.convert_to_int_if_not_none,"},{"line_number":61,"context_line":"              \u0027validate\u0027: {\u0027type:range_or_none\u0027: [constants.MIN_VXLAN_VNI,"},{"line_number":62,"context_line":"                                                  constants.MAX_VXLAN_VNI]"},{"line_number":63,"context_line":"                           },"},{"line_number":64,"context_line":"              \u0027is_visible\u0027: True, \u0027enforce_policy\u0027: True},"},{"line_number":65,"context_line":"    },"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f2577a7_5ad564e4","line":62,"range":{"start_line":61,"start_character":50,"end_line":62,"end_character":73},"updated":"2017-09-14 19:20:21.000000000","message":"Are these added by this change ?\n(I would expect these values to be already defined somewhere, we can perhaps search for that and reuse?)","commit_id":"52e7b9b170da890b9e190d731db8883c57161f3e"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"3676cd31680422a858e13d4cfa3f34ad98728e18","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    bgpvpn.COLLECTION_NAME: {"},{"line_number":59,"context_line":"        VNI: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":60,"context_line":"              \u0027convert_to\u0027: lib_converters.convert_to_int_if_not_none,"},{"line_number":61,"context_line":"              \u0027validate\u0027: {\u0027type:range_or_none\u0027: [constants.MIN_VXLAN_VNI,"},{"line_number":62,"context_line":"                                                  constants.MAX_VXLAN_VNI]"},{"line_number":63,"context_line":"                           },"},{"line_number":64,"context_line":"              \u0027is_visible\u0027: True, \u0027enforce_policy\u0027: True},"},{"line_number":65,"context_line":"    },"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f2577a7_9a3d0c2d","line":62,"range":{"start_line":61,"start_character":50,"end_line":62,"end_character":73},"in_reply_to":"5f2577a7_5ad564e4","updated":"2017-09-14 19:22:53.000000000","message":"Forget the above, for some reason my eyes and eyes socket were misaligned...","commit_id":"52e7b9b170da890b9e190d731db8883c57161f3e"},{"author":{"_account_id":25171,"name":"Deepthi V V","email":"deepthi.v.v@ericsson.com","username":"deepthivv88"},"change_message_id":"67d33f6ed78eef9658055e38124c54f05c0e39ae","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    bgpvpn.COLLECTION_NAME: {"},{"line_number":59,"context_line":"        VNI: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":60,"context_line":"              \u0027convert_to\u0027: lib_converters.convert_to_int_if_not_none,"},{"line_number":61,"context_line":"              \u0027validate\u0027: {\u0027type:range_or_none\u0027: [constants.MIN_VXLAN_VNI,"},{"line_number":62,"context_line":"                                                  constants.MAX_VXLAN_VNI]"},{"line_number":63,"context_line":"                           },"},{"line_number":64,"context_line":"              \u0027is_visible\u0027: True, \u0027enforce_policy\u0027: True},"},{"line_number":65,"context_line":"    },"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f2577a7_a2206dad","line":62,"range":{"start_line":61,"start_character":50,"end_line":62,"end_character":73},"in_reply_to":"5f2577a7_5ad564e4","updated":"2017-09-18 10:22:54.000000000","message":"Yes they are defined in neutron_lib/constants.py.","commit_id":"52e7b9b170da890b9e190d731db8883c57161f3e"}],"neutron_lib/tests/unit/api/definitions/test_bgpvpn_vni.py":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"77ee05449db59f9832870d50fcad1d373bb4ffb3","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class BgpvpnDefinitionTestCase(base.DefinitionBaseTestCase):"},{"line_number":23,"context_line":"    extension_module \u003d bgpvpn_vni"},{"line_number":24,"context_line":"    extension_resources \u003d (bgpvpn.COLLECTION_NAME,)"},{"line_number":25,"context_line":"    extension_attributes \u003d (\u0027vni\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f2577a7_1e7c5e70","line":24,"range":{"start_line":24,"start_character":27,"end_line":24,"end_character":49},"updated":"2017-09-15 12:43:08.000000000","message":"Is this needed? I didn\u0027t think the def was introducing a new resource.","commit_id":"52e7b9b170da890b9e190d731db8883c57161f3e"},{"author":{"_account_id":25171,"name":"Deepthi V V","email":"deepthi.v.v@ericsson.com","username":"deepthivv88"},"change_message_id":"67d33f6ed78eef9658055e38124c54f05c0e39ae","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class BgpvpnDefinitionTestCase(base.DefinitionBaseTestCase):"},{"line_number":23,"context_line":"    extension_module \u003d bgpvpn_vni"},{"line_number":24,"context_line":"    extension_resources \u003d (bgpvpn.COLLECTION_NAME,)"},{"line_number":25,"context_line":"    extension_attributes \u003d (\u0027vni\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f2577a7_02a98122","line":24,"range":{"start_line":24,"start_character":27,"end_line":24,"end_character":49},"in_reply_to":"5f2577a7_1e7c5e70","updated":"2017-09-18 10:22:54.000000000","message":"Done","commit_id":"52e7b9b170da890b9e190d731db8883c57161f3e"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"77ee05449db59f9832870d50fcad1d373bb4ffb3","unresolved":false,"context_lines":[{"line_number":22,"context_line":"class BgpvpnDefinitionTestCase(base.DefinitionBaseTestCase):"},{"line_number":23,"context_line":"    extension_module \u003d bgpvpn_vni"},{"line_number":24,"context_line":"    extension_resources \u003d (bgpvpn.COLLECTION_NAME,)"},{"line_number":25,"context_line":"    extension_attributes \u003d (\u0027vni\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f2577a7_fe807248","line":25,"range":{"start_line":25,"start_character":29,"end_line":25,"end_character":32},"updated":"2017-09-15 12:43:08.000000000","message":"IMO better to use bgpvpn.VNI","commit_id":"52e7b9b170da890b9e190d731db8883c57161f3e"},{"author":{"_account_id":25171,"name":"Deepthi V V","email":"deepthi.v.v@ericsson.com","username":"deepthivv88"},"change_message_id":"67d33f6ed78eef9658055e38124c54f05c0e39ae","unresolved":false,"context_lines":[{"line_number":22,"context_line":"class BgpvpnDefinitionTestCase(base.DefinitionBaseTestCase):"},{"line_number":23,"context_line":"    extension_module \u003d bgpvpn_vni"},{"line_number":24,"context_line":"    extension_resources \u003d (bgpvpn.COLLECTION_NAME,)"},{"line_number":25,"context_line":"    extension_attributes \u003d (\u0027vni\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f2577a7_e2a55548","line":25,"range":{"start_line":25,"start_character":29,"end_line":25,"end_character":32},"in_reply_to":"5f2577a7_fe807248","updated":"2017-09-18 10:22:54.000000000","message":"Done","commit_id":"52e7b9b170da890b9e190d731db8883c57161f3e"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"ad8c17eca67796cedae4c98c5e4bd242282a3d52","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class BgpvpnDefinitionTestCase(base.DefinitionBaseTestCase):"},{"line_number":23,"context_line":"    extension_module \u003d bgpvpn_vni"},{"line_number":24,"context_line":"    extension_resources \u003d (bgpvpn.COLLECTION_NAME,)"},{"line_number":25,"context_line":"    extension_attributes \u003d (bgpvpn_vni.VNI,)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff5d4b2f_fb9ed052","line":24,"range":{"start_line":24,"start_character":27,"end_line":24,"end_character":49},"updated":"2017-09-19 13:44:35.000000000","message":"Didn\u0027t we decide this wasn\u0027t needed since the extension doesn\u0027t actually introduce the resource?","commit_id":"b49513f47f7ab6d4242148136d83865b751b2182"},{"author":{"_account_id":25171,"name":"Deepthi V V","email":"deepthi.v.v@ericsson.com","username":"deepthivv88"},"change_message_id":"2a834541a1a6dd8e22bb34994b43084099cc5c64","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class BgpvpnDefinitionTestCase(base.DefinitionBaseTestCase):"},{"line_number":23,"context_line":"    extension_module \u003d bgpvpn_vni"},{"line_number":24,"context_line":"    extension_resources \u003d (bgpvpn.COLLECTION_NAME,)"},{"line_number":25,"context_line":"    extension_attributes \u003d (bgpvpn_vni.VNI,)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff5d4b2f_c7a8c678","line":24,"range":{"start_line":24,"start_character":27,"end_line":24,"end_character":49},"in_reply_to":"ff5d4b2f_fb9ed052","updated":"2017-09-19 17:14:11.000000000","message":"The test neutron_lib.tests.unit.api.definitions.base.DefinitionBaseTestCase#test_resource_map uses neutron_lib/api/definitions/base.py#KNOWN_RESOURCES. This does not include bgpvpn and hence we need to explicitly add it through extension_resources.","commit_id":"b49513f47f7ab6d4242148136d83865b751b2182"}],"releasenotes/notes/add-vni-to-bgpvpn-7531df9fa4f8955b.yaml":[{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"4a3e26f86ad34e42b7351a97893ef2817c765197","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Add VNI attribute to BGPVPN table"},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - |"},{"line_number":6,"context_line":"    The ``bgpvpn-vni`` API extension adds VNI attribute to base ``bgpvpn``"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f2577a7_1a96bc40","line":3,"range":{"start_line":2,"start_character":0,"end_line":3,"end_character":37},"updated":"2017-09-14 19:20:21.000000000","message":"You can remove this part and only keep feature.","commit_id":"52e7b9b170da890b9e190d731db8883c57161f3e"},{"author":{"_account_id":25171,"name":"Deepthi V V","email":"deepthi.v.v@ericsson.com","username":"deepthivv88"},"change_message_id":"67d33f6ed78eef9658055e38124c54f05c0e39ae","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Add VNI attribute to BGPVPN table"},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - |"},{"line_number":6,"context_line":"    The ``bgpvpn-vni`` API extension adds VNI attribute to base ``bgpvpn``"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f2577a7_3d14a043","line":3,"range":{"start_line":2,"start_character":0,"end_line":3,"end_character":37},"in_reply_to":"5f2577a7_1a96bc40","updated":"2017-09-18 10:22:54.000000000","message":"Done","commit_id":"52e7b9b170da890b9e190d731db8883c57161f3e"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"4a3e26f86ad34e42b7351a97893ef2817c765197","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    Add VNI attribute to BGPVPN table"},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - |"},{"line_number":6,"context_line":"    The ``bgpvpn-vni`` API extension adds VNI attribute to base ``bgpvpn``"},{"line_number":7,"context_line":"    extension, when VXLAN encapsulation is used."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f2577a7_9aa18c97","line":6,"range":{"start_line":6,"start_character":37,"end_line":6,"end_character":45},"updated":"2017-09-14 19:20:21.000000000","message":"\"adds an optional admin-only VNI\"","commit_id":"52e7b9b170da890b9e190d731db8883c57161f3e"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"45fd5781fe3d38b7b252d2878140474b037d34ea","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    Add VNI attribute to BGPVPN table"},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - |"},{"line_number":6,"context_line":"    The ``bgpvpn-vni`` API extension adds VNI attribute to base ``bgpvpn``"},{"line_number":7,"context_line":"    extension, when VXLAN encapsulation is used."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f2577a7_3954d4fe","line":6,"range":{"start_line":6,"start_character":37,"end_line":6,"end_character":45},"in_reply_to":"5f2577a7_1ef1fe01","updated":"2017-09-15 13:36:55.000000000","message":"Combining the two suggestions, and a bit more:\n\nThe ``bgpvpn-vni`` API extension adds the ``vni`` optional attribute to ``bgpvpn`` objects to control the VXLAN VNI when VXLAN is used.","commit_id":"52e7b9b170da890b9e190d731db8883c57161f3e"},{"author":{"_account_id":25171,"name":"Deepthi V V","email":"deepthi.v.v@ericsson.com","username":"deepthivv88"},"change_message_id":"67d33f6ed78eef9658055e38124c54f05c0e39ae","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    Add VNI attribute to BGPVPN table"},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - |"},{"line_number":6,"context_line":"    The ``bgpvpn-vni`` API extension adds VNI attribute to base ``bgpvpn``"},{"line_number":7,"context_line":"    extension, when VXLAN encapsulation is used."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f2577a7_e201d507","line":6,"range":{"start_line":6,"start_character":37,"end_line":6,"end_character":45},"in_reply_to":"5f2577a7_3954d4fe","updated":"2017-09-18 10:22:54.000000000","message":"Done","commit_id":"52e7b9b170da890b9e190d731db8883c57161f3e"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"77ee05449db59f9832870d50fcad1d373bb4ffb3","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    Add VNI attribute to BGPVPN table"},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - |"},{"line_number":6,"context_line":"    The ``bgpvpn-vni`` API extension adds VNI attribute to base ``bgpvpn``"},{"line_number":7,"context_line":"    extension, when VXLAN encapsulation is used."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f2577a7_1ef1fe01","line":6,"range":{"start_line":6,"start_character":37,"end_line":6,"end_character":45},"in_reply_to":"5f2577a7_9aa18c97","updated":"2017-09-15 12:43:08.000000000","message":"IMO we should consider a little rewording; it\u0027d be nice to show the actual attribute added as well as clarify where its added. SOmething like::\n\n  ... adds the ``vni`` attribute to bgpvpn objects...","commit_id":"52e7b9b170da890b9e190d731db8883c57161f3e"}]}