)]}'
{"neutron_lib/api/definitions/bgpvpn.py":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"8581c4060a66636daef6713650c8fc7d0c08046e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5f2577a7_5e1666aa","updated":"2017-09-15 13:04:15.000000000","message":"Since this is fixing a bug, does it make sense to add a UT to validate regressions?","commit_id":"add55713e4d8aa8752275853745a81f57bf867b9"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"152d75b0b04c410a09c1005d5075d2b91846501b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5f2577a7_fe3d12dd","in_reply_to":"5f2577a7_5e1666aa","updated":"2017-09-15 13:25:40.000000000","message":"We actually have unit tests for these regexes in networking-bgpvpn. They should be ported here and augmented to exclude the empty string.\n\nI propose to merge this bugfix, and file a bug to track the need to move UTs for these regexes from networking-bgpvpn to neutron_lib.","commit_id":"add55713e4d8aa8752275853745a81f57bf867b9"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"f9907039389146f263f293f5dda567f042d19ae4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5f2577a7_075e4e43","in_reply_to":"5f2577a7_fe3d12dd","updated":"2017-09-16 07:17:00.000000000","message":"Fix for the existing unit test: I9841f656ca9c484e970e262e9dcbc0d1bc10c4c1\n\nBug to track the fact we need to have unit tests in neutron-lib: https://bugs.launchpad.net/bgpvpn/+bug/1717555","commit_id":"add55713e4d8aa8752275853745a81f57bf867b9"}]}