)]}'
{"neutron_lib/hacking/checks.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"61ea8d923443cdb5408f7e6b52bd48647d592221","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        message describe the check validation failure."},{"line_number":177,"context_line":"    \"\"\""},{"line_number":178,"context_line":"    if noqa:"},{"line_number":179,"context_line":"        return"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    msg \u003d \"N529: Method\u0027s default argument shouldn\u0027t be mutable!\""},{"line_number":182,"context_line":"    if mutable_default_args.match(logical_line):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f2577a7_8b8ffb73","line":179,"updated":"2017-09-14 21:05:46.000000000","message":"can I see an example where a mutable arg should be warranted?","commit_id":"3c1a5f5c44b8735291ae13f2b420d3b7ac075b38"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"5e49696739197298ff725f19eaa89d84ab3d7cae","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        message describe the check validation failure."},{"line_number":177,"context_line":"    \"\"\""},{"line_number":178,"context_line":"    if noqa:"},{"line_number":179,"context_line":"        return"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    msg \u003d \"N529: Method\u0027s default argument shouldn\u0027t be mutable!\""},{"line_number":182,"context_line":"    if mutable_default_args.match(logical_line):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f2577a7_ffa2b9fb","line":179,"in_reply_to":"5f2577a7_0b82eb00","updated":"2017-09-14 23:09:17.000000000","message":"@ihar: \"Time to...?\" (agree that your syntax is elegant indeed)\n@armando: yes, I understand why it might have side effect; although the current doesn\u0027t have any, it\u0027s true it may not always be the case\n\n@both: ok to drop this change...\n\nStill its a pain to have no proper feedback from flake8 when trying to use noqa and finding it effective on some checks, and ineffective on some others.","commit_id":"3c1a5f5c44b8735291ae13f2b420d3b7ac075b38"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"bbf4bcb430b19b8a060a7da742e2d334ee795ea9","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        message describe the check validation failure."},{"line_number":177,"context_line":"    \"\"\""},{"line_number":178,"context_line":"    if noqa:"},{"line_number":179,"context_line":"        return"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    msg \u003d \"N529: Method\u0027s default argument shouldn\u0027t be mutable!\""},{"line_number":182,"context_line":"    if mutable_default_args.match(logical_line):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f2577a7_b1934a5b","line":179,"in_reply_to":"5f2577a7_8b8ffb73","updated":"2017-09-14 22:17:12.000000000","message":"I wouldn\u0027t say warranted, it\u0027s just that in the case where the arg is not modified, I feel its nicer not to have to set the default values in the body of the function.\n\nHere is the exchange that triggered this change (line 246):\n\nhttps://review.openstack.org/#/c/501707/5/networking_bgpvpn_tempest/tests/scenario/test_bgpvpn_basic.py","commit_id":"3c1a5f5c44b8735291ae13f2b420d3b7ac075b38"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b73ff9f115614e1548eaedd3cbae8ad20c0af728","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        message describe the check validation failure."},{"line_number":177,"context_line":"    \"\"\""},{"line_number":178,"context_line":"    if noqa:"},{"line_number":179,"context_line":"        return"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    msg \u003d \"N529: Method\u0027s default argument shouldn\u0027t be mutable!\""},{"line_number":182,"context_line":"    if mutable_default_args.match(logical_line):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f2577a7_0b82eb00","line":179,"in_reply_to":"5f2577a7_8b8ffb73","updated":"2017-09-14 23:00:04.000000000","message":"This, and maybe it\u0027s time to","commit_id":"3c1a5f5c44b8735291ae13f2b420d3b7ac075b38"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"221e3494d42690f8c737accb3e114516b95007eb","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        message describe the check validation failure."},{"line_number":177,"context_line":"    \"\"\""},{"line_number":178,"context_line":"    if noqa:"},{"line_number":179,"context_line":"        return"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    msg \u003d \"N529: Method\u0027s default argument shouldn\u0027t be mutable!\""},{"line_number":182,"context_line":"    if mutable_default_args.match(logical_line):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f2577a7_911f2eb6","line":179,"in_reply_to":"5f2577a7_b1934a5b","updated":"2017-09-14 22:23:56.000000000","message":"thing this this can have side effects [1], and you don\u0027t want to mask that, because you can\u0027t predict how the side effect shows up.\n\n[1] http://docs.python-guide.org/en/latest/writing/gotchas/","commit_id":"3c1a5f5c44b8735291ae13f2b420d3b7ac075b38"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"1001c8135a6bb098560635b1b4c3039493724380","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        message describe the check validation failure."},{"line_number":177,"context_line":"    \"\"\""},{"line_number":178,"context_line":"    if noqa:"},{"line_number":179,"context_line":"        return"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    msg \u003d \"N529: Method\u0027s default argument shouldn\u0027t be mutable!\""},{"line_number":182,"context_line":"    if mutable_default_args.match(logical_line):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f2577a7_b507a482","line":179,"in_reply_to":"5f2577a7_ffa2b9fb","updated":"2017-09-15 17:47:28.000000000","message":"That\u0027s a fair point, though the question is: why provide the ability to skip on an exception basis when these checks are meant to be enforced uniformly?","commit_id":"3c1a5f5c44b8735291ae13f2b420d3b7ac075b38"}]}