)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"9da959a643a4f4e9dc9520d9442b1f97cf011063","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"DVR: Move DVR agent related constants to neutron-lib"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Move DVR agent releated constants to neutron-lib"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ieb9374f5483a0ab2306592ab901686ca374db1c8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ff82abbf_f65c8c7f","line":9,"updated":"2017-11-23 00:17:06.000000000","message":"...because?","commit_id":"6ec3000a184353a6d6e83b1c7e2b5885daaaa264"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"6453e35cd12407e16415e0ee56b2b1b922900b15","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"DVR: Move DVR agent related constants to neutron-lib"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Move DVR agent releated constants to neutron-lib"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ieb9374f5483a0ab2306592ab901686ca374db1c8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ff82abbf_7201d969","line":9,"in_reply_to":"ff82abbf_510b9bd4","updated":"2017-11-29 18:24:05.000000000","message":"So do you want me to refine this patch only with the agent modes or abort this patch.","commit_id":"6ec3000a184353a6d6e83b1c7e2b5885daaaa264"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"a1f829c0204cd0a3652272d6d992d23e3e2dc5c6","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"DVR: Move DVR agent related constants to neutron-lib"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Move DVR agent releated constants to neutron-lib"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ieb9374f5483a0ab2306592ab901686ca374db1c8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ff82abbf_8b482387","line":9,"in_reply_to":"ff82abbf_6b9cbf0d","updated":"2017-11-27 23:15:08.000000000","message":"where are these going to be used? If it\u0027s neutron alone, I find it hard to justify the move.\n\nPerhaps 3_AGENT_MODE_DVR_NO_EXTERNAL makes sense for consistency, and possibly because it might be used by other projects the same way the others have, but my point being here: moving is not free. Once things move, it\u0027s harder to make changes and my suggestion here is to move only stuff that\u0027s absolutely necessary. Constants, really it\u0027s not that high priority.","commit_id":"6ec3000a184353a6d6e83b1c7e2b5885daaaa264"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"b025c263aa92ba56b0b171dbe4b700c713d48067","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"DVR: Move DVR agent related constants to neutron-lib"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Move DVR agent releated constants to neutron-lib"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ieb9374f5483a0ab2306592ab901686ca374db1c8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ff82abbf_34e57edc","line":9,"in_reply_to":"ff82abbf_7201d969","updated":"2017-11-29 19:08:05.000000000","message":"sure, you can do the former.","commit_id":"6ec3000a184353a6d6e83b1c7e2b5885daaaa264"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"aed53619687b67f4fb2214a918036910e1a84aab","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"DVR: Move DVR agent related constants to neutron-lib"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Move DVR agent releated constants to neutron-lib"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ieb9374f5483a0ab2306592ab901686ca374db1c8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ff82abbf_99b14f4a","line":9,"in_reply_to":"ff82abbf_8b482387","updated":"2017-11-28 13:00:19.000000000","message":"We\u0027ve had this discussion on a few patches already. While I certainly agree APIs that are consumed outside of neutron are the priority, I personally haven\u0027t been pushing back too hard on those that try to rehome \"common stuff\". As I\u0027ve mentioned in these types of patches before, I\u0027m fine with merging them, but would consider them low priority.","commit_id":"6ec3000a184353a6d6e83b1c7e2b5885daaaa264"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"050ba9c2f37eb71417ca039881d41ffae92fc1e4","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"DVR: Move DVR agent related constants to neutron-lib"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Move DVR agent releated constants to neutron-lib"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ieb9374f5483a0ab2306592ab901686ca374db1c8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ff82abbf_6b9cbf0d","line":9,"in_reply_to":"ff82abbf_8b590336","updated":"2017-11-27 23:06:42.000000000","message":"For example \u0027dvr\u0027 agent modes constant definition has already been ported to the neutron-lib.\nHere is an example of a constant definition that need to be moved to neutron-lib.\n\nL3_AGENT_MODE_DVR_NO_EXTERNAL \u003d \u0027dvr_no_external\u0027\nDVR_SNAT_BOUND \u003d \u0027dvr_snat_bound\u0027","commit_id":"6ec3000a184353a6d6e83b1c7e2b5885daaaa264"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"c913f3fe29126877a96c6068f590a884f11ef6a0","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"DVR: Move DVR agent related constants to neutron-lib"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Move DVR agent releated constants to neutron-lib"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ieb9374f5483a0ab2306592ab901686ca374db1c8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ff82abbf_510b9bd4","line":9,"in_reply_to":"ff82abbf_99b14f4a","updated":"2017-11-28 15:01:29.000000000","message":"It\u0027s not a matter of pushing back too hard, but it\u0027s about taking the time to educate contributors about the right objectives behind the existence of the neutron-lib module. Allowing the contribution of non-reusable \u0027low-level implementation detail\u0027 constants dilutes the objective of the lib project and should be discouraged because it creates coupling where it does not need to exist.","commit_id":"6ec3000a184353a6d6e83b1c7e2b5885daaaa264"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"5dc28ac8c09d5f2603946621cf59876109b8890c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"DVR: Move DVR agent related constants to neutron-lib"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Move DVR agent releated constants to neutron-lib"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ieb9374f5483a0ab2306592ab901686ca374db1c8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ff82abbf_8b590336","line":9,"in_reply_to":"ff82abbf_da891eca","updated":"2017-11-27 22:32:41.000000000","message":"that doesn\u0027t seem like a good reason to me.\n\nOne of the goals of the rehoming effort is to make neutron-lib objects (constants, methods, etc) reusable across the wider list of projects that use neutron. If DVR is an implementation detail of a specific implementation of L3, just moving variables over seems counterproductive.","commit_id":"6ec3000a184353a6d6e83b1c7e2b5885daaaa264"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"fa7e27746d4ba1ee411beb5b1928c6e0133b7e75","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"DVR: Move DVR agent related constants to neutron-lib"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Move DVR agent releated constants to neutron-lib"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ieb9374f5483a0ab2306592ab901686ca374db1c8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ff82abbf_da891eca","line":9,"in_reply_to":"ff82abbf_f65c8c7f","updated":"2017-11-27 19:10:15.000000000","message":"Because we do have some constants transferred to the neutron-lib and some constants are left in neutron that were added later.","commit_id":"6ec3000a184353a6d6e83b1c7e2b5885daaaa264"}],"neutron_lib/constants.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"28230660272262dd02d7c745d0e3ae88f7701ad5","unresolved":false,"context_lines":[{"line_number":120,"context_line":"L3_AGENT_MODE_DVR_SNAT \u003d \u0027dvr_snat\u0027"},{"line_number":121,"context_line":"L3_AGENT_MODE_LEGACY \u003d \u0027legacy\u0027"},{"line_number":122,"context_line":"L3_AGENT_MODE \u003d \u0027agent_mode\u0027"},{"line_number":123,"context_line":"L3_AGETN_MODE_DVR_NO_EXTERNAL \u003d \u0027dvr_no_external\u0027"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"DVR_SNAT_BOUND \u003d \u0027dvr_snat_bound\u0027"},{"line_number":126,"context_line":"PORT_BINDING_EXT_ALIAS \u003d \u0027binding\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f515b1d_b1e89e7b","line":123,"range":{"start_line":123,"start_character":3,"end_line":123,"end_character":8},"updated":"2017-10-02 07:22:30.000000000","message":"AGENT","commit_id":"b59f3657233f71ee7dcf500863fbb9d17dae750b"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"af7b1eb7bfa017d5e3ecaf1ccae405552fd6effd","unresolved":false,"context_lines":[{"line_number":120,"context_line":"L3_AGENT_MODE_DVR_SNAT \u003d \u0027dvr_snat\u0027"},{"line_number":121,"context_line":"L3_AGENT_MODE_LEGACY \u003d \u0027legacy\u0027"},{"line_number":122,"context_line":"L3_AGENT_MODE \u003d \u0027agent_mode\u0027"},{"line_number":123,"context_line":"L3_AGETN_MODE_DVR_NO_EXTERNAL \u003d \u0027dvr_no_external\u0027"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"DVR_SNAT_BOUND \u003d \u0027dvr_snat_bound\u0027"},{"line_number":126,"context_line":"PORT_BINDING_EXT_ALIAS \u003d \u0027binding\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f515b1d_ce2a4c7d","line":123,"range":{"start_line":123,"start_character":3,"end_line":123,"end_character":8},"in_reply_to":"7f515b1d_b1e89e7b","updated":"2017-10-02 16:56:08.000000000","message":"Sure will fix it.","commit_id":"b59f3657233f71ee7dcf500863fbb9d17dae750b"}],"releasenotes/notes/rehome-dvr-related-leftover-constants-2cf329794166b3f2.yaml":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"59a99bcc0dd966151d224ba55b5edae54e6437d3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Moving the leftover DVR related constants from ``neutron.common.constants``."},{"line_number":4,"context_line":"    The list of constants shown below"},{"line_number":5,"context_line":"    ``L3_AGENT_MODE_DVR_NO_EXTERNAL``,"},{"line_number":6,"context_line":"    ``ROUTER_PORT_OWNERS``,"},{"line_number":7,"context_line":"    ``SNAT_ROUTER_INTF_KEY``,"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5f4e5783_447468fe","line":4,"range":{"start_line":4,"start_character":26,"end_line":4,"end_character":37},"updated":"2017-10-13 15:35:24.000000000","message":"Nit: it doesn\u0027t format into a list with this, so it would read better as something like::\n\n   The constants ``L3_AGENT_MODE_DVR_NO_EXTERNAL``, ... are now available...","commit_id":"6ec3000a184353a6d6e83b1c7e2b5885daaaa264"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"fa7e27746d4ba1ee411beb5b1928c6e0133b7e75","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Moving the leftover DVR related constants from ``neutron.common.constants``."},{"line_number":4,"context_line":"    The list of constants shown below"},{"line_number":5,"context_line":"    ``L3_AGENT_MODE_DVR_NO_EXTERNAL``,"},{"line_number":6,"context_line":"    ``ROUTER_PORT_OWNERS``,"},{"line_number":7,"context_line":"    ``SNAT_ROUTER_INTF_KEY``,"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ff82abbf_9a8f16cc","line":4,"range":{"start_line":4,"start_character":26,"end_line":4,"end_character":37},"in_reply_to":"5f4e5783_447468fe","updated":"2017-11-27 19:10:15.000000000","message":"will fix it.","commit_id":"6ec3000a184353a6d6e83b1c7e2b5885daaaa264"}]}