)]}'
{"api-ref/source/v2/parameters.yaml":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"f6d91bf4a8487114b24fb5939a9c39fe4ed5630d","unresolved":false,"context_lines":[{"line_number":575,"context_line":"    A set of zero or more allowed address pair objects each where address pair"},{"line_number":576,"context_line":"    object contains an ``ip_address`` and ``mac_address``. While the"},{"line_number":577,"context_line":"    ``ip_address`` is required, the ``mac_address`` will be taken from the"},{"line_number":578,"context_line":"    port if not specified. The value of ``ip_address`` can be an IP Address"},{"line_number":579,"context_line":"    or a CIDR (if supported by the underlying extension plugin)."},{"line_number":580,"context_line":"    A server connected to the port can send a packet with source address which"},{"line_number":581,"context_line":"    matches one of the specified allowed address pairs."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f4e5783_12210db1","line":578,"range":{"start_line":578,"start_character":68,"end_line":578,"end_character":69},"updated":"2017-10-13 20:19:19.000000000","message":"nit: should it start with uppercase?","commit_id":"f1b4880f59ef89060a1117cf3648092e8727b48d"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"fa9d1851fbd916f0544690ba798e14928274bc9d","unresolved":false,"context_lines":[{"line_number":575,"context_line":"    A set of zero or more allowed address pair objects each where address pair"},{"line_number":576,"context_line":"    object contains an ``ip_address`` and ``mac_address``. While the"},{"line_number":577,"context_line":"    ``ip_address`` is required, the ``mac_address`` will be taken from the"},{"line_number":578,"context_line":"    port if not specified. The value of ``ip_address`` can be an IP Address"},{"line_number":579,"context_line":"    or a CIDR (if supported by the underlying extension plugin)."},{"line_number":580,"context_line":"    A server connected to the port can send a packet with source address which"},{"line_number":581,"context_line":"    matches one of the specified allowed address pairs."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f4e5783_4d1c84c0","line":578,"range":{"start_line":578,"start_character":68,"end_line":578,"end_character":69},"in_reply_to":"5f4e5783_12210db1","updated":"2017-10-13 20:41:57.000000000","message":"No I don\u0027t think so. This is referring to the actual key name of the JSON object which IIUC is \u0027ip_address\u0027. See the sample uses from the UTs: https://github.com/openstack/neutron/blob/master/neutron/tests/unit/db/test_allowedaddresspairs_db.py#L129","commit_id":"f1b4880f59ef89060a1117cf3648092e8727b48d"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"3ce53425d036579e3a83d5f91a0ed05818ae8613","unresolved":false,"context_lines":[{"line_number":575,"context_line":"    A set of zero or more allowed address pair objects each where address pair"},{"line_number":576,"context_line":"    object contains an ``ip_address`` and ``mac_address``. While the"},{"line_number":577,"context_line":"    ``ip_address`` is required, the ``mac_address`` will be taken from the"},{"line_number":578,"context_line":"    port if not specified. The value of ``ip_address`` can be an IP Address"},{"line_number":579,"context_line":"    or a CIDR (if supported by the underlying extension plugin)."},{"line_number":580,"context_line":"    A server connected to the port can send a packet with source address which"},{"line_number":581,"context_line":"    matches one of the specified allowed address pairs."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f4e5783_289db6bb","line":578,"range":{"start_line":578,"start_character":68,"end_line":578,"end_character":69},"in_reply_to":"5f4e5783_4d1c84c0","updated":"2017-10-13 20:58:17.000000000","message":"ok, thx for clarification","commit_id":"f1b4880f59ef89060a1117cf3648092e8727b48d"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"f6d91bf4a8487114b24fb5939a9c39fe4ed5630d","unresolved":false,"context_lines":[{"line_number":587,"context_line":"    A set of zero or more allowed address pair objects each where address pair"},{"line_number":588,"context_line":"    object contains an ``ip_address`` and ``mac_address``. While the"},{"line_number":589,"context_line":"    ``ip_address`` is required, the ``mac_address`` will be taken from the"},{"line_number":590,"context_line":"    port if not specified. The value of ``ip_address`` can be an IP Address"},{"line_number":591,"context_line":"    or a CIDR (if supported by the underlying extension plugin)."},{"line_number":592,"context_line":"    A server connected to the port can send a packet with source address which"},{"line_number":593,"context_line":"    matches one of the specified allowed address pairs."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f4e5783_b20fd935","line":590,"range":{"start_line":590,"start_character":68,"end_line":590,"end_character":69},"updated":"2017-10-13 20:19:19.000000000","message":"nit: same here","commit_id":"f1b4880f59ef89060a1117cf3648092e8727b48d"}],"api-ref/source/v2/ports.inc":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"90857be82cf6a1da622aabd5f6aa88ff1b25edbf","unresolved":false,"context_lines":[{"line_number":48,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"The ``port-security`` extension adds the ``port_security_enabled`` boolean"},{"line_number":51,"context_line":"attribute to ports. When ``port_security_enabled`` is ``true``, only addresses"},{"line_number":52,"context_line":"are permitted as defined by the ``allowed-address-pairs`` extension. If a"},{"line_number":53,"context_line":"value is not specified during port creation, a port will inherit the"},{"line_number":54,"context_line":"``port_security_enabled`` from the network its connected to."},{"line_number":55,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":1,"id":"5f4e5783_dbc62d4a","line":52,"range":{"start_line":51,"start_character":64,"end_line":52,"end_character":67},"updated":"2017-10-12 03:02:44.000000000","message":"It looks like port-security is used with allowed-address-pairs but originally it want to prevent security group from filtering all packets[1, 2]. I think that we don\u0027t need to describe the details here but it\u0027s better to add a description like \" and ``security-group`` extension\" here.\n\n[1]: https://wiki.openstack.org/wiki/Neutron/ML2PortSecurityExtensionDriver\n[2]: https://specs.openstack.org/openstack/neutron-specs/specs/kilo/ml2-ovs-portsecurity.html","commit_id":"925e97b045a676b5077d003e854d9d9140f7b2f8"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"7ddd903a72e0fbb79367e582629f3acf189e10ae","unresolved":false,"context_lines":[{"line_number":48,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"The ``port-security`` extension adds the ``port_security_enabled`` boolean"},{"line_number":51,"context_line":"attribute to ports. When ``port_security_enabled`` is ``true``, only addresses"},{"line_number":52,"context_line":"are permitted as defined by the ``allowed-address-pairs`` extension. If a"},{"line_number":53,"context_line":"value is not specified during port creation, a port will inherit the"},{"line_number":54,"context_line":"``port_security_enabled`` from the network its connected to."},{"line_number":55,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":1,"id":"5f4e5783_ae71e00e","line":52,"range":{"start_line":51,"start_character":64,"end_line":52,"end_character":67},"in_reply_to":"5f4e5783_dbc62d4a","updated":"2017-10-12 13:20:26.000000000","message":"I\u0027ve changed the wording. Let me know what you think in the updated patch. Thanks","commit_id":"925e97b045a676b5077d003e854d9d9140f7b2f8"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"b8e5959ef3124e0922834bd8b105b27834a11cd8","unresolved":false,"context_lines":[{"line_number":48,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"The ``port-security`` extension adds the ``port_security_enabled`` boolean"},{"line_number":51,"context_line":"attribute to ports. Port security works in conjunction with the"},{"line_number":52,"context_line":"``security-group`` and ``allowed-address-pairs`` extension. If a"},{"line_number":53,"context_line":"``port-security`` value is not specified during port creation, a port will"},{"line_number":54,"context_line":"inherit the ``port_security_enabled`` from the network its connected to."},{"line_number":55,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"5f4e5783_120c6deb","line":52,"range":{"start_line":51,"start_character":20,"end_line":52,"end_character":58},"updated":"2017-10-13 19:52:47.000000000","message":"how does port security work in conjunction with allowed-address-pairs? This statement may be ambiguous in that some may infer that one depend on the other?","commit_id":"f1b4880f59ef89060a1117cf3648092e8727b48d"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"fa9d1851fbd916f0544690ba798e14928274bc9d","unresolved":false,"context_lines":[{"line_number":48,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"The ``port-security`` extension adds the ``port_security_enabled`` boolean"},{"line_number":51,"context_line":"attribute to ports. Port security works in conjunction with the"},{"line_number":52,"context_line":"``security-group`` and ``allowed-address-pairs`` extension. If a"},{"line_number":53,"context_line":"``port-security`` value is not specified during port creation, a port will"},{"line_number":54,"context_line":"inherit the ``port_security_enabled`` from the network its connected to."},{"line_number":55,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"5f4e5783_cd37544d","line":52,"range":{"start_line":51,"start_character":20,"end_line":52,"end_character":58},"in_reply_to":"5f4e5783_120c6deb","updated":"2017-10-13 20:41:57.000000000","message":"IIUC, maybe they should depend on each other.\nBased on the ml2 impl [1]::\n\n        # allowed address pair checks\n        if self._check_update_has_allowed_address_pairs(port):\n            if not port_security:\n                raise addr_pair.AddressPairAndPortSecurityRequired()\n\n\nDoesn\u0027t the code above say addr pairs are only valid when psec is enabled??\n\n\n[1] https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/plugin.py#L1131","commit_id":"f1b4880f59ef89060a1117cf3648092e8727b48d"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"e1c7db3a4d6f22b7c71fd7a791363740432d9250","unresolved":false,"context_lines":[{"line_number":48,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"The ``port-security`` extension adds the ``port_security_enabled`` boolean"},{"line_number":51,"context_line":"attribute to ports. Port security works in conjunction with the"},{"line_number":52,"context_line":"``security-group`` and ``allowed-address-pairs`` extension. If a"},{"line_number":53,"context_line":"``port-security`` value is not specified during port creation, a port will"},{"line_number":54,"context_line":"inherit the ``port_security_enabled`` from the network its connected to."},{"line_number":55,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"5f4e5783_484352b0","line":52,"range":{"start_line":51,"start_character":20,"end_line":52,"end_character":58},"in_reply_to":"5f4e5783_68b60e41","updated":"2017-10-13 21:25:17.000000000","message":"See what you think about the updating wording.","commit_id":"f1b4880f59ef89060a1117cf3648092e8727b48d"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"02e93090cc0c2f4b22cc6d994d51c8d7d2ec7739","unresolved":false,"context_lines":[{"line_number":48,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"The ``port-security`` extension adds the ``port_security_enabled`` boolean"},{"line_number":51,"context_line":"attribute to ports. Port security works in conjunction with the"},{"line_number":52,"context_line":"``security-group`` and ``allowed-address-pairs`` extension. If a"},{"line_number":53,"context_line":"``port-security`` value is not specified during port creation, a port will"},{"line_number":54,"context_line":"inherit the ``port_security_enabled`` from the network its connected to."},{"line_number":55,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"5f4e5783_68b60e41","line":52,"range":{"start_line":51,"start_character":20,"end_line":52,"end_character":58},"in_reply_to":"5f4e5783_cd37544d","updated":"2017-10-13 21:00:52.000000000","message":"Eh, I\u0027d say let\u0027s be more specific on which depends on which ;)","commit_id":"f1b4880f59ef89060a1117cf3648092e8727b48d"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"8b6e112b9a46221975b5a905d061f2a6683acfa1","unresolved":false,"context_lines":[{"line_number":58,"context_line":"The ``allowed-address-pairs`` extension adds an ``allowed_address_pairs``"},{"line_number":59,"context_line":"attribute to ports. The value of ``allowed_address_pairs`` is an array of"},{"line_number":60,"context_line":"allowed address pair objects, each having an ``ip_address`` and a"},{"line_number":61,"context_line":"``mac_address``. The set of allowed address pairs defines traffic permitted"},{"line_number":62,"context_line":"through the port when ``port_security_enabled`` is ``true`` (see the"},{"line_number":63,"context_line":"``port-security`` extension). Note that while the ``ip_address`` is required"},{"line_number":64,"context_line":"in each allowed address pair, the ``mac_address`` is optional and will be"},{"line_number":65,"context_line":"taken from the port if not specified."}],"source_content_type":"text/x-c++src","patch_set":3,"id":"5f4e5783_b726a2cd","line":62,"range":{"start_line":61,"start_character":58,"end_line":62,"end_character":17},"updated":"2017-10-14 11:58:14.000000000","message":"This might be a bit confusing. There are in-bound and out-bound traffic. allowed-address-pairs adds extra IP address and MAC address which the port can use when sending packets. I think it is better to mention \"when sending packets\".","commit_id":"8e5237f38394842c8b2c9dbf5e98d7651a645be3"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"40f3d9309b844483f6a013836f41b1e072507a8b","unresolved":false,"context_lines":[{"line_number":58,"context_line":"The ``allowed-address-pairs`` extension adds an ``allowed_address_pairs``"},{"line_number":59,"context_line":"attribute to ports. The value of ``allowed_address_pairs`` is an array of"},{"line_number":60,"context_line":"allowed address pair objects, each having an ``ip_address`` and a"},{"line_number":61,"context_line":"``mac_address``. The set of allowed address pairs defines traffic permitted"},{"line_number":62,"context_line":"through the port when ``port_security_enabled`` is ``true`` (see the"},{"line_number":63,"context_line":"``port-security`` extension). Note that while the ``ip_address`` is required"},{"line_number":64,"context_line":"in each allowed address pair, the ``mac_address`` is optional and will be"},{"line_number":65,"context_line":"taken from the port if not specified."}],"source_content_type":"text/x-c++src","patch_set":3,"id":"5f4e5783_9bc74865","line":62,"range":{"start_line":61,"start_character":58,"end_line":62,"end_character":17},"in_reply_to":"5f4e5783_b726a2cd","updated":"2017-10-15 12:29:27.000000000","message":"Let me know what you think of the wording in the updated patch. Thanks","commit_id":"8e5237f38394842c8b2c9dbf5e98d7651a645be3"}]}
