)]}'
{"neutron_lib/clients/placement.py":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"e2c2a6ec600e540d133f43a1f4ca458db09a1bfe","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import functools"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from keystoneauth1 import exceptions as ks_exc"},{"line_number":19,"context_line":"from keystoneauth1 import loading as ks_loading"},{"line_number":20,"context_line":"from oslo_config import cfg"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f4e5783_fb863c13","line":18,"updated":"2017-10-15 12:39:30.000000000","message":"I think we have to add keystoneauth1 to the requirements.txt for this don\u0027t we?","commit_id":"24ee3c6c91c404021c9c417cb658c58cce40f8a3"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"625c150c59fb1a2badbeb63a01d5fcde1bae6533","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import functools"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from keystoneauth1 import exceptions as ks_exc"},{"line_number":19,"context_line":"from keystoneauth1 import loading as ks_loading"},{"line_number":20,"context_line":"from oslo_config import cfg"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f4e5783_d548bf2d","line":18,"in_reply_to":"5f4e5783_dba249ae","updated":"2017-10-17 10:49:50.000000000","message":"I\u0027d think we still want it in the requirements.txt no?","commit_id":"24ee3c6c91c404021c9c417cb658c58cce40f8a3"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"5655c0861af1ee3363bff7a58c80b41ff34ef901","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import functools"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from keystoneauth1 import exceptions as ks_exc"},{"line_number":19,"context_line":"from keystoneauth1 import loading as ks_loading"},{"line_number":20,"context_line":"from oslo_config import cfg"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f4e5783_dba249ae","line":18,"in_reply_to":"5f4e5783_fb863c13","updated":"2017-10-16 15:33:30.000000000","message":"It\u0027s already installed as depedency of other package","commit_id":"24ee3c6c91c404021c9c417cb658c58cce40f8a3"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"e2c2a6ec600e540d133f43a1f4ca458db09a1bfe","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    \"\"\"Client class for placement ReST API.\"\"\""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    ks_filter \u003d {\u0027service_type\u0027: \u0027placement\u0027,"},{"line_number":42,"context_line":"                 \u0027region_name\u0027: cfg.CONF.placement.region_name}"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def __init__(self):"},{"line_number":45,"context_line":"        auth_plugin \u003d ks_loading.load_auth_from_conf_options("}],"source_content_type":"text/x-python","patch_set":2,"id":"5f4e5783_db7f0013","line":42,"range":{"start_line":42,"start_character":32,"end_line":42,"end_character":62},"updated":"2017-10-15 12:39:30.000000000","message":"Would it be more generic if the region name was passed into __init__() and consumers could deal with getting its value from CONF or elsewhere?","commit_id":"24ee3c6c91c404021c9c417cb658c58cce40f8a3"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"5632f77cecf8e1808a402400cc95594d4b856fa0","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    \"\"\"Client class for placement ReST API.\"\"\""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    ks_filter \u003d {\u0027service_type\u0027: \u0027placement\u0027,"},{"line_number":42,"context_line":"                 \u0027region_name\u0027: cfg.CONF.placement.region_name}"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def __init__(self):"},{"line_number":45,"context_line":"        auth_plugin \u003d ks_loading.load_auth_from_conf_options("}],"source_content_type":"text/x-python","patch_set":2,"id":"5f4e5783_726ba184","line":42,"updated":"2017-10-13 19:51:53.000000000","message":"it looks that docs tests are failing because of this conf option:http://logs.openstack.org/36/511936/2/check/gate-neutron-lib-docs-ubuntu-xenial/9779a30/console.html#_2017-10-13_18_04_57_695104","commit_id":"24ee3c6c91c404021c9c417cb658c58cce40f8a3"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"5655c0861af1ee3363bff7a58c80b41ff34ef901","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    \"\"\"Client class for placement ReST API.\"\"\""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    ks_filter \u003d {\u0027service_type\u0027: \u0027placement\u0027,"},{"line_number":42,"context_line":"                 \u0027region_name\u0027: cfg.CONF.placement.region_name}"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def __init__(self):"},{"line_number":45,"context_line":"        auth_plugin \u003d ks_loading.load_auth_from_conf_options("}],"source_content_type":"text/x-python","patch_set":2,"id":"5f4e5783_5bcd3964","line":42,"range":{"start_line":42,"start_character":32,"end_line":42,"end_character":62},"in_reply_to":"5f4e5783_db7f0013","updated":"2017-10-16 15:33:30.000000000","message":"Actually because this is a library project, the config parameter should be given by the project (e.g. Neutron) instantiating this class.\n\nThanks for the heads up.","commit_id":"24ee3c6c91c404021c9c417cb658c58cce40f8a3"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"e2c2a6ec600e540d133f43a1f4ca458db09a1bfe","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        \"\"\"Delete a resource provider."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        :param resource_provider_uuid: UUID of the resource provider"},{"line_number":82,"context_line":"        :type resource_provider_uuid: str"},{"line_number":83,"context_line":"        \"\"\""},{"line_number":84,"context_line":"        url \u003d \u0027/resource_providers/%s\u0027 % resource_provider_uuid"},{"line_number":85,"context_line":"        self._delete(url)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f4e5783_5b91d046","line":82,"range":{"start_line":82,"start_character":38,"end_line":82,"end_character":41},"updated":"2017-10-15 12:39:30.000000000","message":"Nit: some of these py docs could use updating to better describe what they are and also use sentence structure (Caps on first letter and period at end).","commit_id":"24ee3c6c91c404021c9c417cb658c58cce40f8a3"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"62b8794918fae7372c383e93bd30a9024bce2ae1","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        \"\"\"Delete a resource provider."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        :param resource_provider_uuid: UUID of the resource provider"},{"line_number":82,"context_line":"        :type resource_provider_uuid: str"},{"line_number":83,"context_line":"        \"\"\""},{"line_number":84,"context_line":"        url \u003d \u0027/resource_providers/%s\u0027 % resource_provider_uuid"},{"line_number":85,"context_line":"        self._delete(url)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f4e5783_e19c34c1","line":82,"range":{"start_line":82,"start_character":38,"end_line":82,"end_character":41},"in_reply_to":"5f4e5783_5b91d046","updated":"2017-10-16 15:30:33.000000000","message":"Just to clarify the comment above. As per our review guidelines [1], the public APIs should be documented using [2]. So for this method:\n- Add a period at the end of the sentence \"UUID of the resource provider\"\n- Optionally remove :type resource_provider_uuid: str... while it\u0027s not bad, we haven\u0027t been using it much to date.\n- Add a :returns: to describe whats returned.\n- Where applicable document exceptions with :raises: for example [4].\n\n\nNote that IMHO this patch shouldn\u0027t be held-up because of these py doc nits, but if you\u0027re willing to fix it\u0027d be nice :)\n\n\n[1] https://github.com/openstack/neutron-lib/blob/master/doc/source/contributor/review-guidelines.rst\n[2] https://www.python.org/dev/peps/pep-0287/\n[3] https://github.com/openstack/neutron-lib/blob/master/neutron_lib/utils/net.py#L46\n[4] https://github.com/openstack/neutron-lib/blob/master/neutron_lib/utils/runtime.py#L37","commit_id":"24ee3c6c91c404021c9c417cb658c58cce40f8a3"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"5655c0861af1ee3363bff7a58c80b41ff34ef901","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        \"\"\"Delete a resource provider."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        :param resource_provider_uuid: UUID of the resource provider"},{"line_number":82,"context_line":"        :type resource_provider_uuid: str"},{"line_number":83,"context_line":"        \"\"\""},{"line_number":84,"context_line":"        url \u003d \u0027/resource_providers/%s\u0027 % resource_provider_uuid"},{"line_number":85,"context_line":"        self._delete(url)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f4e5783_61de046e","line":82,"range":{"start_line":82,"start_character":38,"end_line":82,"end_character":41},"in_reply_to":"5f4e5783_e19c34c1","updated":"2017-10-16 15:33:30.000000000","message":"I\u0027ll fix all docs in the next patch.","commit_id":"24ee3c6c91c404021c9c417cb658c58cce40f8a3"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"230d8f5466fefc5a04c24d8582e1840eaf1b1c03","unresolved":false,"context_lines":[{"line_number":23,"context_line":"PLACEMENT_API_WITH_AGGREGATES \u003d \u0027placement 1.1\u0027"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"def check_placement_api_available(f):"},{"line_number":27,"context_line":"    @functools.wraps(f)"},{"line_number":28,"context_line":"    def wrapper(self, *a, **k):"},{"line_number":29,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f4e5783_d571df77","line":26,"range":{"start_line":26,"start_character":4,"end_line":26,"end_character":33},"updated":"2017-10-17 10:53:05.000000000","message":"Nit: py doc for this public function.","commit_id":"da1d851d08ef36a4b65d83c0a9999c58935a2546"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"15a1f6b3591608123577920a73d2a904c8f4be5a","unresolved":false,"context_lines":[{"line_number":23,"context_line":"PLACEMENT_API_WITH_AGGREGATES \u003d \u0027placement 1.1\u0027"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"def check_placement_api_available(f):"},{"line_number":27,"context_line":"    @functools.wraps(f)"},{"line_number":28,"context_line":"    def wrapper(self, *a, **k):"},{"line_number":29,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f4e5783_d07b2d25","line":26,"range":{"start_line":26,"start_character":4,"end_line":26,"end_character":33},"in_reply_to":"5f4e5783_d571df77","updated":"2017-10-17 11:43:27.000000000","message":"Done","commit_id":"da1d851d08ef36a4b65d83c0a9999c58935a2546"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"5a8a1a3dee960a61ebde71e97c61e966331d0f00","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        self._ks_filter \u003d {\u0027service_type\u0027: \u0027placement\u0027,"},{"line_number":49,"context_line":"                           \u0027region_name\u0027: region_name}"},{"line_number":50,"context_line":"        self._client \u003d placement_client"},{"line_number":51,"context_line":"        self._openstack_api_version \u003d openstack_api_version"},{"line_number":52,"context_line":"        self._disabled \u003d False"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def _get(self, url, **kwargs):"},{"line_number":55,"context_line":"        return self._client.get(url, endpoint_filter\u003dself._ks_filter,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f4b6375_61f4715c","line":52,"range":{"start_line":51,"start_character":0,"end_line":52,"end_character":30},"updated":"2017-10-18 12:52:57.000000000","message":"What are the _openstack_api_version and _disabled used for? I\u0027m not seeing them used herein and they are private.","commit_id":"ae87678135461d97b5cd030b9fb97d6d78431d8f"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"8227bc94731358819650fcfdb553e1ce2de4cd61","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        self._ks_filter \u003d {\u0027service_type\u0027: \u0027placement\u0027,"},{"line_number":49,"context_line":"                           \u0027region_name\u0027: region_name}"},{"line_number":50,"context_line":"        self._client \u003d placement_client"},{"line_number":51,"context_line":"        self._openstack_api_version \u003d openstack_api_version"},{"line_number":52,"context_line":"        self._disabled \u003d False"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def _get(self, url, **kwargs):"},{"line_number":55,"context_line":"        return self._client.get(url, endpoint_filter\u003dself._ks_filter,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f4b6375_e8c6e416","line":52,"range":{"start_line":51,"start_character":0,"end_line":52,"end_character":30},"in_reply_to":"3f4b6375_61f4715c","updated":"2017-10-23 09:02:40.000000000","message":"\"_openstack_api_version\" is used in L159 and L173\n\"_disabled\" is a mistake!","commit_id":"ae87678135461d97b5cd030b9fb97d6d78431d8f"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"5a8a1a3dee960a61ebde71e97c61e966331d0f00","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        url \u003d \u0027/resource_providers/%s/inventories/%s\u0027 % ("},{"line_number":113,"context_line":"            resource_provider_uuid, resource_class)"},{"line_number":114,"context_line":"        try:"},{"line_number":115,"context_line":"            return self._get(url).json()"},{"line_number":116,"context_line":"        except ks_exc.NotFound as e:"},{"line_number":117,"context_line":"            if \"No resource provider with uuid\" in e.details:"},{"line_number":118,"context_line":"                raise n_exc.PlacementResourceProviderNotFound("}],"source_content_type":"text/x-python","patch_set":5,"id":"3f4b6375_e184e1b3","line":115,"range":{"start_line":115,"start_character":33,"end_line":115,"end_character":40},"updated":"2017-10-18 12:52:57.000000000","message":"This explicitly returns json, but most ofthers in there just call self._\u003chttp_method\u003e which returns the value from the client. Does the client return json as well? Just trying to understand why we use .json() here and not other places.","commit_id":"ae87678135461d97b5cd030b9fb97d6d78431d8f"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"8227bc94731358819650fcfdb553e1ce2de4cd61","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        url \u003d \u0027/resource_providers/%s/inventories/%s\u0027 % ("},{"line_number":113,"context_line":"            resource_provider_uuid, resource_class)"},{"line_number":114,"context_line":"        try:"},{"line_number":115,"context_line":"            return self._get(url).json()"},{"line_number":116,"context_line":"        except ks_exc.NotFound as e:"},{"line_number":117,"context_line":"            if \"No resource provider with uuid\" in e.details:"},{"line_number":118,"context_line":"                raise n_exc.PlacementResourceProviderNotFound("}],"source_content_type":"text/x-python","patch_set":5,"id":"3f4b6375_68b1d48f","line":115,"range":{"start_line":115,"start_character":33,"end_line":115,"end_character":40},"in_reply_to":"3f4b6375_e184e1b3","updated":"2017-10-23 09:02:40.000000000","message":"All _get functions (L115, L171) returned content are converted to json.\n\nAlso you can take a look at https://review.openstack.org/#/c/512396/3/neutron_lib/clients/placement.py","commit_id":"ae87678135461d97b5cd030b9fb97d6d78431d8f"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"5a8a1a3dee960a61ebde71e97c61e966331d0f00","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        \"\"\""},{"line_number":156,"context_line":"        url \u003d \u0027/resource_providers/%s/aggregates\u0027 % resource_provider_uuid"},{"line_number":157,"context_line":"        self._put(url, aggregates,"},{"line_number":158,"context_line":"                  headers\u003d{\u0027openstack-api-version\u0027:"},{"line_number":159,"context_line":"                           self._openstack_api_version})"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    @check_placement_api_available"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f4b6375_8162cd15","line":158,"updated":"2017-10-18 12:52:57.000000000","message":"Why do we only use this header on select requests? Just trying to understand.","commit_id":"ae87678135461d97b5cd030b9fb97d6d78431d8f"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"8227bc94731358819650fcfdb553e1ce2de4cd61","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        \"\"\""},{"line_number":156,"context_line":"        url \u003d \u0027/resource_providers/%s/aggregates\u0027 % resource_provider_uuid"},{"line_number":157,"context_line":"        self._put(url, aggregates,"},{"line_number":158,"context_line":"                  headers\u003d{\u0027openstack-api-version\u0027:"},{"line_number":159,"context_line":"                           self._openstack_api_version})"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    @check_placement_api_available"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f4b6375_63d7b5c1","line":158,"in_reply_to":"3f4b6375_8162cd15","updated":"2017-10-23 09:02:40.000000000","message":"Because aggregates are only enabled in this version.\n\nBTW, I just copy-pasted this part of the code. Although http headers are case-insensitive, the constant used in Nova api is \n\u0027OpenStack-API-Version\u0027. I\u0027ll change it.","commit_id":"ae87678135461d97b5cd030b9fb97d6d78431d8f"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"2f899f2b0dfdb9308ea9e7b5e14791ff01a3225a","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                           \u0027region_name\u0027: region_name}"},{"line_number":52,"context_line":"        self._client \u003d placement_client"},{"line_number":53,"context_line":"        self._openstack_api_version \u003d openstack_api_version"},{"line_number":54,"context_line":"        self._disabled \u003d False"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def _get(self, url, **kwargs):"},{"line_number":57,"context_line":"        return self._client.get(url, endpoint_filter\u003dself._ks_filter,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f4b6375_d67710d4","line":54,"updated":"2017-10-22 10:08:18.000000000","message":"where do You need this? I can\u0027t find it anywhere","commit_id":"21f5b64529cd64d000a2b0c1b3e2523939a8ddfb"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"8227bc94731358819650fcfdb553e1ce2de4cd61","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                           \u0027region_name\u0027: region_name}"},{"line_number":52,"context_line":"        self._client \u003d placement_client"},{"line_number":53,"context_line":"        self._openstack_api_version \u003d openstack_api_version"},{"line_number":54,"context_line":"        self._disabled \u003d False"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def _get(self, url, **kwargs):"},{"line_number":57,"context_line":"        return self._client.get(url, endpoint_filter\u003dself._ks_filter,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f4b6375_e138fd3d","line":54,"in_reply_to":"3f4b6375_d67710d4","updated":"2017-10-23 09:02:40.000000000","message":"I thought I removed this one PS ago. I\u0027ll remove it definitely","commit_id":"21f5b64529cd64d000a2b0c1b3e2523939a8ddfb"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"36f91944b694f9239148100123bf8b79ec9046d8","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        try:"},{"line_number":39,"context_line":"            return f(self, *a, **k)"},{"line_number":40,"context_line":"        except ks_exc.EndpointNotFound:"},{"line_number":41,"context_line":"            raise n_exc.PlacementEndpointNotFound()"},{"line_number":42,"context_line":"    return wrapper"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3f4b6375_aed1c2cf","line":41,"updated":"2017-10-23 18:07:57.000000000","message":"One thing we found in the nova-compute agent was that if there\u0027s a race between nova-compute starting up and the placement endpoint being established in keystone, it\u0027s possible for EndpointNotFound to happen. This is bad enough, but worse is that the service catalog will be cached locally so any efforts to retry will be for naught as it\u0027s not a new catalog.\n\nSo what needs to happen is that a new catalog is created.\n\nSee https://review.openstack.org/#/c/493536/ and the related bug for more info.","commit_id":"f7e05df97a96a1192d1f0c4fe01cb5dbc13569b4"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"2d3ba960d9502473bae6e19ed3bc3056a76bf018","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        try:"},{"line_number":39,"context_line":"            return f(self, *a, **k)"},{"line_number":40,"context_line":"        except ks_exc.EndpointNotFound:"},{"line_number":41,"context_line":"            raise n_exc.PlacementEndpointNotFound()"},{"line_number":42,"context_line":"    return wrapper"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3f4b6375_c82144b6","line":41,"in_reply_to":"3f4b6375_aed1c2cf","updated":"2017-11-06 09:11:11.000000000","message":"I\u0027ll implement something similar to https://review.openstack.org/#/c/493536/3/nova/scheduler/client/report.py. Thanks for the tip","commit_id":"f7e05df97a96a1192d1f0c4fe01cb5dbc13569b4"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"231347e7c6d1d7e2feed0481a84e7a83e81af4df","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            additional_headers\u003d{\u0027accept\u0027: \u0027application/json\u0027})"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def _get(self, url, **kwargs):"},{"line_number":89,"context_line":"        return self._client.get(url, endpoint_filter\u003dself._ks_filter,"},{"line_number":90,"context_line":"                                **kwargs)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def _post(self, url, data, **kwargs):"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f4b6375_ccf1386d","line":89,"range":{"start_line":89,"start_character":20,"end_line":89,"end_character":27},"updated":"2017-11-07 14:46:18.000000000","message":"I\u0027m probably missing something obvious, but where\u0027s self._client getting created/set?\n\n\nI do see it in the original: https://github.com/openstack/neutron/blob/master/neutron/services/segments/placement_client.py#L47","commit_id":"32371df53dde0a04c28e987821901aeef23748dd"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"970fe62ddc4ff3b6d4ad7f6270a834855b99037f","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            additional_headers\u003d{\u0027accept\u0027: \u0027application/json\u0027})"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def _get(self, url, **kwargs):"},{"line_number":89,"context_line":"        return self._client.get(url, endpoint_filter\u003dself._ks_filter,"},{"line_number":90,"context_line":"                                **kwargs)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def _post(self, url, data, **kwargs):"}],"source_content_type":"text/x-python","patch_set":9,"id":"1f485f77_a2f6bd8e","line":89,"range":{"start_line":89,"start_character":20,"end_line":89,"end_character":27},"in_reply_to":"3f4b6375_ccf1386d","updated":"2017-11-13 14:03:22.000000000","message":"Every entry point is decorated with _check_placement_api_available, which will check if the endpoint is online. If not, the decorator will create the client again.\n\nAnyway, I\u0027ll force a client check every time the decorator is called. With this, I\u0027ll delay the client creation (allowing the endpoints to be ready) and I\u0027ll retry, if needed, to create the client.","commit_id":"32371df53dde0a04c28e987821901aeef23748dd"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"75a8ecba852a85a33b2818173a35ec1c5570b6c9","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                           \u0027region_name\u0027: region_name}"},{"line_number":74,"context_line":"        self._openstack_api_version \u003d openstack_api_version"},{"line_number":75,"context_line":"        self._conf \u003d conf"},{"line_number":76,"context_line":"        self._client \u003d None"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def _create_client(self):"},{"line_number":79,"context_line":"        \"\"\"Create the HTTP session accessing the placement service.\"\"\""}],"source_content_type":"text/x-python","patch_set":11,"id":"1f485f77_f0221701","line":76,"range":{"start_line":76,"start_character":8,"end_line":76,"end_character":27},"updated":"2017-11-14 13:30:00.000000000","message":"Thanks for explaining the wrapper and how self._client is set. Given this is a change from the current behavior of the client in neutron, is it possible that you could use the \"Depends on approach\" [1] with a neutron patch? This would be just to make sure this change still functions as expected when neutron consumes the client from lib.\n\n\n[1] https://docs.openstack.org/neutron-lib/latest/contributor/review-guidelines.html","commit_id":"8043ce7da5064ed7815ee58170799e128c42f90f"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"118563ab9d02f30323a3e41c48cec1c015e9c001","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                           \u0027region_name\u0027: region_name}"},{"line_number":74,"context_line":"        self._openstack_api_version \u003d openstack_api_version"},{"line_number":75,"context_line":"        self._conf \u003d conf"},{"line_number":76,"context_line":"        self._client \u003d None"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def _create_client(self):"},{"line_number":79,"context_line":"        \"\"\"Create the HTTP session accessing the placement service.\"\"\""}],"source_content_type":"text/x-python","patch_set":11,"id":"1f485f77_4c246faf","line":76,"range":{"start_line":76,"start_character":8,"end_line":76,"end_character":27},"in_reply_to":"1f485f77_f0221701","updated":"2017-11-16 13:46:53.000000000","message":"I\u0027ll try to do this as soon as possible.","commit_id":"8043ce7da5064ed7815ee58170799e128c42f90f"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"f844ff4dad0cc57705dff54f7d23d0b341b9dd4b","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                self._client \u003d self._create_client()"},{"line_number":45,"context_line":"            return f(self, *a, **k)"},{"line_number":46,"context_line":"        except ks_exc.EndpointNotFound:"},{"line_number":47,"context_line":"            LOG.warning(\u0027The placement API endpoint not found. Placement is \u0027"},{"line_number":48,"context_line":"                        \u0027optional in Newton, but required in Ocata. Please \u0027"},{"line_number":49,"context_line":"                        \u0027enable the placement service before upgrading.\u0027)"},{"line_number":50,"context_line":"        except ks_exc.MissingAuthPlugin:"},{"line_number":51,"context_line":"            LOG.warning(\u0027No authentication information found for placement \u0027"},{"line_number":52,"context_line":"                        \u0027API. Placement is optional in Newton, but required \u0027"}],"source_content_type":"text/x-python","patch_set":12,"id":"df87a7cf_eb3cd3c0","line":49,"range":{"start_line":47,"start_character":24,"end_line":49,"end_character":72},"updated":"2017-12-14 09:49:25.000000000","message":"Is this message still actual now when Newton is already EOL?","commit_id":"6c73d2742098c1ec757fda557d59f62fdde1c3ec"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"eb2aa208322a024151030dbf1e9a6af10cfb0e2e","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                self._client \u003d self._create_client()"},{"line_number":45,"context_line":"            return f(self, *a, **k)"},{"line_number":46,"context_line":"        except ks_exc.EndpointNotFound:"},{"line_number":47,"context_line":"            LOG.warning(\u0027The placement API endpoint not found. Placement is \u0027"},{"line_number":48,"context_line":"                        \u0027optional in Newton, but required in Ocata. Please \u0027"},{"line_number":49,"context_line":"                        \u0027enable the placement service before upgrading.\u0027)"},{"line_number":50,"context_line":"        except ks_exc.MissingAuthPlugin:"},{"line_number":51,"context_line":"            LOG.warning(\u0027No authentication information found for placement \u0027"},{"line_number":52,"context_line":"                        \u0027API. Placement is optional in Newton, but required \u0027"}],"source_content_type":"text/x-python","patch_set":12,"id":"bf8cb3f7_71943438","line":49,"range":{"start_line":47,"start_character":24,"end_line":49,"end_character":72},"in_reply_to":"df87a7cf_eb3cd3c0","updated":"2017-12-22 10:03:08.000000000","message":"You are right. This feature can\u0027t be deployed with Nova Newton versions.","commit_id":"6c73d2742098c1ec757fda557d59f62fdde1c3ec"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"f844ff4dad0cc57705dff54f7d23d0b341b9dd4b","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                        \u0027optional in Newton, but required in Ocata. Please \u0027"},{"line_number":49,"context_line":"                        \u0027enable the placement service before upgrading.\u0027)"},{"line_number":50,"context_line":"        except ks_exc.MissingAuthPlugin:"},{"line_number":51,"context_line":"            LOG.warning(\u0027No authentication information found for placement \u0027"},{"line_number":52,"context_line":"                        \u0027API. Placement is optional in Newton, but required \u0027"},{"line_number":53,"context_line":"                        \u0027in Ocata. Please enable the placement service \u0027"},{"line_number":54,"context_line":"                        \u0027before upgrading.\u0027)"},{"line_number":55,"context_line":"        except ks_exc.Unauthorized:"},{"line_number":56,"context_line":"            LOG.warning(\u0027Placement service credentials do not work. \u0027"},{"line_number":57,"context_line":"                        \u0027Placement is optional in Newton, but required \u0027"}],"source_content_type":"text/x-python","patch_set":12,"id":"df87a7cf_6b7a0389","line":54,"range":{"start_line":51,"start_character":24,"end_line":54,"end_character":43},"updated":"2017-12-14 09:49:25.000000000","message":"same here","commit_id":"6c73d2742098c1ec757fda557d59f62fdde1c3ec"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"f844ff4dad0cc57705dff54f7d23d0b341b9dd4b","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                        \u0027in Ocata. Please enable the placement service \u0027"},{"line_number":54,"context_line":"                        \u0027before upgrading.\u0027)"},{"line_number":55,"context_line":"        except ks_exc.Unauthorized:"},{"line_number":56,"context_line":"            LOG.warning(\u0027Placement service credentials do not work. \u0027"},{"line_number":57,"context_line":"                        \u0027Placement is optional in Newton, but required \u0027"},{"line_number":58,"context_line":"                        \u0027in Ocata. Please enable the placement service \u0027"},{"line_number":59,"context_line":"                        \u0027before upgrading.\u0027)"},{"line_number":60,"context_line":"        except ks_exc.DiscoveryFailure:"},{"line_number":61,"context_line":"            LOG.warning(\u0027Discovering suitable URL for placement API failed.\u0027)"},{"line_number":62,"context_line":"        except ks_exc.ConnectFailure:"}],"source_content_type":"text/x-python","patch_set":12,"id":"df87a7cf_0b6fb7c5","line":59,"range":{"start_line":56,"start_character":24,"end_line":59,"end_character":43},"updated":"2017-12-14 09:49:25.000000000","message":"and here","commit_id":"6c73d2742098c1ec757fda557d59f62fdde1c3ec"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"117719dcd0da99eabf7e0bd0cc92b23d4ac3ded2","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                self._client \u003d self._create_client()"},{"line_number":45,"context_line":"            return f(self, *a, **k)"},{"line_number":46,"context_line":"        except ks_exc.EndpointNotFound:"},{"line_number":47,"context_line":"            LOG.warning(\u0027Please enable the placement service.\u0027)"},{"line_number":48,"context_line":"        except ks_exc.MissingAuthPlugin:"},{"line_number":49,"context_line":"            LOG.warning(\u0027No authentication information found for placement \u0027"},{"line_number":50,"context_line":"                        \u0027API. Please enable the placement service.\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"9f91af0f_f7eb48d9","line":47,"range":{"start_line":47,"start_character":25,"end_line":47,"end_character":31},"updated":"2018-01-03 14:33:32.000000000","message":"I\u0027d probably opt to drop the \"Please\", but likely a personal preference.","commit_id":"9ef0860033796ce38c29e9b541898b42fbb913c5"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d20929ae10871db4e5ce05701005716cb096f7c8","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                self._client \u003d self._create_client()"},{"line_number":45,"context_line":"            return f(self, *a, **k)"},{"line_number":46,"context_line":"        except ks_exc.EndpointNotFound:"},{"line_number":47,"context_line":"            LOG.warning(\u0027Please enable the placement service.\u0027)"},{"line_number":48,"context_line":"        except ks_exc.MissingAuthPlugin:"},{"line_number":49,"context_line":"            LOG.warning(\u0027No authentication information found for placement \u0027"},{"line_number":50,"context_line":"                        \u0027API. Please enable the placement service.\u0027)"}],"source_content_type":"text/x-python","patch_set":15,"id":"9f91af0f_04174a53","line":47,"range":{"start_line":47,"start_character":25,"end_line":47,"end_character":31},"in_reply_to":"9f91af0f_f7eb48d9","updated":"2018-01-08 10:41:24.000000000","message":"IMHO it is fine :)","commit_id":"9ef0860033796ce38c29e9b541898b42fbb913c5"}],"neutron_lib/exceptions/placement.py":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"5a8a1a3dee960a61ebde71e97c61e966331d0f00","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class PlacementEndpointNotFound(exceptions.NotFound):"},{"line_number":20,"context_line":"    message \u003d _(\"Placement API endpoint not found\")"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class PlacementResourceProviderNotFound(exceptions.NotFound):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f4b6375_a17ca9b5","line":20,"range":{"start_line":20,"start_character":44,"end_line":20,"end_character":49},"updated":"2017-10-18 12:52:57.000000000","message":"Nit; Period for consistency.","commit_id":"ae87678135461d97b5cd030b9fb97d6d78431d8f"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"8227bc94731358819650fcfdb553e1ce2de4cd61","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class PlacementEndpointNotFound(exceptions.NotFound):"},{"line_number":20,"context_line":"    message \u003d _(\"Placement API endpoint not found\")"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class PlacementResourceProviderNotFound(exceptions.NotFound):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f4b6375_e3f4c55d","line":20,"range":{"start_line":20,"start_character":44,"end_line":20,"end_character":49},"in_reply_to":"3f4b6375_a17ca9b5","updated":"2017-10-23 09:02:40.000000000","message":"Done","commit_id":"ae87678135461d97b5cd030b9fb97d6d78431d8f"}],"neutron_lib/fixture.py":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"231347e7c6d1d7e2feed0481a84e7a83e81af4df","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        return APIDefinitionFixture(*tuple(definitions._ALL_API_DEFINITIONS))"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"class PlacementAPIClientFixture(fixtures.Fixture):"},{"line_number":161,"context_line":"    \"\"\"Placement API client fixture."},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    This class is intended to be used as a fixture within unit tests and"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f4b6375_cc4db89a","line":160,"updated":"2017-11-07 14:46:18.000000000","message":"This fixture should also have a UT in neutron_lib.tests.unit.test_fixture. This will also help others understand how the fixture is used.","commit_id":"32371df53dde0a04c28e987821901aeef23748dd"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"970fe62ddc4ff3b6d4ad7f6270a834855b99037f","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        return APIDefinitionFixture(*tuple(definitions._ALL_API_DEFINITIONS))"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"class PlacementAPIClientFixture(fixtures.Fixture):"},{"line_number":161,"context_line":"    \"\"\"Placement API client fixture."},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    This class is intended to be used as a fixture within unit tests and"}],"source_content_type":"text/x-python","patch_set":9,"id":"1f485f77_fbcb3ca2","line":160,"in_reply_to":"3f4b6375_cc4db89a","updated":"2017-11-13 14:03:22.000000000","message":"Done","commit_id":"32371df53dde0a04c28e987821901aeef23748dd"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"231347e7c6d1d7e2feed0481a84e7a83e81af4df","unresolved":false,"context_lines":[{"line_number":163,"context_line":"    This class is intended to be used as a fixture within unit tests and"},{"line_number":164,"context_line":"    therefore consumers must register it using useFixture() within their"},{"line_number":165,"context_line":"    unit test class. The implementation optionally allows consumers to pass"},{"line_number":166,"context_line":"    in the CallbacksManager manager to use for your tests."},{"line_number":167,"context_line":"    \"\"\""},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    def __init__(self, region_name\u003d\u0027region_name\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f4b6375_ecf51452","line":166,"range":{"start_line":166,"start_character":11,"end_line":166,"end_character":27},"updated":"2017-11-07 14:46:18.000000000","message":"Think this might have been a copy/paste thing.","commit_id":"32371df53dde0a04c28e987821901aeef23748dd"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"970fe62ddc4ff3b6d4ad7f6270a834855b99037f","unresolved":false,"context_lines":[{"line_number":163,"context_line":"    This class is intended to be used as a fixture within unit tests and"},{"line_number":164,"context_line":"    therefore consumers must register it using useFixture() within their"},{"line_number":165,"context_line":"    unit test class. The implementation optionally allows consumers to pass"},{"line_number":166,"context_line":"    in the CallbacksManager manager to use for your tests."},{"line_number":167,"context_line":"    \"\"\""},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    def __init__(self, region_name\u003d\u0027region_name\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"1f485f77_3bd2f45d","line":166,"range":{"start_line":166,"start_character":11,"end_line":166,"end_character":27},"in_reply_to":"3f4b6375_ecf51452","updated":"2017-11-13 14:03:22.000000000","message":"Done","commit_id":"32371df53dde0a04c28e987821901aeef23748dd"}],"neutron_lib/tests/unit/clients/test_placement.py":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"ee4cfe5a893e59f308fc05b0bfdf448da033df6a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":2,"context_line":"# you may not use this file except in compliance with the License."},{"line_number":3,"context_line":"# You may obtain a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f4b6375_498c2cd6","line":1,"updated":"2017-10-26 12:38:18.000000000","message":"I think you may want to just copy over the lic header from the original source in neutron (including the copyright). IIUC this is how things should be done to preserve existing works/copyrights.","commit_id":"f7e05df97a96a1192d1f0c4fe01cb5dbc13569b4"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"2d3ba960d9502473bae6e19ed3bc3056a76bf018","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":2,"context_line":"# you may not use this file except in compliance with the License."},{"line_number":3,"context_line":"# You may obtain a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f4b6375_481f946b","line":1,"in_reply_to":"3f4b6375_498c2cd6","updated":"2017-11-06 09:11:11.000000000","message":"This file doesn\u0027t exist in Neutron","commit_id":"f7e05df97a96a1192d1f0c4fe01cb5dbc13569b4"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"ee4cfe5a893e59f308fc05b0bfdf448da033df6a","unresolved":false,"context_lines":[{"line_number":26,"context_line":"RESOURCE_CLASS_NAME \u003d \u0027resource_class_name\u0027"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class TestPlacementAPIClient(base.BaseTestCase):"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def setUp(self):"},{"line_number":32,"context_line":"        super(TestPlacementAPIClient, self).setUp()"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f4b6375_a9b4c080","line":29,"updated":"2017-10-26 12:38:18.000000000","message":"Question: do we think consumers will need to \"mock out\" the placement client for their testing? If so please consider adding a reusable fixture. Existing examples in neutron_lib.fixtures.py","commit_id":"f7e05df97a96a1192d1f0c4fe01cb5dbc13569b4"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"2d3ba960d9502473bae6e19ed3bc3056a76bf018","unresolved":false,"context_lines":[{"line_number":26,"context_line":"RESOURCE_CLASS_NAME \u003d \u0027resource_class_name\u0027"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class TestPlacementAPIClient(base.BaseTestCase):"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def setUp(self):"},{"line_number":32,"context_line":"        super(TestPlacementAPIClient, self).setUp()"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f4b6375_0ea3e5b3","line":29,"in_reply_to":"3f4b6375_a9b4c080","updated":"2017-11-06 09:11:11.000000000","message":"Done","commit_id":"f7e05df97a96a1192d1f0c4fe01cb5dbc13569b4"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"231347e7c6d1d7e2feed0481a84e7a83e81af4df","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def setUp(self):"},{"line_number":32,"context_line":"        super(TestPlacementAPIClient, self).setUp()"},{"line_number":33,"context_line":"        placement_client \u003d mock.Mock()"},{"line_number":34,"context_line":"        region_name \u003d \u0027region_name\u0027"},{"line_number":35,"context_line":"        self.openstack_api_version \u003d \u0027version 1.1\u0027"},{"line_number":36,"context_line":"        self.placement_api_client \u003d placement.PlacementAPIClient("}],"source_content_type":"text/x-python","patch_set":9,"id":"3f4b6375_8c38e0ed","line":33,"updated":"2017-11-07 14:46:18.000000000","message":"Why not use the shiny new fixture?","commit_id":"32371df53dde0a04c28e987821901aeef23748dd"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"970fe62ddc4ff3b6d4ad7f6270a834855b99037f","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def setUp(self):"},{"line_number":32,"context_line":"        super(TestPlacementAPIClient, self).setUp()"},{"line_number":33,"context_line":"        placement_client \u003d mock.Mock()"},{"line_number":34,"context_line":"        region_name \u003d \u0027region_name\u0027"},{"line_number":35,"context_line":"        self.openstack_api_version \u003d \u0027version 1.1\u0027"},{"line_number":36,"context_line":"        self.placement_api_client \u003d placement.PlacementAPIClient("}],"source_content_type":"text/x-python","patch_set":9,"id":"1f485f77_b155e552","line":33,"in_reply_to":"3f4b6375_8c38e0ed","updated":"2017-11-13 14:03:22.000000000","message":"Done","commit_id":"32371df53dde0a04c28e987821901aeef23748dd"}],"releasenotes/notes/rehome-placement-api-client-a9ac5d96ca8570aa.yaml":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"230d8f5466fefc5a04c24d8582e1840eaf1b1c03","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - The neutron placement API client is now available as"},{"line_number":4,"context_line":"    ``neutron_lib.client.placement``."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5f4e5783_152ad72a","line":4,"range":{"start_line":4,"start_character":18,"end_line":4,"end_character":24},"updated":"2017-10-17 10:53:05.000000000","message":"I think this should be \u0027clients\u0027.","commit_id":"da1d851d08ef36a4b65d83c0a9999c58935a2546"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"15a1f6b3591608123577920a73d2a904c8f4be5a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - The neutron placement API client is now available as"},{"line_number":4,"context_line":"    ``neutron_lib.client.placement``."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5f4e5783_f0a509a3","line":4,"range":{"start_line":4,"start_character":18,"end_line":4,"end_character":24},"in_reply_to":"5f4e5783_152ad72a","updated":"2017-10-17 11:43:27.000000000","message":"Makes sense","commit_id":"da1d851d08ef36a4b65d83c0a9999c58935a2546"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"231347e7c6d1d7e2feed0481a84e7a83e81af4df","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"3f4b6375_6c14844d","line":5,"updated":"2017-11-07 14:46:18.000000000","message":"If we are going to include the fixture, IMHO it should also be included here in its own bullet.","commit_id":"32371df53dde0a04c28e987821901aeef23748dd"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"970fe62ddc4ff3b6d4ad7f6270a834855b99037f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"1f485f77_9152e966","line":5,"in_reply_to":"3f4b6375_6c14844d","updated":"2017-11-13 14:03:22.000000000","message":"Done","commit_id":"32371df53dde0a04c28e987821901aeef23748dd"}]}
