)]}'
{"neutron_lib/api/definitions/address_scope.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"46b8a30047b790af8a6adfaa5439ecea153a9fbf","unresolved":false,"context_lines":[{"line_number":50,"context_line":"                          \u0027type:string\u0027: db_constants.PROJECT_ID_FIELD_SIZE},"},{"line_number":51,"context_line":"                      \u0027required_by_policy\u0027: True,"},{"line_number":52,"context_line":"                      \u0027is_visible\u0027: True},"},{"line_number":53,"context_line":"        constants.SHARED: {\u0027allow_post\u0027: True,"},{"line_number":54,"context_line":"                           \u0027allow_put\u0027: True,"},{"line_number":55,"context_line":"                           \u0027default\u0027: False,"},{"line_number":56,"context_line":"                           \u0027convert_to\u0027: converters.convert_to_boolean,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f96bb07_5b44d174","line":53,"updated":"2018-01-19 21:05:34.000000000","message":"just asking: why this one attribute should be treated in \"special\" way. There is no constant for any other attribute AFAIK. Maybe constant shouldn\u0027t be used here?","commit_id":"624d75828f26205a143d2c1baee106f25d448833"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"bac9bfbab31857018b72735992f21e40dec5f9d2","unresolved":false,"context_lines":[{"line_number":50,"context_line":"                          \u0027type:string\u0027: db_constants.PROJECT_ID_FIELD_SIZE},"},{"line_number":51,"context_line":"                      \u0027required_by_policy\u0027: True,"},{"line_number":52,"context_line":"                      \u0027is_visible\u0027: True},"},{"line_number":53,"context_line":"        constants.SHARED: {\u0027allow_post\u0027: True,"},{"line_number":54,"context_line":"                           \u0027allow_put\u0027: True,"},{"line_number":55,"context_line":"                           \u0027default\u0027: False,"},{"line_number":56,"context_line":"                           \u0027convert_to\u0027: converters.convert_to_boolean,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f96bb07_9fc1c531","line":53,"in_reply_to":"7f96bb07_5b44d174","updated":"2018-01-22 11:53:34.000000000","message":"IMO if there\u0027s a constant for the attr name its better to use it. I\u0027d prefer these defs to use constants where applicable rather than static strings, but I\u0027m fine either way.","commit_id":"624d75828f26205a143d2c1baee106f25d448833"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6e3d6241dc2c063f17dfe55124b8651f83079d1b","unresolved":false,"context_lines":[{"line_number":50,"context_line":"                          \u0027type:string\u0027: db_constants.PROJECT_ID_FIELD_SIZE},"},{"line_number":51,"context_line":"                      \u0027required_by_policy\u0027: True,"},{"line_number":52,"context_line":"                      \u0027is_visible\u0027: True},"},{"line_number":53,"context_line":"        constants.SHARED: {\u0027allow_post\u0027: True,"},{"line_number":54,"context_line":"                           \u0027allow_put\u0027: True,"},{"line_number":55,"context_line":"                           \u0027default\u0027: False,"},{"line_number":56,"context_line":"                           \u0027convert_to\u0027: converters.convert_to_boolean,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f96bb07_4a4cd975","line":53,"in_reply_to":"7f96bb07_9fc1c531","updated":"2018-01-22 12:11:30.000000000","message":"ok, You convinced me :)","commit_id":"624d75828f26205a143d2c1baee106f25d448833"}]}