)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"63a4d6fc974934c900e974fdeda288499c6b9001","unresolved":false,"context_lines":[{"line_number":18,"context_line":"4.There is no \"name\" attribute in \"POST /v2.0/lbaas/health_monitors\""},{"line_number":19,"context_line":"request body, but from the lbaas v2.0 code and datamodel, there is"},{"line_number":20,"context_line":" a \"name\" attribute added in to healthmonitor object."},{"line_number":21,"context_line":"The patch modifies those mistakes."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: Ia7417c818f6646c419f734d7273fd3bf8eb5aad5"},{"line_number":24,"context_line":"Closes-Bug: #1719259"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3f79a3b5_8519097b","line":21,"range":{"start_line":21,"start_character":10,"end_line":21,"end_character":18},"updated":"2018-08-13 08:22:56.000000000","message":"nit: I would rather say \"fixes\" ;)","commit_id":"140b32ada580f5aad326549567d9bb013f783757"}],"api-ref/source/v2/lbaas-v2.inc":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"33d0f93c91a854361d7dccbb792bbfe0e7bf7905","unresolved":false,"context_lines":[{"line_number":498,"context_line":""},{"line_number":499,"context_line":"- ``description``. The load balancer description."},{"line_number":500,"context_line":""},{"line_number":501,"context_line":"- ``protocol``. The IP protocol. Valid value is icmp, tcp, udp or"},{"line_number":502,"context_line":"  null. No default."},{"line_number":503,"context_line":""},{"line_number":504,"context_line":"- ``protocol_port``. The port on which the front end listens. Must"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"5f93b717_f94c25c9","line":501,"updated":"2018-01-31 16:42:48.000000000","message":"I\u0027m not following why the valid values are icmp, tcp, etc..\n\nLooking at the attribute map for \u0027protocol\u0027 [1], its valid values are LISTENER_SUPPORTED_PROTOCOLS [2] which are:\n\n  LISTENER_SUPPORTED_PROTOCOLS \u003d (PROTOCOL_TCP, PROTOCOL_HTTPS, PROTOCOL_HTTP,\n                                PROTOCOL_TERMINATED_HTTPS)\n\n\ne.g. TCP, HTTPS, etc.. the values shown for protocol before your change.\n\n\n\n[1] https://github.com/openstack/neutron-lbaas/blob/master/neutron_lbaas/extensions/loadbalancerv2.py#L247\n[2] https://github.com/openstack/neutron-lbaas/blob/master/neutron_lbaas/services/loadbalancer/constants.py#L28","commit_id":"4c04e2fe03f30447441f7a48f18aa4ab4fae5c6f"},{"author":{"_account_id":25564,"name":"yanpuqing","email":"yanpq@awcloud.com","username":"ycx"},"change_message_id":"d8e7b9315021625f8d81520fdb79b8ef17a23b1c","unresolved":false,"context_lines":[{"line_number":498,"context_line":""},{"line_number":499,"context_line":"- ``description``. The load balancer description."},{"line_number":500,"context_line":""},{"line_number":501,"context_line":"- ``protocol``. The IP protocol. Valid value is icmp, tcp, udp or"},{"line_number":502,"context_line":"  null. No default."},{"line_number":503,"context_line":""},{"line_number":504,"context_line":"- ``protocol_port``. The port on which the front end listens. Must"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"5f7c97a3_02436643","line":501,"in_reply_to":"5f93b717_f94c25c9","updated":"2018-05-16 06:29:18.000000000","message":"Done, thanks.","commit_id":"4c04e2fe03f30447441f7a48f18aa4ab4fae5c6f"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"33d0f93c91a854361d7dccbb792bbfe0e7bf7905","unresolved":false,"context_lines":[{"line_number":792,"context_line":"   - pools: pools-obj"},{"line_number":793,"context_line":"   - admin_state_up: admin_state_up"},{"line_number":794,"context_line":"   - description: description"},{"line_number":795,"context_line":"   - healthmonitor_id: healthmonitor-id"},{"line_number":796,"context_line":"   - id: pool-id-response"},{"line_number":797,"context_line":"   - lb_algorithm: lb_algorithm"},{"line_number":798,"context_line":"   - members: members"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"5f93b717_d96929f9","line":795,"updated":"2018-01-31 16:42:48.000000000","message":"These params don\u0027t seem proper to me. Based on the api def [1] I\u0027m expecting to also see:\n- listener_id\n- listeners\n- session_persistence\n- etc..\n\n\nNot quite sure why we\u0027d differ here in the API ref from whats in the actual API definition [1].\n\n\n[1] https://github.com/openstack/neutron-lbaas/blob/master/neutron_lbaas/extensions/loadbalancerv2.py#L260","commit_id":"4c04e2fe03f30447441f7a48f18aa4ab4fae5c6f"},{"author":{"_account_id":25564,"name":"yanpuqing","email":"yanpq@awcloud.com","username":"ycx"},"change_message_id":"d8e7b9315021625f8d81520fdb79b8ef17a23b1c","unresolved":false,"context_lines":[{"line_number":792,"context_line":"   - pools: pools-obj"},{"line_number":793,"context_line":"   - admin_state_up: admin_state_up"},{"line_number":794,"context_line":"   - description: description"},{"line_number":795,"context_line":"   - healthmonitor_id: healthmonitor-id"},{"line_number":796,"context_line":"   - id: pool-id-response"},{"line_number":797,"context_line":"   - lb_algorithm: lb_algorithm"},{"line_number":798,"context_line":"   - members: members"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"5f7c97a3_c28fae72","line":795,"in_reply_to":"5f93b717_d96929f9","updated":"2018-05-16 06:29:18.000000000","message":"Yes, thank you, but I just add the listeners and session_persistence params in the new patch, because the \u0027is_visible\u0027 of the listener_id is the \u0027False\u0027.[1]\n\n[1] https://github.com/openstack/neutron-lbaas/blob/0e0ce79ca46cc765e697f075b18f21c28bebef4e/neutron_lbaas/extensions/loadbalancerv2.py#L279","commit_id":"4c04e2fe03f30447441f7a48f18aa4ab4fae5c6f"}],"api-ref/source/v2/parameters.yaml":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"63a4d6fc974934c900e974fdeda288499c6b9001","unresolved":false,"context_lines":[{"line_number":3984,"context_line":"pool-session_persistence:"},{"line_number":3985,"context_line":"  description: |"},{"line_number":3986,"context_line":"    A JSON object specifying the session persistence for"},{"line_number":3987,"context_line":"    the pool or null for no session persistence. Default is null."},{"line_number":3988,"context_line":"  in: body"},{"line_number":3989,"context_line":"  required: true"},{"line_number":3990,"context_line":"  type: object"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f79a3b5_05ce592c","line":3987,"range":{"start_line":3987,"start_character":16,"end_line":3987,"end_character":20},"updated":"2018-08-13 08:22:56.000000000","message":"please write it with ``, so will be:\n``null``\n\nAnd apply this to all 4 words \"null\" in Your change :)","commit_id":"140b32ada580f5aad326549567d9bb013f783757"}],"api-ref/source/v2/samples/lbaas/healthmonitor-show-response.json":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f94276323d5430b0f0d50244e0ae147116198fda","unresolved":false,"context_lines":[{"line_number":9,"context_line":"        \"name\": \"healthmonitor1\","},{"line_number":10,"context_line":"        \"http_method\": \"GET\","},{"line_number":11,"context_line":"        \"timeout\": 1,"},{"line_number":12,"context_line":"        \"pools\": ["},{"line_number":13,"context_line":"            {"},{"line_number":14,"context_line":"                \"status\": \"ACTIVE\","},{"line_number":15,"context_line":"                \"pool_id\": \"5a9a3e9e-d1aa-448e-af37-a70171f2a332\""},{"line_number":16,"context_line":"            }"},{"line_number":17,"context_line":"        ],"},{"line_number":18,"context_line":"        \"url_path\": \"/index.html\","},{"line_number":19,"context_line":"        \"type\": \"HTTP\","},{"line_number":20,"context_line":"        \"id\": \"b7633ade-24dc-4d72-8475-06aa22be5412\""}],"source_content_type":"application/json","patch_set":7,"id":"3f79a3b5_c2ffb0a8","line":17,"range":{"start_line":12,"start_character":1,"end_line":17,"end_character":10},"updated":"2018-08-27 21:37:22.000000000","message":"This \"pools\" list does not exist in neutron-lbaas.","commit_id":"2e9238b0edd049282f390cf27de15f11c1e2a9e3"},{"author":{"_account_id":25564,"name":"yanpuqing","email":"yanpq@awcloud.com","username":"ycx"},"change_message_id":"b61527d1c50e665fb9e279e084a2a3ddea7621c2","unresolved":false,"context_lines":[{"line_number":9,"context_line":"        \"name\": \"healthmonitor1\","},{"line_number":10,"context_line":"        \"http_method\": \"GET\","},{"line_number":11,"context_line":"        \"timeout\": 1,"},{"line_number":12,"context_line":"        \"pools\": ["},{"line_number":13,"context_line":"            {"},{"line_number":14,"context_line":"                \"status\": \"ACTIVE\","},{"line_number":15,"context_line":"                \"pool_id\": \"5a9a3e9e-d1aa-448e-af37-a70171f2a332\""},{"line_number":16,"context_line":"            }"},{"line_number":17,"context_line":"        ],"},{"line_number":18,"context_line":"        \"url_path\": \"/index.html\","},{"line_number":19,"context_line":"        \"type\": \"HTTP\","},{"line_number":20,"context_line":"        \"id\": \"b7633ade-24dc-4d72-8475-06aa22be5412\""}],"source_content_type":"application/json","patch_set":7,"id":"3f79a3b5_30cf8ab1","line":17,"range":{"start_line":12,"start_character":1,"end_line":17,"end_character":10},"in_reply_to":"3f79a3b5_c2ffb0a8","updated":"2018-08-30 06:56:22.000000000","message":"The \"pools\" list exist in neutron-lbaas, but It does have a little problem in this doc, the \"pools\" just contains a \"id\" resource.\nThere is my healthmonitor-show response in my mitaka environment.[1]\nThere is \"pools\" list in healthmonitor code.[2]\nSo I\u0027m going to modify a little bit in here, thank you:)\n\n[1] {\"healthmonitor\": {\"name\": \"443\", \"admin_state_up\": true, \"tenant_id\": \"4c35cd50a2a24042bd6f524e8f5729a2\",  \"delay\": 2, \"max_retries\": 2, \"timeout\": 2, \"pools\": [{\"id\": \"7011f672-64e5-44ec-abd3-d6b8d2c4729a\"}], \"type\": \"TCP\", \"id\": \"8f7d8308-bfce-4947-b074-bd147a11f523\"}}\n[2] https://github.com/openstack/neutron-lbaas/blob/8d47cdb375b5fa52bea98823bc417100890ffb62/neutron_lbaas/services/loadbalancer/data_models.py#L343-L345","commit_id":"2e9238b0edd049282f390cf27de15f11c1e2a9e3"}],"api-ref/source/v2/samples/lbaas/healthmonitor-update-response.json":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f94276323d5430b0f0d50244e0ae147116198fda","unresolved":false,"context_lines":[{"line_number":9,"context_line":"        \"name\": \"healthmonitor1\","},{"line_number":10,"context_line":"        \"http_method\": \"POST\","},{"line_number":11,"context_line":"        \"timeout\": 2,"},{"line_number":12,"context_line":"        \"pools\": ["},{"line_number":13,"context_line":"            {"},{"line_number":14,"context_line":"                \"status\": \"ACTIVE\","},{"line_number":15,"context_line":"                \"status_description\": null,"},{"line_number":16,"context_line":"                \"pool_id\": \"5a9a3e9e-d1aa-448e-af37-a70171f2a332\""},{"line_number":17,"context_line":"            }"},{"line_number":18,"context_line":"        ],"},{"line_number":19,"context_line":"        \"url_path\": \"/page.html\","},{"line_number":20,"context_line":"        \"type\": \"HTTP\","},{"line_number":21,"context_line":"        \"id\": \"b7633ade-24dc-4d72-8475-06aa22be5412\""}],"source_content_type":"application/json","patch_set":7,"id":"3f79a3b5_822f783d","line":18,"range":{"start_line":12,"start_character":0,"end_line":18,"end_character":10},"updated":"2018-08-27 21:37:22.000000000","message":"This pools list does not exist in neutron-lbaas","commit_id":"2e9238b0edd049282f390cf27de15f11c1e2a9e3"}],"api-ref/source/v2/samples/lbaas/healthmonitors-list-response.json":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f94276323d5430b0f0d50244e0ae147116198fda","unresolved":false,"context_lines":[{"line_number":10,"context_line":"            \"name\": \"healthmonitor1\","},{"line_number":11,"context_line":"            \"http_method\": \"GET\","},{"line_number":12,"context_line":"            \"timeout\": 1,"},{"line_number":13,"context_line":"            \"pools\": ["},{"line_number":14,"context_line":"                {"},{"line_number":15,"context_line":"                    \"status\": \"ACTIVE\","},{"line_number":16,"context_line":"                    \"pool_id\": \"5a9a3e9e-d1aa-448e-af37-a70171f2a332\""},{"line_number":17,"context_line":"                }"},{"line_number":18,"context_line":"            ],"},{"line_number":19,"context_line":"            \"url_path\": \"/index.html\","},{"line_number":20,"context_line":"            \"type\": \"HTTP\","},{"line_number":21,"context_line":"            \"id\": \"b7633ade-24dc-4d72-8475-06aa22be5412\""}],"source_content_type":"application/json","patch_set":7,"id":"3f79a3b5_62281c32","line":18,"range":{"start_line":13,"start_character":0,"end_line":18,"end_character":14},"updated":"2018-08-27 21:37:22.000000000","message":"This \"pools\" list does not exist in neutron-lbaas","commit_id":"2e9238b0edd049282f390cf27de15f11c1e2a9e3"}]}