)]}'
{"api-ref/source/v2/l3-agent-scheduler.inc":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"13d39bd28d9a3eabc1688d06109d780cf228e656","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"The L3 agent scheduler extension (``l3agentschduler``) allows administrators"},{"line_number":8,"context_line":"to assign Neutron routers to Neutron L3 agents, and retrieve mappings between"},{"line_number":9,"context_line":"Neutron routers and L3 agents. This feature is implemented on top of Agent"},{"line_number":10,"context_line":"Management extension."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"List routers hosted by an L3 agent"},{"line_number":13,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"3fa0c359_0ed17e23","line":10,"range":{"start_line":9,"start_character":31,"end_line":10,"end_character":21},"updated":"2018-02-12 14:12:16.000000000","message":"Can we mention the agent extension\u0027s alias here too? e.g. ``l3_agent_scheduler``","commit_id":"619746ad69c276eeae2db1f6e32a58335ed595b3"},{"author":{"_account_id":27546,"name":"Michal Kelner Mishali","email":"mkelnermishal@vmware.com","username":"mkelnermishal"},"change_message_id":"c6ce266747803aa66a6a906909f942b55ca9a528","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"The L3 agent scheduler extension (``l3agentschduler``) allows administrators"},{"line_number":8,"context_line":"to assign Neutron routers to Neutron L3 agents, and retrieve mappings between"},{"line_number":9,"context_line":"Neutron routers and L3 agents. This feature is implemented on top of Agent"},{"line_number":10,"context_line":"Management extension."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"List routers hosted by an L3 agent"},{"line_number":13,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"1f9dbf25_d388ca72","line":10,"range":{"start_line":9,"start_character":31,"end_line":10,"end_character":21},"in_reply_to":"3fa0c359_0ed17e23","updated":"2018-03-07 12:23:37.000000000","message":"Done","commit_id":"619746ad69c276eeae2db1f6e32a58335ed595b3"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"13d39bd28d9a3eabc1688d06109d780cf228e656","unresolved":false,"context_lines":[{"line_number":15,"context_line":".. rest_method::  GET /v2.0/agents/{agent_id}/l3-routers"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Lists routers that a l3 agent host."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Normal response codes: 200"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":1,"id":"3fa0c359_cec63669","line":18,"range":{"start_line":18,"start_character":30,"end_line":18,"end_character":34},"updated":"2018-02-12 14:12:16.000000000","message":"Nit: \u0027hosts\u0027","commit_id":"619746ad69c276eeae2db1f6e32a58335ed595b3"},{"author":{"_account_id":27546,"name":"Michal Kelner Mishali","email":"mkelnermishal@vmware.com","username":"mkelnermishal"},"change_message_id":"c6ce266747803aa66a6a906909f942b55ca9a528","unresolved":false,"context_lines":[{"line_number":15,"context_line":".. rest_method::  GET /v2.0/agents/{agent_id}/l3-routers"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Lists routers that a l3 agent host."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Normal response codes: 200"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":1,"id":"1f9dbf25_737d366d","line":18,"range":{"start_line":18,"start_character":30,"end_line":18,"end_character":34},"in_reply_to":"3fa0c359_cec63669","updated":"2018-03-07 12:23:37.000000000","message":"Done","commit_id":"619746ad69c276eeae2db1f6e32a58335ed595b3"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"13d39bd28d9a3eabc1688d06109d780cf228e656","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Response Parameters"},{"line_number":32,"context_line":"-------------------"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":1,"id":"3fa0c359_a43e6ab5","line":33,"updated":"2018-02-12 14:12:16.000000000","message":"Isn\u0027t the response a list of Agent objects here? If so we should list the attribute like whats done for GET agents.","commit_id":"619746ad69c276eeae2db1f6e32a58335ed595b3"},{"author":{"_account_id":27546,"name":"Michal Kelner Mishali","email":"mkelnermishal@vmware.com","username":"mkelnermishal"},"change_message_id":"c6ce266747803aa66a6a906909f942b55ca9a528","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Response Parameters"},{"line_number":32,"context_line":"-------------------"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":1,"id":"1f9dbf25_9382424f","line":33,"in_reply_to":"3fa0c359_a43e6ab5","updated":"2018-03-07 12:23:37.000000000","message":"Done","commit_id":"619746ad69c276eeae2db1f6e32a58335ed595b3"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"13d39bd28d9a3eabc1688d06109d780cf228e656","unresolved":false,"context_lines":[{"line_number":37,"context_line":"Response Example"},{"line_number":38,"context_line":"----------------"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    - external_gateway_info: external_gateway_info"},{"line_number":43,"context_line":"    - id: agent_id-path"},{"line_number":44,"context_line":"    - name: router_name"},{"line_number":45,"context_line":"    - tenant_id: tenant_id"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":".. literalinclude:: ../v2/samples/agents/agent-l3-routers-list-response.json"},{"line_number":48,"context_line":"   :language: javascript"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"3fa0c359_c46e16c8","line":45,"range":{"start_line":40,"start_character":0,"end_line":45,"end_character":26},"updated":"2018-02-12 14:12:16.000000000","message":"Maybe you meant to put this above where I asked about the response params?","commit_id":"619746ad69c276eeae2db1f6e32a58335ed595b3"},{"author":{"_account_id":27546,"name":"Michal Kelner Mishali","email":"mkelnermishal@vmware.com","username":"mkelnermishal"},"change_message_id":"c6ce266747803aa66a6a906909f942b55ca9a528","unresolved":false,"context_lines":[{"line_number":37,"context_line":"Response Example"},{"line_number":38,"context_line":"----------------"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    - external_gateway_info: external_gateway_info"},{"line_number":43,"context_line":"    - id: agent_id-path"},{"line_number":44,"context_line":"    - name: router_name"},{"line_number":45,"context_line":"    - tenant_id: tenant_id"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":".. literalinclude:: ../v2/samples/agents/agent-l3-routers-list-response.json"},{"line_number":48,"context_line":"   :language: javascript"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"1f9dbf25_3397ae93","line":45,"range":{"start_line":40,"start_character":0,"end_line":45,"end_character":26},"in_reply_to":"3fa0c359_c46e16c8","updated":"2018-03-07 12:23:37.000000000","message":"Done","commit_id":"619746ad69c276eeae2db1f6e32a58335ed595b3"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"13d39bd28d9a3eabc1688d06109d780cf228e656","unresolved":false,"context_lines":[{"line_number":50,"context_line":"List L3 agents hosted by router"},{"line_number":51,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":".. rest_method::  GET /v2.0/agents/{router_id}/l3-agents"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Lists l3 agents that hosts a specific router."}],"source_content_type":"text/x-c++src","patch_set":1,"id":"3fa0c359_44b7663b","line":53,"range":{"start_line":53,"start_character":28,"end_line":53,"end_character":34},"updated":"2018-02-12 14:12:16.000000000","message":"This should be the path for the router API... \u0027routers\u0027 here I think","commit_id":"619746ad69c276eeae2db1f6e32a58335ed595b3"},{"author":{"_account_id":27546,"name":"Michal Kelner Mishali","email":"mkelnermishal@vmware.com","username":"mkelnermishal"},"change_message_id":"c6ce266747803aa66a6a906909f942b55ca9a528","unresolved":false,"context_lines":[{"line_number":50,"context_line":"List L3 agents hosted by router"},{"line_number":51,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":".. rest_method::  GET /v2.0/agents/{router_id}/l3-agents"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Lists l3 agents that hosts a specific router."}],"source_content_type":"text/x-c++src","patch_set":1,"id":"1f9dbf25_5394ba8b","line":53,"range":{"start_line":53,"start_character":28,"end_line":53,"end_character":34},"in_reply_to":"3fa0c359_44b7663b","updated":"2018-03-07 12:23:37.000000000","message":"Done","commit_id":"619746ad69c276eeae2db1f6e32a58335ed595b3"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"13d39bd28d9a3eabc1688d06109d780cf228e656","unresolved":false,"context_lines":[{"line_number":75,"context_line":"Response Example"},{"line_number":76,"context_line":"----------------"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    - admin_state_up: admin_state_up"},{"line_number":81,"context_line":"    - alive: alive"},{"line_number":82,"context_line":"    - ha_state: ha_state"},{"line_number":83,"context_line":"    - host: host"},{"line_number":84,"context_line":"    - id: agent_id-path"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":".. literalinclude:: ../v2/samples/agents/agent-l3-routers-list-response.json"},{"line_number":87,"context_line":"   :language: javascript"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"3fa0c359_e47f9263","line":84,"range":{"start_line":78,"start_character":0,"end_line":84,"end_character":23},"updated":"2018-02-12 14:12:16.000000000","message":"Same here; I think this was supposed to go under the REsponse params.","commit_id":"619746ad69c276eeae2db1f6e32a58335ed595b3"},{"author":{"_account_id":27546,"name":"Michal Kelner Mishali","email":"mkelnermishal@vmware.com","username":"mkelnermishal"},"change_message_id":"c6ce266747803aa66a6a906909f942b55ca9a528","unresolved":false,"context_lines":[{"line_number":75,"context_line":"Response Example"},{"line_number":76,"context_line":"----------------"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    - admin_state_up: admin_state_up"},{"line_number":81,"context_line":"    - alive: alive"},{"line_number":82,"context_line":"    - ha_state: ha_state"},{"line_number":83,"context_line":"    - host: host"},{"line_number":84,"context_line":"    - id: agent_id-path"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":".. literalinclude:: ../v2/samples/agents/agent-l3-routers-list-response.json"},{"line_number":87,"context_line":"   :language: javascript"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"1f9dbf25_b3e89e16","line":84,"range":{"start_line":78,"start_character":0,"end_line":84,"end_character":23},"in_reply_to":"3fa0c359_e47f9263","updated":"2018-03-07 12:23:37.000000000","message":"Done","commit_id":"619746ad69c276eeae2db1f6e32a58335ed595b3"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"13d39bd28d9a3eabc1688d06109d780cf228e656","unresolved":false,"context_lines":[{"line_number":86,"context_line":".. literalinclude:: ../v2/samples/agents/agent-l3-routers-list-response.json"},{"line_number":87,"context_line":"   :language: javascript"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Create l3 routers"},{"line_number":90,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":".. rest_method::  POST /v2.0/agents/{agent_id}/l3-routers"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"3fa0c359_c4ca969f","line":89,"updated":"2018-02-12 14:12:16.000000000","message":"Create adds a router to an L3 agent I believe; not creating a router here.","commit_id":"619746ad69c276eeae2db1f6e32a58335ed595b3"},{"author":{"_account_id":27546,"name":"Michal Kelner Mishali","email":"mkelnermishal@vmware.com","username":"mkelnermishal"},"change_message_id":"c6ce266747803aa66a6a906909f942b55ca9a528","unresolved":false,"context_lines":[{"line_number":86,"context_line":".. literalinclude:: ../v2/samples/agents/agent-l3-routers-list-response.json"},{"line_number":87,"context_line":"   :language: javascript"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"Create l3 routers"},{"line_number":90,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":".. rest_method::  POST /v2.0/agents/{agent_id}/l3-routers"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"1f9dbf25_33dc8e73","line":89,"in_reply_to":"3fa0c359_c4ca969f","updated":"2018-03-07 12:23:37.000000000","message":"Done","commit_id":"619746ad69c276eeae2db1f6e32a58335ed595b3"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"13d39bd28d9a3eabc1688d06109d780cf228e656","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Error codes:"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"- ``400`` The operation returns this error code if the request is malformed,"},{"line_number":97,"context_line":"  e.g. there are missing or invalid parameters in the request."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"- ``401`` The operation is not authorized."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"- ``404`` If the extension is not available"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Normal response codes: 201"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"3fa0c359_44be86ff","line":101,"range":{"start_line":96,"start_character":0,"end_line":101,"end_character":43},"updated":"2018-02-12 14:12:16.000000000","message":"I\u0027d stick with the format below... Seems inconsistent to just list the error code meanings here.","commit_id":"619746ad69c276eeae2db1f6e32a58335ed595b3"},{"author":{"_account_id":27546,"name":"Michal Kelner Mishali","email":"mkelnermishal@vmware.com","username":"mkelnermishal"},"change_message_id":"c6ce266747803aa66a6a906909f942b55ca9a528","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"Error codes:"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"- ``400`` The operation returns this error code if the request is malformed,"},{"line_number":97,"context_line":"  e.g. there are missing or invalid parameters in the request."},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"- ``401`` The operation is not authorized."},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"- ``404`` If the extension is not available"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Normal response codes: 201"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"1f9dbf25_13e39235","line":101,"range":{"start_line":96,"start_character":0,"end_line":101,"end_character":43},"in_reply_to":"3fa0c359_44be86ff","updated":"2018-03-07 12:23:37.000000000","message":"Done","commit_id":"619746ad69c276eeae2db1f6e32a58335ed595b3"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"13d39bd28d9a3eabc1688d06109d780cf228e656","unresolved":false,"context_lines":[{"line_number":111,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"   - agent_id: agent_id-path"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"Request Example"},{"line_number":116,"context_line":"---------------"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":1,"id":"3fa0c359_4453e6e2","line":114,"updated":"2018-02-12 14:12:16.000000000","message":"Need to doc the request params too; as per the controller:\n\n  router_id \u003d body[\u0027router_id\u0027]\n\nSo the request body can have a \u0027router_id\u0027 to specify the router to add to the agent. See the controller code.","commit_id":"619746ad69c276eeae2db1f6e32a58335ed595b3"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"13d39bd28d9a3eabc1688d06109d780cf228e656","unresolved":false,"context_lines":[{"line_number":115,"context_line":"Request Example"},{"line_number":116,"context_line":"---------------"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":".. literalinclude:: ../v2/samples/agents/agent-l3-router-create-request.json"},{"line_number":119,"context_line":"   :language: javascript"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"Response Parameters"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"3fa0c359_04639eb3","line":118,"range":{"start_line":118,"start_character":41,"end_line":118,"end_character":76},"updated":"2018-02-12 14:12:16.000000000","message":"Going to be a different request here; see my comment about request params.","commit_id":"619746ad69c276eeae2db1f6e32a58335ed595b3"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"13d39bd28d9a3eabc1688d06109d780cf228e656","unresolved":false,"context_lines":[{"line_number":121,"context_line":"Response Parameters"},{"line_number":122,"context_line":"-------------------"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"null"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"Response Example"},{"line_number":127,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"3fa0c359_a4718a78","line":124,"range":{"start_line":124,"start_character":0,"end_line":124,"end_character":4},"updated":"2018-02-12 14:12:16.000000000","message":"I\u0027m pretty sure something comes back in the response. we need to doc that too.","commit_id":"619746ad69c276eeae2db1f6e32a58335ed595b3"},{"author":{"_account_id":27546,"name":"Michal Kelner Mishali","email":"mkelnermishal@vmware.com","username":"mkelnermishal"},"change_message_id":"c6ce266747803aa66a6a906909f942b55ca9a528","unresolved":false,"context_lines":[{"line_number":121,"context_line":"Response Parameters"},{"line_number":122,"context_line":"-------------------"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"null"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"Response Example"},{"line_number":127,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"ff6b8bd7_f4f8587d","line":124,"range":{"start_line":124,"start_character":0,"end_line":124,"end_character":4},"in_reply_to":"3fa0c359_a4718a78","updated":"2018-03-07 12:23:37.000000000","message":"\u003e I\u0027m pretty sure something comes back in the response. we need to\n \u003e doc that too.","commit_id":"619746ad69c276eeae2db1f6e32a58335ed595b3"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"13d39bd28d9a3eabc1688d06109d780cf228e656","unresolved":false,"context_lines":[{"line_number":130,"context_line":"   :language: javascript"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"Delete l3 router"},{"line_number":134,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":".. rest_method::  DELETE /v2.0/agents/{agent_id}/l3-routers/{router_id}"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"3fa0c359_240b3ad6","line":133,"range":{"start_line":133,"start_character":0,"end_line":133,"end_character":16},"updated":"2018-02-12 14:12:16.000000000","message":"I dont think this deletes the router; it just removes it from the agent IIUC.","commit_id":"619746ad69c276eeae2db1f6e32a58335ed595b3"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"9abb9365773a42621f4d922257cbcb744d4f6d93","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"The L3 agent scheduler extension (``l3agentschduler``) allows administrators"},{"line_number":8,"context_line":"to assign Neutron routers to Neutron L3 agents, and retrieve mappings between"},{"line_number":9,"context_line":"Neutron routers and L3 agents. This feature is implemented on top of Agent"},{"line_number":10,"context_line":"Management extension, ``l3_agent_scheduler``."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"List routers hosted by an L3 agent"},{"line_number":13,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"ff6b8bd7_e15095d7","line":10,"range":{"start_line":9,"start_character":31,"end_line":10,"end_character":43},"updated":"2018-03-05 14:55:59.000000000","message":"I\u0027m a little confused on this sentence. Isn\u0027t this extension\u0027s ALIAS l3_agent_scheduler? If so this reads to me like the Agent Management Extension is aliased as l3_agent_scheduler","commit_id":"cbac621682019fbfbcbd51576835029537e5566a"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"9abb9365773a42621f4d922257cbcb744d4f6d93","unresolved":false,"context_lines":[{"line_number":34,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    - status: router-status"},{"line_number":37,"context_line":"    - ha_vr_id: router-ha-vr-id"},{"line_number":38,"context_line":"    - description: description"},{"line_number":39,"context_line":"    - tags: tags"},{"line_number":40,"context_line":"    - updated_at: updated_at"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"ff6b8bd7_e11735ed","line":37,"updated":"2018-03-05 14:55:59.000000000","message":"I\u0027m confused; isn\u0027t this response just a router resource? If so it\u0027s not clear to me where some of these response params are coming from like ha_vr_id as I don\u0027t see them returned on the GET router details API: http://logs.openstack.org/08/543408/4/check/build-openstack-api-ref/fe6113b/html/v2/index.html#routers-routers","commit_id":"cbac621682019fbfbcbd51576835029537e5566a"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"9abb9365773a42621f4d922257cbcb744d4f6d93","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    - interfaces: interfaces"},{"line_number":107,"context_line":"    - floating_ips: router-floating_ips"},{"line_number":108,"context_line":"    - interface_driver: router-interface_driver"},{"line_number":109,"context_line":"    - log_agent_heartbeats: log_agent_heartbeats"},{"line_number":110,"context_line":"    - external_network_bridge: router-external_network_bridge"},{"line_number":111,"context_line":"    - ex_gw_ports: router-external_gateway_ports"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":4,"id":"ff6b8bd7_04e6f717","line":109,"updated":"2018-03-05 14:55:59.000000000","message":"I would\u0027ve expected this to just return an \u0027agent\u0027 resource, like that from GET /v2.0/agents/{agent_id}\n\nWith that in mind I\u0027m not understanding where some of these extra params are coming from (e.g. the new ones here that are not in GET agent.\n\n\nWhat am I missing here?","commit_id":"cbac621682019fbfbcbd51576835029537e5566a"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"9abb9365773a42621f4d922257cbcb744d4f6d93","unresolved":false,"context_lines":[{"line_number":116,"context_line":".. literalinclude:: ../v2/samples/agents/router-l3-agent-list-response.json"},{"line_number":117,"context_line":"   :language: javascript"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"Schedule router to an l3 agent"},{"line_number":120,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":".. rest_method::  POST /v2.0/agents/{agent_id}/l3-routers"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"ff6b8bd7_01cfc97f","line":119,"updated":"2018-03-05 14:55:59.000000000","message":"IMO we should keep the agent APIs together, so I\u0027d opt to move this up under \"List routers hosted by an L3 agent\"","commit_id":"cbac621682019fbfbcbd51576835029537e5566a"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"9abb9365773a42621f4d922257cbcb744d4f6d93","unresolved":false,"context_lines":[{"line_number":149,"context_line":"Response Example"},{"line_number":150,"context_line":"----------------"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"   There is no body content for the response of a successful ADD request."},{"line_number":153,"context_line":""},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"Remove l3 router from an l3 agent"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"ff6b8bd7_017d891b","line":152,"range":{"start_line":152,"start_character":3,"end_line":152,"end_character":73},"updated":"2018-03-05 14:55:59.000000000","message":"Really? Seems like this might be a bug. I think we should follow-up on it. Most of the other POST requests I see return something in the response body.\n\n\nAlso no need for the tab before the text here, it changes the formatting.","commit_id":"cbac621682019fbfbcbd51576835029537e5566a"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"9abb9365773a42621f4d922257cbcb744d4f6d93","unresolved":false,"context_lines":[{"line_number":152,"context_line":"   There is no body content for the response of a successful ADD request."},{"line_number":153,"context_line":""},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"Remove l3 router from an l3 agent"},{"line_number":156,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":".. rest_method::  DELETE /v2.0/agents/{agent_id}/l3-routers/{router_id}"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"ff6b8bd7_81bbd9e3","line":155,"updated":"2018-03-05 14:55:59.000000000","message":"IMO we should keep the agent APIs together, so I\u0027d opt to move this up under \"List routers hosted by an L3 agent\"","commit_id":"cbac621682019fbfbcbd51576835029537e5566a"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"9abb9365773a42621f4d922257cbcb744d4f6d93","unresolved":false,"context_lines":[{"line_number":174,"context_line":"Response Example"},{"line_number":175,"context_line":"----------------"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"   There is no body content for the response of a successful REMOVE request."}],"source_content_type":"text/x-c++src","patch_set":4,"id":"ff6b8bd7_41986169","line":177,"range":{"start_line":177,"start_character":0,"end_line":177,"end_character":3},"updated":"2018-03-05 14:55:59.000000000","message":"This tab isn\u0027t needed and in fact changes the formatting.","commit_id":"cbac621682019fbfbcbd51576835029537e5566a"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"d24d2e6f362c09ebb33125dda7fa514321a5772d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"L3 agent scheduler"},{"line_number":5,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"The L3 agent scheduler extension (``l3agentschduler``) allows administrators"},{"line_number":8,"context_line":"to assign Neutron routers to Neutron L3 agents, and retrieve mappings between"},{"line_number":9,"context_line":"Neutron routers and L3 agents. This feature, ``l3_agent_scheduler``,"},{"line_number":10,"context_line":"is implemented on top of Agent Management extension, ."}],"source_content_type":"text/x-c++src","patch_set":6,"id":"df7087c5_b26f2dc4","line":7,"range":{"start_line":7,"start_character":36,"end_line":7,"end_character":51},"updated":"2018-03-08 14:12:01.000000000","message":"As per [1] this should be the ALIAS; l3_agent_scheduler\n\n\n[1] https://github.com/openstack/neutron/blob/master/neutron/extensions/l3agentscheduler.py#L117","commit_id":"94f9f886bc2b0d9cdca9351e164e4f4748684a52"},{"author":{"_account_id":27546,"name":"Michal Kelner Mishali","email":"mkelnermishal@vmware.com","username":"mkelnermishal"},"change_message_id":"a8b9ff4ab7580804f4017b669976ed5198977f8c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"L3 agent scheduler"},{"line_number":5,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"The L3 agent scheduler extension (``l3agentschduler``) allows administrators"},{"line_number":8,"context_line":"to assign Neutron routers to Neutron L3 agents, and retrieve mappings between"},{"line_number":9,"context_line":"Neutron routers and L3 agents. This feature, ``l3_agent_scheduler``,"},{"line_number":10,"context_line":"is implemented on top of Agent Management extension, ."}],"source_content_type":"text/x-c++src","patch_set":6,"id":"bf659307_a3d10c5a","line":7,"range":{"start_line":7,"start_character":36,"end_line":7,"end_character":51},"in_reply_to":"df7087c5_b26f2dc4","updated":"2018-04-08 08:27:14.000000000","message":"Done","commit_id":"94f9f886bc2b0d9cdca9351e164e4f4748684a52"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"d24d2e6f362c09ebb33125dda7fa514321a5772d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"The L3 agent scheduler extension (``l3agentschduler``) allows administrators"},{"line_number":8,"context_line":"to assign Neutron routers to Neutron L3 agents, and retrieve mappings between"},{"line_number":9,"context_line":"Neutron routers and L3 agents. This feature, ``l3_agent_scheduler``,"},{"line_number":10,"context_line":"is implemented on top of Agent Management extension, ."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"List routers hosted by an L3 agent"},{"line_number":13,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"df7087c5_72f8b5c3","line":10,"range":{"start_line":10,"start_character":51,"end_line":10,"end_character":54},"updated":"2018-03-08 14:12:01.000000000","message":"IMO we should just drop this last sentence; I don\u0027t see what value API users get from knowing this is impl\u0027d on top of the AME. If we decided to keep it; Extraneous \", \" at the end.","commit_id":"94f9f886bc2b0d9cdca9351e164e4f4748684a52"},{"author":{"_account_id":27546,"name":"Michal Kelner Mishali","email":"mkelnermishal@vmware.com","username":"mkelnermishal"},"change_message_id":"a8b9ff4ab7580804f4017b669976ed5198977f8c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"The L3 agent scheduler extension (``l3agentschduler``) allows administrators"},{"line_number":8,"context_line":"to assign Neutron routers to Neutron L3 agents, and retrieve mappings between"},{"line_number":9,"context_line":"Neutron routers and L3 agents. This feature, ``l3_agent_scheduler``,"},{"line_number":10,"context_line":"is implemented on top of Agent Management extension, ."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"List routers hosted by an L3 agent"},{"line_number":13,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"bf659307_c3d4404a","line":10,"range":{"start_line":10,"start_character":51,"end_line":10,"end_character":54},"in_reply_to":"df7087c5_72f8b5c3","updated":"2018-04-08 08:27:14.000000000","message":"Done","commit_id":"94f9f886bc2b0d9cdca9351e164e4f4748684a52"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"d24d2e6f362c09ebb33125dda7fa514321a5772d","unresolved":false,"context_lines":[{"line_number":31,"context_line":"Response Parameters"},{"line_number":32,"context_line":"-------------------"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    - external_gateway_info: router-external_gateway_info"},{"line_number":37,"context_line":"    - project_id: project_id"},{"line_number":38,"context_line":"    - id: router-id-body"},{"line_number":39,"context_line":"    - name: router_name"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Response Example"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"df7087c5_ed75c499","line":39,"range":{"start_line":34,"start_character":0,"end_line":39,"end_character":23},"updated":"2018-03-08 14:12:01.000000000","message":"I think I commented this before, but I didn\u0027t see a response. Doesn\u0027t this just return a list of router resources, and would thus look like the response (params) of https://developer.openstack.org/api-ref/network/v2/index.html#routers-routers  for LIST routers?","commit_id":"94f9f886bc2b0d9cdca9351e164e4f4748684a52"},{"author":{"_account_id":27546,"name":"Michal Kelner Mishali","email":"mkelnermishal@vmware.com","username":"mkelnermishal"},"change_message_id":"a8b9ff4ab7580804f4017b669976ed5198977f8c","unresolved":false,"context_lines":[{"line_number":31,"context_line":"Response Parameters"},{"line_number":32,"context_line":"-------------------"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    - external_gateway_info: router-external_gateway_info"},{"line_number":37,"context_line":"    - project_id: project_id"},{"line_number":38,"context_line":"    - id: router-id-body"},{"line_number":39,"context_line":"    - name: router_name"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Response Example"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"bf659307_83864813","line":39,"range":{"start_line":34,"start_character":0,"end_line":39,"end_character":23},"in_reply_to":"df7087c5_ed75c499","updated":"2018-04-08 08:27:14.000000000","message":"Used the same params and sample as in LIST routers.","commit_id":"94f9f886bc2b0d9cdca9351e164e4f4748684a52"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"d24d2e6f362c09ebb33125dda7fa514321a5772d","unresolved":false,"context_lines":[{"line_number":73,"context_line":"Response Parameters"},{"line_number":74,"context_line":"-------------------"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"null"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"Response Example"},{"line_number":79,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"df7087c5_8d94488d","line":76,"range":{"start_line":76,"start_character":0,"end_line":76,"end_character":4},"updated":"2018-03-08 14:12:01.000000000","message":"I think I mentioned this before, but this seems odd to not have a response body; did you follow up on it or create a bug?","commit_id":"94f9f886bc2b0d9cdca9351e164e4f4748684a52"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"d3346657191cebd283d6dcc56d7df1a7adabcc5f","unresolved":false,"context_lines":[{"line_number":73,"context_line":"Response Parameters"},{"line_number":74,"context_line":"-------------------"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"null"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"Response Example"},{"line_number":79,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"bf659307_d4136665","line":76,"range":{"start_line":76,"start_character":0,"end_line":76,"end_character":4},"in_reply_to":"bf659307_6a50a05f","updated":"2018-04-10 13:35:05.000000000","message":"I submitted a bug for this: https://bugs.launchpad.net/neutron/+bug/1762733","commit_id":"94f9f886bc2b0d9cdca9351e164e4f4748684a52"},{"author":{"_account_id":27546,"name":"Michal Kelner Mishali","email":"mkelnermishal@vmware.com","username":"mkelnermishal"},"change_message_id":"7cc2a5af54b59a13f20a3e4a75dca1efbeb2fe40","unresolved":false,"context_lines":[{"line_number":73,"context_line":"Response Parameters"},{"line_number":74,"context_line":"-------------------"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"null"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"Response Example"},{"line_number":79,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"bf659307_6a50a05f","line":76,"range":{"start_line":76,"start_character":0,"end_line":76,"end_character":4},"in_reply_to":"bf659307_a69a7ac2","updated":"2018-04-09 06:36:07.000000000","message":"The return from the plugin is None, I\u0027ve made some prints in the code:\n\nApr 08 23:31:17 mkm-instance01 neutron-server[1591]: ERROR l3agentscheduler [None req-a1112a9c-5605-4c7a-98cf-a862b37e20f4 admin admin] this is the result None","commit_id":"94f9f886bc2b0d9cdca9351e164e4f4748684a52"},{"author":{"_account_id":27546,"name":"Michal Kelner Mishali","email":"mkelnermishal@vmware.com","username":"mkelnermishal"},"change_message_id":"a8b9ff4ab7580804f4017b669976ed5198977f8c","unresolved":false,"context_lines":[{"line_number":73,"context_line":"Response Parameters"},{"line_number":74,"context_line":"-------------------"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"null"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"Response Example"},{"line_number":79,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"bf659307_a69a7ac2","line":76,"range":{"start_line":76,"start_character":0,"end_line":76,"end_character":4},"in_reply_to":"df7087c5_8d94488d","updated":"2018-04-08 08:27:14.000000000","message":"I\u0027ve tested this one using several methods (cli, curl, postman), I always get null. Also, you can see here https://specs.openstack.org/openstack/neutron-specs/specs/api/agent_schedulers.html, it says the same. I can open a bug today.","commit_id":"94f9f886bc2b0d9cdca9351e164e4f4748684a52"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"d24d2e6f362c09ebb33125dda7fa514321a5772d","unresolved":false,"context_lines":[{"line_number":78,"context_line":"Response Example"},{"line_number":79,"context_line":"----------------"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"There is no body content for the response of a successful ADD request."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"Remove l3 router from an l3 agent"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"df7087c5_0deef821","line":81,"range":{"start_line":81,"start_character":58,"end_line":81,"end_character":61},"updated":"2018-03-08 14:12:01.000000000","message":"POST?","commit_id":"94f9f886bc2b0d9cdca9351e164e4f4748684a52"},{"author":{"_account_id":27546,"name":"Michal Kelner Mishali","email":"mkelnermishal@vmware.com","username":"mkelnermishal"},"change_message_id":"a8b9ff4ab7580804f4017b669976ed5198977f8c","unresolved":false,"context_lines":[{"line_number":78,"context_line":"Response Example"},{"line_number":79,"context_line":"----------------"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"There is no body content for the response of a successful ADD request."},{"line_number":82,"context_line":""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"Remove l3 router from an l3 agent"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"bf659307_43227003","line":81,"range":{"start_line":81,"start_character":58,"end_line":81,"end_character":61},"in_reply_to":"df7087c5_0deef821","updated":"2018-04-08 08:27:14.000000000","message":"Done","commit_id":"94f9f886bc2b0d9cdca9351e164e4f4748684a52"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"d24d2e6f362c09ebb33125dda7fa514321a5772d","unresolved":false,"context_lines":[{"line_number":103,"context_line":"Response Example"},{"line_number":104,"context_line":"----------------"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"There is no body content for the response of a successful REMOVE request."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"List L3 agents hosted by router"},{"line_number":109,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"df7087c5_cdd00054","line":106,"range":{"start_line":106,"start_character":58,"end_line":106,"end_character":64},"updated":"2018-03-08 14:12:01.000000000","message":"DELETE?","commit_id":"94f9f886bc2b0d9cdca9351e164e4f4748684a52"},{"author":{"_account_id":27546,"name":"Michal Kelner Mishali","email":"mkelnermishal@vmware.com","username":"mkelnermishal"},"change_message_id":"a8b9ff4ab7580804f4017b669976ed5198977f8c","unresolved":false,"context_lines":[{"line_number":103,"context_line":"Response Example"},{"line_number":104,"context_line":"----------------"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"There is no body content for the response of a successful REMOVE request."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"List L3 agents hosted by router"},{"line_number":109,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"bf659307_e32064fa","line":106,"range":{"start_line":106,"start_character":58,"end_line":106,"end_character":64},"in_reply_to":"df7087c5_cdd00054","updated":"2018-04-08 08:27:14.000000000","message":"Done","commit_id":"94f9f886bc2b0d9cdca9351e164e4f4748684a52"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"d24d2e6f362c09ebb33125dda7fa514321a5772d","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    - host: host"},{"line_number":133,"context_line":"    - ha_state: agent-ha_state"},{"line_number":134,"context_line":"    - id: agent_id"},{"line_number":135,"context_line":"    - alive: alive"},{"line_number":136,"context_line":"    - admin_state_up: admin_state_up"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"Response Example"},{"line_number":139,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"df7087c5_4d5150d8","line":136,"range":{"start_line":132,"start_character":0,"end_line":136,"end_character":36},"updated":"2018-03-08 14:12:01.000000000","message":"Doesn\u0027t this just return a list of agent resources and would thus look like the response params for listing agents [1]? I\u0027m confused as to why there\u0027s a difference.\n\n\n[1] https://developer.openstack.org/api-ref/network/v2/index.html#agents","commit_id":"94f9f886bc2b0d9cdca9351e164e4f4748684a52"},{"author":{"_account_id":27546,"name":"Michal Kelner Mishali","email":"mkelnermishal@vmware.com","username":"mkelnermishal"},"change_message_id":"a8b9ff4ab7580804f4017b669976ed5198977f8c","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    - host: host"},{"line_number":133,"context_line":"    - ha_state: agent-ha_state"},{"line_number":134,"context_line":"    - id: agent_id"},{"line_number":135,"context_line":"    - alive: alive"},{"line_number":136,"context_line":"    - admin_state_up: admin_state_up"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"Response Example"},{"line_number":139,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"bf659307_a3efcc85","line":136,"range":{"start_line":132,"start_character":0,"end_line":136,"end_character":36},"in_reply_to":"df7087c5_4d5150d8","updated":"2018-04-08 08:27:14.000000000","message":"Used the same params and sample as in LIST agents.","commit_id":"94f9f886bc2b0d9cdca9351e164e4f4748684a52"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"d9202affd4a8857fb5d7fc4cce58ae4ea2494de9","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"   - routers: routers"},{"line_number":36,"context_line":"   - id: router-id-body"},{"line_number":37,"context_line":"   - tenant_id: project_id"},{"line_number":38,"context_line":"   - project_id: project_id"}],"source_content_type":"text/x-c++src","patch_set":7,"id":"bf659307_77fdbcaf","line":35,"updated":"2018-04-10 13:49:34.000000000","message":"I wonder if we can\u0027t somehow just ref the routers response here rather than dup the params?\n\nThe issue is that routers ref has already changed and now include the service_type_id param, not included here. Seems like if we dup the params here we have to make sure to keep them all in sync.","commit_id":"29ab93cb8c1cbeb2a175c2e80fd8940649dd72db"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"e3e55ac8ecc9e4f432375f0a385794ff16bc558d","unresolved":false,"context_lines":[{"line_number":51,"context_line":"   - distributed: router-distributed"},{"line_number":52,"context_line":"   - ha: router-ha"},{"line_number":53,"context_line":"   - availability_zone_hints: router-availability_zone_hints"},{"line_number":54,"context_line":"   - availability_zones: router-availability_zones"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":11,"id":"9f6a8fd7_a54820cc","line":54,"updated":"2018-04-18 15:08:29.000000000","message":"These params still aren\u0027t up to date with the latest router attributes [1]. Appears we are missing service_type_id and flavor_id\n\n\n[1] https://developer.openstack.org/api-ref/network/v2/#routers-routers","commit_id":"87a229387367ea1fcacea0a15e14d4d5c093edbb"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"fa967b49a1d01bdc3407f068dd13659b05303a01","unresolved":false,"context_lines":[{"line_number":120,"context_line":""},{"line_number":121,"context_line":"There is no body content for the response of a successful DELETE request."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"List L3 agents hosted by router"},{"line_number":124,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":".. rest_method::  GET /v2.0/routers/{router_id}/l3-agents"}],"source_content_type":"text/x-c++src","patch_set":13,"id":"9f6a8fd7_b66e94fd","line":123,"range":{"start_line":123,"start_character":15,"end_line":123,"end_character":31},"updated":"2018-04-24 19:38:49.000000000","message":"I think this syntax is odd. Routers don\u0027t host L3 agents. It is the other around. See L11 above. So I think this should be \"hosting a router\"","commit_id":"67f154de26839478bc92c8c44ec149ee87ac7407"},{"author":{"_account_id":27546,"name":"Michal Kelner Mishali","email":"mkelnermishal@vmware.com","username":"mkelnermishal"},"change_message_id":"5cc68e1ef4cdd31abe41ace8845757128a2e825a","unresolved":false,"context_lines":[{"line_number":120,"context_line":""},{"line_number":121,"context_line":"There is no body content for the response of a successful DELETE request."},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"List L3 agents hosted by router"},{"line_number":124,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":".. rest_method::  GET /v2.0/routers/{router_id}/l3-agents"}],"source_content_type":"text/x-c++src","patch_set":13,"id":"9f6a8fd7_3abb1d73","line":123,"range":{"start_line":123,"start_character":15,"end_line":123,"end_character":31},"in_reply_to":"9f6a8fd7_b66e94fd","updated":"2018-04-26 11:36:34.000000000","message":"Done","commit_id":"67f154de26839478bc92c8c44ec149ee87ac7407"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"fa967b49a1d01bdc3407f068dd13659b05303a01","unresolved":false,"context_lines":[{"line_number":126,"context_line":".. rest_method::  GET /v2.0/routers/{router_id}/l3-agents"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"Lists l3 agent hosted by a specific router."},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"Normal response codes: 200"},{"line_number":132,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":13,"id":"9f6a8fd7_3653643b","line":129,"range":{"start_line":129,"start_character":15,"end_line":129,"end_character":43},"updated":"2018-04-24 19:38:49.000000000","message":"hosting a specific router","commit_id":"67f154de26839478bc92c8c44ec149ee87ac7407"},{"author":{"_account_id":27546,"name":"Michal Kelner Mishali","email":"mkelnermishal@vmware.com","username":"mkelnermishal"},"change_message_id":"5cc68e1ef4cdd31abe41ace8845757128a2e825a","unresolved":false,"context_lines":[{"line_number":126,"context_line":".. rest_method::  GET /v2.0/routers/{router_id}/l3-agents"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"Lists l3 agent hosted by a specific router."},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"Normal response codes: 200"},{"line_number":132,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":13,"id":"9f6a8fd7_daaf8129","line":129,"range":{"start_line":129,"start_character":15,"end_line":129,"end_character":43},"in_reply_to":"9f6a8fd7_3653643b","updated":"2018-04-26 11:36:34.000000000","message":"Done","commit_id":"67f154de26839478bc92c8c44ec149ee87ac7407"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fac7c0cce66db083ffe12f5ceaf908d52d9ac8eb","unresolved":false,"context_lines":[{"line_number":14,"context_line":".. rest_method::  GET /v2.0/agents/{agent_id}/l3-routers"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Lists routers that a l3 agent hosts."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Normal response codes: 200"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":14,"id":"9f6a8fd7_63124065","line":17,"range":{"start_line":17,"start_character":19,"end_line":17,"end_character":20},"updated":"2018-04-27 07:31:16.000000000","message":"nit: \"an\" probably :)","commit_id":"ef6facf95da15ded55afa4e1fa2393a33d20353d"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fac7c0cce66db083ffe12f5ceaf908d52d9ac8eb","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":".. rest_method::  POST /v2.0/agents/{agent_id}/l3-routers"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Add a router to an l3 agent"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Normal response codes: 201"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":14,"id":"9f6a8fd7_1e3ab7cc","line":68,"updated":"2018-04-27 07:31:16.000000000","message":"missing \".\" at the end of sentence","commit_id":"ef6facf95da15ded55afa4e1fa2393a33d20353d"},{"author":{"_account_id":27546,"name":"Michal Kelner Mishali","email":"mkelnermishal@vmware.com","username":"mkelnermishal"},"change_message_id":"d5025af65d808ab8b7a8b80f758573684863fd21","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":".. rest_method::  POST /v2.0/agents/{agent_id}/l3-routers"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"Add a router to an l3 agent"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Normal response codes: 201"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":14,"id":"9f6a8fd7_2ee171ff","line":68,"in_reply_to":"9f6a8fd7_1e3ab7cc","updated":"2018-04-29 08:09:52.000000000","message":"Done","commit_id":"ef6facf95da15ded55afa4e1fa2393a33d20353d"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fac7c0cce66db083ffe12f5ceaf908d52d9ac8eb","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":".. rest_method::  DELETE /v2.0/agents/{agent_id}/l3-routers/{router_id}"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Removes a router from a l3 agent."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"Normal response codes: 204"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":14,"id":"9f6a8fd7_7e0c133b","line":104,"range":{"start_line":104,"start_character":22,"end_line":104,"end_character":23},"updated":"2018-04-27 07:31:16.000000000","message":"s/a/an ?","commit_id":"ef6facf95da15ded55afa4e1fa2393a33d20353d"},{"author":{"_account_id":27546,"name":"Michal Kelner Mishali","email":"mkelnermishal@vmware.com","username":"mkelnermishal"},"change_message_id":"d5025af65d808ab8b7a8b80f758573684863fd21","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":".. rest_method::  DELETE /v2.0/agents/{agent_id}/l3-routers/{router_id}"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"Removes a router from a l3 agent."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"Normal response codes: 204"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":14,"id":"9f6a8fd7_cee5550c","line":104,"range":{"start_line":104,"start_character":22,"end_line":104,"end_character":23},"in_reply_to":"9f6a8fd7_7e0c133b","updated":"2018-04-29 08:09:52.000000000","message":"Done","commit_id":"ef6facf95da15ded55afa4e1fa2393a33d20353d"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fac7c0cce66db083ffe12f5ceaf908d52d9ac8eb","unresolved":false,"context_lines":[{"line_number":126,"context_line":".. rest_method::  GET /v2.0/routers/{router_id}/l3-agents"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"Lists l3 agent hosting a specific router."},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"Normal response codes: 200"},{"line_number":132,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":14,"id":"9f6a8fd7_7e25f3aa","line":129,"range":{"start_line":129,"start_character":9,"end_line":129,"end_character":14},"updated":"2018-04-27 07:31:16.000000000","message":"agents probably","commit_id":"ef6facf95da15ded55afa4e1fa2393a33d20353d"},{"author":{"_account_id":27546,"name":"Michal Kelner Mishali","email":"mkelnermishal@vmware.com","username":"mkelnermishal"},"change_message_id":"d5025af65d808ab8b7a8b80f758573684863fd21","unresolved":false,"context_lines":[{"line_number":126,"context_line":".. rest_method::  GET /v2.0/routers/{router_id}/l3-agents"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"Lists l3 agent hosting a specific router."},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"Normal response codes: 200"},{"line_number":132,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":14,"id":"9f6a8fd7_8eef5de8","line":129,"range":{"start_line":129,"start_character":9,"end_line":129,"end_character":14},"in_reply_to":"9f6a8fd7_7e25f3aa","updated":"2018-04-29 08:09:52.000000000","message":"Done","commit_id":"ef6facf95da15ded55afa4e1fa2393a33d20353d"}],"api-ref/source/v2/parameters.yaml":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"8a647b6f88d952c260dfc32a2cc7b81d6a0e31dc","unresolved":false,"context_lines":[{"line_number":3970,"context_line":"  in: body"},{"line_number":3971,"context_line":"  required: false"},{"line_number":3972,"context_line":"  type: boolean"},{"line_number":3973,"context_line":"router_id:"},{"line_number":3974,"context_line":"  description: |"},{"line_number":3975,"context_line":"    The ID of the router."},{"line_number":3976,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"df7087c5_11cb9753","line":3973,"updated":"2018-03-07 11:52:39.000000000","message":"what\u0027s the difference between this one and route-id-body? Do we need both of them?","commit_id":"8f955769a5f99d1f13cdce8eac58cf61f55670c9"},{"author":{"_account_id":27546,"name":"Michal Kelner Mishali","email":"mkelnermishal@vmware.com","username":"mkelnermishal"},"change_message_id":"c6ce266747803aa66a6a906909f942b55ca9a528","unresolved":false,"context_lines":[{"line_number":3970,"context_line":"  in: body"},{"line_number":3971,"context_line":"  required: false"},{"line_number":3972,"context_line":"  type: boolean"},{"line_number":3973,"context_line":"router_id:"},{"line_number":3974,"context_line":"  description: |"},{"line_number":3975,"context_line":"    The ID of the router."},{"line_number":3976,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"df7087c5_8ce8ea16","line":3973,"in_reply_to":"df7087c5_11cb9753","updated":"2018-03-07 12:23:37.000000000","message":"changing to router-id-body","commit_id":"8f955769a5f99d1f13cdce8eac58cf61f55670c9"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"8a647b6f88d952c260dfc32a2cc7b81d6a0e31dc","unresolved":false,"context_lines":[{"line_number":4519,"context_line":"  in: body"},{"line_number":4520,"context_line":"  required: true"},{"line_number":4521,"context_line":"  type: string"},{"line_number":4522,"context_line":"tenant_id:"},{"line_number":4523,"context_line":"  description: |"},{"line_number":4524,"context_line":"    ID of the tenant."},{"line_number":4525,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"df7087c5_91dc8719","line":4522,"updated":"2018-03-07 11:52:39.000000000","message":"can\u0027t project_id be used instead?","commit_id":"8f955769a5f99d1f13cdce8eac58cf61f55670c9"},{"author":{"_account_id":27546,"name":"Michal Kelner Mishali","email":"mkelnermishal@vmware.com","username":"mkelnermishal"},"change_message_id":"c6ce266747803aa66a6a906909f942b55ca9a528","unresolved":false,"context_lines":[{"line_number":4519,"context_line":"  in: body"},{"line_number":4520,"context_line":"  required: true"},{"line_number":4521,"context_line":"  type: string"},{"line_number":4522,"context_line":"tenant_id:"},{"line_number":4523,"context_line":"  description: |"},{"line_number":4524,"context_line":"    ID of the tenant."},{"line_number":4525,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"df7087c5_4cf2d208","line":4522,"in_reply_to":"df7087c5_91dc8719","updated":"2018-03-07 12:23:37.000000000","message":"Done","commit_id":"8f955769a5f99d1f13cdce8eac58cf61f55670c9"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"d24d2e6f362c09ebb33125dda7fa514321a5772d","unresolved":false,"context_lines":[{"line_number":383,"context_line":"  type: object"},{"line_number":384,"context_line":"agent-ha_state:"},{"line_number":385,"context_line":"  description: |"},{"line_number":386,"context_line":"    agent ha state."},{"line_number":387,"context_line":"  in: body"},{"line_number":388,"context_line":"  required: true"},{"line_number":389,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"df7087c5_4dff10aa","line":386,"range":{"start_line":386,"start_character":4,"end_line":386,"end_character":19},"updated":"2018-03-08 14:12:01.000000000","message":"If this is needed better to have a more complete description. But as per my comments I\u0027m not sure why the agent response params don\u0027t match that from the list response of agents API.","commit_id":"94f9f886bc2b0d9cdca9351e164e4f4748684a52"},{"author":{"_account_id":27546,"name":"Michal Kelner Mishali","email":"mkelnermishal@vmware.com","username":"mkelnermishal"},"change_message_id":"a8b9ff4ab7580804f4017b669976ed5198977f8c","unresolved":false,"context_lines":[{"line_number":383,"context_line":"  type: object"},{"line_number":384,"context_line":"agent-ha_state:"},{"line_number":385,"context_line":"  description: |"},{"line_number":386,"context_line":"    agent ha state."},{"line_number":387,"context_line":"  in: body"},{"line_number":388,"context_line":"  required: true"},{"line_number":389,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bf659307_83a16849","line":386,"range":{"start_line":386,"start_character":4,"end_line":386,"end_character":19},"in_reply_to":"df7087c5_4dff10aa","updated":"2018-04-08 08:27:14.000000000","message":"removed","commit_id":"94f9f886bc2b0d9cdca9351e164e4f4748684a52"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"d24d2e6f362c09ebb33125dda7fa514321a5772d","unresolved":false,"context_lines":[{"line_number":393,"context_line":"  in: body"},{"line_number":394,"context_line":"  required: true"},{"line_number":395,"context_line":"  type: string"},{"line_number":396,"context_line":"agent_mode:"},{"line_number":397,"context_line":"  description: |"},{"line_number":398,"context_line":"    Agent mode such as ``legacy``."},{"line_number":399,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"df7087c5_2d6dfc97","line":396,"range":{"start_line":396,"start_character":0,"end_line":396,"end_character":10},"updated":"2018-03-08 14:12:01.000000000","message":"Where is this used?","commit_id":"94f9f886bc2b0d9cdca9351e164e4f4748684a52"},{"author":{"_account_id":27546,"name":"Michal Kelner Mishali","email":"mkelnermishal@vmware.com","username":"mkelnermishal"},"change_message_id":"a8b9ff4ab7580804f4017b669976ed5198977f8c","unresolved":false,"context_lines":[{"line_number":393,"context_line":"  in: body"},{"line_number":394,"context_line":"  required: true"},{"line_number":395,"context_line":"  type: string"},{"line_number":396,"context_line":"agent_mode:"},{"line_number":397,"context_line":"  description: |"},{"line_number":398,"context_line":"    Agent mode such as ``legacy``."},{"line_number":399,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bf659307_23889cc4","line":396,"range":{"start_line":396,"start_character":0,"end_line":396,"end_character":10},"in_reply_to":"df7087c5_2d6dfc97","updated":"2018-04-08 08:27:14.000000000","message":"removed","commit_id":"94f9f886bc2b0d9cdca9351e164e4f4748684a52"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fac7c0cce66db083ffe12f5ceaf908d52d9ac8eb","unresolved":false,"context_lines":[{"line_number":1013,"context_line":"  in: body"},{"line_number":1014,"context_line":"  required: true"},{"line_number":1015,"context_line":"  type: object"},{"line_number":1016,"context_line":"agent_id:"},{"line_number":1017,"context_line":"  description: |"},{"line_number":1018,"context_line":"    The ID of the agent."},{"line_number":1019,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"9f6a8fd7_9e4b275e","line":1016,"updated":"2018-04-27 07:31:16.000000000","message":"Do You need to propose new variable here? There is already \"id\" variable defined below and it is used e.g. in \"agents.inc\" file in agents API description","commit_id":"ef6facf95da15ded55afa4e1fa2393a33d20353d"}],"api-ref/source/v2/samples/agents/agent-l3-router-add-request.json":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"9abb9365773a42621f4d922257cbcb744d4f6d93","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{\"router_id\": \"43e66290-79a4-415d-9eb9-7ff7919839e1\"}"}],"source_content_type":"application/json","patch_set":4,"id":"ff6b8bd7_61afa594","line":1,"updated":"2018-03-05 14:55:59.000000000","message":"Please use JSON formatting like the other responses. e.g.:\n\n  {\n      \"router_id\": \"43e66290-79a4-415d-9eb9-7ff7919839e1\"\n  }","commit_id":"cbac621682019fbfbcbd51576835029537e5566a"}],"api-ref/source/v2/samples/agents/router-l3-agent-list-response.json":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"8a647b6f88d952c260dfc32a2cc7b81d6a0e31dc","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    \"host\": \"mkm-instance01\","},{"line_number":4,"context_line":"    \"ha_state\": \"\","},{"line_number":5,"context_line":"    \"id\": \"d8276eef-945d-49bb-a804-b11adea51bb5\","},{"line_number":6,"context_line":"    \"alive\": \":-)\","},{"line_number":7,"context_line":"    \"admin_state_up\": true"},{"line_number":8,"context_line":"  }"},{"line_number":9,"context_line":"]"}],"source_content_type":"application/json","patch_set":5,"id":"df7087c5_11f9577f","line":6,"range":{"start_line":6,"start_character":14,"end_line":6,"end_character":17},"updated":"2018-03-07 11:52:39.000000000","message":"I think that such smile is not send from neutron, it is only used in client","commit_id":"8f955769a5f99d1f13cdce8eac58cf61f55670c9"},{"author":{"_account_id":27546,"name":"Michal Kelner Mishali","email":"mkelnermishal@vmware.com","username":"mkelnermishal"},"change_message_id":"c6ce266747803aa66a6a906909f942b55ca9a528","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    \"host\": \"mkm-instance01\","},{"line_number":4,"context_line":"    \"ha_state\": \"\","},{"line_number":5,"context_line":"    \"id\": \"d8276eef-945d-49bb-a804-b11adea51bb5\","},{"line_number":6,"context_line":"    \"alive\": \":-)\","},{"line_number":7,"context_line":"    \"admin_state_up\": true"},{"line_number":8,"context_line":"  }"},{"line_number":9,"context_line":"]"}],"source_content_type":"application/json","patch_set":5,"id":"df7087c5_2c70be72","line":6,"range":{"start_line":6,"start_character":14,"end_line":6,"end_character":17},"in_reply_to":"df7087c5_11f9577f","updated":"2018-03-07 12:23:37.000000000","message":"thanks, changed to true","commit_id":"8f955769a5f99d1f13cdce8eac58cf61f55670c9"}]}
