)]}'
{"neutron_lib/api/definitions/base.py":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"c55e3770155d14ad03bb164e76645ab0b46e3788","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    \u0027bgpvpn\u0027,  # https://git.openstack.org/cgit/openstack/networking-bgpvpn"},{"line_number":131,"context_line":"    \u0027bgpvpn-routes-control\u0027,"},{"line_number":132,"context_line":"    \u0027bgpvpn-vni\u0027,"},{"line_number":133,"context_line":"    \u0027segment\u0027,  # https://git.openstack.org/cgit/openstack/neutron"},{"line_number":134,"context_line":")"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"KNOWN_KEYWORDS \u003d ("}],"source_content_type":"text/x-python","patch_set":2,"id":"df7087c5_41d82a7e","line":133,"range":{"start_line":133,"start_character":4,"end_line":133,"end_character":66},"updated":"2018-03-09 07:06:15.000000000","message":"Please look at L123. This line should be moved above L113.","commit_id":"5e98c9eb388d7a3160a2d7eb3bcb54a4b2aea6f3"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"cf796171ffd031954a27ffb318b528149f0773e3","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    \u0027bgpvpn\u0027,  # https://git.openstack.org/cgit/openstack/networking-bgpvpn"},{"line_number":131,"context_line":"    \u0027bgpvpn-routes-control\u0027,"},{"line_number":132,"context_line":"    \u0027bgpvpn-vni\u0027,"},{"line_number":133,"context_line":"    \u0027segment\u0027,  # https://git.openstack.org/cgit/openstack/neutron"},{"line_number":134,"context_line":")"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"KNOWN_KEYWORDS \u003d ("}],"source_content_type":"text/x-python","patch_set":2,"id":"df7087c5_81a2c24a","line":133,"range":{"start_line":133,"start_character":4,"end_line":133,"end_character":66},"in_reply_to":"df7087c5_41d82a7e","updated":"2018-03-09 07:54:38.000000000","message":"Done","commit_id":"5e98c9eb388d7a3160a2d7eb3bcb54a4b2aea6f3"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"290101d48633d25390fc927ccd766230f2434c53","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    \u0027router\u0027,"},{"line_number":111,"context_line":"    \u0027router_availability_zone\u0027,"},{"line_number":112,"context_line":"    \u0027security-group\u0027,"},{"line_number":113,"context_line":"    \u0027segment\u0027,"},{"line_number":114,"context_line":"    \u0027service-type\u0027,"},{"line_number":115,"context_line":"    \u0027sorting\u0027,"},{"line_number":116,"context_line":"    \u0027standard-attr-description\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_70aced33","line":113,"range":{"start_line":113,"start_character":5,"end_line":113,"end_character":12},"updated":"2018-03-12 12:15:32.000000000","message":"Should this match your API def alias: subnet-segmentid-writable ??","commit_id":"51ce968c1b2413a33ceee816856e502efea0f4c0"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"f3126e23af9f1bc7eed7d070faa83a2b15ea0487","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    \u0027router\u0027,"},{"line_number":111,"context_line":"    \u0027router_availability_zone\u0027,"},{"line_number":112,"context_line":"    \u0027security-group\u0027,"},{"line_number":113,"context_line":"    \u0027segment\u0027,"},{"line_number":114,"context_line":"    \u0027service-type\u0027,"},{"line_number":115,"context_line":"    \u0027sorting\u0027,"},{"line_number":116,"context_line":"    \u0027standard-attr-description\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_ae9ea151","line":113,"range":{"start_line":113,"start_character":5,"end_line":113,"end_character":12},"in_reply_to":"df7087c5_70aced33","updated":"2018-03-12 13:50:15.000000000","message":"I agree that this patch shoud add subnet-segmentid-writable but the \u0027segment\u0027 is needed here. I think that it\u0027s missed when it\u0027s rehomed. The subnet-segmentid-writable requires \u0027segment\u0027 extension so we should add it as well.","commit_id":"51ce968c1b2413a33ceee816856e502efea0f4c0"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"354f396b21fc37522788854153dc9f6112d98f2d","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    \u0027router\u0027,"},{"line_number":111,"context_line":"    \u0027router_availability_zone\u0027,"},{"line_number":112,"context_line":"    \u0027security-group\u0027,"},{"line_number":113,"context_line":"    \u0027segment\u0027,"},{"line_number":114,"context_line":"    \u0027service-type\u0027,"},{"line_number":115,"context_line":"    \u0027sorting\u0027,"},{"line_number":116,"context_line":"    \u0027standard-attr-description\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_71ef0eb0","line":113,"range":{"start_line":113,"start_character":5,"end_line":113,"end_character":12},"in_reply_to":"df7087c5_ae9ea151","updated":"2018-03-12 14:29:14.000000000","message":"Sorry, I missed this comment. I will upload another patch set shortly.","commit_id":"51ce968c1b2413a33ceee816856e502efea0f4c0"}],"neutron_lib/tests/unit/api/definitions/test_subnet_segmentid_writable.py":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"290101d48633d25390fc927ccd766230f2434c53","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class SubnetSegmentIDDefinitionTestCase(base.DefinitionBaseTestCase):"},{"line_number":18,"context_line":"    extension_module \u003d subnet_segmentid_writable"},{"line_number":19,"context_line":"    extension_attributes \u003d (\u0027segment_id\u0027,)"}],"source_content_type":"text/x-python","patch_set":3,"id":"df7087c5_d07299e3","line":19,"range":{"start_line":19,"start_character":29,"end_line":19,"end_character":39},"updated":"2018-03-12 12:15:32.000000000","message":"Can\u0027t we use segment.SEGMENT_ID here?","commit_id":"51ce968c1b2413a33ceee816856e502efea0f4c0"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"39a8c9cc72f7fd043ef963184ce460ab9db135a3","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class SubnetSegmentIDDefinitionTestCase(base.DefinitionBaseTestCase):"},{"line_number":18,"context_line":"    extension_module \u003d subnet_segmentid_writable"},{"line_number":19,"context_line":"    extension_attributes \u003d (\u0027segment_id\u0027,)"}],"source_content_type":"text/x-python","patch_set":4,"id":"df7087c5_6bc4d75f","line":19,"range":{"start_line":19,"start_character":29,"end_line":19,"end_character":39},"updated":"2018-03-13 13:06:20.000000000","message":"I think I mentioned this before, but can\u0027t we use segment.SEGMENT_ID here?","commit_id":"6c2c71d884c41f51c2afe5301ff25d90f9d65502"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"19faf24f288b81106c1b986eaf2de39d32c273fa","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"class SubnetSegmentIDDefinitionTestCase(base.DefinitionBaseTestCase):"},{"line_number":18,"context_line":"    extension_module \u003d subnet_segmentid_writable"},{"line_number":19,"context_line":"    extension_attributes \u003d (\u0027segment_id\u0027,)"}],"source_content_type":"text/x-python","patch_set":4,"id":"df7087c5_661c0ec1","line":19,"range":{"start_line":19,"start_character":29,"end_line":19,"end_character":39},"in_reply_to":"df7087c5_6bc4d75f","updated":"2018-03-13 14:08:59.000000000","message":"Done","commit_id":"6c2c71d884c41f51c2afe5301ff25d90f9d65502"}],"releasenotes/notes/subnet_segmentid_writable-e28a85033272f05d.yaml":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"290101d48633d25390fc927ccd766230f2434c53","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Make segment_id of subnet resource writable. Enables the possibility to"},{"line_number":5,"context_line":"    migrate a non-routed network to a routed network."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"df7087c5_f046bd7c","line":4,"range":{"start_line":4,"start_character":9,"end_line":4,"end_character":19},"updated":"2018-03-12 12:15:32.000000000","message":"Nit: use ``segment_id``.","commit_id":"51ce968c1b2413a33ceee816856e502efea0f4c0"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"39a8c9cc72f7fd043ef963184ce460ab9db135a3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Make segment_id of subnet resource writable. Enables the possibility to"},{"line_number":5,"context_line":"    migrate a non-routed network to a routed network."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"df7087c5_0ba3dbb3","line":4,"range":{"start_line":4,"start_character":9,"end_line":4,"end_character":19},"updated":"2018-03-13 13:06:20.000000000","message":"As nitted before: this would format a little nicer with:\n\n  ``segment_id``","commit_id":"6c2c71d884c41f51c2afe5301ff25d90f9d65502"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"19faf24f288b81106c1b986eaf2de39d32c273fa","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Make segment_id of subnet resource writable. Enables the possibility to"},{"line_number":5,"context_line":"    migrate a non-routed network to a routed network."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"df7087c5_c6807ac2","line":4,"range":{"start_line":4,"start_character":9,"end_line":4,"end_character":19},"in_reply_to":"df7087c5_0ba3dbb3","updated":"2018-03-13 14:08:59.000000000","message":"Done","commit_id":"6c2c71d884c41f51c2afe5301ff25d90f9d65502"}]}
