)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"572e06bfd36552ddf1048f2c19fb2d9b52890307","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"rehome model_query and its dependencies"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch rehomes neutron_lib.db._model_query into neutron-lib. While"},{"line_number":10,"context_line":"our longer term goal to use OVO rather than queries and tables, this"},{"line_number":11,"context_line":"module is provided as a stepping stone (as mentioned in release note"},{"line_number":12,"context_line":"herein). The patch also includes a few other APIs that are required for"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9f6a8fd7_c7b658fb","line":9,"range":{"start_line":9,"start_character":19,"end_line":9,"end_character":30},"updated":"2018-04-19 17:34:45.000000000","message":"neutron","commit_id":"090657fa8104495ba59c415a3cb797e0ce609a77"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"572e06bfd36552ddf1048f2c19fb2d9b52890307","unresolved":false,"context_lines":[{"line_number":7,"context_line":"rehome model_query and its dependencies"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch rehomes neutron_lib.db._model_query into neutron-lib. While"},{"line_number":10,"context_line":"our longer term goal to use OVO rather than queries and tables, this"},{"line_number":11,"context_line":"module is provided as a stepping stone (as mentioned in release note"},{"line_number":12,"context_line":"herein). The patch also includes a few other APIs that are required for"},{"line_number":13,"context_line":"the rehome including some utils and an exception class."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9f6a8fd7_62509ad5","line":10,"range":{"start_line":10,"start_character":21,"end_line":10,"end_character":23},"updated":"2018-04-19 17:34:45.000000000","message":"is to","commit_id":"090657fa8104495ba59c415a3cb797e0ce609a77"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"572e06bfd36552ddf1048f2c19fb2d9b52890307","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"For more details see the spec on [1]."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Also a sample consumption patch can be found on [2]. While won\u0027t work"},{"line_number":18,"context_line":"as-is with the depends on approach (it needs to be rebased on multiple"},{"line_number":19,"context_line":"other DNMs in neutron) I tested in locally. In addition this change"},{"line_number":20,"context_line":"was tested locally with a sample vmware-nsx consumption patch [3]."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9f6a8fd7_62697a89","line":17,"range":{"start_line":17,"start_character":58,"end_line":17,"end_character":64},"updated":"2018-04-19 17:34:45.000000000","message":"it won\u0027t?","commit_id":"090657fa8104495ba59c415a3cb797e0ce609a77"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"572e06bfd36552ddf1048f2c19fb2d9b52890307","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Also a sample consumption patch can be found on [2]. While won\u0027t work"},{"line_number":18,"context_line":"as-is with the depends on approach (it needs to be rebased on multiple"},{"line_number":19,"context_line":"other DNMs in neutron) I tested in locally. In addition this change"},{"line_number":20,"context_line":"was tested locally with a sample vmware-nsx consumption patch [3]."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"[1] https://review.openstack.org/#/c/473531/"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9f6a8fd7_02067ecf","line":19,"range":{"start_line":19,"start_character":32,"end_line":19,"end_character":34},"updated":"2018-04-19 17:34:45.000000000","message":"it","commit_id":"090657fa8104495ba59c415a3cb797e0ce609a77"}],"doc/source/contributor/db_model_query.rst":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"8ddecad128f664808efeafa5325b168c28f5a275","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"9f6a8fd7_d98638dc","updated":"2018-04-19 19:27:06.000000000","message":"Thanks! Great way to preserve the documentation :-)","commit_id":"966e2c1e27c72d4a39caf877877a1520ba2c0db2"}],"neutron_lib/db/model_query.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"572e06bfd36552ddf1048f2c19fb2d9b52890307","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    :param query_hook: The method to be called to augment the query."},{"line_number":72,"context_line":"    :param filter_hook: A method to be called to augment the query filter."},{"line_number":73,"context_line":"    :param result_filters: A Method to be called to filter the query result."},{"line_number":74,"context_line":"    :returns: None."},{"line_number":75,"context_line":"    \"\"\""},{"line_number":76,"context_line":"    if callable(query_hook):"},{"line_number":77,"context_line":"        query_hook \u003d helpers.make_weak_ref(query_hook)"}],"source_content_type":"text/x-python","patch_set":9,"id":"9f6a8fd7_e244aa1d","line":74,"updated":"2018-04-19 17:34:45.000000000","message":"While I understand:\n\n1) The note in L15 above\n2) You are trying to stick to a standard format for the docstring\n\nI think we are loosing a good piece of documentation: https://github.com/openstack/neutron/blob/master/neutron/db/_model_query.py#L86-L107.\n\nPlease consider keeping it for the sake of clarity and other Neutron devs","commit_id":"090657fa8104495ba59c415a3cb797e0ce609a77"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"572e06bfd36552ddf1048f2c19fb2d9b52890307","unresolved":false,"context_lines":[{"line_number":288,"context_line":"    :param model: The model for the collection."},{"line_number":289,"context_line":"    :param dict_func: The function used to build the collection dict."},{"line_number":290,"context_line":"    :param filters: The filters to apply."},{"line_number":291,"context_line":"    :param fields: The fields to collecty."},{"line_number":292,"context_line":"    :param sorts: The sort keys to use."},{"line_number":293,"context_line":"    :param limit: The limit for the query if applicable."},{"line_number":294,"context_line":"    :param marker_obj: The marker object if applicable."}],"source_content_type":"text/x-python","patch_set":9,"id":"9f6a8fd7_4708082b","line":291,"range":{"start_line":291,"start_character":33,"end_line":291,"end_character":41},"updated":"2018-04-19 17:34:45.000000000","message":"collect","commit_id":"090657fa8104495ba59c415a3cb797e0ce609a77"}],"neutron_lib/tests/unit/db/test_model_query.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"9a8fa1a9154eaab5425c4fffbc9af5df6cf47f64","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        self.useFixture(fixture.DBQueryHooksFixture())"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def test_register_hook(self):"},{"line_number":30,"context_line":"        hook \u003d lambda x: x"},{"line_number":31,"context_line":"        mock_model \u003d mock.Mock()"},{"line_number":32,"context_line":"        model_query.register_hook("},{"line_number":33,"context_line":"            mock_model, \u0027hook1\u0027, hook, hook, result_filters\u003dhook)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f6a8fd7_9ac82975","line":30,"updated":"2018-04-14 21:04:49.000000000","message":"pep8 is complaining about this one","commit_id":"8a921aff68b80986da2c6f9aea268edaf8a44e1e"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"8e82aada63d5b1e103f17fb89556f5208e2dbb52","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        self.useFixture(fixture.DBQueryHooksFixture())"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def test_register_hook(self):"},{"line_number":30,"context_line":"        hook \u003d lambda x: x"},{"line_number":31,"context_line":"        mock_model \u003d mock.Mock()"},{"line_number":32,"context_line":"        model_query.register_hook("},{"line_number":33,"context_line":"            mock_model, \u0027hook1\u0027, hook, hook, result_filters\u003dhook)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f6a8fd7_bebcebbb","line":30,"in_reply_to":"9f6a8fd7_9ac82975","updated":"2018-04-16 15:35:12.000000000","message":"Got it... and the next one too.","commit_id":"8a921aff68b80986da2c6f9aea268edaf8a44e1e"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"9a8fa1a9154eaab5425c4fffbc9af5df6cf47f64","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                self.assertEqual(hook_ref, d.get(k))"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def test_register_hook_non_callables(self):"},{"line_number":43,"context_line":"        hook \u003d lambda x: x"},{"line_number":44,"context_line":"        mock_model \u003d mock.Mock()"},{"line_number":45,"context_line":"        model_query.register_hook("},{"line_number":46,"context_line":"            mock_model, \u0027hook1\u0027, hook, {}, result_filters\u003d{})"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f6a8fd7_bac5ed5d","line":43,"updated":"2018-04-14 21:04:49.000000000","message":"same here","commit_id":"8a921aff68b80986da2c6f9aea268edaf8a44e1e"}],"releasenotes/notes/rehome-db-model-query-234b1559f3728a5e.yaml":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"572e06bfd36552ddf1048f2c19fb2d9b52890307","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - The public functions of ``neutron.db._model_query`` are not available in"},{"line_number":4,"context_line":"    ``neutron_lib.db.model_query`` with the same name. While this modules can"},{"line_number":5,"context_line":"    be used, forward looking projects should start moving to versioned objects"},{"line_number":6,"context_line":"    and after which point we can remove this module."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9f6a8fd7_227aa287","line":3,"range":{"start_line":3,"start_character":60,"end_line":3,"end_character":63},"updated":"2018-04-19 17:34:45.000000000","message":"now","commit_id":"090657fa8104495ba59c415a3cb797e0ce609a77"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"572e06bfd36552ddf1048f2c19fb2d9b52890307","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - The public functions of ``neutron.db._model_query`` are not available in"},{"line_number":4,"context_line":"    ``neutron_lib.db.model_query`` with the same name. While this modules can"},{"line_number":5,"context_line":"    be used, forward looking projects should start moving to versioned objects"},{"line_number":6,"context_line":"    and after which point we can remove this module."},{"line_number":7,"context_line":"  - A new fixture named ``DBQueryHooksFixture`` is provided for testing"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9f6a8fd7_a26552e3","line":4,"range":{"start_line":4,"start_character":61,"end_line":4,"end_character":65},"updated":"2018-04-19 17:34:45.000000000","message":"these","commit_id":"090657fa8104495ba59c415a3cb797e0ce609a77"}]}