)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"0b0f63a3b4403b4831bdfb9e715a12de61b16c51","unresolved":false,"context_lines":[{"line_number":10,"context_line":"defined in data model but this attribute is defined in API definition"},{"line_number":11,"context_line":"which is inconsistent. This patch removes this attribute from"},{"line_number":12,"context_line":"API definition."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Id93530645821aec66de0ef9dfebf29af59076a98"},{"line_number":15,"context_line":"Closes-Bug: #1773827"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_00aa8c6f","line":13,"updated":"2018-06-01 04:47:39.000000000","message":"I have seen old bug[1] which may be related to this issue. Did you check it works fine?\n\n[1]: https://review.openstack.org/#/c/217440/","commit_id":"549779b31579974663181bb3da7b86ca665e7e57"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"6f46cf83b83f22f7c31011f603a59f30a64be9ad","unresolved":false,"context_lines":[{"line_number":10,"context_line":"defined in data model but this attribute is defined in API definition"},{"line_number":11,"context_line":"which is inconsistent. This patch removes this attribute from"},{"line_number":12,"context_line":"API definition."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Id93530645821aec66de0ef9dfebf29af59076a98"},{"line_number":15,"context_line":"Closes-Bug: #1773827"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_bddf110b","line":13,"in_reply_to":"5f7c97a3_00aa8c6f","updated":"2018-06-04 19:13:40.000000000","message":"Thanks for pointing this out.\n\nI have checked bug #217440 and it didn\u0027t work fine, so this patch is not the right approach to proceed.\n\nIn order to fix bug #1773827, there are several options available:\n\n* Mark the \u0027tenant_id\u0027 field as invisible and reject the request if the sort_key is an invisible attribute.\n* Add \u0027tenant_id\u0027 to the data model of flavor and service_profiles (which requires db migration).\n* Hack the sorting logic to ignore non-existing attribute.\n\nWhich option is the right direction to proceed?","commit_id":"549779b31579974663181bb3da7b86ca665e7e57"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"5c11acc5e2c06fbe05346d886058edbcd43f897d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Mark tenant_id as invisible for some resources"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"According to the API reference [1], the resources flavors,"},{"line_number":10,"context_line":"service_profiles and metering label rules don\u0027t have attribute"},{"line_number":11,"context_line":"\u0027tenant_id\u0027 in their responses. Therefore, this attribute should"},{"line_number":12,"context_line":"be marked as invisible in apidef."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"[1] https://developer.openstack.org/api-ref/network/v2/"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Id93530645821aec66de0ef9dfebf29af59076a98"},{"line_number":17,"context_line":"Related-Bug: #1773827"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_871e68b9","line":14,"range":{"start_line":9,"start_character":0,"end_line":14,"end_character":55},"updated":"2018-06-18 02:59:46.000000000","message":"nit: I think that API reference is not specification. We just created the reference according to the implementation and specification. It\u0027s better to point to the specification[1] here.\n\n[1]: https://specs.openstack.org/openstack/neutron-specs/specs/liberty/neutron-flavor-framework.html","commit_id":"4fa23af7f30597ea1d53f77a786844ab9d5b08d8"}]}