)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"b6adc9f0173695b5e9bf84d9d796541c11a02ece","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update the segment api extension"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The segment api defintion is changed in server side [1]. This patch"},{"line_number":10,"context_line":"sync up the defintion in neutron-lib. In addition, remove the"},{"line_number":11,"context_line":"dependency from standard-attr-segment on segment since the"},{"line_number":12,"context_line":"dependency is reserved: we have segment depending on"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_c03b4bce","line":9,"range":{"start_line":9,"start_character":16,"end_line":9,"end_character":25},"updated":"2018-06-25 19:57:49.000000000","message":"nit: definition","commit_id":"88d53455baed35c42fd2fe379a48fb14b7c3042a"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"cee6a442e2f80c31222f8bb94033101f9c9691ce","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update the segment api extension"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The segment api defintion is changed in server side [1]. This patch"},{"line_number":10,"context_line":"sync up the defintion in neutron-lib. In addition, remove the"},{"line_number":11,"context_line":"dependency from standard-attr-segment on segment since the"},{"line_number":12,"context_line":"dependency is reserved: we have segment depending on"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_c44edf94","line":9,"range":{"start_line":9,"start_character":16,"end_line":9,"end_character":25},"in_reply_to":"5f7c97a3_c03b4bce","updated":"2018-06-26 22:16:20.000000000","message":"Done","commit_id":"88d53455baed35c42fd2fe379a48fb14b7c3042a"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"b6adc9f0173695b5e9bf84d9d796541c11a02ece","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Update the segment api extension"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The segment api defintion is changed in server side [1]. This patch"},{"line_number":10,"context_line":"sync up the defintion in neutron-lib. In addition, remove the"},{"line_number":11,"context_line":"dependency from standard-attr-segment on segment since the"},{"line_number":12,"context_line":"dependency is reserved: we have segment depending on"},{"line_number":13,"context_line":"standard-attr-segment with the latest change."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_6087d762","line":10,"range":{"start_line":10,"start_character":12,"end_line":10,"end_character":21},"updated":"2018-06-25 19:57:49.000000000","message":"definition","commit_id":"88d53455baed35c42fd2fe379a48fb14b7c3042a"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"cee6a442e2f80c31222f8bb94033101f9c9691ce","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Update the segment api extension"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The segment api defintion is changed in server side [1]. This patch"},{"line_number":10,"context_line":"sync up the defintion in neutron-lib. In addition, remove the"},{"line_number":11,"context_line":"dependency from standard-attr-segment on segment since the"},{"line_number":12,"context_line":"dependency is reserved: we have segment depending on"},{"line_number":13,"context_line":"standard-attr-segment with the latest change."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_64410b63","line":10,"range":{"start_line":10,"start_character":12,"end_line":10,"end_character":21},"in_reply_to":"5f7c97a3_6087d762","updated":"2018-06-26 22:16:20.000000000","message":"Done","commit_id":"88d53455baed35c42fd2fe379a48fb14b7c3042a"}],"neutron_lib/api/definitions/segment.py":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"20e1a2cf27edf4358f23df4b715701cc5e971c85","unresolved":false,"context_lines":[{"line_number":106,"context_line":"            \u0027is_sort_key\u0027: True,"},{"line_number":107,"context_line":"            \u0027is_visible\u0027: True"},{"line_number":108,"context_line":"        },"},{"line_number":109,"context_line":"        \u0027description\u0027: {"},{"line_number":110,"context_line":"            \u0027allow_post\u0027: True,"},{"line_number":111,"context_line":"            \u0027allow_put\u0027: True,"},{"line_number":112,"context_line":"            \u0027default\u0027: constants.ATTR_NOT_SPECIFIED,"},{"line_number":113,"context_line":"            \u0027validate\u0027: {"},{"line_number":114,"context_line":"                \u0027type:string_or_none\u0027: DESC_LEN"},{"line_number":115,"context_line":"            },"},{"line_number":116,"context_line":"            \u0027is_visible\u0027: True"},{"line_number":117,"context_line":"        }"},{"line_number":118,"context_line":"    },"},{"line_number":119,"context_line":"    subnet.COLLECTION_NAME: {"},{"line_number":120,"context_line":"        SEGMENT_ID: {"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_ce812cc4","line":117,"range":{"start_line":109,"start_character":9,"end_line":117,"end_character":9},"updated":"2018-06-26 10:50:11.000000000","message":"Shouldn\u0027t description be removed as per https://review.openstack.org/#/c/571292/2/neutron/extensions/segment.py","commit_id":"88d53455baed35c42fd2fe379a48fb14b7c3042a"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"cee6a442e2f80c31222f8bb94033101f9c9691ce","unresolved":false,"context_lines":[{"line_number":106,"context_line":"            \u0027is_sort_key\u0027: True,"},{"line_number":107,"context_line":"            \u0027is_visible\u0027: True"},{"line_number":108,"context_line":"        },"},{"line_number":109,"context_line":"        \u0027description\u0027: {"},{"line_number":110,"context_line":"            \u0027allow_post\u0027: True,"},{"line_number":111,"context_line":"            \u0027allow_put\u0027: True,"},{"line_number":112,"context_line":"            \u0027default\u0027: constants.ATTR_NOT_SPECIFIED,"},{"line_number":113,"context_line":"            \u0027validate\u0027: {"},{"line_number":114,"context_line":"                \u0027type:string_or_none\u0027: DESC_LEN"},{"line_number":115,"context_line":"            },"},{"line_number":116,"context_line":"            \u0027is_visible\u0027: True"},{"line_number":117,"context_line":"        }"},{"line_number":118,"context_line":"    },"},{"line_number":119,"context_line":"    subnet.COLLECTION_NAME: {"},{"line_number":120,"context_line":"        SEGMENT_ID: {"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_a44ba384","line":117,"range":{"start_line":109,"start_character":9,"end_line":117,"end_character":9},"in_reply_to":"5f7c97a3_ce812cc4","updated":"2018-06-26 22:16:20.000000000","message":"Done","commit_id":"88d53455baed35c42fd2fe379a48fb14b7c3042a"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"8626a50db87c3bc2342af774d3a6b40172226321","unresolved":false,"context_lines":[{"line_number":124,"context_line":"SUB_RESOURCE_ATTRIBUTE_MAP \u003d {}"},{"line_number":125,"context_line":"ACTION_MAP \u003d {}"},{"line_number":126,"context_line":"REQUIRED_EXTENSIONS \u003d ["},{"line_number":127,"context_line":"    \u0027standard-attr-description\u0027,"},{"line_number":128,"context_line":"    stdattrseg.ALIAS"},{"line_number":129,"context_line":"]"},{"line_number":130,"context_line":"OPTIONAL_EXTENSIONS \u003d []"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_6c8452b3","line":127,"range":{"start_line":127,"start_character":4,"end_line":127,"end_character":31},"updated":"2018-06-29 02:37:46.000000000","message":"The standard_attr_segment requires this extension so I think that it\u0027s not necessary to require it here.","commit_id":"f774221409e10ce186b4535b3199a419b82501a8"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"7146a2671c3a0427cc6169d90f58f6005aefccbc","unresolved":false,"context_lines":[{"line_number":124,"context_line":"SUB_RESOURCE_ATTRIBUTE_MAP \u003d {}"},{"line_number":125,"context_line":"ACTION_MAP \u003d {}"},{"line_number":126,"context_line":"REQUIRED_EXTENSIONS \u003d ["},{"line_number":127,"context_line":"    \u0027standard-attr-description\u0027,"},{"line_number":128,"context_line":"    stdattrseg.ALIAS"},{"line_number":129,"context_line":"]"},{"line_number":130,"context_line":"OPTIONAL_EXTENSIONS \u003d []"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_e99a8611","line":127,"range":{"start_line":127,"start_character":4,"end_line":127,"end_character":31},"in_reply_to":"5f7c97a3_6c8452b3","updated":"2018-06-29 14:35:25.000000000","message":"This is a decision made on server\u0027s patch: https://review.openstack.org/#/c/571292/2/neutron/extensions/segment.py . I will let @boden to comment on it.","commit_id":"f774221409e10ce186b4535b3199a419b82501a8"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"d7a29c16997bde22861ac4eb31b14b5dfbed957b","unresolved":false,"context_lines":[{"line_number":124,"context_line":"SUB_RESOURCE_ATTRIBUTE_MAP \u003d {}"},{"line_number":125,"context_line":"ACTION_MAP \u003d {}"},{"line_number":126,"context_line":"REQUIRED_EXTENSIONS \u003d ["},{"line_number":127,"context_line":"    \u0027standard-attr-description\u0027,"},{"line_number":128,"context_line":"    stdattrseg.ALIAS"},{"line_number":129,"context_line":"]"},{"line_number":130,"context_line":"OPTIONAL_EXTENSIONS \u003d []"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_b99d40bc","line":127,"range":{"start_line":127,"start_character":4,"end_line":127,"end_character":31},"in_reply_to":"5f7c97a3_7d059014","updated":"2018-07-06 13:13:45.000000000","message":"I\u0027m saying:\n\n- segment requires standard-attr-description and optionally requires standard-attr-segment.\n- standard-attr-segment requires segment.\n\n\nThe optional dependency from segment -\u003e standard-attr-segment may not technically have any impact, but doesn\u0027t it better describe the segment api def? If not I\u0027m fine with not having the optional dependency if you think the required dependency is sufficient.\n\n\nOf course if others have different ideas, please speak up.","commit_id":"f774221409e10ce186b4535b3199a419b82501a8"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"f08ef5b997e34df3e7a61a3b41c950387a30f482","unresolved":false,"context_lines":[{"line_number":124,"context_line":"SUB_RESOURCE_ATTRIBUTE_MAP \u003d {}"},{"line_number":125,"context_line":"ACTION_MAP \u003d {}"},{"line_number":126,"context_line":"REQUIRED_EXTENSIONS \u003d ["},{"line_number":127,"context_line":"    \u0027standard-attr-description\u0027,"},{"line_number":128,"context_line":"    stdattrseg.ALIAS"},{"line_number":129,"context_line":"]"},{"line_number":130,"context_line":"OPTIONAL_EXTENSIONS \u003d []"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_4f553a51","line":127,"range":{"start_line":127,"start_character":4,"end_line":127,"end_character":31},"in_reply_to":"5f7c97a3_b99d40bc","updated":"2018-07-06 14:58:48.000000000","message":"Done","commit_id":"f774221409e10ce186b4535b3199a419b82501a8"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"80ad7aaa9f37dcab31ca4fcf9c5e465e700c2de3","unresolved":false,"context_lines":[{"line_number":124,"context_line":"SUB_RESOURCE_ATTRIBUTE_MAP \u003d {}"},{"line_number":125,"context_line":"ACTION_MAP \u003d {}"},{"line_number":126,"context_line":"REQUIRED_EXTENSIONS \u003d ["},{"line_number":127,"context_line":"    \u0027standard-attr-description\u0027,"},{"line_number":128,"context_line":"    stdattrseg.ALIAS"},{"line_number":129,"context_line":"]"},{"line_number":130,"context_line":"OPTIONAL_EXTENSIONS \u003d []"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_7d059014","line":127,"range":{"start_line":127,"start_character":4,"end_line":127,"end_character":31},"in_reply_to":"5f7c97a3_cd2a1690","updated":"2018-07-03 19:56:07.000000000","message":"It sounds like your suggestion is:\n\n* segment optionally depends on standard_attr_segment\n* standard_attr_segment mandatory depends on segment\n\nIs it correct? If yes, then the optional dependency won\u0027t have any effect because the extension loading process will block on loading these two extensions and drop the optional dependency to proceed? It sounds like the optional dependency is unnecessary.","commit_id":"f774221409e10ce186b4535b3199a419b82501a8"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"5b7916e4beee145ba0fdb25d2f63590eb2524d47","unresolved":false,"context_lines":[{"line_number":124,"context_line":"SUB_RESOURCE_ATTRIBUTE_MAP \u003d {}"},{"line_number":125,"context_line":"ACTION_MAP \u003d {}"},{"line_number":126,"context_line":"REQUIRED_EXTENSIONS \u003d ["},{"line_number":127,"context_line":"    \u0027standard-attr-description\u0027,"},{"line_number":128,"context_line":"    stdattrseg.ALIAS"},{"line_number":129,"context_line":"]"},{"line_number":130,"context_line":"OPTIONAL_EXTENSIONS \u003d []"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_cd2a1690","line":127,"range":{"start_line":127,"start_character":4,"end_line":127,"end_character":31},"in_reply_to":"5f7c97a3_e99a8611","updated":"2018-07-02 13:11:05.000000000","message":"I\u0027m not sure we fully discussed/addressed the circular dependency issue on 571292. So let\u0027s decide the best way here and I\u0027m happy to update neutron if needed based on our decision.\n\n\nSome of the considerations here in IMO are:\n- Since \u0027description\u0027 is removed from segment, but is part of the resource, it seems segment needs to depend on standard-attr-description, otherwise if not present the segment resource is incomplete/broken (missing \u0027description\u0027).\n- In terms of expressing the dependencies/api, it seems standard-attr-segment should depend on segment; it really only applies to this resource and is useless without.\n\n\nWhat if we made segment depend on standard-attr-description with an optional dependency on standard_attr_segment. Then standard_attr_segment could depend on segment without the circular dependency I think.\n\n\nWhat do you think?","commit_id":"f774221409e10ce186b4535b3199a419b82501a8"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"bd54c1db12ad7c83444a6407c98ab25dbd9c4fec","unresolved":false,"context_lines":[{"line_number":126,"context_line":"    \u0027standard-attr-description\u0027"},{"line_number":127,"context_line":"]"},{"line_number":128,"context_line":"OPTIONAL_EXTENSIONS \u003d ["},{"line_number":129,"context_line":"    \u0027standard-attr-segment\u0027"},{"line_number":130,"context_line":"]"},{"line_number":131,"context_line":"ACTION_STATUS \u003d {}"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_657cd770","line":129,"range":{"start_line":129,"start_character":5,"end_line":129,"end_character":26},"updated":"2018-07-06 15:56:49.000000000","message":"To avoid circulated import, I use string instead of constant in here.","commit_id":"fff9a49691816f902edd6cc149c30d56229c76a4"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"f7a1334ac6210a1fe19b1a555fe00494e5a8871e","unresolved":false,"context_lines":[{"line_number":126,"context_line":"    \u0027standard-attr-description\u0027"},{"line_number":127,"context_line":"]"},{"line_number":128,"context_line":"OPTIONAL_EXTENSIONS \u003d ["},{"line_number":129,"context_line":"    \u0027standard-attr-segment\u0027"},{"line_number":130,"context_line":"]"},{"line_number":131,"context_line":"ACTION_STATUS \u003d {}"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_2e4c8d40","line":129,"range":{"start_line":129,"start_character":5,"end_line":129,"end_character":26},"in_reply_to":"3f79a3b5_e5255d0a","updated":"2018-08-13 15:50:11.000000000","message":"Done","commit_id":"fff9a49691816f902edd6cc149c30d56229c76a4"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"35a63226abb143850d138d0588583423bdce80b1","unresolved":false,"context_lines":[{"line_number":126,"context_line":"    \u0027standard-attr-description\u0027"},{"line_number":127,"context_line":"]"},{"line_number":128,"context_line":"OPTIONAL_EXTENSIONS \u003d ["},{"line_number":129,"context_line":"    \u0027standard-attr-segment\u0027"},{"line_number":130,"context_line":"]"},{"line_number":131,"context_line":"ACTION_STATUS \u003d {}"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_e5255d0a","line":129,"range":{"start_line":129,"start_character":5,"end_line":129,"end_character":26},"in_reply_to":"5f7c97a3_657cd770","updated":"2018-08-13 08:14:50.000000000","message":"Maybe this should be added as comment in code instead of comment on Gerrit only?","commit_id":"fff9a49691816f902edd6cc149c30d56229c76a4"}],"neutron_lib/api/definitions/standard_attr_segment.py":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"8626a50db87c3bc2342af774d3a6b40172226321","unresolved":false,"context_lines":[{"line_number":22,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {}"},{"line_number":23,"context_line":"SUB_RESOURCE_ATTRIBUTE_MAP \u003d {}"},{"line_number":24,"context_line":"ACTION_MAP \u003d {}"},{"line_number":25,"context_line":"REQUIRED_EXTENSIONS \u003d [segment.ALIAS]"},{"line_number":26,"context_line":"OPTIONAL_EXTENSIONS \u003d ["},{"line_number":27,"context_line":"    \u0027standard-attr-description\u0027,"},{"line_number":28,"context_line":"    \u0027standard-attr-timestamp\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_8c652e4c","side":"PARENT","line":25,"range":{"start_line":25,"start_character":23,"end_line":25,"end_character":36},"updated":"2018-06-29 02:37:46.000000000","message":"Do we need to remove it? This extension need segment extension, right?","commit_id":"76020dd81f0a65bca34abc9d02de0e48b09545d4"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"7146a2671c3a0427cc6169d90f58f6005aefccbc","unresolved":false,"context_lines":[{"line_number":22,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {}"},{"line_number":23,"context_line":"SUB_RESOURCE_ATTRIBUTE_MAP \u003d {}"},{"line_number":24,"context_line":"ACTION_MAP \u003d {}"},{"line_number":25,"context_line":"REQUIRED_EXTENSIONS \u003d [segment.ALIAS]"},{"line_number":26,"context_line":"OPTIONAL_EXTENSIONS \u003d ["},{"line_number":27,"context_line":"    \u0027standard-attr-description\u0027,"},{"line_number":28,"context_line":"    \u0027standard-attr-timestamp\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_c91d4a78","side":"PARENT","line":25,"range":{"start_line":25,"start_character":23,"end_line":25,"end_character":36},"in_reply_to":"5f7c97a3_8c652e4c","updated":"2018-06-29 14:35:25.000000000","message":"If it is not removed, there will be a circulate dependency across extensions. In theory, this extension is a shim extension so it doesn\u0027t have to depend on segment extension. However, I am totally fine if you want to set the dependency but the circulate dependency problem is a blocker.","commit_id":"76020dd81f0a65bca34abc9d02de0e48b09545d4"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"6d774471edefd42eef7c62f93fa9f353be1fa808","unresolved":false,"context_lines":[{"line_number":22,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {}"},{"line_number":23,"context_line":"SUB_RESOURCE_ATTRIBUTE_MAP \u003d {}"},{"line_number":24,"context_line":"ACTION_MAP \u003d {}"},{"line_number":25,"context_line":"REQUIRED_EXTENSIONS \u003d [segment.ALIAS]"},{"line_number":26,"context_line":"OPTIONAL_EXTENSIONS \u003d ["},{"line_number":27,"context_line":"    \u0027standard-attr-description\u0027,"},{"line_number":28,"context_line":"    \u0027standard-attr-timestamp\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_2ecdcd2f","side":"PARENT","line":25,"range":{"start_line":25,"start_character":23,"end_line":25,"end_character":36},"in_reply_to":"5f7c97a3_c91d4a78","updated":"2018-07-02 02:58:58.000000000","message":"I see. Actually this extension extended segment extension but it seemed that neutron patch[1] replaced them. I\u0027d like to see boden\u0027s opinion.\n\n[1]: https://review.openstack.org/#/c/571292/","commit_id":"76020dd81f0a65bca34abc9d02de0e48b09545d4"}],"releasenotes/notes/update-segment-api-definition-d7297e73e76a754c.yaml":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"35a63226abb143850d138d0588583423bdce80b1","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    This release removes the ``description`` from the segment extension\u0027s"},{"line_number":5,"context_line":"    attribute map as well as adds the ``standard-attr-description`` and"},{"line_number":6,"context_line":"    ``standard-attr-segment`` as a required dependency."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    In addition, extension ``standard-attr-segment`` doesn\u0027t depends on"},{"line_number":9,"context_line":"    extension ``segment`` anymore."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_0532d95e","line":6,"range":{"start_line":6,"start_character":6,"end_line":6,"end_character":27},"updated":"2018-08-13 08:14:50.000000000","message":"this is added as \"optional extension\" - which version is then correct?","commit_id":"fff9a49691816f902edd6cc149c30d56229c76a4"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"f7a1334ac6210a1fe19b1a555fe00494e5a8871e","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    This release removes the ``description`` from the segment extension\u0027s"},{"line_number":5,"context_line":"    attribute map as well as adds the ``standard-attr-description`` and"},{"line_number":6,"context_line":"    ``standard-attr-segment`` as a required dependency."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    In addition, extension ``standard-attr-segment`` doesn\u0027t depends on"},{"line_number":9,"context_line":"    extension ``segment`` anymore."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_ae617dab","line":6,"range":{"start_line":6,"start_character":6,"end_line":6,"end_character":27},"in_reply_to":"3f79a3b5_0532d95e","updated":"2018-08-13 15:50:11.000000000","message":"Done","commit_id":"fff9a49691816f902edd6cc149c30d56229c76a4"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"35a63226abb143850d138d0588583423bdce80b1","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    attribute map as well as adds the ``standard-attr-description`` and"},{"line_number":6,"context_line":"    ``standard-attr-segment`` as a required dependency."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    In addition, extension ``standard-attr-segment`` doesn\u0027t depends on"},{"line_number":9,"context_line":"    extension ``segment`` anymore."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_e53c7d30","line":9,"range":{"start_line":8,"start_character":4,"end_line":9,"end_character":34},"updated":"2018-08-13 08:14:50.000000000","message":"sorry but where this change is in Your patch?","commit_id":"fff9a49691816f902edd6cc149c30d56229c76a4"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"f7a1334ac6210a1fe19b1a555fe00494e5a8871e","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    attribute map as well as adds the ``standard-attr-description`` and"},{"line_number":6,"context_line":"    ``standard-attr-segment`` as a required dependency."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    In addition, extension ``standard-attr-segment`` doesn\u0027t depends on"},{"line_number":9,"context_line":"    extension ``segment`` anymore."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_2efa4dbc","line":9,"range":{"start_line":8,"start_character":4,"end_line":9,"end_character":34},"in_reply_to":"3f79a3b5_e53c7d30","updated":"2018-08-13 15:50:11.000000000","message":"I removed it. This change was in the previous patchset and removed in latest patchset to address reviewer\u0027s comment.","commit_id":"fff9a49691816f902edd6cc149c30d56229c76a4"}]}