)]}'
{"api-ref/source/v2/floatingips.inc":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"b42764681beae63f3622539e397fa19a17802210","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3f79a3b5_d967b34c","updated":"2018-08-15 14:50:42.000000000","message":"Should this really be part of the floatingips.inc? Seems like it\u0027s a new top-level resource and should maybe be in its own file??","commit_id":"036f69c9b2f5ee597dd4a2882a04dd6a350061b7"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"42d810d29240a09160f918e49fc232a07be3db86","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3f79a3b5_949004f0","in_reply_to":"3f79a3b5_d967b34c","updated":"2018-08-16 15:04:25.000000000","message":"Done","commit_id":"036f69c9b2f5ee597dd4a2882a04dd6a350061b7"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"20af55da75ae2cc995bf726f3cfbe505543e6e53","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3f79a3b5_0aab8b74","in_reply_to":"3f79a3b5_d967b34c","updated":"2018-08-15 16:06:09.000000000","message":"IMO, its okay to have it here but for consistency can be done like subnetpool is separate of subnets !","commit_id":"036f69c9b2f5ee597dd4a2882a04dd6a350061b7"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"a371eeca401b05df51cb9d3448b04b535e869bdc","unresolved":false,"context_lines":[{"line_number":419,"context_line":".. rest_method::  GET /v2.0/floatingip_pools"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"Lists floating IP pools visible to the user."},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"Normal response codes: 200"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"Error response codes: 401"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"5f7c97a3_2049fa2d","line":422,"updated":"2018-07-30 18:32:59.000000000","message":"may be for consistency these two lines can also be added like they are here https://github.com/openstack/neutron-lib/blob/master/api-ref/source/v2/floatingips.inc#L54_L55","commit_id":"036f69c9b2f5ee597dd4a2882a04dd6a350061b7"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"574eb4a5636192b9d0836d69783e546eb09a89e8","unresolved":false,"context_lines":[{"line_number":419,"context_line":".. rest_method::  GET /v2.0/floatingip_pools"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"Lists floating IP pools visible to the user."},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"Normal response codes: 200"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"Error response codes: 401"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"5f7c97a3_fb94f9e8","line":422,"in_reply_to":"5f7c97a3_2049fa2d","updated":"2018-07-31 18:48:33.000000000","message":"Not sure exactly what you were trying to suggest. Could you elaborate?","commit_id":"036f69c9b2f5ee597dd4a2882a04dd6a350061b7"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"554397af5abf02e8c2a40aa498ad29c6f0144b03","unresolved":false,"context_lines":[{"line_number":419,"context_line":".. rest_method::  GET /v2.0/floatingip_pools"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"Lists floating IP pools visible to the user."},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"Normal response codes: 200"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"Error response codes: 401"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"3f79a3b5_95f713d4","line":422,"in_reply_to":"5f7c97a3_843802cb","updated":"2018-08-10 15:55:54.000000000","message":"I feel this is optional. Only floating IP contains those two lines and it really doesn\u0027t give too much information IMO.","commit_id":"036f69c9b2f5ee597dd4a2882a04dd6a350061b7"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"34a1bbe58f2ba8084c30b643881bf711d60770b8","unresolved":false,"context_lines":[{"line_number":419,"context_line":".. rest_method::  GET /v2.0/floatingip_pools"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"Lists floating IP pools visible to the user."},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"Normal response codes: 200"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"Error response codes: 401"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"5f7c97a3_843802cb","line":422,"in_reply_to":"5f7c97a3_fb94f9e8","updated":"2018-07-31 20:23:58.000000000","message":"I meant add an example like https://github.com/openstack/neutron-lib/blob/master/api-ref/source/v2/floatingips.inc#L54_L55 has with\nAccept: application/json","commit_id":"036f69c9b2f5ee597dd4a2882a04dd6a350061b7"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"a371eeca401b05df51cb9d3448b04b535e869bdc","unresolved":false,"context_lines":[{"line_number":425,"context_line":"Error response codes: 401"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"Request"},{"line_number":428,"context_line":"-------"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"Response Parameters"},{"line_number":431,"context_line":"-------------------"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"5f7c97a3_e0d2225b","line":428,"range":{"start_line":428,"start_character":0,"end_line":428,"end_character":7},"updated":"2018-07-30 18:32:59.000000000","message":"was this suppose to include rest_parameters ?","commit_id":"036f69c9b2f5ee597dd4a2882a04dd6a350061b7"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"e28c492e94c2fd55cf594de17cb3c6e1aad6ac55","unresolved":false,"context_lines":[{"line_number":425,"context_line":"Error response codes: 401"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"Request"},{"line_number":428,"context_line":"-------"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"Response Parameters"},{"line_number":431,"context_line":"-------------------"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"3f79a3b5_2ea48da5","line":428,"range":{"start_line":428,"start_character":0,"end_line":428,"end_character":7},"in_reply_to":"3f79a3b5_2e3d6dc3","updated":"2018-08-13 15:56:45.000000000","message":"In other places of this API reference, if there is no request parameters, this will be empty without a note. I would opt for that option for consistency if there is no further inputs from other reviewers.","commit_id":"036f69c9b2f5ee597dd4a2882a04dd6a350061b7"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"b42764681beae63f3622539e397fa19a17802210","unresolved":false,"context_lines":[{"line_number":425,"context_line":"Error response codes: 401"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"Request"},{"line_number":428,"context_line":"-------"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"Response Parameters"},{"line_number":431,"context_line":"-------------------"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"3f79a3b5_39582786","line":428,"range":{"start_line":428,"start_character":0,"end_line":428,"end_character":7},"in_reply_to":"3f79a3b5_2ea48da5","updated":"2018-08-15 14:50:42.000000000","message":"Fine by me... Assuming there\u0027s no query param or anything to doc for the request.","commit_id":"036f69c9b2f5ee597dd4a2882a04dd6a350061b7"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"1526afb152a6e2d0cf3b33c2d5b9b23d320a9553","unresolved":false,"context_lines":[{"line_number":425,"context_line":"Error response codes: 401"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"Request"},{"line_number":428,"context_line":"-------"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"Response Parameters"},{"line_number":431,"context_line":"-------------------"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"3f79a3b5_2e3d6dc3","line":428,"range":{"start_line":428,"start_character":0,"end_line":428,"end_character":7},"in_reply_to":"3f79a3b5_d52a6b2a","updated":"2018-08-13 15:42:18.000000000","message":"something ! there are no request parameters ?","commit_id":"036f69c9b2f5ee597dd4a2882a04dd6a350061b7"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"34a1bbe58f2ba8084c30b643881bf711d60770b8","unresolved":false,"context_lines":[{"line_number":425,"context_line":"Error response codes: 401"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"Request"},{"line_number":428,"context_line":"-------"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"Response Parameters"},{"line_number":431,"context_line":"-------------------"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"5f7c97a3_843322f7","line":428,"range":{"start_line":428,"start_character":0,"end_line":428,"end_character":7},"in_reply_to":"5f7c97a3_7b80e99c","updated":"2018-07-31 20:23:58.000000000","message":"add a note then ?","commit_id":"036f69c9b2f5ee597dd4a2882a04dd6a350061b7"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"554397af5abf02e8c2a40aa498ad29c6f0144b03","unresolved":false,"context_lines":[{"line_number":425,"context_line":"Error response codes: 401"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"Request"},{"line_number":428,"context_line":"-------"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"Response Parameters"},{"line_number":431,"context_line":"-------------------"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"3f79a3b5_d52a6b2a","line":428,"range":{"start_line":428,"start_character":0,"end_line":428,"end_character":7},"in_reply_to":"5f7c97a3_843322f7","updated":"2018-08-10 15:55:54.000000000","message":"What kind of note you were looking for. Any other API endpoint has a similar note so that I can refer?","commit_id":"036f69c9b2f5ee597dd4a2882a04dd6a350061b7"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"574eb4a5636192b9d0836d69783e546eb09a89e8","unresolved":false,"context_lines":[{"line_number":425,"context_line":"Error response codes: 401"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"Request"},{"line_number":428,"context_line":"-------"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"Response Parameters"},{"line_number":431,"context_line":"-------------------"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"5f7c97a3_7b80e99c","line":428,"range":{"start_line":428,"start_character":0,"end_line":428,"end_character":7},"in_reply_to":"5f7c97a3_e0d2225b","updated":"2018-07-31 18:48:33.000000000","message":"There is no rest parameters in this API endpoint.","commit_id":"036f69c9b2f5ee597dd4a2882a04dd6a350061b7"}]}