)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"1f01d3db37d345da7bc26e61211d781dae58edb4","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change [1] introduced support for advsvc role. This added"},{"line_number":10,"context_line":"possibility for user with role advsvc to create/update/etc"},{"line_number":11,"context_line":"ports in foreign tenants."},{"line_number":12,"context_line":"Due the check in _validate_privileges() it was not working."},{"line_number":13,"context_line":"This patch fixes that."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_3181654e","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":5},"updated":"2018-10-11 21:36:36.000000000","message":"only ports? I think it allows CRUD also for other resources, right?","commit_id":"b4c33bba9dba897e868bb40542c6ced09c9d7898"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"e8247da7d8c91a10d93f2b79141f3d1978526319","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change [1] introduced support for advsvc role. This added"},{"line_number":10,"context_line":"possibility for user with role advsvc to create/update/etc"},{"line_number":11,"context_line":"ports in foreign tenants."},{"line_number":12,"context_line":"Due the check in _validate_privileges() it was not working."},{"line_number":13,"context_line":"This patch fixes that."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_896b461a","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":5},"in_reply_to":"3f79a3b5_3181654e","updated":"2018-10-15 07:53:25.000000000","message":"According to http://codesearch.openstack.org/?q\u003d_fixup_res_dict\u0026i\u003dnope\u0026files\u003d\u0026repos\u003d\nIts for ports, subnets and networks. So\u0027ll add those here.","commit_id":"b4c33bba9dba897e868bb40542c6ced09c9d7898"}],"api-ref/source/v2/parameters.yaml":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"1fe32d9ce68dfc1ae6508bfad62601f38172e8dc","unresolved":false,"context_lines":[{"line_number":3733,"context_line":"  description: |"},{"line_number":3734,"context_line":"    The MAC address of the port."},{"line_number":3735,"context_line":"    By default, only administrative users and users with advsvc role"},{"line_number":3736,"context_line":"    can change this value."},{"line_number":3737,"context_line":"  in: body"},{"line_number":3738,"context_line":"  required: false"},{"line_number":3739,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_09cb244b","line":3736,"updated":"2018-10-22 10:03:13.000000000","message":"How this change is related to Your patch?","commit_id":"00147a7d700e6d0142161152137bbab0c39ce4c0"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"88030541be4b53f39278757ba6cb15719615c6d9","unresolved":false,"context_lines":[{"line_number":3733,"context_line":"  description: |"},{"line_number":3734,"context_line":"    The MAC address of the port."},{"line_number":3735,"context_line":"    By default, only administrative users and users with advsvc role"},{"line_number":3736,"context_line":"    can change this value."},{"line_number":3737,"context_line":"  in: body"},{"line_number":3738,"context_line":"  required: false"},{"line_number":3739,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_699c180d","line":3736,"in_reply_to":"3f79a3b5_09cb244b","updated":"2018-10-22 10:13:42.000000000","message":"It is said that only administrative user can do this, but user with role advsvc is also able to do that.\n\nhttps://github.com/openstack/neutron/blob/master/etc/policy.json#L93","commit_id":"00147a7d700e6d0142161152137bbab0c39ce4c0"}],"neutron_lib/api/attributes.py":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"54bfe232e157cff6afa90bd56441758902961117","unresolved":false,"context_lines":[{"line_number":25,"context_line":"def _validate_privileges(context, res_dict):"},{"line_number":26,"context_line":"    if (\u0027project_id\u0027 in res_dict and"},{"line_number":27,"context_line":"            res_dict[\u0027project_id\u0027] !\u003d context.project_id and"},{"line_number":28,"context_line":"            not (context.is_admin or context.is_advsvc)):"},{"line_number":29,"context_line":"        msg \u003d _(\"Specifying \u0027project_id\u0027 or \u0027tenant_id\u0027 other than the \""},{"line_number":30,"context_line":"                \"authenticated project in request requires admin or advsvc \""},{"line_number":31,"context_line":"                \"privileges\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_d5590b8d","line":28,"updated":"2018-10-11 12:20:39.000000000","message":"What about a UT to check the new behavior?","commit_id":"fc9dfbabe18bc9d76970339af5d53fe82dd0fb5f"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"ff93713a567d08006adb3654380934db8cc75de4","unresolved":false,"context_lines":[{"line_number":25,"context_line":"def _validate_privileges(context, res_dict):"},{"line_number":26,"context_line":"    if (\u0027project_id\u0027 in res_dict and"},{"line_number":27,"context_line":"            res_dict[\u0027project_id\u0027] !\u003d context.project_id and"},{"line_number":28,"context_line":"            not (context.is_admin or context.is_advsvc)):"},{"line_number":29,"context_line":"        msg \u003d _(\"Specifying \u0027project_id\u0027 or \u0027tenant_id\u0027 other than the \""},{"line_number":30,"context_line":"                \"authenticated project in request requires admin or advsvc \""},{"line_number":31,"context_line":"                \"privileges\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_15330315","line":28,"in_reply_to":"3f79a3b5_d5590b8d","updated":"2018-10-11 12:33:26.000000000","message":"Yes, right, doing.\nI\u0027ll create also for the previous behavior due the testclass is not yet here.","commit_id":"fc9dfbabe18bc9d76970339af5d53fe82dd0fb5f"}],"neutron_lib/tests/unit/api/test_attributes.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"1f01d3db37d345da7bc26e61211d781dae58edb4","unresolved":false,"context_lines":[{"line_number":288,"context_line":"        project_id \u003d \u0027fake_project\u0027"},{"line_number":289,"context_line":"        ctx \u003d context.Context(project_id\u003dproject_id)"},{"line_number":290,"context_line":"        res_dict \u003d {\u0027project_id\u0027: project_id}"},{"line_number":291,"context_line":"        self.assertIsNone("},{"line_number":292,"context_line":"            attributes._validate_privileges(ctx, res_dict))"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"    def test__validate_privileges_user_other_tenant(self):"},{"line_number":295,"context_line":"        project_id \u003d \u0027fake_project\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_11f1c900","line":292,"range":{"start_line":291,"start_character":0,"end_line":292,"end_character":59},"updated":"2018-10-11 21:36:36.000000000","message":"I think better could be something like:\n\n    try:\n        attributes._validate_privileges(ctx, res_dict))\n    except exc.HTTPBadRequest:\n        self.fail(\"HTTPBadRequest exception should not be raised\")\n\nor something like that","commit_id":"b4c33bba9dba897e868bb40542c6ced09c9d7898"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"e8247da7d8c91a10d93f2b79141f3d1978526319","unresolved":false,"context_lines":[{"line_number":288,"context_line":"        project_id \u003d \u0027fake_project\u0027"},{"line_number":289,"context_line":"        ctx \u003d context.Context(project_id\u003dproject_id)"},{"line_number":290,"context_line":"        res_dict \u003d {\u0027project_id\u0027: project_id}"},{"line_number":291,"context_line":"        self.assertIsNone("},{"line_number":292,"context_line":"            attributes._validate_privileges(ctx, res_dict))"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"    def test__validate_privileges_user_other_tenant(self):"},{"line_number":295,"context_line":"        project_id \u003d \u0027fake_project\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_49f1ae69","line":292,"range":{"start_line":291,"start_character":0,"end_line":292,"end_character":59},"in_reply_to":"3f79a3b5_11f1c900","updated":"2018-10-15 07:53:25.000000000","message":"okey, done ;)","commit_id":"b4c33bba9dba897e868bb40542c6ced09c9d7898"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"1f01d3db37d345da7bc26e61211d781dae58edb4","unresolved":false,"context_lines":[{"line_number":306,"context_line":"                              is_admin\u003dTrue)"},{"line_number":307,"context_line":"        res_dict \u003d {\u0027project_id\u0027: project_id}"},{"line_number":308,"context_line":"        self.assertIsNone("},{"line_number":309,"context_line":"            attributes._validate_privileges(ctx, res_dict))"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"    def test__validate_privileges_advsvc_other_tenant(self):"},{"line_number":312,"context_line":"        project_id \u003d \u0027fake_project\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_b1d9f584","line":309,"updated":"2018-10-11 21:36:36.000000000","message":"ditto","commit_id":"b4c33bba9dba897e868bb40542c6ced09c9d7898"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"1f01d3db37d345da7bc26e61211d781dae58edb4","unresolved":false,"context_lines":[{"line_number":314,"context_line":"                              is_advsvc\u003dTrue)"},{"line_number":315,"context_line":"        res_dict \u003d {\u0027project_id\u0027: project_id}"},{"line_number":316,"context_line":"        self.assertIsNone("},{"line_number":317,"context_line":"            attributes._validate_privileges(ctx, res_dict))"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_91dcf971","line":317,"updated":"2018-10-11 21:36:36.000000000","message":"ditto","commit_id":"b4c33bba9dba897e868bb40542c6ced09c9d7898"}]}
