)]}'
{"neutron_lib/db/model_query.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"87dc6cb8ee20815db2d3722156222b6f8f2c51c7","unresolved":false,"context_lines":[{"line_number":174,"context_line":"                    # do multiple equals matches"},{"line_number":175,"context_line":"                    query \u003d query.filter("},{"line_number":176,"context_line":"                        or_(*[column \u003d\u003d v for v in value]))"},{"line_number":177,"context_line":"                elif isinstance(value, obj_utils.FilterObj):"},{"line_number":178,"context_line":"                    query \u003d query.filter(value.filter(column))"},{"line_number":179,"context_line":"                elif isinstance(value, obj_utils.StringMatchingFilterObj):"},{"line_number":180,"context_line":"                    if value.is_contains:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_99af30e0","line":177,"range":{"start_line":177,"start_character":32,"end_line":177,"end_character":37},"updated":"2018-10-25 09:02:35.000000000","message":"If value is StringMatchingFilterObj, will match this condition. Do we need L179-188 now?","commit_id":"ea74cadc94d66dd26853f5f37d0286e6b6b32d26"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"4eaadf9ddc2d087ebdacb622bea659e4e2795374","unresolved":false,"context_lines":[{"line_number":174,"context_line":"                    # do multiple equals matches"},{"line_number":175,"context_line":"                    query \u003d query.filter("},{"line_number":176,"context_line":"                        or_(*[column \u003d\u003d v for v in value]))"},{"line_number":177,"context_line":"                elif isinstance(value, obj_utils.FilterObj):"},{"line_number":178,"context_line":"                    query \u003d query.filter(value.filter(column))"},{"line_number":179,"context_line":"                elif isinstance(value, obj_utils.StringMatchingFilterObj):"},{"line_number":180,"context_line":"                    if value.is_contains:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_66b4e181","line":177,"range":{"start_line":177,"start_character":32,"end_line":177,"end_character":37},"in_reply_to":"3f79a3b5_99af30e0","updated":"2018-10-25 21:24:05.000000000","message":"Good catch. I removed it.","commit_id":"ea74cadc94d66dd26853f5f37d0286e6b6b32d26"}],"neutron_lib/objects/utils.py":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"66e3c4cb725608375f14fe19fc81dffbabc29552","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        self.ends \u003d matching_string"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"class FilterObj(object):"},{"line_number":64,"context_line":"    pass"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_7e6217db","line":63,"updated":"2018-10-15 12:51:55.000000000","message":"Should StringMatchingFilterObj also be a FliterObj? Otherwise it seems we have a split hierarchy for filters.","commit_id":"05f8acfaff16b4c31c2bad332be2ad62ae36ec09"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"3a6178ad8c3db3068c8886d28a146679a475fffb","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        self.ends \u003d matching_string"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"class FilterObj(object):"},{"line_number":64,"context_line":"    pass"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_ee9227a0","line":63,"in_reply_to":"3f79a3b5_7e6217db","updated":"2018-10-24 19:37:11.000000000","message":"Done","commit_id":"05f8acfaff16b4c31c2bad332be2ad62ae36ec09"},{"author":{"_account_id":28581,"name":"Lujin Luo","email":"lujinluo@gmail.com","username":"lujin"},"change_message_id":"c4d1c46ec0f14fd1c9eb96adc552c596bf9b9765","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"class NotIn(FilterObj):"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def operate(self, column):"},{"line_number":70,"context_line":"        return ~column.in_(self.value)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def __init__(self, value):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_b3d8b9ec","line":69,"range":{"start_line":69,"start_character":8,"end_line":69,"end_character":15},"updated":"2018-10-17 02:35:23.000000000","message":"can we come up with a more explicit name for this method? \"operate\" seems too vague for me","commit_id":"05f8acfaff16b4c31c2bad332be2ad62ae36ec09"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"3a6178ad8c3db3068c8886d28a146679a475fffb","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"class NotIn(FilterObj):"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def operate(self, column):"},{"line_number":70,"context_line":"        return ~column.in_(self.value)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def __init__(self, value):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_2eea5f0c","line":69,"range":{"start_line":69,"start_character":8,"end_line":69,"end_character":15},"in_reply_to":"3f79a3b5_b3d8b9ec","updated":"2018-10-24 19:37:11.000000000","message":"I renamed it to \"filter\". Hope it will be more clearer..","commit_id":"05f8acfaff16b4c31c2bad332be2ad62ae36ec09"}],"releasenotes/notes/support-custom-filter-f4a15bb5b38b7d3e.yaml":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"55cfb87814db51f37949297d994deac1d098b03e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    This release adds support for custom filtering."},{"line_number":5,"context_line":"    In particular, a class called ``FilterObj`` is introduced."},{"line_number":6,"context_line":"    This is the base class from which the custom filter class should inherit."},{"line_number":7,"context_line":"    This release also implements two filter class: ``NotIn`` and ``NotEqual``."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_daa31e43","line":4,"updated":"2018-10-29 11:06:00.000000000","message":"I would add something like \"custome filtering in OV objects\" to be clear\nAlso I think that this first sentece is worth to be mentioned in \"Prelude\" section of release note.","commit_id":"ec3807f7c13805a27a8f9f9245fb312b9c7e1c17"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"2697400de5ed33af70d53c16bc7915f0a597846d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    This release adds support for custom filtering."},{"line_number":5,"context_line":"    In particular, a class called ``FilterObj`` is introduced."},{"line_number":6,"context_line":"    This is the base class from which the custom filter class should inherit."},{"line_number":7,"context_line":"    This release also implements two filter class: ``NotIn`` and ``NotEqual``."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_5c4f0668","line":4,"in_reply_to":"3f79a3b5_daa31e43","updated":"2018-10-29 15:28:43.000000000","message":"Done","commit_id":"ec3807f7c13805a27a8f9f9245fb312b9c7e1c17"}]}
