)]}'
{"neutron_lib/api/definitions/l3_port_ip_change_not_allow.py":[{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"08ad9cd4108df35aa80e9fb574257ba0a5ad41c6","unresolved":false,"context_lines":[{"line_number":13,"context_line":"from neutron_lib.api.definitions import l3"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"ALIAS \u003d \u0027l3-port-ip-change-not-allow\u0027"},{"line_number":17,"context_line":"IS_SHIM_EXTENSION \u003d True"},{"line_number":18,"context_line":"IS_STANDARD_ATTR_EXTENSION \u003d False"},{"line_number":19,"context_line":"NAME \u003d \u0027L3 Related Port IP Change Not Allow Shim Extension\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_02fdf96b","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":5},"updated":"2018-10-24 17:49:28.000000000","message":"Need to add this extension to KNOWN_EXTENSIONS as well https://github.com/openstack/neutron-lib/blob/master/neutron_lib/api/definitions/base.py#L77","commit_id":"f2b7c60023cd7bb5d34c31f88759559e0158ddf4"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"2e798db143249fce1a84818e2f93ddb66f322d97","unresolved":false,"context_lines":[{"line_number":13,"context_line":"from neutron_lib.api.definitions import l3"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"ALIAS \u003d \u0027l3-port-ip-change-not-allow\u0027"},{"line_number":17,"context_line":"IS_SHIM_EXTENSION \u003d True"},{"line_number":18,"context_line":"IS_STANDARD_ATTR_EXTENSION \u003d False"},{"line_number":19,"context_line":"NAME \u003d \u0027L3 Related Port IP Change Not Allow Shim Extension\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_3d861e18","line":16,"updated":"2018-10-24 13:32:29.000000000","message":"not-allowed IMO would be better","commit_id":"f2b7c60023cd7bb5d34c31f88759559e0158ddf4"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"f58c368b9f9f677e9ee920b61a53c4f9c4a23964","unresolved":false,"context_lines":[{"line_number":13,"context_line":"from neutron_lib.api.definitions import l3"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"ALIAS \u003d \u0027l3-port-ip-change-not-allow\u0027"},{"line_number":17,"context_line":"IS_SHIM_EXTENSION \u003d True"},{"line_number":18,"context_line":"IS_STANDARD_ATTR_EXTENSION \u003d False"},{"line_number":19,"context_line":"NAME \u003d \u0027L3 Related Port IP Change Not Allow Shim Extension\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_5de66bb1","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":5},"in_reply_to":"3f79a3b5_02fdf96b","updated":"2018-10-25 01:51:37.000000000","message":"Done","commit_id":"f2b7c60023cd7bb5d34c31f88759559e0158ddf4"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"f58c368b9f9f677e9ee920b61a53c4f9c4a23964","unresolved":false,"context_lines":[{"line_number":13,"context_line":"from neutron_lib.api.definitions import l3"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"ALIAS \u003d \u0027l3-port-ip-change-not-allow\u0027"},{"line_number":17,"context_line":"IS_SHIM_EXTENSION \u003d True"},{"line_number":18,"context_line":"IS_STANDARD_ATTR_EXTENSION \u003d False"},{"line_number":19,"context_line":"NAME \u003d \u0027L3 Related Port IP Change Not Allow Shim Extension\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_3de12f98","line":16,"in_reply_to":"3f79a3b5_3d861e18","updated":"2018-10-25 01:51:37.000000000","message":"Done","commit_id":"f2b7c60023cd7bb5d34c31f88759559e0158ddf4"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"2e798db143249fce1a84818e2f93ddb66f322d97","unresolved":false,"context_lines":[{"line_number":16,"context_line":"ALIAS \u003d \u0027l3-port-ip-change-not-allow\u0027"},{"line_number":17,"context_line":"IS_SHIM_EXTENSION \u003d True"},{"line_number":18,"context_line":"IS_STANDARD_ATTR_EXTENSION \u003d False"},{"line_number":19,"context_line":"NAME \u003d \u0027L3 Related Port IP Change Not Allow Shim Extension\u0027"},{"line_number":20,"context_line":"DESCRIPTION \u003d \u0027Forbidden some L3 related port type change IP address\u0027"},{"line_number":21,"context_line":"UPDATED_TIMESTAMP \u003d \u00272018-10-09T10:00:00-00:00\u0027"},{"line_number":22,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_9da17295","line":19,"range":{"start_line":19,"start_character":8,"end_line":19,"end_character":58},"updated":"2018-10-24 13:32:29.000000000","message":"What about something like: \"Router ports IP change forbidden\"?","commit_id":"f2b7c60023cd7bb5d34c31f88759559e0158ddf4"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"f58c368b9f9f677e9ee920b61a53c4f9c4a23964","unresolved":false,"context_lines":[{"line_number":16,"context_line":"ALIAS \u003d \u0027l3-port-ip-change-not-allow\u0027"},{"line_number":17,"context_line":"IS_SHIM_EXTENSION \u003d True"},{"line_number":18,"context_line":"IS_STANDARD_ATTR_EXTENSION \u003d False"},{"line_number":19,"context_line":"NAME \u003d \u0027L3 Related Port IP Change Not Allow Shim Extension\u0027"},{"line_number":20,"context_line":"DESCRIPTION \u003d \u0027Forbidden some L3 related port type change IP address\u0027"},{"line_number":21,"context_line":"UPDATED_TIMESTAMP \u003d \u00272018-10-09T10:00:00-00:00\u0027"},{"line_number":22,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_fdfe5737","line":19,"range":{"start_line":19,"start_character":8,"end_line":19,"end_character":58},"in_reply_to":"3f79a3b5_9da17295","updated":"2018-10-25 01:51:37.000000000","message":"Done","commit_id":"f2b7c60023cd7bb5d34c31f88759559e0158ddf4"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"08ad9cd4108df35aa80e9fb574257ba0a5ad41c6","unresolved":false,"context_lines":[{"line_number":17,"context_line":"IS_SHIM_EXTENSION \u003d True"},{"line_number":18,"context_line":"IS_STANDARD_ATTR_EXTENSION \u003d False"},{"line_number":19,"context_line":"NAME \u003d \u0027L3 Related Port IP Change Not Allow Shim Extension\u0027"},{"line_number":20,"context_line":"DESCRIPTION \u003d \u0027Forbidden some L3 related port type change IP address\u0027"},{"line_number":21,"context_line":"UPDATED_TIMESTAMP \u003d \u00272018-10-09T10:00:00-00:00\u0027"},{"line_number":22,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {}"},{"line_number":23,"context_line":"SUB_RESOURCE_ATTRIBUTE_MAP \u003d {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_a251a565","line":20,"range":{"start_line":20,"start_character":25,"end_line":20,"end_character":29},"updated":"2018-10-24 17:49:28.000000000","message":"IMHO, it is better to define the exact set of port types, so that API behavior is more determinative when this API extension is presented.","commit_id":"f2b7c60023cd7bb5d34c31f88759559e0158ddf4"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"2e798db143249fce1a84818e2f93ddb66f322d97","unresolved":false,"context_lines":[{"line_number":17,"context_line":"IS_SHIM_EXTENSION \u003d True"},{"line_number":18,"context_line":"IS_STANDARD_ATTR_EXTENSION \u003d False"},{"line_number":19,"context_line":"NAME \u003d \u0027L3 Related Port IP Change Not Allow Shim Extension\u0027"},{"line_number":20,"context_line":"DESCRIPTION \u003d \u0027Forbidden some L3 related port type change IP address\u0027"},{"line_number":21,"context_line":"UPDATED_TIMESTAMP \u003d \u00272018-10-09T10:00:00-00:00\u0027"},{"line_number":22,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {}"},{"line_number":23,"context_line":"SUB_RESOURCE_ATTRIBUTE_MAP \u003d {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_ddc4ca43","line":20,"updated":"2018-10-24 13:32:29.000000000","message":"and here something like: \"Change of IP addresses of some types of ports used by L3 routers is forbidden\"","commit_id":"f2b7c60023cd7bb5d34c31f88759559e0158ddf4"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"f58c368b9f9f677e9ee920b61a53c4f9c4a23964","unresolved":false,"context_lines":[{"line_number":17,"context_line":"IS_SHIM_EXTENSION \u003d True"},{"line_number":18,"context_line":"IS_STANDARD_ATTR_EXTENSION \u003d False"},{"line_number":19,"context_line":"NAME \u003d \u0027L3 Related Port IP Change Not Allow Shim Extension\u0027"},{"line_number":20,"context_line":"DESCRIPTION \u003d \u0027Forbidden some L3 related port type change IP address\u0027"},{"line_number":21,"context_line":"UPDATED_TIMESTAMP \u003d \u00272018-10-09T10:00:00-00:00\u0027"},{"line_number":22,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {}"},{"line_number":23,"context_line":"SUB_RESOURCE_ATTRIBUTE_MAP \u003d {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_1dfc733d","line":20,"range":{"start_line":20,"start_character":25,"end_line":20,"end_character":29},"in_reply_to":"3f79a3b5_a251a565","updated":"2018-10-25 01:51:37.000000000","message":"Done","commit_id":"f2b7c60023cd7bb5d34c31f88759559e0158ddf4"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"f58c368b9f9f677e9ee920b61a53c4f9c4a23964","unresolved":false,"context_lines":[{"line_number":17,"context_line":"IS_SHIM_EXTENSION \u003d True"},{"line_number":18,"context_line":"IS_STANDARD_ATTR_EXTENSION \u003d False"},{"line_number":19,"context_line":"NAME \u003d \u0027L3 Related Port IP Change Not Allow Shim Extension\u0027"},{"line_number":20,"context_line":"DESCRIPTION \u003d \u0027Forbidden some L3 related port type change IP address\u0027"},{"line_number":21,"context_line":"UPDATED_TIMESTAMP \u003d \u00272018-10-09T10:00:00-00:00\u0027"},{"line_number":22,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {}"},{"line_number":23,"context_line":"SUB_RESOURCE_ATTRIBUTE_MAP \u003d {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_fd83b7a8","line":20,"in_reply_to":"3f79a3b5_ddc4ca43","updated":"2018-10-25 01:51:37.000000000","message":"@Slawek, IMO, we should express that \u0027forbidden\u0027 first.","commit_id":"f2b7c60023cd7bb5d34c31f88759559e0158ddf4"}],"neutron_lib/api/definitions/l3_port_ip_change_not_allowed.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"f91020a15a7cef4fc60a001656adb72b453c2fbf","unresolved":false,"context_lines":[{"line_number":16,"context_line":"ALIAS \u003d \u0027l3-port-ip-change-not-allowed\u0027"},{"line_number":17,"context_line":"IS_SHIM_EXTENSION \u003d True"},{"line_number":18,"context_line":"IS_STANDARD_ATTR_EXTENSION \u003d False"},{"line_number":19,"context_line":"NAME \u003d \u0027Router Ports IP Change Forbidden Shim Extension\u0027"},{"line_number":20,"context_line":"DESCRIPTION \u003d \u0027Forbidden some L3 related port type change IP address\u0027"},{"line_number":21,"context_line":"UPDATED_TIMESTAMP \u003d \u00272018-10-09T10:00:00-00:00\u0027"},{"line_number":22,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {}"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_40ba6de0","line":19,"range":{"start_line":19,"start_character":7,"end_line":19,"end_character":56},"updated":"2018-11-01 21:16:39.000000000","message":"Consider the following alternative:\n\n\"Prevent L3 router ports IP address change Shim Extension\"","commit_id":"89ae5e1defcf51fe68d2f2eb1aacf71a243e8b71"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"aa3f56d2e66b84ceee70b45d710ba7815aa415fd","unresolved":false,"context_lines":[{"line_number":16,"context_line":"ALIAS \u003d \u0027l3-port-ip-change-not-allowed\u0027"},{"line_number":17,"context_line":"IS_SHIM_EXTENSION \u003d True"},{"line_number":18,"context_line":"IS_STANDARD_ATTR_EXTENSION \u003d False"},{"line_number":19,"context_line":"NAME \u003d \u0027Router Ports IP Change Forbidden Shim Extension\u0027"},{"line_number":20,"context_line":"DESCRIPTION \u003d \u0027Forbidden some L3 related port type change IP address\u0027"},{"line_number":21,"context_line":"UPDATED_TIMESTAMP \u003d \u00272018-10-09T10:00:00-00:00\u0027"},{"line_number":22,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {}"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_602f3b89","line":19,"range":{"start_line":19,"start_character":7,"end_line":19,"end_character":56},"in_reply_to":"3f79a3b5_40ba6de0","updated":"2018-11-05 06:05:52.000000000","message":"Done","commit_id":"89ae5e1defcf51fe68d2f2eb1aacf71a243e8b71"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"f91020a15a7cef4fc60a001656adb72b453c2fbf","unresolved":false,"context_lines":[{"line_number":17,"context_line":"IS_SHIM_EXTENSION \u003d True"},{"line_number":18,"context_line":"IS_STANDARD_ATTR_EXTENSION \u003d False"},{"line_number":19,"context_line":"NAME \u003d \u0027Router Ports IP Change Forbidden Shim Extension\u0027"},{"line_number":20,"context_line":"DESCRIPTION \u003d \u0027Forbidden some L3 related port type change IP address\u0027"},{"line_number":21,"context_line":"UPDATED_TIMESTAMP \u003d \u00272018-10-09T10:00:00-00:00\u0027"},{"line_number":22,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {}"},{"line_number":23,"context_line":"SUB_RESOURCE_ATTRIBUTE_MAP \u003d {}"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_8063a5ab","line":20,"range":{"start_line":20,"start_character":15,"end_line":20,"end_character":68},"updated":"2018-11-01 21:16:39.000000000","message":"Please consider this alternative, which IMO read better in English:\n\n\"Prevent change of IP address for some L3 router related ports\"","commit_id":"89ae5e1defcf51fe68d2f2eb1aacf71a243e8b71"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"aa3f56d2e66b84ceee70b45d710ba7815aa415fd","unresolved":false,"context_lines":[{"line_number":17,"context_line":"IS_SHIM_EXTENSION \u003d True"},{"line_number":18,"context_line":"IS_STANDARD_ATTR_EXTENSION \u003d False"},{"line_number":19,"context_line":"NAME \u003d \u0027Router Ports IP Change Forbidden Shim Extension\u0027"},{"line_number":20,"context_line":"DESCRIPTION \u003d \u0027Forbidden some L3 related port type change IP address\u0027"},{"line_number":21,"context_line":"UPDATED_TIMESTAMP \u003d \u00272018-10-09T10:00:00-00:00\u0027"},{"line_number":22,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {}"},{"line_number":23,"context_line":"SUB_RESOURCE_ATTRIBUTE_MAP \u003d {}"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_802a9775","line":20,"range":{"start_line":20,"start_character":15,"end_line":20,"end_character":68},"in_reply_to":"3f79a3b5_8063a5ab","updated":"2018-11-05 06:05:52.000000000","message":"Done","commit_id":"89ae5e1defcf51fe68d2f2eb1aacf71a243e8b71"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"826cf081e966a6e2876309780953e859de58de48","unresolved":false,"context_lines":[{"line_number":16,"context_line":"ALIAS \u003d \u0027l3-port-ip-change-not-allowed\u0027"},{"line_number":17,"context_line":"IS_SHIM_EXTENSION \u003d True"},{"line_number":18,"context_line":"IS_STANDARD_ATTR_EXTENSION \u003d False"},{"line_number":19,"context_line":"NAME \u003d \u0027Prevent L3 router ports IP address change Shim Extension\u0027"},{"line_number":20,"context_line":"DESCRIPTION \u003d \u0027Prevent change of IP address for some L3 router related ports\u0027"},{"line_number":21,"context_line":"UPDATED_TIMESTAMP \u003d \u00272018-10-09T10:00:00-00:00\u0027"},{"line_number":22,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {}"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_f00e958d","line":19,"range":{"start_line":19,"start_character":50,"end_line":19,"end_character":64},"updated":"2018-11-06 14:02:12.000000000","message":"s/extension","commit_id":"8e292e90c1c41d5c986a9acf4e82cbdc246aee17"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"4420a68d5a44bd115965ff184a43e55f6e03d1c7","unresolved":false,"context_lines":[{"line_number":16,"context_line":"ALIAS \u003d \u0027l3-port-ip-change-not-allowed\u0027"},{"line_number":17,"context_line":"IS_SHIM_EXTENSION \u003d True"},{"line_number":18,"context_line":"IS_STANDARD_ATTR_EXTENSION \u003d False"},{"line_number":19,"context_line":"NAME \u003d \u0027Prevent L3 router ports IP address change Shim Extension\u0027"},{"line_number":20,"context_line":"DESCRIPTION \u003d \u0027Prevent change of IP address for some L3 router related ports\u0027"},{"line_number":21,"context_line":"UPDATED_TIMESTAMP \u003d \u00272018-10-09T10:00:00-00:00\u0027"},{"line_number":22,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {}"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_dcc29388","line":19,"range":{"start_line":19,"start_character":50,"end_line":19,"end_character":64},"in_reply_to":"3f79a3b5_f00e958d","updated":"2018-11-06 15:18:50.000000000","message":"Done","commit_id":"8e292e90c1c41d5c986a9acf4e82cbdc246aee17"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"826cf081e966a6e2876309780953e859de58de48","unresolved":false,"context_lines":[{"line_number":17,"context_line":"IS_SHIM_EXTENSION \u003d True"},{"line_number":18,"context_line":"IS_STANDARD_ATTR_EXTENSION \u003d False"},{"line_number":19,"context_line":"NAME \u003d \u0027Prevent L3 router ports IP address change Shim Extension\u0027"},{"line_number":20,"context_line":"DESCRIPTION \u003d \u0027Prevent change of IP address for some L3 router related ports\u0027"},{"line_number":21,"context_line":"UPDATED_TIMESTAMP \u003d \u00272018-10-09T10:00:00-00:00\u0027"},{"line_number":22,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {}"},{"line_number":23,"context_line":"SUB_RESOURCE_ATTRIBUTE_MAP \u003d {}"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_d0fb5977","line":20,"range":{"start_line":20,"start_character":63,"end_line":20,"end_character":70},"updated":"2018-11-06 14:02:12.000000000","message":"think you can delete \u0027related\u0027","commit_id":"8e292e90c1c41d5c986a9acf4e82cbdc246aee17"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"4420a68d5a44bd115965ff184a43e55f6e03d1c7","unresolved":false,"context_lines":[{"line_number":17,"context_line":"IS_SHIM_EXTENSION \u003d True"},{"line_number":18,"context_line":"IS_STANDARD_ATTR_EXTENSION \u003d False"},{"line_number":19,"context_line":"NAME \u003d \u0027Prevent L3 router ports IP address change Shim Extension\u0027"},{"line_number":20,"context_line":"DESCRIPTION \u003d \u0027Prevent change of IP address for some L3 router related ports\u0027"},{"line_number":21,"context_line":"UPDATED_TIMESTAMP \u003d \u00272018-10-09T10:00:00-00:00\u0027"},{"line_number":22,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {}"},{"line_number":23,"context_line":"SUB_RESOURCE_ATTRIBUTE_MAP \u003d {}"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_9cc09b7f","line":20,"range":{"start_line":20,"start_character":63,"end_line":20,"end_character":70},"in_reply_to":"3f79a3b5_d0fb5977","updated":"2018-11-06 15:18:50.000000000","message":"Done","commit_id":"8e292e90c1c41d5c986a9acf4e82cbdc246aee17"}],"neutron_lib/constants.py":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"a287c2696369c4cc0ebc881d1cf26d57a6e291b8","unresolved":false,"context_lines":[{"line_number":371,"context_line":""},{"line_number":372,"context_line":"# The following L3 router ports will not be allowed to"},{"line_number":373,"context_line":"# directly update the IP address:"},{"line_number":374,"context_line":"L3_IP_UPDATE_NOT_ALLOWED_LIST \u003d ["},{"line_number":375,"context_line":"    DEVICE_OWNER_ROUTER_INTF,"},{"line_number":376,"context_line":"    DEVICE_OWNER_ROUTER_HA_INTF,"},{"line_number":377,"context_line":"    DEVICE_OWNER_HA_REPLICATED_INT,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_8319fa76","line":374,"updated":"2018-10-25 12:33:45.000000000","message":"Would it be better to use a set here instead of a list?","commit_id":"69eaa9ba5eac58b481a073bbc5a1e5356e9a28f6"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"0182bb70b5c246e815aea4c075694e45be2740e7","unresolved":false,"context_lines":[{"line_number":371,"context_line":""},{"line_number":372,"context_line":"# The following L3 router ports will not be allowed to"},{"line_number":373,"context_line":"# directly update the IP address:"},{"line_number":374,"context_line":"L3_IP_UPDATE_NOT_ALLOWED_LIST \u003d ["},{"line_number":375,"context_line":"    DEVICE_OWNER_ROUTER_INTF,"},{"line_number":376,"context_line":"    DEVICE_OWNER_ROUTER_HA_INTF,"},{"line_number":377,"context_line":"    DEVICE_OWNER_HA_REPLICATED_INT,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_c036f64f","line":374,"in_reply_to":"3f79a3b5_8319fa76","updated":"2018-10-26 03:04:34.000000000","message":"Here:\nhttps://review.openstack.org/#/c/608909/14/neutron/services/l3_router/l3_router_plugin.py@93","commit_id":"69eaa9ba5eac58b481a073bbc5a1e5356e9a28f6"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"9e76b3462fb10a8bc57432a7acaa007dc5d67ce2","unresolved":false,"context_lines":[{"line_number":371,"context_line":""},{"line_number":372,"context_line":"# The following L3 router ports will not be allowed to"},{"line_number":373,"context_line":"# directly update the IP address:"},{"line_number":374,"context_line":"L3_IP_UPDATE_NOT_ALLOWED_LIST \u003d ["},{"line_number":375,"context_line":"    DEVICE_OWNER_ROUTER_INTF,"},{"line_number":376,"context_line":"    DEVICE_OWNER_ROUTER_HA_INTF,"},{"line_number":377,"context_line":"    DEVICE_OWNER_HA_REPLICATED_INT,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_c0f036dd","line":374,"in_reply_to":"3f79a3b5_8319fa76","updated":"2018-10-26 02:52:00.000000000","message":"This will be removed, and move to each plugin.","commit_id":"69eaa9ba5eac58b481a073bbc5a1e5356e9a28f6"}],"releasenotes/notes/l3-port-ip-change-not-allow-2c98e13c08b5ee85.yaml":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"f91020a15a7cef4fc60a001656adb72b453c2fbf","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Directly updating some L3 related port IP address does not have any"},{"line_number":5,"context_line":"    influence in L3 agent side. In other words, these L3 related ports should"},{"line_number":6,"context_line":"    not allow changing the IP address. So we add a shim extension to forbidden"},{"line_number":7,"context_line":"    such IP change. For more information please see bug"},{"line_number":8,"context_line":"    `1796824 \u003chttps://bugs.launchpad.net/neutron/+bug/1796824\u003e`_"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_60976948","line":5,"range":{"start_line":5,"start_character":32,"end_line":5,"end_character":46},"updated":"2018-11-01 21:16:39.000000000","message":"As a consequence","commit_id":"89ae5e1defcf51fe68d2f2eb1aacf71a243e8b71"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"f91020a15a7cef4fc60a001656adb72b453c2fbf","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Directly updating some L3 related port IP address does not have any"},{"line_number":5,"context_line":"    influence in L3 agent side. In other words, these L3 related ports should"},{"line_number":6,"context_line":"    not allow changing the IP address. So we add a shim extension to forbidden"},{"line_number":7,"context_line":"    such IP change. For more information please see bug"},{"line_number":8,"context_line":"    `1796824 \u003chttps://bugs.launchpad.net/neutron/+bug/1796824\u003e`_"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_209ad174","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":16},"updated":"2018-11-01 21:16:39.000000000","message":"Consider:\n\neffect on the","commit_id":"89ae5e1defcf51fe68d2f2eb1aacf71a243e8b71"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"aa3f56d2e66b84ceee70b45d710ba7815aa415fd","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Directly updating some L3 related port IP address does not have any"},{"line_number":5,"context_line":"    influence in L3 agent side. In other words, these L3 related ports should"},{"line_number":6,"context_line":"    not allow changing the IP address. So we add a shim extension to forbidden"},{"line_number":7,"context_line":"    such IP change. For more information please see bug"},{"line_number":8,"context_line":"    `1796824 \u003chttps://bugs.launchpad.net/neutron/+bug/1796824\u003e`_"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_404a3f5a","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":16},"in_reply_to":"3f79a3b5_209ad174","updated":"2018-11-05 06:05:52.000000000","message":"Done","commit_id":"89ae5e1defcf51fe68d2f2eb1aacf71a243e8b71"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"aa3f56d2e66b84ceee70b45d710ba7815aa415fd","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Directly updating some L3 related port IP address does not have any"},{"line_number":5,"context_line":"    influence in L3 agent side. In other words, these L3 related ports should"},{"line_number":6,"context_line":"    not allow changing the IP address. So we add a shim extension to forbidden"},{"line_number":7,"context_line":"    such IP change. For more information please see bug"},{"line_number":8,"context_line":"    `1796824 \u003chttps://bugs.launchpad.net/neutron/+bug/1796824\u003e`_"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_005447fc","line":5,"range":{"start_line":5,"start_character":32,"end_line":5,"end_character":46},"in_reply_to":"3f79a3b5_60976948","updated":"2018-11-05 06:05:52.000000000","message":"Done","commit_id":"89ae5e1defcf51fe68d2f2eb1aacf71a243e8b71"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"f91020a15a7cef4fc60a001656adb72b453c2fbf","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Directly updating some L3 related port IP address does not have any"},{"line_number":5,"context_line":"    influence in L3 agent side. In other words, these L3 related ports should"},{"line_number":6,"context_line":"    not allow changing the IP address. So we add a shim extension to forbidden"},{"line_number":7,"context_line":"    such IP change. For more information please see bug"},{"line_number":8,"context_line":"    `1796824 \u003chttps://bugs.launchpad.net/neutron/+bug/1796824\u003e`_"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_c073dd4e","line":6,"range":{"start_line":6,"start_character":69,"end_line":6,"end_character":78},"updated":"2018-11-01 21:16:39.000000000","message":"Change to forbid. Another alternative is prevent","commit_id":"89ae5e1defcf51fe68d2f2eb1aacf71a243e8b71"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"aa3f56d2e66b84ceee70b45d710ba7815aa415fd","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Directly updating some L3 related port IP address does not have any"},{"line_number":5,"context_line":"    influence in L3 agent side. In other words, these L3 related ports should"},{"line_number":6,"context_line":"    not allow changing the IP address. So we add a shim extension to forbidden"},{"line_number":7,"context_line":"    such IP change. For more information please see bug"},{"line_number":8,"context_line":"    `1796824 \u003chttps://bugs.launchpad.net/neutron/+bug/1796824\u003e`_"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_a03a33c2","line":6,"range":{"start_line":6,"start_character":69,"end_line":6,"end_character":78},"in_reply_to":"3f79a3b5_c073dd4e","updated":"2018-11-05 06:05:52.000000000","message":"Done","commit_id":"89ae5e1defcf51fe68d2f2eb1aacf71a243e8b71"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"7e6e25463157a92d18abaff82edc8d2252e0d933","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Directly updating some L3 related port IP address does not have any"},{"line_number":5,"context_line":"    effect on the L3 agent side. As a consequence, these L3 related ports"},{"line_number":6,"context_line":"    should not allow changing the IP address. So we add a shim extension"},{"line_number":7,"context_line":"    to prevent such IP change. For more information please see bug"},{"line_number":8,"context_line":"    `1796824 \u003chttps://bugs.launchpad.net/neutron/+bug/1796824\u003e`_"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_988e8731","line":6,"range":{"start_line":6,"start_character":58,"end_line":6,"end_character":72},"updated":"2018-11-05 12:55:09.000000000","message":"Nit; it might be nice to mention what extension was added. e.g. \"add the ``l3-port-ip-change-not-allowed`` extension..\"","commit_id":"738918c7d36e9467c3ffe136d6e2b93caf545aba"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"468611b3401664f0dc330bf6eaad38de21b8720b","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Directly updating some L3 related port IP address does not have any"},{"line_number":5,"context_line":"    effect on the L3 agent side. As a consequence, these L3 related ports"},{"line_number":6,"context_line":"    should not allow changing the IP address. So we add a shim extension"},{"line_number":7,"context_line":"    to prevent such IP change. For more information please see bug"},{"line_number":8,"context_line":"    `1796824 \u003chttps://bugs.launchpad.net/neutron/+bug/1796824\u003e`_"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_ffcc28bf","line":6,"range":{"start_line":6,"start_character":58,"end_line":6,"end_character":72},"in_reply_to":"3f79a3b5_988e8731","updated":"2018-11-06 11:30:27.000000000","message":"Done","commit_id":"738918c7d36e9467c3ffe136d6e2b93caf545aba"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"7dd716630a603c166d266034eddb7f7ed77930c8","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Directly updating some L3 related port IP address does not have any"},{"line_number":5,"context_line":"    effect on the L3 agent side. As a consequence, these L3 related ports"},{"line_number":6,"context_line":"    should not allow changing the IP address. So we add a shim extension"},{"line_number":7,"context_line":"    to prevent such IP change. For more information please see bug"},{"line_number":8,"context_line":"    `1796824 \u003chttps://bugs.launchpad.net/neutron/+bug/1796824\u003e`_"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_e7834c54","line":6,"range":{"start_line":6,"start_character":58,"end_line":6,"end_character":72},"in_reply_to":"3f79a3b5_988e8731","updated":"2018-11-05 23:00:44.000000000","message":"I agree. The extension should be mentioned. The reader of the release notes is not necessarily looking at the patch. Or at least, we should force him / her to look at the patches to fully understand the release note","commit_id":"738918c7d36e9467c3ffe136d6e2b93caf545aba"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"468611b3401664f0dc330bf6eaad38de21b8720b","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Directly updating some L3 related port IP address does not have any"},{"line_number":5,"context_line":"    effect on the L3 agent side. As a consequence, these L3 related ports"},{"line_number":6,"context_line":"    should not allow changing the IP address. So we add a shim extension"},{"line_number":7,"context_line":"    to prevent such IP change. For more information please see bug"},{"line_number":8,"context_line":"    `1796824 \u003chttps://bugs.launchpad.net/neutron/+bug/1796824\u003e`_"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3f79a3b5_bfc23087","line":6,"range":{"start_line":6,"start_character":58,"end_line":6,"end_character":72},"in_reply_to":"3f79a3b5_e7834c54","updated":"2018-11-06 11:30:27.000000000","message":"Done","commit_id":"738918c7d36e9467c3ffe136d6e2b93caf545aba"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"826cf081e966a6e2876309780953e859de58de48","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Directly updating some L3 related port IP address does not have any"},{"line_number":5,"context_line":"    effect on the L3 agent side. As a consequence, these L3 related ports"},{"line_number":6,"context_line":"    should not allow changing the IP address. So we add a shim extension"},{"line_number":7,"context_line":"    ``l3-port-ip-change-not-allowed`` to prevent such IP change. For more"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f79a3b5_d094b937","line":4,"range":{"start_line":4,"start_character":27,"end_line":4,"end_character":37},"updated":"2018-11-06 14:02:12.000000000","message":"s/L3-related","commit_id":"8e292e90c1c41d5c986a9acf4e82cbdc246aee17"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"826cf081e966a6e2876309780953e859de58de48","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Directly updating some L3 related port IP address does not have any"},{"line_number":5,"context_line":"    effect on the L3 agent side. As a consequence, these L3 related ports"},{"line_number":6,"context_line":"    should not allow changing the IP address. So we add a shim extension"},{"line_number":7,"context_line":"    ``l3-port-ip-change-not-allowed`` to prevent such IP change. For more"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f79a3b5_909ac15d","line":4,"range":{"start_line":4,"start_character":46,"end_line":4,"end_character":53},"updated":"2018-11-06 14:02:12.000000000","message":"s/addresses","commit_id":"8e292e90c1c41d5c986a9acf4e82cbdc246aee17"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"4420a68d5a44bd115965ff184a43e55f6e03d1c7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Directly updating some L3 related port IP address does not have any"},{"line_number":5,"context_line":"    effect on the L3 agent side. As a consequence, these L3 related ports"},{"line_number":6,"context_line":"    should not allow changing the IP address. So we add a shim extension"},{"line_number":7,"context_line":"    ``l3-port-ip-change-not-allowed`` to prevent such IP change. For more"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f79a3b5_9c641be8","line":4,"range":{"start_line":4,"start_character":46,"end_line":4,"end_character":53},"in_reply_to":"3f79a3b5_909ac15d","updated":"2018-11-06 15:18:50.000000000","message":"Done","commit_id":"8e292e90c1c41d5c986a9acf4e82cbdc246aee17"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"4420a68d5a44bd115965ff184a43e55f6e03d1c7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Directly updating some L3 related port IP address does not have any"},{"line_number":5,"context_line":"    effect on the L3 agent side. As a consequence, these L3 related ports"},{"line_number":6,"context_line":"    should not allow changing the IP address. So we add a shim extension"},{"line_number":7,"context_line":"    ``l3-port-ip-change-not-allowed`` to prevent such IP change. For more"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f79a3b5_fc6bcfb4","line":4,"range":{"start_line":4,"start_character":27,"end_line":4,"end_character":37},"in_reply_to":"3f79a3b5_d094b937","updated":"2018-11-06 15:18:50.000000000","message":"Done","commit_id":"8e292e90c1c41d5c986a9acf4e82cbdc246aee17"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"826cf081e966a6e2876309780953e859de58de48","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Directly updating some L3 related port IP address does not have any"},{"line_number":5,"context_line":"    effect on the L3 agent side. As a consequence, these L3 related ports"},{"line_number":6,"context_line":"    should not allow changing the IP address. So we add a shim extension"},{"line_number":7,"context_line":"    ``l3-port-ip-change-not-allowed`` to prevent such IP change. For more"},{"line_number":8,"context_line":"    information please see bug"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f79a3b5_30a3ad9e","line":5,"range":{"start_line":5,"start_character":57,"end_line":5,"end_character":67},"updated":"2018-11-06 14:02:12.000000000","message":"s/L3-related","commit_id":"8e292e90c1c41d5c986a9acf4e82cbdc246aee17"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"4420a68d5a44bd115965ff184a43e55f6e03d1c7","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Directly updating some L3 related port IP address does not have any"},{"line_number":5,"context_line":"    effect on the L3 agent side. As a consequence, these L3 related ports"},{"line_number":6,"context_line":"    should not allow changing the IP address. So we add a shim extension"},{"line_number":7,"context_line":"    ``l3-port-ip-change-not-allowed`` to prevent such IP change. For more"},{"line_number":8,"context_line":"    information please see bug"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f79a3b5_dc6613f1","line":5,"range":{"start_line":5,"start_character":57,"end_line":5,"end_character":67},"in_reply_to":"3f79a3b5_30a3ad9e","updated":"2018-11-06 15:18:50.000000000","message":"Done","commit_id":"8e292e90c1c41d5c986a9acf4e82cbdc246aee17"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"826cf081e966a6e2876309780953e859de58de48","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Directly updating some L3 related port IP address does not have any"},{"line_number":5,"context_line":"    effect on the L3 agent side. As a consequence, these L3 related ports"},{"line_number":6,"context_line":"    should not allow changing the IP address. So we add a shim extension"},{"line_number":7,"context_line":"    ``l3-port-ip-change-not-allowed`` to prevent such IP change. For more"},{"line_number":8,"context_line":"    information please see bug"},{"line_number":9,"context_line":"    `1796824 \u003chttps://bugs.launchpad.net/neutron/+bug/1796824\u003e`_"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f79a3b5_10dd5112","line":6,"range":{"start_line":6,"start_character":46,"end_line":6,"end_character":72},"updated":"2018-11-06 14:02:12.000000000","message":"s/A new shim extension has been added called","commit_id":"8e292e90c1c41d5c986a9acf4e82cbdc246aee17"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"826cf081e966a6e2876309780953e859de58de48","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Directly updating some L3 related port IP address does not have any"},{"line_number":5,"context_line":"    effect on the L3 agent side. As a consequence, these L3 related ports"},{"line_number":6,"context_line":"    should not allow changing the IP address. So we add a shim extension"},{"line_number":7,"context_line":"    ``l3-port-ip-change-not-allowed`` to prevent such IP change. For more"},{"line_number":8,"context_line":"    information please see bug"},{"line_number":9,"context_line":"    `1796824 \u003chttps://bugs.launchpad.net/neutron/+bug/1796824\u003e`_"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f79a3b5_f0b215e8","line":6,"range":{"start_line":6,"start_character":30,"end_line":6,"end_character":33},"updated":"2018-11-06 14:02:12.000000000","message":"s/of their","commit_id":"8e292e90c1c41d5c986a9acf4e82cbdc246aee17"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"4420a68d5a44bd115965ff184a43e55f6e03d1c7","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Directly updating some L3 related port IP address does not have any"},{"line_number":5,"context_line":"    effect on the L3 agent side. As a consequence, these L3 related ports"},{"line_number":6,"context_line":"    should not allow changing the IP address. So we add a shim extension"},{"line_number":7,"context_line":"    ``l3-port-ip-change-not-allowed`` to prevent such IP change. For more"},{"line_number":8,"context_line":"    information please see bug"},{"line_number":9,"context_line":"    `1796824 \u003chttps://bugs.launchpad.net/neutron/+bug/1796824\u003e`_"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f79a3b5_1c71ebab","line":6,"range":{"start_line":6,"start_character":46,"end_line":6,"end_character":72},"in_reply_to":"3f79a3b5_10dd5112","updated":"2018-11-06 15:18:50.000000000","message":"Done","commit_id":"8e292e90c1c41d5c986a9acf4e82cbdc246aee17"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"4420a68d5a44bd115965ff184a43e55f6e03d1c7","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Directly updating some L3 related port IP address does not have any"},{"line_number":5,"context_line":"    effect on the L3 agent side. As a consequence, these L3 related ports"},{"line_number":6,"context_line":"    should not allow changing the IP address. So we add a shim extension"},{"line_number":7,"context_line":"    ``l3-port-ip-change-not-allowed`` to prevent such IP change. For more"},{"line_number":8,"context_line":"    information please see bug"},{"line_number":9,"context_line":"    `1796824 \u003chttps://bugs.launchpad.net/neutron/+bug/1796824\u003e`_"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f79a3b5_3c7627a5","line":6,"range":{"start_line":6,"start_character":30,"end_line":6,"end_character":33},"in_reply_to":"3f79a3b5_f0b215e8","updated":"2018-11-06 15:18:50.000000000","message":"Done","commit_id":"8e292e90c1c41d5c986a9acf4e82cbdc246aee17"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"826cf081e966a6e2876309780953e859de58de48","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Directly updating some L3 related port IP address does not have any"},{"line_number":5,"context_line":"    effect on the L3 agent side. As a consequence, these L3 related ports"},{"line_number":6,"context_line":"    should not allow changing the IP address. So we add a shim extension"},{"line_number":7,"context_line":"    ``l3-port-ip-change-not-allowed`` to prevent such IP change. For more"},{"line_number":8,"context_line":"    information please see bug"},{"line_number":9,"context_line":"    `1796824 \u003chttps://bugs.launchpad.net/neutron/+bug/1796824\u003e`_"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f79a3b5_70cb654a","line":7,"range":{"start_line":7,"start_character":54,"end_line":7,"end_character":56},"updated":"2018-11-06 14:02:12.000000000","message":"s/IP address","commit_id":"8e292e90c1c41d5c986a9acf4e82cbdc246aee17"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"4420a68d5a44bd115965ff184a43e55f6e03d1c7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Directly updating some L3 related port IP address does not have any"},{"line_number":5,"context_line":"    effect on the L3 agent side. As a consequence, these L3 related ports"},{"line_number":6,"context_line":"    should not allow changing the IP address. So we add a shim extension"},{"line_number":7,"context_line":"    ``l3-port-ip-change-not-allowed`` to prevent such IP change. For more"},{"line_number":8,"context_line":"    information please see bug"},{"line_number":9,"context_line":"    `1796824 \u003chttps://bugs.launchpad.net/neutron/+bug/1796824\u003e`_"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f79a3b5_7c3edfb6","line":7,"range":{"start_line":7,"start_character":54,"end_line":7,"end_character":56},"in_reply_to":"3f79a3b5_70cb654a","updated":"2018-11-06 15:18:50.000000000","message":"Done","commit_id":"8e292e90c1c41d5c986a9acf4e82cbdc246aee17"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"826cf081e966a6e2876309780953e859de58de48","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    should not allow changing the IP address. So we add a shim extension"},{"line_number":7,"context_line":"    ``l3-port-ip-change-not-allowed`` to prevent such IP change. For more"},{"line_number":8,"context_line":"    information please see bug"},{"line_number":9,"context_line":"    `1796824 \u003chttps://bugs.launchpad.net/neutron/+bug/1796824\u003e`_"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f79a3b5_b08fbd1f","line":9,"updated":"2018-11-06 14:02:12.000000000","message":"nit: missing trailing period","commit_id":"8e292e90c1c41d5c986a9acf4e82cbdc246aee17"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"4420a68d5a44bd115965ff184a43e55f6e03d1c7","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    should not allow changing the IP address. So we add a shim extension"},{"line_number":7,"context_line":"    ``l3-port-ip-change-not-allowed`` to prevent such IP change. For more"},{"line_number":8,"context_line":"    information please see bug"},{"line_number":9,"context_line":"    `1796824 \u003chttps://bugs.launchpad.net/neutron/+bug/1796824\u003e`_"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f79a3b5_5c41a336","line":9,"in_reply_to":"3f79a3b5_b08fbd1f","updated":"2018-11-06 15:18:50.000000000","message":"Done","commit_id":"8e292e90c1c41d5c986a9acf4e82cbdc246aee17"}]}