)]}'
{"neutron_lib/db/model_query.py":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"e9959a45d9e7a7e8f2d7ce0e694619ebe26290a0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3f79a3b5_6c3a8332","updated":"2018-11-26 14:02:50.000000000","message":"What about some UTs for these changes?","commit_id":"b1a9d158971512e8f1b5458170bacc1984f6fd0c"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"2d340bc9b274aa66f254a597488aa1d72ae6ab11","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3f79a3b5_5304fb7c","in_reply_to":"3f79a3b5_6c3a8332","updated":"2018-11-26 20:22:40.000000000","message":"Done","commit_id":"b1a9d158971512e8f1b5458170bacc1984f6fd0c"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"e9959a45d9e7a7e8f2d7ce0e694619ebe26290a0","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        if hasattr(model, field):"},{"line_number":109,"context_line":"            field \u003d getattr(model, field)"},{"line_number":110,"context_line":"        else:"},{"line_number":111,"context_line":"            msg \u003d \"\u0027%s\u0027 is not supported as field\" % field"},{"line_number":112,"context_line":"            raise n_exc.InvalidInput(error_message\u003dmsg)"},{"line_number":113,"context_line":"        query \u003d context.session.query(field)"},{"line_number":114,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_acef3bb0","line":111,"range":{"start_line":111,"start_character":12,"end_line":111,"end_character":15},"updated":"2018-11-26 14:02:50.000000000","message":"Shouldn\u0027t msg be translated?","commit_id":"b1a9d158971512e8f1b5458170bacc1984f6fd0c"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"2d340bc9b274aa66f254a597488aa1d72ae6ab11","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        if hasattr(model, field):"},{"line_number":109,"context_line":"            field \u003d getattr(model, field)"},{"line_number":110,"context_line":"        else:"},{"line_number":111,"context_line":"            msg \u003d \"\u0027%s\u0027 is not supported as field\" % field"},{"line_number":112,"context_line":"            raise n_exc.InvalidInput(error_message\u003dmsg)"},{"line_number":113,"context_line":"        query \u003d context.session.query(field)"},{"line_number":114,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_13fa0375","line":111,"range":{"start_line":111,"start_character":12,"end_line":111,"end_character":15},"in_reply_to":"3f79a3b5_acef3bb0","updated":"2018-11-26 20:22:40.000000000","message":"Done","commit_id":"b1a9d158971512e8f1b5458170bacc1984f6fd0c"}],"neutron_lib/tests/unit/db/test_model_query.py":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"22b1a31cd429fa3260e2644aa59d443667604968","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            query_with_hooks.return_value \u003d [[\u0027value1\u0027], [\u0027value2\u0027]]"},{"line_number":66,"context_line":"            values \u003d model_query.get_values(mock_context, mock_model,"},{"line_number":67,"context_line":"                                            \u0027fake_field\u0027)"},{"line_number":68,"context_line":"        self.assertEqual([\u0027value1\u0027, \u0027value2\u0027], values)"},{"line_number":69,"context_line":"        query_with_hooks.assert_called_with("},{"line_number":70,"context_line":"            mock_context, mock_model, field\u003d\u0027fake_field\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_36ce0d8f","line":68,"range":{"start_line":68,"start_character":13,"end_line":68,"end_character":24},"updated":"2018-11-26 20:59:31.000000000","message":"There was recently a comment about ordering here [1]. Not sure if it\u0027s really needed or not since we have other tests using the unsorted/unordered approach.\n\n\n[1] https://review.openstack.org/#/c/615941/1/neutron_lib/tests/unit/objects/test_utils.py@71","commit_id":"5aad62cbc0144a52feef21651d2e42b8a66201e4"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"46ff098048db2def5aa0a15dff47f455ec0f23da","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            query_with_hooks.return_value \u003d [[\u0027value1\u0027], [\u0027value2\u0027]]"},{"line_number":66,"context_line":"            values \u003d model_query.get_values(mock_context, mock_model,"},{"line_number":67,"context_line":"                                            \u0027fake_field\u0027)"},{"line_number":68,"context_line":"        self.assertEqual([\u0027value1\u0027, \u0027value2\u0027], values)"},{"line_number":69,"context_line":"        query_with_hooks.assert_called_with("},{"line_number":70,"context_line":"            mock_context, mock_model, field\u003d\u0027fake_field\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_67f36ae9","line":68,"range":{"start_line":68,"start_character":13,"end_line":68,"end_character":24},"in_reply_to":"3f79a3b5_36ce0d8f","updated":"2018-11-27 08:56:27.000000000","message":"Here it will work as query_with_hooks mock is configured to return it in the same order so it should be fine as it is","commit_id":"5aad62cbc0144a52feef21651d2e42b8a66201e4"}],"releasenotes/notes/add-support-for-fetching-specific-column-in-OVO-81b764b203849776.yaml":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"e9959a45d9e7a7e8f2d7ce0e694619ebe26290a0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add method ``get_values`` in neutron_lib.db.model_query."},{"line_number":5,"context_line":"    This method allow callers to fetch specific column from"},{"line_number":6,"context_line":"    a database model."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_4ca3079d","line":4,"range":{"start_line":4,"start_character":33,"end_line":4,"end_character":59},"updated":"2018-11-26 14:02:50.000000000","message":"Nit: use ``neutron_lib.db.model_query`` for formatting.","commit_id":"b1a9d158971512e8f1b5458170bacc1984f6fd0c"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"2d340bc9b274aa66f254a597488aa1d72ae6ab11","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add method ``get_values`` in neutron_lib.db.model_query."},{"line_number":5,"context_line":"    This method allow callers to fetch specific column from"},{"line_number":6,"context_line":"    a database model."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f79a3b5_b3f46f89","line":4,"range":{"start_line":4,"start_character":33,"end_line":4,"end_character":59},"in_reply_to":"3f79a3b5_4ca3079d","updated":"2018-11-26 20:22:40.000000000","message":"Done","commit_id":"b1a9d158971512e8f1b5458170bacc1984f6fd0c"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"e9959a45d9e7a7e8f2d7ce0e694619ebe26290a0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3f79a3b5_8ccb5f49","line":7,"updated":"2018-11-26 14:02:50.000000000","message":"What about the change to query_with_hooks?","commit_id":"b1a9d158971512e8f1b5458170bacc1984f6fd0c"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"2d340bc9b274aa66f254a597488aa1d72ae6ab11","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3f79a3b5_d3efabaf","line":7,"in_reply_to":"3f79a3b5_8ccb5f49","updated":"2018-11-26 20:22:40.000000000","message":"Done","commit_id":"b1a9d158971512e8f1b5458170bacc1984f6fd0c"}]}