)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"fbb0431e532da6f80921d98ffdbc65fb64e64693","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Also, warn on mixed uses of old and new methods."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #1803745"},{"line_number":14,"context_line":"Change-Id: Ic04efbe6915293d2f8d181c9a5348cc8aa58bd62"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_218305ac","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":20},"updated":"2018-11-28 09:41:46.000000000","message":"Related-Bug","commit_id":"475661100c8cd97ed0be99dbdb54e96ce27e1bbf"}],"neutron_lib/context.py":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"36245a37096b37b823a7a092f3a1a65cfd9602b0","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        # when reader and writer will be used"},{"line_number":148,"context_line":"        if hasattr(super(Context, self), \u0027session\u0027):"},{"line_number":149,"context_line":"            if self._session:"},{"line_number":150,"context_line":"                warnings.warn(\u0027context.session is used with and without \u0027"},{"line_number":151,"context_line":"                              \u0027new enginefacade. Please update the code to \u0027"},{"line_number":152,"context_line":"                              \u0027use new enginefacede consistently.\u0027,"},{"line_number":153,"context_line":"                              DeprecationWarning)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_34dd6512","line":150,"updated":"2018-11-29 13:09:16.000000000","message":"I\u0027m trying to understand the use of warnings better... Why are we using warn() here rather than logging something?","commit_id":"7d3bb6862eb3f8e9dc0ee62be27845c9920a05a6"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"569b7d056e74b694b403082b1a27378e8df1b9a9","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        # when reader and writer will be used"},{"line_number":148,"context_line":"        if hasattr(super(Context, self), \u0027session\u0027):"},{"line_number":149,"context_line":"            if self._session:"},{"line_number":150,"context_line":"                warnings.warn(\u0027context.session is used with and without \u0027"},{"line_number":151,"context_line":"                              \u0027new enginefacade. Please update the code to \u0027"},{"line_number":152,"context_line":"                              \u0027use new enginefacede consistently.\u0027,"},{"line_number":153,"context_line":"                              DeprecationWarning)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_fdc6949b","line":150,"in_reply_to":"3f79a3b5_3209e329","updated":"2018-12-04 16:52:59.000000000","message":"In this case it seems like we want to alert a developer that they are doing something dangerous. There\u0027s not much action an operator could take with this without changing code (ie putting on the developer hat). This won\u0027t pollute logs with things the operator can\u0027t or is otherwise not inclined to fix on their own, which I think is appreciated by many operators.\n\nThis is how I justify this approach, maybe others disagree?","commit_id":"7d3bb6862eb3f8e9dc0ee62be27845c9920a05a6"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"e76ba278a066b4398e1c6643beacc4395c02034e","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        # when reader and writer will be used"},{"line_number":148,"context_line":"        if hasattr(super(Context, self), \u0027session\u0027):"},{"line_number":149,"context_line":"            if self._session:"},{"line_number":150,"context_line":"                warnings.warn(\u0027context.session is used with and without \u0027"},{"line_number":151,"context_line":"                              \u0027new enginefacade. Please update the code to \u0027"},{"line_number":152,"context_line":"                              \u0027use new enginefacede consistently.\u0027,"},{"line_number":153,"context_line":"                              DeprecationWarning)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_ead708bd","line":150,"in_reply_to":"3f79a3b5_34dd6512","updated":"2018-11-29 15:07:34.000000000","message":"i thought it was better not to rely on the logger setup because this is a library.","commit_id":"7d3bb6862eb3f8e9dc0ee62be27845c9920a05a6"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"62c96fc2c556b69880fc8c62e62fc9b1f48438d2","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        # when reader and writer will be used"},{"line_number":148,"context_line":"        if hasattr(super(Context, self), \u0027session\u0027):"},{"line_number":149,"context_line":"            if self._session:"},{"line_number":150,"context_line":"                warnings.warn(\u0027context.session is used with and without \u0027"},{"line_number":151,"context_line":"                              \u0027new enginefacade. Please update the code to \u0027"},{"line_number":152,"context_line":"                              \u0027use new enginefacede consistently.\u0027,"},{"line_number":153,"context_line":"                              DeprecationWarning)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_3209e329","line":150,"in_reply_to":"3f79a3b5_ead708bd","updated":"2018-11-30 08:48:05.000000000","message":"I see that Oslo_log logger is used in many other places in neutron-lib, like e.g. in neutron_lib.callbacks.manager or neutron_lib.api.validators module. So is it really worth to do it differently in this case?","commit_id":"7d3bb6862eb3f8e9dc0ee62be27845c9920a05a6"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ad8ef34977295e08ce7c4d6be7e0868c340b933b","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        # when reader and writer will be used"},{"line_number":148,"context_line":"        if hasattr(super(Context, self), \u0027session\u0027):"},{"line_number":149,"context_line":"            if self._session:"},{"line_number":150,"context_line":"                warnings.warn(\u0027context.session is used with and without \u0027"},{"line_number":151,"context_line":"                              \u0027new enginefacade. Please update the code to \u0027"},{"line_number":152,"context_line":"                              \u0027use new enginefacede consistently.\u0027,"},{"line_number":153,"context_line":"                              DeprecationWarning)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_236ffb61","line":150,"in_reply_to":"3f79a3b5_fdc6949b","updated":"2018-12-05 08:25:38.000000000","message":"Yes, I think You are right Ryan","commit_id":"7d3bb6862eb3f8e9dc0ee62be27845c9920a05a6"}]}