)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ef24e4d321ded0a941a0f5af982a5d06ca96692f","unresolved":false,"context_lines":[{"line_number":17,"context_line":"It seems to be less flexible since user cannot directly change the"},{"line_number":18,"context_line":"ceiling value unless he/she changes the rpc_response_timeout. By adding"},{"line_number":19,"context_line":"rpc_max_timeout, user can now modify it without changing the any other"},{"line_number":20,"context_line":"parameters."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"In class _BackingOffContextWrapper, _max_timeout and its setters are"},{"line_number":23,"context_line":"useless temporarily because users can now directly change the rpc_max_"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f79a3b5_2fd99252","line":20,"updated":"2018-12-12 08:47:59.000000000","message":"I understand that Your solution is more flexible but can You explain exactly why this flexibility is good and is \"plus value\" for user?\nDo we really need to add another knob to config? What real problem it can solve?","commit_id":"c4081ff259d54cc2ed4b7b5ecaf3cae5f6ccc81d"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"350b270228670e079ed87c7b2efa0a9154841996","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     nicky \u003cpomelonicky@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-12-20 13:24:00 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add a new configuration parameter rpc_max_timeout"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"A new parameter rpc_max_timeout is added and registered into"},{"line_number":10,"context_line":"neutron.conf. (related codes in neutron)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3f79a3b5_7e9d5a69","line":7,"range":{"start_line":7,"start_character":34,"end_line":7,"end_character":49},"updated":"2018-12-20 06:17:54.000000000","message":"What about the new name `rpc_response_max_timeout`? It will look like more proper to the rpc_response_timeout, since it is only cover the response time out. rpc_max_timeout looks a very generic beyond current usage.","commit_id":"ee901c3e1ea2651d3074ba93a5467788c91bd74b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a2d974179bb3ff32c63b3fd7c056bd494680821a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"A new parameter rpc_response_max_timeout is added and registered into"},{"line_number":10,"context_line":"neutron.conf. (related codes in neutron)"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The rpc_response_max_timeout plays a role of the ceiling of timeout seconds when"},{"line_number":13,"context_line":"waiting for the response of a remote rpc server."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"During an RPC call, the waiting time starts from the existing parameter"},{"line_number":16,"context_line":"rpc_response_timeout(default 60s) and doubled each time until it reaches"},{"line_number":17,"context_line":"the ceiling which is currently set as 10 times rpc_response_timeout."},{"line_number":18,"context_line":"It seems to be less flexible since user cannot directly change the"},{"line_number":19,"context_line":"ceiling value unless he/she changes the rpc_response_timeout. By adding"},{"line_number":20,"context_line":"rpc_response_max_timeout, user can now modify it without changing the any other"},{"line_number":21,"context_line":"parameters."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"In class _BackingOffContextWrapper, _max_timeout and its setters are"},{"line_number":24,"context_line":"useless temporarily because users can now directly change the rpc_max_"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3f79a3b5_bdaf757d","line":21,"range":{"start_line":12,"start_character":0,"end_line":21,"end_character":11},"updated":"2018-12-20 10:18:22.000000000","message":"please wrap lines at 73 chars in commit message","commit_id":"2feb88880fd7603d88bc6f3f464d0b11ca2b5b77"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a2d974179bb3ff32c63b3fd7c056bd494680821a","unresolved":false,"context_lines":[{"line_number":26,"context_line":"prevent the developer to override this parameter."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Co-Authored-By: Allain Legacy\u003cAllain.legacy@windriver.com\u003e"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Change-Id: I45d2e5c063d2dd43cb8aec1d46faa3ee8ea4825f"},{"line_number":31,"context_line":"Related-Bug: #1805769"},{"line_number":32,"context_line":"Story: 2004456"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3f79a3b5_7da55d9b","line":29,"updated":"2018-12-20 10:18:22.000000000","message":"Please add \"Depends-on\" with neutron patch https://review.openstack.org/#/c/626109/","commit_id":"2feb88880fd7603d88bc6f3f464d0b11ca2b5b77"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"9fbbc61e29d7f3246d6f050da6be126d03963a80","unresolved":false,"context_lines":[{"line_number":29,"context_line":"Co-Authored-By: Allain Legacy\u003cAllain.legacy@windriver.com\u003e"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Change-Id: I45d2e5c063d2dd43cb8aec1d46faa3ee8ea4825f"},{"line_number":32,"context_line":"Depends-on: https://review.openstack.org/#/c/626109/5"},{"line_number":33,"context_line":"Related-Bug: #1805769"},{"line_number":34,"context_line":"Story: 2004456"},{"line_number":35,"context_line":"Task: 28171"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"1f769fc5_75b88d29","line":32,"range":{"start_line":32,"start_character":12,"end_line":32,"end_character":53},"updated":"2018-12-31 17:07:56.000000000","message":"Not sure how this Depends on will work with a specified patchset (5 here)... I think this should really just be a link to the patch itself https://review.openstack.org/#/c/626109","commit_id":"925865fa21b81eb285f88cd5281f23608f7f013e"}],"neutron_lib/rpc.py":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"cb9f51a17aef2db6f6899cb5299921b683ff13d1","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    return collections.defaultdict(_get_default_method_timeout)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"def _get_max_timeout():"},{"line_number":94,"context_line":"    return TRANSPORT.conf.rpc_max_timeout"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_ce92b9fb","line":93,"range":{"start_line":93,"start_character":4,"end_line":93,"end_character":20},"updated":"2018-12-07 13:23:50.000000000","message":"If this is private any only used on L136, why not just use TRANSPORT.conf.rpc_max_timeout rather than defining this new private function?","commit_id":"7debff2aa4a0c1ffeabf7e7587b193492328f385"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ef24e4d321ded0a941a0f5af982a5d06ca96692f","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    cfg.IntOpt(\u0027rpc_max_timeout\u0027,"},{"line_number":45,"context_line":"               default\u003d600,"},{"line_number":46,"context_line":"               help\u003d\u0027Maximum seconds to wait for a response from a call.\u0027),"},{"line_number":47,"context_line":"]"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"def init(conf, rpc_ext_mods\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_8f5546c7","line":47,"updated":"2018-12-12 08:47:59.000000000","message":"I\u0027m not sure about general policy of how it should be done but I can\u0027t see any other config option defined in neutron-lib so I think that config options should be defined in neutron repo directly.\n@Boden, @mlavalle: do You agree or can/should we define config options in neutron-lib directly?\nEven if it\u0027s good to have it in neutron-lib, it should be moved to separate directory, in similar way like it\u0027s done in Neutron repo now.","commit_id":"c4081ff259d54cc2ed4b7b5ecaf3cae5f6ccc81d"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"514a460f7bb87f41f1d31c328378fd663a89f884","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    cfg.IntOpt(\u0027rpc_max_timeout\u0027,"},{"line_number":45,"context_line":"               default\u003d600,"},{"line_number":46,"context_line":"               help\u003d\u0027Maximum seconds to wait for a response from a call.\u0027),"},{"line_number":47,"context_line":"]"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"def init(conf, rpc_ext_mods\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_fae26fff","line":47,"in_reply_to":"3f79a3b5_8f5546c7","updated":"2018-12-12 14:03:15.000000000","message":"To date I don\u0027t think we\u0027ve defined any conf opts in neutron-lib. IIRC the problem arises if consumers need the config opt for generating config files, etc.. in which case IIRC it needs to be in the setup.cfg and there isn\u0027t a good way for consumers to access it as such.\n\n\nHowever addressing config opts is something we need to do at some point. There\u0027s a work item for it here: https://etherpad.openstack.org/p/neutron-lib-volunteers-and-punch-list","commit_id":"c4081ff259d54cc2ed4b7b5ecaf3cae5f6ccc81d"}],"neutron_lib/tests/unit/test_rpc.py":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"cb9f51a17aef2db6f6899cb5299921b683ff13d1","unresolved":false,"context_lines":[{"line_number":292,"context_line":"        self.call_context \u003d mock.Mock()"},{"line_number":293,"context_line":"        self.sleep \u003d mock.patch(\u0027time.sleep\u0027).start()"},{"line_number":294,"context_line":"        rpc.TRANSPORT.conf.rpc_response_timeout \u003d 10"},{"line_number":295,"context_line":"        rpc.TRANSPORT.conf.rpc_max_timeout \u003d 100"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"    def test_timeout_unaffected_when_explicitly_set(self):"},{"line_number":298,"context_line":"        rpc.TRANSPORT.conf.rpc_response_timeout \u003d 5"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_6eacc537","line":295,"updated":"2018-12-07 13:23:50.000000000","message":"How is this being tested to ensure get_max_timeout() is actually using the value when it should?","commit_id":"7debff2aa4a0c1ffeabf7e7587b193492328f385"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a2d974179bb3ff32c63b3fd7c056bd494680821a","unresolved":false,"context_lines":[{"line_number":292,"context_line":"        self.call_context \u003d mock.Mock()"},{"line_number":293,"context_line":"        self.sleep \u003d mock.patch(\u0027time.sleep\u0027).start()"},{"line_number":294,"context_line":"        rpc.TRANSPORT.conf.rpc_response_timeout \u003d 10"},{"line_number":295,"context_line":"        rpc.TRANSPORT.conf.rpc_response_max_timeout \u003d 100"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"    def test_timeout_unaffected_when_explicitly_set(self):"},{"line_number":298,"context_line":"        rpc.TRANSPORT.conf.rpc_response_timeout \u003d 5"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_ddd91127","line":295,"updated":"2018-12-20 10:18:22.000000000","message":"please use different value and adjust corresponding tests to it. That way You will prove that Your change is actually working as expected :)","commit_id":"2feb88880fd7603d88bc6f3f464d0b11ca2b5b77"}],"releasenotes/notes/add-a-getter-for-a-newly-added-option-2082877bf7dd136b.yaml":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a2d974179bb3ff32c63b3fd7c056bd494680821a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - A getter of the newly added option rpc_max_timeout"},{"line_number":4,"context_line":"    is added."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3f79a3b5_3d1fe5b9","line":4,"updated":"2018-12-20 10:18:22.000000000","message":"I\u0027m not sure if release not for this is necessary. If it is, I would say something more important for end users here, for example something like:\n\n\"Maximum rpc timeout is now configurable by ``rpc_response_max_timeout`` from Neutron config instead of being calculated as ``10 * rpc_response_timeout`` value\"\n\nOr something like that.","commit_id":"2feb88880fd7603d88bc6f3f464d0b11ca2b5b77"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6363d774788f0d195ce15b002d714502e4d7f68c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Maximum rpc timeout is now configurable by \"rpc_response_max_timeout\""},{"line_number":4,"context_line":"    from Neutron config instead of being calculated as \"10 *"},{"line_number":5,"context_line":"    rpc_response_timeout\" value."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f79a3b5_66db7a7a","line":3,"range":{"start_line":3,"start_character":47,"end_line":3,"end_character":48},"updated":"2018-12-21 07:36:42.000000000","message":"please use `` instead of \"","commit_id":"b22f99b4e65ad8c6c15a4d392c751fe779bbb14c"}],"releasenotes/notes/add-a-new-configuration-parameter-09460618774982c1.yaml":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ef24e4d321ded0a941a0f5af982a5d06ca96692f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - A new configuration parameter rpc_max_timeout"},{"line_number":4,"context_line":"    is added in neutron_lib/rpc.py."},{"line_number":5,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f79a3b5_afffe2ae","line":3,"range":{"start_line":3,"start_character":34,"end_line":3,"end_character":49},"updated":"2018-12-12 08:47:59.000000000","message":"this should be inside `` ``, so something like:\n\n    ``rpc_max_timeout``","commit_id":"c4081ff259d54cc2ed4b7b5ecaf3cae5f6ccc81d"}]}