)]}'
{"api-ref/source/v2/interconnection.inc":[{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"754575363a71f709c603c475ebd93ece87d8427f","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"   - interconnections: interconnections"},{"line_number":39,"context_line":"   - project_id: project_id"},{"line_number":40,"context_line":"   - id: interconnection-id"},{"line_number":41,"context_line":"   - name: interconnection-name"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"1f769fc5_04b9df2c","line":38,"updated":"2019-01-02 16:49:54.000000000","message":"It looks like we need to add some definitions for these fields in https://github.com/openstack/neutron-lib/blob/master/api-ref/source/v2/parameters.yaml","commit_id":"9732d079739e93bd86c84106817d7b99ff5e39ad"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"34d28e4a59d5bfda3ae4d8cbdbf6b1574e00808b","unresolved":false,"context_lines":[{"line_number":9,"context_line":"List interconnections"},{"line_number":10,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":".. rest_method::  GET /v2.0/inter/interconnections"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Lists all interconnections belonging to the project."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":4,"id":"bfdaf3ff_3928c8e0","line":12,"range":{"start_line":12,"start_character":28,"end_line":12,"end_character":33},"updated":"2019-01-15 13:18:43.000000000","message":"I do see this as the API_PREFIX, but seems a bit odd... Is there a reason to use this /inter/ prefix?","commit_id":"cbd75d1c9e486490e2c8507f6d248215592a847c"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"34d28e4a59d5bfda3ae4d8cbdbf6b1574e00808b","unresolved":false,"context_lines":[{"line_number":38,"context_line":"   - interconnections: interconnections"},{"line_number":39,"context_line":"   - project_id: project_id"},{"line_number":40,"context_line":"   - id: interconnection-id-body"},{"line_number":41,"context_line":"   - name: interconnection-name"},{"line_number":42,"context_line":"   - type: interconnection-type"},{"line_number":43,"context_line":"   - state: interconnection-state"},{"line_number":44,"context_line":"   - local_resource_id: interconnection-local_resource_id"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"bfdaf3ff_b962783d","line":41,"range":{"start_line":41,"start_character":11,"end_line":41,"end_character":31},"updated":"2019-01-15 13:18:43.000000000","message":"This shows up as optional; meaning it doesn\u0027t always come back in the response body. Is this true?","commit_id":"cbd75d1c9e486490e2c8507f6d248215592a847c"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"34d28e4a59d5bfda3ae4d8cbdbf6b1574e00808b","unresolved":false,"context_lines":[{"line_number":40,"context_line":"   - id: interconnection-id-body"},{"line_number":41,"context_line":"   - name: interconnection-name"},{"line_number":42,"context_line":"   - type: interconnection-type"},{"line_number":43,"context_line":"   - state: interconnection-state"},{"line_number":44,"context_line":"   - local_resource_id: interconnection-local_resource_id"},{"line_number":45,"context_line":"   - remote_resource_id: interconnection-remote_resource_id"},{"line_number":46,"context_line":"   - remote_keystone: interconnection-remote_keystone"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"bfdaf3ff_d965fc46","line":43,"range":{"start_line":43,"start_character":5,"end_line":43,"end_character":10},"updated":"2019-01-15 13:18:43.000000000","message":"This shows up as optional; meaning it doesn\u0027t always come back in the response body. Is this true?","commit_id":"cbd75d1c9e486490e2c8507f6d248215592a847c"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"34d28e4a59d5bfda3ae4d8cbdbf6b1574e00808b","unresolved":false,"context_lines":[{"line_number":46,"context_line":"   - remote_keystone: interconnection-remote_keystone"},{"line_number":47,"context_line":"   - remote_region: interconnection-remote_region"},{"line_number":48,"context_line":"   - remote_interconnection_id: interconnection-remote_interconnection_id"},{"line_number":49,"context_line":"   - local_parameters: interconnection-local_parameters"},{"line_number":50,"context_line":"   - remote_parameters: interconnection-remote_parameters"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Response Example"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"bfdaf3ff_795c107e","line":49,"range":{"start_line":49,"start_character":5,"end_line":49,"end_character":21},"updated":"2019-01-15 13:18:43.000000000","message":"This shows up as optional; meaning it doesn\u0027t always come back in the response body. Is this true?","commit_id":"cbd75d1c9e486490e2c8507f6d248215592a847c"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"dc21a1195d769c69b7b1be94307f8ffea3fbf4ad","unresolved":false,"context_lines":[{"line_number":46,"context_line":"   - remote_keystone: interconnection-remote_keystone"},{"line_number":47,"context_line":"   - remote_region: interconnection-remote_region"},{"line_number":48,"context_line":"   - remote_interconnection_id: interconnection-remote_interconnection_id"},{"line_number":49,"context_line":"   - local_parameters: interconnection-local_parameters"},{"line_number":50,"context_line":"   - remote_parameters: interconnection-remote_parameters"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Response Example"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"9fdfeff1_43934a50","line":49,"range":{"start_line":49,"start_character":5,"end_line":49,"end_character":21},"in_reply_to":"bfdaf3ff_795c107e","updated":"2019-01-24 15:57:18.000000000","message":"(yes)\n\nAdditionally, we could document that this read-only attribute should only be visible to the admin.","commit_id":"cbd75d1c9e486490e2c8507f6d248215592a847c"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"34d28e4a59d5bfda3ae4d8cbdbf6b1574e00808b","unresolved":false,"context_lines":[{"line_number":47,"context_line":"   - remote_region: interconnection-remote_region"},{"line_number":48,"context_line":"   - remote_interconnection_id: interconnection-remote_interconnection_id"},{"line_number":49,"context_line":"   - local_parameters: interconnection-local_parameters"},{"line_number":50,"context_line":"   - remote_parameters: interconnection-remote_parameters"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Response Example"},{"line_number":53,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"bfdaf3ff_3956885e","line":50,"range":{"start_line":50,"start_character":5,"end_line":50,"end_character":22},"updated":"2019-01-15 13:18:43.000000000","message":"This shows up as optional; meaning it doesn\u0027t always come back in the response body. Is this true?","commit_id":"cbd75d1c9e486490e2c8507f6d248215592a847c"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"dc21a1195d769c69b7b1be94307f8ffea3fbf4ad","unresolved":false,"context_lines":[{"line_number":47,"context_line":"   - remote_region: interconnection-remote_region"},{"line_number":48,"context_line":"   - remote_interconnection_id: interconnection-remote_interconnection_id"},{"line_number":49,"context_line":"   - local_parameters: interconnection-local_parameters"},{"line_number":50,"context_line":"   - remote_parameters: interconnection-remote_parameters"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Response Example"},{"line_number":53,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"9fdfeff1_e3991e6e","line":50,"range":{"start_line":50,"start_character":5,"end_line":50,"end_character":22},"in_reply_to":"bfdaf3ff_3956885e","updated":"2019-01-24 15:57:18.000000000","message":"(ditto)","commit_id":"cbd75d1c9e486490e2c8507f6d248215592a847c"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"34d28e4a59d5bfda3ae4d8cbdbf6b1574e00808b","unresolved":false,"context_lines":[{"line_number":72,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"   - interconnection: interconnection"},{"line_number":75,"context_line":"   - project_id: project_id-request"},{"line_number":76,"context_line":"   - name: interconnection-name"},{"line_number":77,"context_line":"   - type: interconnection-type"},{"line_number":78,"context_line":"   - local_resource_id: interconnection-local_resource_id"},{"line_number":79,"context_line":"   - remote_resource_id: interconnection-remote_resource_id"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"bfdaf3ff_59d6ecc5","line":76,"range":{"start_line":75,"start_character":5,"end_line":76,"end_character":31},"updated":"2019-01-15 13:18:43.000000000","message":"Just to confirm what this says... Only the name and project_id are optional on the request; everything else is required and must be in the request body??","commit_id":"cbd75d1c9e486490e2c8507f6d248215592a847c"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"858ad73b8cac5f2c5d29f6c791e0be94bf5e0cc4","unresolved":false,"context_lines":[{"line_number":72,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"   - interconnection: interconnection"},{"line_number":75,"context_line":"   - project_id: project_id-request"},{"line_number":76,"context_line":"   - name: interconnection-name"},{"line_number":77,"context_line":"   - type: interconnection-type"},{"line_number":78,"context_line":"   - local_resource_id: interconnection-local_resource_id"},{"line_number":79,"context_line":"   - remote_resource_id: interconnection-remote_resource_id"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"9fdfeff1_cca68cac","line":76,"range":{"start_line":75,"start_character":5,"end_line":76,"end_character":31},"in_reply_to":"bfdaf3ff_59d6ecc5","updated":"2019-02-08 16:43:01.000000000","message":"The name should be optional in fact, its just informative.\n\nAnd I think type, local_resource_id, and remote_resource_id should be required, but not remote_keystone and remote_region, which could be left to their default","commit_id":"cbd75d1c9e486490e2c8507f6d248215592a847c"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"fdc68f74e7ffbb7405fe98a9e7da94284e1a718f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Introduce a new ``interconnection`` resource."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"An interconnection is created by a tenant and parameters specific to the"},{"line_number":10,"context_line":"interconnection mechanism (``local_parameters`` and ``remote_parameters``) are"},{"line_number":11,"context_line":"only visible by the admin or users with specific role (default role:"},{"line_number":12,"context_line":"``neutron_interconnection_peer``)."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":7,"id":"9fdfeff1_09878f63","line":10,"range":{"start_line":10,"start_character":75,"end_line":10,"end_character":78},"updated":"2019-02-11 13:22:25.000000000","message":"that are?","commit_id":"871772f6f7ffdee663be19371de2f50fe168eeec"},{"author":{"_account_id":19990,"name":"Yannick Thomas","email":"ythomas1.ext@orange.com","username":"ythomas1"},"change_message_id":"dc711ee7ebfa3b8022711495f15daa1d83fa9278","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Introduce a new ``interconnection`` resource."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"An interconnection is created by a tenant and parameters specific to the"},{"line_number":10,"context_line":"interconnection mechanism (``local_parameters`` and ``remote_parameters``) are"},{"line_number":11,"context_line":"only visible by the admin or users with specific role (default role:"},{"line_number":12,"context_line":"``neutron_interconnection_peer``)."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":7,"id":"9fdfeff1_7af58456","line":10,"range":{"start_line":10,"start_character":75,"end_line":10,"end_character":78},"in_reply_to":"9fdfeff1_09878f63","updated":"2019-02-13 15:15:18.000000000","message":"Done","commit_id":"871772f6f7ffdee663be19371de2f50fe168eeec"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"fdc68f74e7ffbb7405fe98a9e7da94284e1a718f","unresolved":false,"context_lines":[{"line_number":53,"context_line":"   - remote_keystone: interconnection-remote_keystone"},{"line_number":54,"context_line":"   - remote_region: interconnection-remote_region"},{"line_number":55,"context_line":"   - remote_interconnection_id: interconnection-remote_interconnection_id"},{"line_number":56,"context_line":"   - local_parameters: interconnection-local_parameters"},{"line_number":57,"context_line":"   - remote_parameters: interconnection-remote_parameters"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"Response Example"},{"line_number":60,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":7,"id":"9fdfeff1_2991339a","line":57,"range":{"start_line":56,"start_character":0,"end_line":57,"end_character":57},"updated":"2019-02-11 13:22:25.000000000","message":"Local and remote params only come back in the response sometimes?? Just confirming what the use of \"optional\" says here.","commit_id":"871772f6f7ffdee663be19371de2f50fe168eeec"},{"author":{"_account_id":19990,"name":"Yannick Thomas","email":"ythomas1.ext@orange.com","username":"ythomas1"},"change_message_id":"dc711ee7ebfa3b8022711495f15daa1d83fa9278","unresolved":false,"context_lines":[{"line_number":53,"context_line":"   - remote_keystone: interconnection-remote_keystone"},{"line_number":54,"context_line":"   - remote_region: interconnection-remote_region"},{"line_number":55,"context_line":"   - remote_interconnection_id: interconnection-remote_interconnection_id"},{"line_number":56,"context_line":"   - local_parameters: interconnection-local_parameters"},{"line_number":57,"context_line":"   - remote_parameters: interconnection-remote_parameters"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"Response Example"},{"line_number":60,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":7,"id":"9fdfeff1_5a63e01a","line":57,"range":{"start_line":56,"start_character":0,"end_line":57,"end_character":57},"in_reply_to":"9fdfeff1_2991339a","updated":"2019-02-13 15:15:18.000000000","message":"\"Optional\" here means that it depends on the role of the user that send the request (see above)","commit_id":"871772f6f7ffdee663be19371de2f50fe168eeec"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"d2fe8adc74a9e279616e90b5a8e7e54767094a62","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Neutron-Neutron Interconnection"},{"line_number":5,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Introduce a new ``interconnection`` resource."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"On a created interconnection by a tenant, parameters specific to the"},{"line_number":10,"context_line":"interconnection mechanism (``local_parameters`` and ``remote_parameters``) are"}],"source_content_type":"text/x-c++src","patch_set":10,"id":"9fdfeff1_40899c72","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":9},"updated":"2019-02-14 13:15:58.000000000","message":"Introduces?","commit_id":"02a424823d7dac1a80d4f31864df6ca7033ef601"},{"author":{"_account_id":19990,"name":"Yannick Thomas","email":"ythomas1.ext@orange.com","username":"ythomas1"},"change_message_id":"68522804805a09f46d40640495e6f578614f7b25","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Neutron-Neutron Interconnection"},{"line_number":5,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Introduce a new ``interconnection`` resource."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"On a created interconnection by a tenant, parameters specific to the"},{"line_number":10,"context_line":"interconnection mechanism (``local_parameters`` and ``remote_parameters``) are"}],"source_content_type":"text/x-c++src","patch_set":10,"id":"9fdfeff1_666b9884","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":9},"in_reply_to":"9fdfeff1_40899c72","updated":"2019-02-14 15:48:18.000000000","message":"Done","commit_id":"02a424823d7dac1a80d4f31864df6ca7033ef601"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"d2fe8adc74a9e279616e90b5a8e7e54767094a62","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Introduce a new ``interconnection`` resource."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"On a created interconnection by a tenant, parameters specific to the"},{"line_number":10,"context_line":"interconnection mechanism (``local_parameters`` and ``remote_parameters``) are"},{"line_number":11,"context_line":"only visible by the admin or users with specific role (default role:"},{"line_number":12,"context_line":"``neutron_interconnection_peer``)."}],"source_content_type":"text/x-c++src","patch_set":10,"id":"9fdfeff1_a09968c4","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":52},"updated":"2019-02-14 13:15:58.000000000","message":"When an interconnection is created by a tenant?","commit_id":"02a424823d7dac1a80d4f31864df6ca7033ef601"},{"author":{"_account_id":19990,"name":"Yannick Thomas","email":"ythomas1.ext@orange.com","username":"ythomas1"},"change_message_id":"68522804805a09f46d40640495e6f578614f7b25","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Introduce a new ``interconnection`` resource."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"On a created interconnection by a tenant, parameters specific to the"},{"line_number":10,"context_line":"interconnection mechanism (``local_parameters`` and ``remote_parameters``) are"},{"line_number":11,"context_line":"only visible by the admin or users with specific role (default role:"},{"line_number":12,"context_line":"``neutron_interconnection_peer``)."}],"source_content_type":"text/x-c++src","patch_set":10,"id":"9fdfeff1_460a14d2","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":52},"in_reply_to":"9fdfeff1_a09968c4","updated":"2019-02-14 15:48:18.000000000","message":"Done","commit_id":"02a424823d7dac1a80d4f31864df6ca7033ef601"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"d2fe8adc74a9e279616e90b5a8e7e54767094a62","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Introduce a new ``interconnection`` resource."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"On a created interconnection by a tenant, parameters specific to the"},{"line_number":10,"context_line":"interconnection mechanism (``local_parameters`` and ``remote_parameters``) are"},{"line_number":11,"context_line":"only visible by the admin or users with specific role (default role:"},{"line_number":12,"context_line":"``neutron_interconnection_peer``)."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":10,"id":"9fdfeff1_c047cc1c","line":10,"range":{"start_line":10,"start_character":52,"end_line":10,"end_character":73},"updated":"2019-02-14 13:15:58.000000000","message":"And remote keystone + region??","commit_id":"02a424823d7dac1a80d4f31864df6ca7033ef601"},{"author":{"_account_id":19990,"name":"Yannick Thomas","email":"ythomas1.ext@orange.com","username":"ythomas1"},"change_message_id":"68522804805a09f46d40640495e6f578614f7b25","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Introduce a new ``interconnection`` resource."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"On a created interconnection by a tenant, parameters specific to the"},{"line_number":10,"context_line":"interconnection mechanism (``local_parameters`` and ``remote_parameters``) are"},{"line_number":11,"context_line":"only visible by the admin or users with specific role (default role:"},{"line_number":12,"context_line":"``neutron_interconnection_peer``)."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":10,"id":"9fdfeff1_b1fbf876","line":10,"range":{"start_line":10,"start_character":52,"end_line":10,"end_character":73},"in_reply_to":"9fdfeff1_c047cc1c","updated":"2019-02-14 15:48:18.000000000","message":"Different because ``remote_keystone`` and ``remote_region`` are parameters managed by tenant, so they are visible without specific role","commit_id":"02a424823d7dac1a80d4f31864df6ca7033ef601"}],"api-ref/source/v2/parameters.yaml":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"135c2bfd0d744312423694cb68156a899090aba2","unresolved":false,"context_lines":[{"line_number":135,"context_line":"  type: string"},{"line_number":136,"context_line":"interconnection-id-path:"},{"line_number":137,"context_line":"  description: |"},{"line_number":138,"context_line":"      The ID of the interconnection."},{"line_number":139,"context_line":"  in: path"},{"line_number":140,"context_line":"  required: true"},{"line_number":141,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dfd5e7cf_cfe459af","line":138,"range":{"start_line":138,"start_character":20,"end_line":138,"end_character":35},"updated":"2019-01-09 11:29:28.000000000","message":"shouldn\u0027t it be inside `` ``?","commit_id":"c5e6c5fe97470bf13f863e6550eeab387f8b4143"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"135c2bfd0d744312423694cb68156a899090aba2","unresolved":false,"context_lines":[{"line_number":3385,"context_line":"  type: string"},{"line_number":3386,"context_line":"interconnection-remote_keystone:"},{"line_number":3387,"context_line":"  description: |"},{"line_number":3388,"context_line":"   auth_url of the remote Keystone."},{"line_number":3389,"context_line":"  in: body"},{"line_number":3390,"context_line":"  required: true"},{"line_number":3391,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dfd5e7cf_cffd393b","line":3388,"range":{"start_line":3388,"start_character":3,"end_line":3388,"end_character":11},"updated":"2019-01-09 11:29:28.000000000","message":"shouldn\u0027t it be inside `` ``?","commit_id":"c5e6c5fe97470bf13f863e6550eeab387f8b4143"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"135c2bfd0d744312423694cb68156a899090aba2","unresolved":false,"context_lines":[{"line_number":3391,"context_line":"  type: string"},{"line_number":3392,"context_line":"interconnection-remote_parameters:"},{"line_number":3393,"context_line":"  description: |"},{"line_number":3394,"context_line":"   Parameters specific to remote interconnection mechanism exchanged with "},{"line_number":3395,"context_line":"   remote Neutron."},{"line_number":3396,"context_line":"  in: body"},{"line_number":3397,"context_line":"  required: false"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dfd5e7cf_2fff2535","line":3394,"range":{"start_line":3394,"start_character":73,"end_line":3394,"end_character":74},"updated":"2019-01-09 11:29:28.000000000","message":"please remove trailing space","commit_id":"c5e6c5fe97470bf13f863e6550eeab387f8b4143"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"135c2bfd0d744312423694cb68156a899090aba2","unresolved":false,"context_lines":[{"line_number":3411,"context_line":"  type: string"},{"line_number":3412,"context_line":"interconnection-state:"},{"line_number":3413,"context_line":"  description: |"},{"line_number":3414,"context_line":"   The state of the ``interconnection``. Values are ``TO_VALIDATE``,"},{"line_number":3415,"context_line":"   ``PRE_VALIDATE``, ``VALIDATING``, ``VALIDATED``, ``PRE_ACTIVATE``,"},{"line_number":3416,"context_line":"   ``ACTIVATING``, ``ACTIVE``, ``PRE_ACTIVE_CHECK``, ``ACTIVE_CHECKING`` or"},{"line_number":3417,"context_line":"   ``TEARDOWN``."},{"line_number":3418,"context_line":"  in: body"},{"line_number":3419,"context_line":"  required: false"},{"line_number":3420,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dfd5e7cf_afc1d5e6","line":3417,"range":{"start_line":3414,"start_character":0,"end_line":3417,"end_character":16},"updated":"2019-01-09 11:29:28.000000000","message":"those values are different than it was specified in specs: https://specs.openstack.org/openstack/neutron-specs/specs/rocky/neutron-inter.html","commit_id":"c5e6c5fe97470bf13f863e6550eeab387f8b4143"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"135c2bfd0d744312423694cb68156a899090aba2","unresolved":false,"context_lines":[{"line_number":3421,"context_line":"interconnection-type:"},{"line_number":3422,"context_line":"  description: |"},{"line_number":3423,"context_line":"   Selection of the type of interconnection. Allowed values are ``network_l2``,"},{"line_number":3424,"context_line":"   ``network_l3`` or ``router``. Default is ``network_l3``."},{"line_number":3425,"context_line":"  in: body"},{"line_number":3426,"context_line":"  required: true"},{"line_number":3427,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dfd5e7cf_cfabf91a","line":3424,"range":{"start_line":3424,"start_character":46,"end_line":3424,"end_character":56},"updated":"2019-01-09 11:29:28.000000000","message":"in api definition default is \"router\"? Which is true then?","commit_id":"c5e6c5fe97470bf13f863e6550eeab387f8b4143"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"34d28e4a59d5bfda3ae4d8cbdbf6b1574e00808b","unresolved":false,"context_lines":[{"line_number":3439,"context_line":"  type: string"},{"line_number":3440,"context_line":"interconnection-remote_keystone:"},{"line_number":3441,"context_line":"  description: |"},{"line_number":3442,"context_line":"   ``auth_url`` of the remote Keystone."},{"line_number":3443,"context_line":"  in: body"},{"line_number":3444,"context_line":"  required: true"},{"line_number":3445,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bfdaf3ff_f9fd603a","line":3442,"range":{"start_line":3442,"start_character":30,"end_line":3442,"end_character":38},"updated":"2019-01-15 13:18:43.000000000","message":"Nit: might read better as \"Keystone service\" or something like that.","commit_id":"cbd75d1c9e486490e2c8507f6d248215592a847c"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"34d28e4a59d5bfda3ae4d8cbdbf6b1574e00808b","unresolved":false,"context_lines":[{"line_number":3465,"context_line":"  type: string"},{"line_number":3466,"context_line":"interconnection-state:"},{"line_number":3467,"context_line":"  description: |"},{"line_number":3468,"context_line":"   Indicates the state of the ``interconnection``."},{"line_number":3469,"context_line":"  in: body"},{"line_number":3470,"context_line":"  required: false"},{"line_number":3471,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bfdaf3ff_b99598e6","line":3468,"range":{"start_line":3468,"start_character":17,"end_line":3468,"end_character":22},"updated":"2019-01-15 13:18:43.000000000","message":"Is there a list of possible states???","commit_id":"cbd75d1c9e486490e2c8507f6d248215592a847c"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"dc21a1195d769c69b7b1be94307f8ffea3fbf4ad","unresolved":false,"context_lines":[{"line_number":3465,"context_line":"  type: string"},{"line_number":3466,"context_line":"interconnection-state:"},{"line_number":3467,"context_line":"  description: |"},{"line_number":3468,"context_line":"   Indicates the state of the ``interconnection``."},{"line_number":3469,"context_line":"  in: body"},{"line_number":3470,"context_line":"  required: false"},{"line_number":3471,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9fdfeff1_6378ce29","line":3468,"range":{"start_line":3468,"start_character":17,"end_line":3468,"end_character":22},"in_reply_to":"bfdaf3ff_b99598e6","updated":"2019-01-24 15:57:18.000000000","message":"Hi boden...\n\nThe \"status\" is meant to be loosely informative to help eventual human troubleshooting, but not something which we want to document in detail other than in the code and contributors documentation and on certainly not something on which we want our API users to rely on (we may eventually realize that to solve coordination issues between state machines, we need to add/remove a state, and we don\u0027t want backward compat issues with that). \n\nSo the idea is to explicitly *not* detail the list, and document that \"the list of states and their names is an implementation details on which API users should not rely\".\n\nAdding this sentence here will help, I think.","commit_id":"cbd75d1c9e486490e2c8507f6d248215592a847c"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"fdc68f74e7ffbb7405fe98a9e7da94284e1a718f","unresolved":false,"context_lines":[{"line_number":3427,"context_line":"  type: string"},{"line_number":3428,"context_line":"interconnection-local_parameters:"},{"line_number":3429,"context_line":"  description: |"},{"line_number":3430,"context_line":"   Parameters specific to local interconnection mechanism."},{"line_number":3431,"context_line":"  in: body"},{"line_number":3432,"context_line":"  required: false"},{"line_number":3433,"context_line":"  type: dict"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9fdfeff1_29bff3fb","line":3430,"updated":"2019-02-11 13:22:25.000000000","message":"Is it worth noting that these are in a map/dict form?","commit_id":"871772f6f7ffdee663be19371de2f50fe168eeec"},{"author":{"_account_id":19990,"name":"Yannick Thomas","email":"ythomas1.ext@orange.com","username":"ythomas1"},"change_message_id":"dc711ee7ebfa3b8022711495f15daa1d83fa9278","unresolved":false,"context_lines":[{"line_number":3427,"context_line":"  type: string"},{"line_number":3428,"context_line":"interconnection-local_parameters:"},{"line_number":3429,"context_line":"  description: |"},{"line_number":3430,"context_line":"   Parameters specific to local interconnection mechanism."},{"line_number":3431,"context_line":"  in: body"},{"line_number":3432,"context_line":"  required: false"},{"line_number":3433,"context_line":"  type: dict"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9fdfeff1_67ff3101","line":3430,"in_reply_to":"9fdfeff1_29bff3fb","updated":"2019-02-13 15:15:18.000000000","message":"Done","commit_id":"871772f6f7ffdee663be19371de2f50fe168eeec"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"fdc68f74e7ffbb7405fe98a9e7da94284e1a718f","unresolved":false,"context_lines":[{"line_number":3484,"context_line":"  type: string"},{"line_number":3485,"context_line":"interconnection-state:"},{"line_number":3486,"context_line":"  description: |"},{"line_number":3487,"context_line":"   Indicates the state of the ``interconnection``."},{"line_number":3488,"context_line":"  in: body"},{"line_number":3489,"context_line":"  required: true"},{"line_number":3490,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9fdfeff1_c943c712","line":3487,"updated":"2019-02-11 13:22:25.000000000","message":"Is it possible to list the states here? Seems users may want to know this.","commit_id":"871772f6f7ffdee663be19371de2f50fe168eeec"},{"author":{"_account_id":19990,"name":"Yannick Thomas","email":"ythomas1.ext@orange.com","username":"ythomas1"},"change_message_id":"dc711ee7ebfa3b8022711495f15daa1d83fa9278","unresolved":false,"context_lines":[{"line_number":3484,"context_line":"  type: string"},{"line_number":3485,"context_line":"interconnection-state:"},{"line_number":3486,"context_line":"  description: |"},{"line_number":3487,"context_line":"   Indicates the state of the ``interconnection``."},{"line_number":3488,"context_line":"  in: body"},{"line_number":3489,"context_line":"  required: true"},{"line_number":3490,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9fdfeff1_5ac76013","line":3487,"in_reply_to":"9fdfeff1_c943c712","updated":"2019-02-13 15:15:18.000000000","message":"Please, see Thomas Morin\u0027s comment on patch set 4.","commit_id":"871772f6f7ffdee663be19371de2f50fe168eeec"}],"api-ref/source/v2/samples/interconnection/interconnection-create-request.json":[{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"754575363a71f709c603c475ebd93ece87d8427f","unresolved":false,"context_lines":[{"line_number":3,"context_line":"        \"project_id\": \"5455570dafa34c32abb69c70005a57de\","},{"line_number":4,"context_line":"        \"name\": \"interconnection1\","},{"line_number":5,"context_line":"        \"type\": \"network_l3\","},{"line_number":6,"context_line":"        \"local_resource_id\": \"5d6820bf-a528-4e0c-85df-c2e771368d55\","},{"line_number":7,"context_line":"        \"remote_resource_id\": \"a02d408d-7493-4291-b7bc-56894d063693\","},{"line_number":8,"context_line":"        \"remote_keystone\": \"http://10.0.0.100/identity\","},{"line_number":9,"context_line":"        \"remote_region\": \"RegionOne\""}],"source_content_type":"application/json","patch_set":2,"id":"1f769fc5_64cbf371","line":6,"updated":"2019-01-02 16:49:54.000000000","message":"What is local_resource_id? Is this the UUID of a local router or network, or is it something else? This is unclear to me, some more documentation around this would be helpful.","commit_id":"9732d079739e93bd86c84106817d7b99ff5e39ad"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"754575363a71f709c603c475ebd93ece87d8427f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"        \"name\": \"interconnection1\","},{"line_number":5,"context_line":"        \"type\": \"network_l3\","},{"line_number":6,"context_line":"        \"local_resource_id\": \"5d6820bf-a528-4e0c-85df-c2e771368d55\","},{"line_number":7,"context_line":"        \"remote_resource_id\": \"a02d408d-7493-4291-b7bc-56894d063693\","},{"line_number":8,"context_line":"        \"remote_keystone\": \"http://10.0.0.100/identity\","},{"line_number":9,"context_line":"        \"remote_region\": \"RegionOne\""},{"line_number":10,"context_line":"    }"}],"source_content_type":"application/json","patch_set":2,"id":"1f769fc5_e492a34b","line":7,"updated":"2019-01-02 16:49:54.000000000","message":"Similar comment here, is this a remote resource ID for a router/network/...? Should we also be sending the remote interconnection ID on a create request? Should an interconnection exist as a resource without a remote interconnection ID?","commit_id":"9732d079739e93bd86c84106817d7b99ff5e39ad"}],"api-ref/source/v2/samples/interconnection/interconnection-create-response.json":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"34d28e4a59d5bfda3ae4d8cbdbf6b1574e00808b","unresolved":false,"context_lines":[{"line_number":9,"context_line":"        \"remote_resource_id\": \"a02d408d-7493-4291-b7bc-56894d063693\","},{"line_number":10,"context_line":"        \"remote_keystone\": \"http://10.0.0.100/identity\","},{"line_number":11,"context_line":"        \"remote_region\": \"RegionOne\","},{"line_number":12,"context_line":"        \"remote_interconnection_id\": \"\","},{"line_number":13,"context_line":"        \"local_parameters\": {},"},{"line_number":14,"context_line":"        \"remote_parameters\": {}"},{"line_number":15,"context_line":"    }"}],"source_content_type":"application/json","patch_set":4,"id":"bfdaf3ff_79ead075","line":12,"range":{"start_line":12,"start_character":37,"end_line":12,"end_character":39},"updated":"2019-01-15 13:18:43.000000000","message":"Will this be the empty sting, or null?","commit_id":"cbd75d1c9e486490e2c8507f6d248215592a847c"}],"api-ref/source/v2/samples/interconnection/interconnection-show-response.json":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"d2fe8adc74a9e279616e90b5a8e7e54767094a62","unresolved":false,"context_lines":[{"line_number":10,"context_line":"        \"remote_keystone\": \"http://10.0.0.100/identity\","},{"line_number":11,"context_line":"        \"remote_region\": \"RegionOne\","},{"line_number":12,"context_line":"        \"remote_interconnection_id\": \"5f063750-ad6d-4bbe-8b82-aeb49d48ce2d\","},{"line_number":13,"context_line":"        \"local_parameters\": {\"bar\": \"43\"},"},{"line_number":14,"context_line":"        \"remote_parameters\": {\"foo\": \"42\"}"},{"line_number":15,"context_line":"    }"},{"line_number":16,"context_line":"}"}],"source_content_type":"application/json","patch_set":10,"id":"9fdfeff1_a075e865","line":14,"range":{"start_line":13,"start_character":8,"end_line":14,"end_character":42},"updated":"2019-02-14 13:15:58.000000000","message":"These sample local/remote params aren\u0027t overly useful. I\u0027d prefer more realistic key/values, but perhaps it\u0027s just me.","commit_id":"02a424823d7dac1a80d4f31864df6ca7033ef601"},{"author":{"_account_id":19990,"name":"Yannick Thomas","email":"ythomas1.ext@orange.com","username":"ythomas1"},"change_message_id":"68522804805a09f46d40640495e6f578614f7b25","unresolved":false,"context_lines":[{"line_number":10,"context_line":"        \"remote_keystone\": \"http://10.0.0.100/identity\","},{"line_number":11,"context_line":"        \"remote_region\": \"RegionOne\","},{"line_number":12,"context_line":"        \"remote_interconnection_id\": \"5f063750-ad6d-4bbe-8b82-aeb49d48ce2d\","},{"line_number":13,"context_line":"        \"local_parameters\": {\"bar\": \"43\"},"},{"line_number":14,"context_line":"        \"remote_parameters\": {\"foo\": \"42\"}"},{"line_number":15,"context_line":"    }"},{"line_number":16,"context_line":"}"}],"source_content_type":"application/json","patch_set":10,"id":"9fdfeff1_862ebc89","line":14,"range":{"start_line":13,"start_character":8,"end_line":14,"end_character":42},"in_reply_to":"9fdfeff1_a075e865","updated":"2019-02-14 15:48:18.000000000","message":"Done","commit_id":"02a424823d7dac1a80d4f31864df6ca7033ef601"}],"api-ref/source/v2/samples/interconnection/interconnections-list-response.json":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"fdc68f74e7ffbb7405fe98a9e7da94284e1a718f","unresolved":false,"context_lines":[{"line_number":10,"context_line":"            \"remote_resource_id\": \"a02d408d-7493-4291-b7bc-56894d063693\","},{"line_number":11,"context_line":"            \"remote_keystone\": \"http://10.0.0.100/identity\","},{"line_number":12,"context_line":"            \"remote_region\": \"RegionOne\","},{"line_number":13,"context_line":"\t        \"remote_interconnection_id\": \"5f063750-ad6d-4bbe-8b82-aeb49d48ce2d\","},{"line_number":14,"context_line":"            \"local_parameters\": {\"bar\": \"43\"},"},{"line_number":15,"context_line":"            \"remote_parameters\": {\"foo\": \"42\"}"},{"line_number":16,"context_line":"        }"}],"source_content_type":"application/json","patch_set":7,"id":"9fdfeff1_2954d3c9","line":13,"updated":"2019-02-11 13:22:25.000000000","message":"I don\u0027t think this needs a extra tab does it?","commit_id":"871772f6f7ffdee663be19371de2f50fe168eeec"},{"author":{"_account_id":19990,"name":"Yannick Thomas","email":"ythomas1.ext@orange.com","username":"ythomas1"},"change_message_id":"dc711ee7ebfa3b8022711495f15daa1d83fa9278","unresolved":false,"context_lines":[{"line_number":10,"context_line":"            \"remote_resource_id\": \"a02d408d-7493-4291-b7bc-56894d063693\","},{"line_number":11,"context_line":"            \"remote_keystone\": \"http://10.0.0.100/identity\","},{"line_number":12,"context_line":"            \"remote_region\": \"RegionOne\","},{"line_number":13,"context_line":"\t        \"remote_interconnection_id\": \"5f063750-ad6d-4bbe-8b82-aeb49d48ce2d\","},{"line_number":14,"context_line":"            \"local_parameters\": {\"bar\": \"43\"},"},{"line_number":15,"context_line":"            \"remote_parameters\": {\"foo\": \"42\"}"},{"line_number":16,"context_line":"        }"}],"source_content_type":"application/json","patch_set":7,"id":"9fdfeff1_44846bd3","line":13,"in_reply_to":"9fdfeff1_2954d3c9","updated":"2019-02-13 15:15:18.000000000","message":"Done","commit_id":"871772f6f7ffdee663be19371de2f50fe168eeec"}],"neutron_lib/api/definitions/interconnection.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"135c2bfd0d744312423694cb68156a899090aba2","unresolved":false,"context_lines":[{"line_number":36,"context_line":"DESCRIPTION \u003d \"Provides support for Neutron-Neutron Interconnections\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"# A timestamp of when the extension was introduced."},{"line_number":39,"context_line":"UPDATED_TIMESTAMP \u003d \"2018-07-05T15:30:00-00:00\""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"API_PREFIX \u003d \u0027/inter\u0027"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"dfd5e7cf_af1d5574","line":39,"range":{"start_line":39,"start_character":21,"end_line":39,"end_character":31},"updated":"2019-01-09 11:29:28.000000000","message":"nit: maybe it should be updated? :)","commit_id":"c5e6c5fe97470bf13f863e6550eeab387f8b4143"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"135c2bfd0d744312423694cb68156a899090aba2","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"TEARDOWN \u003d \u0027TEARDOWN\u0027"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"VALID_STATES \u003d [TO_VALIDATE,"},{"line_number":68,"context_line":"                PRE_VALIDATE, VALIDATING, VALIDATED,"},{"line_number":69,"context_line":"                PRE_ACTIVATE, ACTIVATING, ACTIVE,"},{"line_number":70,"context_line":"                PRE_ACTIVE_CHECK, ACTIVE_CHECKING,"},{"line_number":71,"context_line":"                TEARDOWN]"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"# Common definitions for maximum string field length"},{"line_number":74,"context_line":"KEYSTONE_URL_LEN \u003d 2000"}],"source_content_type":"text/x-python","patch_set":3,"id":"dfd5e7cf_0f0ee13a","line":71,"range":{"start_line":67,"start_character":0,"end_line":71,"end_character":25},"updated":"2019-01-09 11:29:28.000000000","message":"those states are different than described in specs: https://specs.openstack.org/openstack/neutron-specs/specs/rocky/neutron-inter.html","commit_id":"c5e6c5fe97470bf13f863e6550eeab387f8b4143"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"135c2bfd0d744312423694cb68156a899090aba2","unresolved":false,"context_lines":[{"line_number":81,"context_line":"               \u0027validate\u0027: {\u0027type:uuid\u0027: None},"},{"line_number":82,"context_line":"               \u0027is_visible\u0027: True,"},{"line_number":83,"context_line":"               \u0027primary_key\u0027: True,"},{"line_number":84,"context_line":"               \u0027enforce_policy\u0027: True},"},{"line_number":85,"context_line":"        \u0027project_id\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":86,"context_line":"                       \u0027validate\u0027: {"},{"line_number":87,"context_line":"                            \u0027type:string\u0027: db_const.PROJECT_ID_FIELD_SIZE},"}],"source_content_type":"text/x-python","patch_set":3,"id":"dfd5e7cf_924d1a74","line":84,"range":{"start_line":84,"start_character":15,"end_line":84,"end_character":37},"updated":"2019-01-09 11:29:28.000000000","message":"do You need to have \"enforce_policy\" for all those attributes? According to https://docs.openstack.org/neutron-lib/queens/contributor/api_attributes.html it should be set for attributes which are \"actively part of the policy enforcing mechanism\". Is it like that for each of Your attributes?","commit_id":"c5e6c5fe97470bf13f863e6550eeab387f8b4143"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"135c2bfd0d744312423694cb68156a899090aba2","unresolved":false,"context_lines":[{"line_number":94,"context_line":"                 \u0027is_visible\u0027: True,"},{"line_number":95,"context_line":"                 \u0027enforce_policy\u0027: True},"},{"line_number":96,"context_line":"        \u0027type\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":97,"context_line":"                 \u0027default\u0027: ROUTER,"},{"line_number":98,"context_line":"                 \u0027validate\u0027: {\u0027type:values\u0027: VALID_TYPES},"},{"line_number":99,"context_line":"                 \u0027is_visible\u0027: True,"},{"line_number":100,"context_line":"                 \u0027enforce_policy\u0027: True},"}],"source_content_type":"text/x-python","patch_set":3,"id":"dfd5e7cf_8f63b11a","line":97,"range":{"start_line":97,"start_character":28,"end_line":97,"end_character":34},"updated":"2019-01-09 11:29:28.000000000","message":"in documentation You said that default is \"network_l3\"","commit_id":"c5e6c5fe97470bf13f863e6550eeab387f8b4143"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"34d28e4a59d5bfda3ae4d8cbdbf6b1574e00808b","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                 \u0027default\u0027: NETWORK_L3,"},{"line_number":74,"context_line":"                 \u0027validate\u0027: {\u0027type:values\u0027: VALID_TYPES},"},{"line_number":75,"context_line":"                 \u0027is_visible\u0027: True},"},{"line_number":76,"context_line":"        \u0027state\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":77,"context_line":"                  \u0027is_visible\u0027: True},"},{"line_number":78,"context_line":"        \u0027local_resource_id\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":79,"context_line":"                              \u0027validate\u0027: {\u0027type:uuid\u0027: None},"}],"source_content_type":"text/x-python","patch_set":4,"id":"bfdaf3ff_39d1a8fc","line":76,"range":{"start_line":76,"start_character":9,"end_line":76,"end_character":14},"updated":"2019-01-15 13:18:43.000000000","message":"Are there a list of values that state can take on, or some way we can validate this value?","commit_id":"cbd75d1c9e486490e2c8507f6d248215592a847c"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"fdc68f74e7ffbb7405fe98a9e7da94284e1a718f","unresolved":false,"context_lines":[{"line_number":44,"context_line":"RESOURCE_NAME \u003d \u0027interconnection\u0027"},{"line_number":45,"context_line":"COLLECTION_NAME \u003d \u0027interconnections\u0027"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"ROUTER \u003d \u0027router\u0027"},{"line_number":48,"context_line":"NETWORK_L2 \u003d \u0027network_l2\u0027"},{"line_number":49,"context_line":"NETWORK_L3 \u003d \u0027network_l3\u0027"},{"line_number":50,"context_line":"VALID_TYPES \u003d [ROUTER, NETWORK_L2, NETWORK_L3]"}],"source_content_type":"text/x-python","patch_set":7,"id":"9fdfeff1_8964dfe6","line":47,"updated":"2019-02-11 13:22:25.000000000","message":"We already have neutron_lib.api.definitions.l3.ROUTER. Is there any reason we need to redefine it herein?","commit_id":"871772f6f7ffdee663be19371de2f50fe168eeec"},{"author":{"_account_id":19990,"name":"Yannick Thomas","email":"ythomas1.ext@orange.com","username":"ythomas1"},"change_message_id":"dc711ee7ebfa3b8022711495f15daa1d83fa9278","unresolved":false,"context_lines":[{"line_number":44,"context_line":"RESOURCE_NAME \u003d \u0027interconnection\u0027"},{"line_number":45,"context_line":"COLLECTION_NAME \u003d \u0027interconnections\u0027"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"ROUTER \u003d \u0027router\u0027"},{"line_number":48,"context_line":"NETWORK_L2 \u003d \u0027network_l2\u0027"},{"line_number":49,"context_line":"NETWORK_L3 \u003d \u0027network_l3\u0027"},{"line_number":50,"context_line":"VALID_TYPES \u003d [ROUTER, NETWORK_L2, NETWORK_L3]"}],"source_content_type":"text/x-python","patch_set":7,"id":"9fdfeff1_e46c7f37","line":47,"in_reply_to":"9fdfeff1_8964dfe6","updated":"2019-02-13 15:15:18.000000000","message":"Done","commit_id":"871772f6f7ffdee663be19371de2f50fe168eeec"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"fdc68f74e7ffbb7405fe98a9e7da94284e1a718f","unresolved":false,"context_lines":[{"line_number":50,"context_line":"VALID_TYPES \u003d [ROUTER, NETWORK_L2, NETWORK_L3]"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"# Common definitions for maximum string field length"},{"line_number":53,"context_line":"KEYSTONE_URL_LEN \u003d 2000"},{"line_number":54,"context_line":"REGION_LEN \u003d 255"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"# The resource attribute map for the extension."},{"line_number":57,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {"}],"source_content_type":"text/x-python","patch_set":7,"id":"9fdfeff1_0950ef09","line":54,"range":{"start_line":53,"start_character":0,"end_line":54,"end_character":16},"updated":"2019-02-11 13:22:25.000000000","message":"Are these constrained by the DB field sizes?\nIf so these might be better to live in neutron_lib.db.constants.","commit_id":"871772f6f7ffdee663be19371de2f50fe168eeec"},{"author":{"_account_id":19990,"name":"Yannick Thomas","email":"ythomas1.ext@orange.com","username":"ythomas1"},"change_message_id":"dc711ee7ebfa3b8022711495f15daa1d83fa9278","unresolved":false,"context_lines":[{"line_number":50,"context_line":"VALID_TYPES \u003d [ROUTER, NETWORK_L2, NETWORK_L3]"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"# Common definitions for maximum string field length"},{"line_number":53,"context_line":"KEYSTONE_URL_LEN \u003d 2000"},{"line_number":54,"context_line":"REGION_LEN \u003d 255"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"# The resource attribute map for the extension."},{"line_number":57,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {"}],"source_content_type":"text/x-python","patch_set":7,"id":"9fdfeff1_046ae318","line":54,"range":{"start_line":53,"start_character":0,"end_line":54,"end_character":16},"in_reply_to":"9fdfeff1_0950ef09","updated":"2019-02-13 15:15:18.000000000","message":"Done","commit_id":"871772f6f7ffdee663be19371de2f50fe168eeec"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"1a3645ff46975df1dcafa16e6d5ca06cda7fce3b","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                 \u0027validate\u0027: {\u0027type:string\u0027: db_const.NAME_FIELD_SIZE},"},{"line_number":71,"context_line":"                 \u0027is_visible\u0027: True},"},{"line_number":72,"context_line":"        \u0027type\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":73,"context_line":"                 \u0027default\u0027: NETWORK_L3,"},{"line_number":74,"context_line":"                 \u0027validate\u0027: {\u0027type:values\u0027: VALID_TYPES},"},{"line_number":75,"context_line":"                 \u0027is_visible\u0027: True},"},{"line_number":76,"context_line":"        \u0027state\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9fdfeff1_4c37fc4e","line":73,"range":{"start_line":73,"start_character":28,"end_line":73,"end_character":38},"updated":"2019-02-08 20:22:46.000000000","message":"I don\u0027t think we should have a default, because omitting type will only work if local/remote resource IDs are network IDs. There is not works-all-the-time value sane to use as a default.","commit_id":"871772f6f7ffdee663be19371de2f50fe168eeec"},{"author":{"_account_id":19990,"name":"Yannick Thomas","email":"ythomas1.ext@orange.com","username":"ythomas1"},"change_message_id":"dc711ee7ebfa3b8022711495f15daa1d83fa9278","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                 \u0027validate\u0027: {\u0027type:string\u0027: db_const.NAME_FIELD_SIZE},"},{"line_number":71,"context_line":"                 \u0027is_visible\u0027: True},"},{"line_number":72,"context_line":"        \u0027type\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":73,"context_line":"                 \u0027default\u0027: NETWORK_L3,"},{"line_number":74,"context_line":"                 \u0027validate\u0027: {\u0027type:values\u0027: VALID_TYPES},"},{"line_number":75,"context_line":"                 \u0027is_visible\u0027: True},"},{"line_number":76,"context_line":"        \u0027state\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9fdfeff1_c46ffb25","line":73,"range":{"start_line":73,"start_character":28,"end_line":73,"end_character":38},"in_reply_to":"9fdfeff1_4c37fc4e","updated":"2019-02-13 15:15:18.000000000","message":"Done","commit_id":"871772f6f7ffdee663be19371de2f50fe168eeec"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"d2fe8adc74a9e279616e90b5a8e7e54767094a62","unresolved":false,"context_lines":[{"line_number":111,"context_line":"}"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"# The list of required extensions."},{"line_number":114,"context_line":"REQUIRED_EXTENSIONS \u003d ["},{"line_number":115,"context_line":"]"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"# The list of optional extensions."}],"source_content_type":"text/x-python","patch_set":10,"id":"9fdfeff1_e0c9b0ab","line":114,"range":{"start_line":114,"start_character":0,"end_line":114,"end_character":19},"updated":"2019-02-14 13:15:58.000000000","message":"Shouldn\u0027t l3 be a required or at least optional extension?","commit_id":"02a424823d7dac1a80d4f31864df6ca7033ef601"},{"author":{"_account_id":19990,"name":"Yannick Thomas","email":"ythomas1.ext@orange.com","username":"ythomas1"},"change_message_id":"68522804805a09f46d40640495e6f578614f7b25","unresolved":false,"context_lines":[{"line_number":111,"context_line":"}"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"# The list of required extensions."},{"line_number":114,"context_line":"REQUIRED_EXTENSIONS \u003d ["},{"line_number":115,"context_line":"]"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"# The list of optional extensions."}],"source_content_type":"text/x-python","patch_set":10,"id":"9fdfeff1_8b66c5ba","line":114,"range":{"start_line":114,"start_character":0,"end_line":114,"end_character":19},"in_reply_to":"9fdfeff1_e0c9b0ab","updated":"2019-02-14 15:48:18.000000000","message":"Done","commit_id":"02a424823d7dac1a80d4f31864df6ca7033ef601"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c7456ff46fece9dca159162c525e27b2615de2ab","unresolved":false,"context_lines":[{"line_number":39,"context_line":"# A timestamp of when the extension was introduced."},{"line_number":40,"context_line":"UPDATED_TIMESTAMP \u003d \"2019-01-14T16:30:00-00:00\""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"API_PREFIX \u003d \u0027/inter\u0027"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"# The specific resources and/or attributes for the extension (optional)."},{"line_number":45,"context_line":"RESOURCE_NAME \u003d \u0027interconnection\u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_56da704b","line":42,"range":{"start_line":42,"start_character":13,"end_line":42,"end_character":21},"updated":"2019-02-19 14:00:37.000000000","message":"Can\u0027t we use more meaningful name?There are several possible  inter-xxxx so it can be ambiguous.","commit_id":"dde69023466091a30c7da42cc470cec921be84f6"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"8f647728af721471ef818b40d330fe98ce67a977","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                             \u0027is_visible\u0027: True},"},{"line_number":90,"context_line":"        \u0027remote_parameters\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":91,"context_line":"                              \u0027is_visible\u0027: True}"},{"line_number":92,"context_line":"    },"},{"line_number":93,"context_line":"}"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"# The subresource attribute map for the extension. It adds child resources"}],"source_content_type":"text/x-python","patch_set":11,"id":"9fdfeff1_01710c0d","line":92,"updated":"2019-02-19 08:35:42.000000000","message":"Shouldn\u0027t You add \"is_filter\" and \"is_sort_key\" flags to some of those parameters, like e.g. \"name\", \"type\" or \"state\"?\nI think it would be useful to allow filtering or ordering by some of those attributes.","commit_id":"dde69023466091a30c7da42cc470cec921be84f6"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e1c6af0a471b299ea1b19c8fbe63fed619d42685","unresolved":false,"context_lines":[{"line_number":39,"context_line":"# A timestamp of when the extension was introduced."},{"line_number":40,"context_line":"UPDATED_TIMESTAMP \u003d \"2019-01-14T16:30:00-00:00\""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"API_PREFIX \u003d \u0027/inter\u0027"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"# The specific resources and/or attributes for the extension (optional)."},{"line_number":45,"context_line":"RESOURCE_NAME \u003d \u0027interconnection\u0027"}],"source_content_type":"text/x-python","patch_set":12,"id":"9fdfeff1_63cb334a","line":42,"updated":"2019-02-19 16:04:46.000000000","message":"Could you check my comment on this in patch set 11?","commit_id":"3b4724881122e8db3d1bcc30955a69d6037f2e1d"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"18648ec4f2877d02e00d9dafa73e39d225efe103","unresolved":false,"context_lines":[{"line_number":39,"context_line":"# A timestamp of when the extension was introduced."},{"line_number":40,"context_line":"UPDATED_TIMESTAMP \u003d \"2019-01-14T16:30:00-00:00\""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"API_PREFIX \u003d \u0027/inter\u0027"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"# The specific resources and/or attributes for the extension (optional)."},{"line_number":45,"context_line":"RESOURCE_NAME \u003d \u0027interconnection\u0027"}],"source_content_type":"text/x-python","patch_set":12,"id":"9fdfeff1_830de536","line":42,"in_reply_to":"9fdfeff1_63cb334a","updated":"2019-02-20 09:10:00.000000000","message":"This was agreed in specs: https://specs.openstack.org/openstack/neutron-specs/specs/rocky/neutron-inter.html\nBut IMO we still can change it now :)","commit_id":"3b4724881122e8db3d1bcc30955a69d6037f2e1d"},{"author":{"_account_id":12021,"name":"Thomas Morin","email":"tmmorin.orange@gmail.com","username":"tmorin"},"change_message_id":"846b1cb4ef7ac5b518ac76a2fa3438df5fc55df4","unresolved":false,"context_lines":[{"line_number":39,"context_line":"# A timestamp of when the extension was introduced."},{"line_number":40,"context_line":"UPDATED_TIMESTAMP \u003d \"2019-01-14T16:30:00-00:00\""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"API_PREFIX \u003d \u0027/inter\u0027"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"# The specific resources and/or attributes for the extension (optional)."},{"line_number":45,"context_line":"RESOURCE_NAME \u003d \u0027interconnection\u0027"}],"source_content_type":"text/x-python","patch_set":12,"id":"9fdfeff1_3c775d3e","line":42,"in_reply_to":"9fdfeff1_830de536","updated":"2019-02-21 11:09:45.000000000","message":"I think that it would be reasonable and possibly less prone to confusion to use \"/interconnection\" to echo the project name \"neutron-interconnection\".","commit_id":"3b4724881122e8db3d1bcc30955a69d6037f2e1d"}]}