)]}'
{"neutron_lib/plugins/ml2/api.py":[{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"ba3272d2d1ee2c7e8f6d029409c08eb53f186f80","unresolved":false,"context_lines":[{"line_number":478,"context_line":"        \"\"\""},{"line_number":479,"context_line":""},{"line_number":480,"context_line":"    @abc.abstractmethod"},{"line_number":481,"context_line":"    def validate_provider_segment(self, segment):"},{"line_number":482,"context_line":"        \"\"\"Validate attributes of a provider network segment."},{"line_number":483,"context_line":""},{"line_number":484,"context_line":"        :param segment: segment dictionary using keys defined above"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_d8e30106","side":"PARENT","line":481,"updated":"2019-02-18 17:04:27.000000000","message":"I\u0027m also wondering about style here. Nearly every function we have that takes a context, it\u0027s the first argument. Do we want another abstract base class  that  follows that convention (with all methods), rather than a keyword extension here?  (I don\u0027t know the answer to that, I\u0027m  just thinking out loud.)","commit_id":"3133add2c9197a8fb7c7b43ece89591973ecd58a"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"cb630a7b4047e653e1c608b0f4d6b85d3424734a","unresolved":false,"context_lines":[{"line_number":478,"context_line":"        \"\"\""},{"line_number":479,"context_line":""},{"line_number":480,"context_line":"    @abc.abstractmethod"},{"line_number":481,"context_line":"    def validate_provider_segment(self, segment, context\u003dNone):"},{"line_number":482,"context_line":"        \"\"\"Validate attributes of a provider network segment."},{"line_number":483,"context_line":""},{"line_number":484,"context_line":"        :param segment: segment dictionary using keys defined above"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_b6395ca4","line":481,"range":{"start_line":481,"start_character":49,"end_line":481,"end_character":61},"updated":"2019-02-19 13:52:12.000000000","message":"+1\n\nCan this context initialize in the inherited function inline by calling the neutron_lib context?","commit_id":"68d4814c1f6b73521f2c4780a6c4fc4adaa1b751"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"1c0f942c48260738638ed99198e5562475385c9c","unresolved":false,"context_lines":[{"line_number":478,"context_line":"        \"\"\""},{"line_number":479,"context_line":""},{"line_number":480,"context_line":"    @abc.abstractmethod"},{"line_number":481,"context_line":"    def validate_provider_segment(self, segment, context\u003dNone):"},{"line_number":482,"context_line":"        \"\"\"Validate attributes of a provider network segment."},{"line_number":483,"context_line":""},{"line_number":484,"context_line":"        :param segment: segment dictionary using keys defined above"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fdfeff1_88055448","line":481,"range":{"start_line":481,"start_character":49,"end_line":481,"end_character":56},"updated":"2019-02-15 13:25:03.000000000","message":"I don\u0027t know much about this work, but it seems a little odd that only this method needs a context while the others don\u0027t... Why wouldn\u0027t other methods like is_partial_segment need a context, but this method does???","commit_id":"68d4814c1f6b73521f2c4780a6c4fc4adaa1b751"}]}