)]}'
{"neutron_lib/rpc.py":[{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"b37802700c8fbb564d2ad43cfba961ad96063932","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    def cast(self, ctxt, method, **kwargs):"},{"line_number":105,"context_line":"        try:"},{"line_number":106,"context_line":"            self._original_context.cast(ctxt, method, **kwargs)"},{"line_number":107,"context_line":"        except Exception as e:"},{"line_number":108,"context_line":"            # TODO(kevinbenton): make catch specific to missing exchange once"},{"line_number":109,"context_line":"            # bug/1705351 is resolved on the oslo.messaging side; if"},{"line_number":110,"context_line":"            # oslo.messaging auto-creates the exchange, then just remove the"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_98bc9907","side":"PARENT","line":107,"updated":"2019-02-18 17:01:55.000000000","message":"We are importing an _module  from oslo, isn\u0027t that private?  Are there non-AMPQ messaging queuees that would have issues now?","commit_id":"3133add2c9197a8fb7c7b43ece89591973ecd58a"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"354f124c9a4e04c8f8c464c35422004881520d12","unresolved":false,"context_lines":[{"line_number":104,"context_line":"    def cast(self, ctxt, method, **kwargs):"},{"line_number":105,"context_line":"        try:"},{"line_number":106,"context_line":"            self._original_context.cast(ctxt, method, **kwargs)"},{"line_number":107,"context_line":"        except Exception as e:"},{"line_number":108,"context_line":"            # TODO(kevinbenton): make catch specific to missing exchange once"},{"line_number":109,"context_line":"            # bug/1705351 is resolved on the oslo.messaging side; if"},{"line_number":110,"context_line":"            # oslo.messaging auto-creates the exchange, then just remove the"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_1bc97159","side":"PARENT","line":107,"in_reply_to":"9fdfeff1_98bc9907","updated":"2019-02-19 13:20:49.000000000","message":"Agree; doesn\u0027t seem like we should be importing and using private modules.","commit_id":"3133add2c9197a8fb7c7b43ece89591973ecd58a"},{"author":{"_account_id":8770,"name":"Ken Giusti","email":"kgiusti@gmail.com","username":"kgiusti"},"change_message_id":"f190203a27f2abab2af0802465c65e9a0267f8ed","unresolved":false,"context_lines":[{"line_number":105,"context_line":"    def cast(self, ctxt, method, **kwargs):"},{"line_number":106,"context_line":"        try:"},{"line_number":107,"context_line":"            self._original_context.cast(ctxt, method, **kwargs)"},{"line_number":108,"context_line":"        except rpc_amqp.AMQPDestinationNotFound as e:"},{"line_number":109,"context_line":"            LOG.debug(\"Ignored exception during cast: %s\", str(e))"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_987d79b4","line":108,"updated":"2019-02-18 17:30:22.000000000","message":"I wouldn\u0027t expect AMQPDestinationNotFound to occur - I would\u0027ve expected a MessageDeliveryFailure exception instead (which is public):\n\nfrom oslo_messaging.exceptions import MessageDeliveryFailure","commit_id":"e952b07bd8c4505000f8961082ae3bd2017b50dc"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"48a2c3857c47d9c940a6cb6d1499f79aa8bd390a","unresolved":false,"context_lines":[{"line_number":105,"context_line":"    def cast(self, ctxt, method, **kwargs):"},{"line_number":106,"context_line":"        try:"},{"line_number":107,"context_line":"            self._original_context.cast(ctxt, method, **kwargs)"},{"line_number":108,"context_line":"        except rpc_amqp.AMQPDestinationNotFound as e:"},{"line_number":109,"context_line":"            LOG.debug(\"Ignored exception during cast: %s\", str(e))"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_54e1fe29","line":108,"in_reply_to":"9fdfeff1_987d79b4","updated":"2019-02-19 21:11:25.000000000","message":"From the try...except...except stanza [1] in oslo.messaging that looks like it would be key, it looks like AMQPDestinationNotFound is the only error that does not turn in to a MessageDeliveryFailure.  Is there another place where this would get changed into an exception that is public?\n\n[1] https://git.openstack.org/cgit/openstack/oslo.messaging/tree/oslo_messaging/_drivers/impl_rabbit.py#n728 lines 728 to 755","commit_id":"e952b07bd8c4505000f8961082ae3bd2017b50dc"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"55a08c25845e029d999ee786f37a6194c5202d47","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from oslo_config import cfg"},{"line_number":26,"context_line":"from oslo_log import log as logging"},{"line_number":27,"context_line":"import oslo_messaging"},{"line_number":28,"context_line":"from oslo_messaging._drivers import amqp as rpc_amqp"},{"line_number":29,"context_line":"from oslo_messaging.rpc import dispatcher"},{"line_number":30,"context_line":"from oslo_messaging import exceptions as oslomsg_exc"},{"line_number":31,"context_line":"from oslo_messaging import serializer as om_serializer"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_95f7498d","line":28,"range":{"start_line":28,"start_character":44,"end_line":28,"end_character":52},"updated":"2019-02-20 22:50:55.000000000","message":"Looks like you don\u0027t need this import now?","commit_id":"0e32316c9d0fef68879196d1cfc39caf04b0e6d1"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"ed3dc50f6e677a278822d1da3e4a3f308835e874","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from oslo_config import cfg"},{"line_number":26,"context_line":"from oslo_log import log as logging"},{"line_number":27,"context_line":"import oslo_messaging"},{"line_number":28,"context_line":"from oslo_messaging._drivers import amqp as rpc_amqp"},{"line_number":29,"context_line":"from oslo_messaging.rpc import dispatcher"},{"line_number":30,"context_line":"from oslo_messaging import exceptions as oslomsg_exc"},{"line_number":31,"context_line":"from oslo_messaging import serializer as om_serializer"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfeff1_c9645024","line":28,"range":{"start_line":28,"start_character":44,"end_line":28,"end_character":52},"in_reply_to":"9fdfeff1_95f7498d","updated":"2019-02-21 14:25:28.000000000","message":"thanks, done","commit_id":"0e32316c9d0fef68879196d1cfc39caf04b0e6d1"}]}
