)]}'
{"api-ref/source/v2/parameters.yaml":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"c9b539bd1c35a66b164d1d6c4bc388b0d665f12f","unresolved":false,"context_lines":[{"line_number":1279,"context_line":"    Filter the subnet list result based on if ``dns_publish_fixed_ip`` is"},{"line_number":1280,"context_line":"    enabled or disabled for the subnet."},{"line_number":1281,"context_line":"  in: query"},{"line_number":1282,"context_line":"  required: false"},{"line_number":1283,"context_line":"  type: boolean"},{"line_number":1284,"context_line":"subnet-enable_dhcp-query:"},{"line_number":1285,"context_line":"  description: |"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9fb8cfa7_d8ed7ef0","line":1282,"range":{"start_line":1282,"start_character":12,"end_line":1282,"end_character":17},"updated":"2019-06-12 12:30:18.000000000","message":"I think we decided this should be \u0027true\u0027 since its used as the request param and is always returned by the extension?","commit_id":"b929908ba7dac942649dd5c5f8ffb9af0c22ec02"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"3d4796baf04d76cff8094d185f4e2ed3b679a837","unresolved":false,"context_lines":[{"line_number":1279,"context_line":"    Filter the subnet list result based on if ``dns_publish_fixed_ip`` is"},{"line_number":1280,"context_line":"    enabled or disabled for the subnet."},{"line_number":1281,"context_line":"  in: query"},{"line_number":1282,"context_line":"  required: false"},{"line_number":1283,"context_line":"  type: boolean"},{"line_number":1284,"context_line":"subnet-enable_dhcp-query:"},{"line_number":1285,"context_line":"  description: |"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9fb8cfa7_48ec5629","line":1282,"range":{"start_line":1282,"start_character":12,"end_line":1282,"end_character":17},"in_reply_to":"9fb8cfa7_d8ed7ef0","updated":"2019-06-12 20:00:24.000000000","message":"No, this is the query param, where it it optional. I added that in this PS because I think that filtering the subnet_list response by the new parameter should also be possibly, similar to filtering by the enable_dhcp parameter below.","commit_id":"b929908ba7dac942649dd5c5f8ffb9af0c22ec02"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"3d4796baf04d76cff8094d185f4e2ed3b679a837","unresolved":false,"context_lines":[{"line_number":5995,"context_line":"  description: |"},{"line_number":5996,"context_line":"    Whether to publish DNS records for IPs from this subnet"},{"line_number":5997,"context_line":"  in: body"},{"line_number":5998,"context_line":"  required: false"},{"line_number":5999,"context_line":"  type: boolean"},{"line_number":6000,"context_line":"subnet-dns_publish_fixed_ip-request:"},{"line_number":6001,"context_line":"  description: |"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9fb8cfa7_68d83a7a","line":5998,"updated":"2019-06-12 20:00:24.000000000","message":"But this param, which is the response part, should have a \"true\" indeed, sorry that I messed that up once more.","commit_id":"b929908ba7dac942649dd5c5f8ffb9af0c22ec02"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d641fc445c4de396d080d658bf43839c64b36f12","unresolved":false,"context_lines":[{"line_number":5993,"context_line":"  type: array"},{"line_number":5994,"context_line":"subnet-dns_publish_fixed_ip:"},{"line_number":5995,"context_line":"  description: |"},{"line_number":5996,"context_line":"    Whether to publish DNS records for IPs from this subnet"},{"line_number":5997,"context_line":"  in: body"},{"line_number":5998,"context_line":"  required: true"},{"line_number":5999,"context_line":"  type: boolean"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9fb8cfa7_e6644e4c","line":5996,"updated":"2019-06-13 14:50:19.000000000","message":"nitty nit: missing dot at the end","commit_id":"08505a497185858f01fce83e1b09ac8ba2c84d4d"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d641fc445c4de396d080d658bf43839c64b36f12","unresolved":false,"context_lines":[{"line_number":6000,"context_line":"subnet-dns_publish_fixed_ip-request:"},{"line_number":6001,"context_line":"  description: |"},{"line_number":6002,"context_line":"    Whether to publish DNS records for IPs from this subnet. Default"},{"line_number":6003,"context_line":"    is false."},{"line_number":6004,"context_line":"  in: body"},{"line_number":6005,"context_line":"  required: false"},{"line_number":6006,"context_line":"  type: boolean"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9fb8cfa7_c6d26ad1","line":6003,"range":{"start_line":6003,"start_character":7,"end_line":6003,"end_character":12},"updated":"2019-06-13 14:50:19.000000000","message":"maybe You can put it in `` `` as e.g. in L6017 ?","commit_id":"08505a497185858f01fce83e1b09ac8ba2c84d4d"}],"api-ref/source/v2/samples/subnets/subnet-create-response.json":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8c3f97debc0f586f862e5bbd8e97969bb0764dd6","unresolved":false,"context_lines":[{"line_number":7,"context_line":"        \"project_id\": \"4fd44f30292945e481c7b8a0c8908869\","},{"line_number":8,"context_line":"        \"tenant_id\": \"4fd44f30292945e481c7b8a0c8908869\","},{"line_number":9,"context_line":"        \"dns_nameservers\": [],"},{"line_number":10,"context_line":"\t\t\t\t\"dns_publish_fixed_ip\": false,"},{"line_number":11,"context_line":"        \"allocation_pools\": ["},{"line_number":12,"context_line":"            {"},{"line_number":13,"context_line":"                \"start\": \"192.168.199.2\","}],"source_content_type":"application/json","patch_set":2,"id":"9fb8cfa7_4e0a878a","line":10,"updated":"2019-06-06 15:48:52.000000000","message":"indentation and tabs :(","commit_id":"5ad3bc6c5d055ff1db1304bec366871b464798d5"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"b458d1a7f8741f1b5e440bd660e1b29519313843","unresolved":false,"context_lines":[{"line_number":7,"context_line":"        \"project_id\": \"4fd44f30292945e481c7b8a0c8908869\","},{"line_number":8,"context_line":"        \"tenant_id\": \"4fd44f30292945e481c7b8a0c8908869\","},{"line_number":9,"context_line":"        \"dns_nameservers\": [],"},{"line_number":10,"context_line":"\t\t\t\t\"dns_publish_fixed_ip\": false,"},{"line_number":11,"context_line":"        \"allocation_pools\": ["},{"line_number":12,"context_line":"            {"},{"line_number":13,"context_line":"                \"start\": \"192.168.199.2\","}],"source_content_type":"application/json","patch_set":2,"id":"9fb8cfa7_37088990","line":10,"in_reply_to":"9fb8cfa7_4e0a878a","updated":"2019-06-11 06:19:01.000000000","message":"Oops, sorry for that, it wasn\u0027t intentional, seems my new version of vim does unexpected things. Fixed up now.","commit_id":"5ad3bc6c5d055ff1db1304bec366871b464798d5"}],"api-ref/source/v2/samples/subnets/subnet-show-response.json":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8c3f97debc0f586f862e5bbd8e97969bb0764dd6","unresolved":false,"context_lines":[{"line_number":8,"context_line":"        \"tenant_id\": \"4fd44f30292945e481c7b8a0c8908869\","},{"line_number":9,"context_line":"        \"created_at\": \"2016-03-08T20:19:41\","},{"line_number":10,"context_line":"        \"dns_nameservers\": [],"},{"line_number":11,"context_line":"\t\t\t\t\"dns_publish_fixed_ip\": false,"},{"line_number":12,"context_line":"        \"allocation_pools\": ["},{"line_number":13,"context_line":"            {"},{"line_number":14,"context_line":"                \"start\": \"192.0.0.2\","}],"source_content_type":"application/json","patch_set":2,"id":"9fb8cfa7_ee001b6a","line":11,"updated":"2019-06-06 15:48:52.000000000","message":"same","commit_id":"5ad3bc6c5d055ff1db1304bec366871b464798d5"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"b458d1a7f8741f1b5e440bd660e1b29519313843","unresolved":false,"context_lines":[{"line_number":8,"context_line":"        \"tenant_id\": \"4fd44f30292945e481c7b8a0c8908869\","},{"line_number":9,"context_line":"        \"created_at\": \"2016-03-08T20:19:41\","},{"line_number":10,"context_line":"        \"dns_nameservers\": [],"},{"line_number":11,"context_line":"\t\t\t\t\"dns_publish_fixed_ip\": false,"},{"line_number":12,"context_line":"        \"allocation_pools\": ["},{"line_number":13,"context_line":"            {"},{"line_number":14,"context_line":"                \"start\": \"192.0.0.2\","}],"source_content_type":"application/json","patch_set":2,"id":"9fb8cfa7_570dfd9e","line":11,"in_reply_to":"9fb8cfa7_ee001b6a","updated":"2019-06-11 06:19:01.000000000","message":"Done","commit_id":"5ad3bc6c5d055ff1db1304bec366871b464798d5"}],"api-ref/source/v2/samples/subnets/subnet-update-response.json":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8c3f97debc0f586f862e5bbd8e97969bb0764dd6","unresolved":false,"context_lines":[{"line_number":9,"context_line":"        \"tenant_id\": \"26a7980765d0414dbc1fc1f88cdb7e6e\","},{"line_number":10,"context_line":"        \"created_at\": \"2016-03-08T20:19:41\","},{"line_number":11,"context_line":"        \"dns_nameservers\": [],"},{"line_number":12,"context_line":"\t\t\t\t\"dns_publish_fixed_ip\": false,"},{"line_number":13,"context_line":"        \"service_types\": [],"},{"line_number":14,"context_line":"        \"allocation_pools\": ["},{"line_number":15,"context_line":"            {"}],"source_content_type":"application/json","patch_set":2,"id":"9fb8cfa7_cef51785","line":12,"updated":"2019-06-06 15:48:52.000000000","message":"same","commit_id":"5ad3bc6c5d055ff1db1304bec366871b464798d5"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"b458d1a7f8741f1b5e440bd660e1b29519313843","unresolved":false,"context_lines":[{"line_number":9,"context_line":"        \"tenant_id\": \"26a7980765d0414dbc1fc1f88cdb7e6e\","},{"line_number":10,"context_line":"        \"created_at\": \"2016-03-08T20:19:41\","},{"line_number":11,"context_line":"        \"dns_nameservers\": [],"},{"line_number":12,"context_line":"\t\t\t\t\"dns_publish_fixed_ip\": false,"},{"line_number":13,"context_line":"        \"service_types\": [],"},{"line_number":14,"context_line":"        \"allocation_pools\": ["},{"line_number":15,"context_line":"            {"}],"source_content_type":"application/json","patch_set":2,"id":"9fb8cfa7_f7fd116e","line":12,"in_reply_to":"9fb8cfa7_cef51785","updated":"2019-06-11 06:19:01.000000000","message":"Done","commit_id":"5ad3bc6c5d055ff1db1304bec366871b464798d5"}],"api-ref/source/v2/samples/subnets/subnets-create-bulk-response.json":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8c3f97debc0f586f862e5bbd8e97969bb0764dd6","unresolved":false,"context_lines":[{"line_number":9,"context_line":"            ],"},{"line_number":10,"context_line":"            \"cidr\": \"192.168.199.0/24\","},{"line_number":11,"context_line":"            \"dns_nameservers\": [],"},{"line_number":12,"context_line":"\t\t\t\t\t\t\"dns_publish_fixed_ip\": false,"},{"line_number":13,"context_line":"            \"enable_dhcp\": true,"},{"line_number":14,"context_line":"            \"gateway_ip\": \"192.168.199.1\","},{"line_number":15,"context_line":"            \"host_routes\": [],"}],"source_content_type":"application/json","patch_set":2,"id":"9fb8cfa7_ae3f8323","line":12,"updated":"2019-06-06 15:48:52.000000000","message":"same","commit_id":"5ad3bc6c5d055ff1db1304bec366871b464798d5"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"b458d1a7f8741f1b5e440bd660e1b29519313843","unresolved":false,"context_lines":[{"line_number":9,"context_line":"            ],"},{"line_number":10,"context_line":"            \"cidr\": \"192.168.199.0/24\","},{"line_number":11,"context_line":"            \"dns_nameservers\": [],"},{"line_number":12,"context_line":"\t\t\t\t\t\t\"dns_publish_fixed_ip\": false,"},{"line_number":13,"context_line":"            \"enable_dhcp\": true,"},{"line_number":14,"context_line":"            \"gateway_ip\": \"192.168.199.1\","},{"line_number":15,"context_line":"            \"host_routes\": [],"}],"source_content_type":"application/json","patch_set":2,"id":"9fb8cfa7_b7fb1977","line":12,"in_reply_to":"9fb8cfa7_ae3f8323","updated":"2019-06-11 06:19:01.000000000","message":"Done","commit_id":"5ad3bc6c5d055ff1db1304bec366871b464798d5"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8c3f97debc0f586f862e5bbd8e97969bb0764dd6","unresolved":false,"context_lines":[{"line_number":39,"context_line":"            ],"},{"line_number":40,"context_line":"            \"cidr\": \"10.56.4.0/22\","},{"line_number":41,"context_line":"            \"dns_nameservers\": [],"},{"line_number":42,"context_line":"\t\t\t\t\t\t\"dns_publish_fixed_ip\": false,"},{"line_number":43,"context_line":"            \"enable_dhcp\": true,"},{"line_number":44,"context_line":"            \"gateway_ip\": \"10.56.4.1\","},{"line_number":45,"context_line":"            \"host_routes\": [],"}],"source_content_type":"application/json","patch_set":2,"id":"9fb8cfa7_6e498bce","line":42,"updated":"2019-06-06 15:48:52.000000000","message":"same","commit_id":"5ad3bc6c5d055ff1db1304bec366871b464798d5"}],"api-ref/source/v2/samples/subnets/subnets-list-response.json":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8c3f97debc0f586f862e5bbd8e97969bb0764dd6","unresolved":false,"context_lines":[{"line_number":8,"context_line":"            \"project_id\": \"26a7980765d0414dbc1fc1f88cdb7e6e\","},{"line_number":9,"context_line":"            \"tenant_id\": \"26a7980765d0414dbc1fc1f88cdb7e6e\","},{"line_number":10,"context_line":"            \"dns_nameservers\": [],"},{"line_number":11,"context_line":"\t\t\t\t\t\t\"dns_publish_fixed_ip\": false,"},{"line_number":12,"context_line":"            \"allocation_pools\": ["},{"line_number":13,"context_line":"                {"},{"line_number":14,"context_line":"                    \"start\": \"10.0.0.2\","}],"source_content_type":"application/json","patch_set":2,"id":"9fb8cfa7_4e1847d2","line":11,"updated":"2019-06-06 15:48:52.000000000","message":"same","commit_id":"5ad3bc6c5d055ff1db1304bec366871b464798d5"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"b458d1a7f8741f1b5e440bd660e1b29519313843","unresolved":false,"context_lines":[{"line_number":8,"context_line":"            \"project_id\": \"26a7980765d0414dbc1fc1f88cdb7e6e\","},{"line_number":9,"context_line":"            \"tenant_id\": \"26a7980765d0414dbc1fc1f88cdb7e6e\","},{"line_number":10,"context_line":"            \"dns_nameservers\": [],"},{"line_number":11,"context_line":"\t\t\t\t\t\t\"dns_publish_fixed_ip\": false,"},{"line_number":12,"context_line":"            \"allocation_pools\": ["},{"line_number":13,"context_line":"                {"},{"line_number":14,"context_line":"                    \"start\": \"10.0.0.2\","}],"source_content_type":"application/json","patch_set":2,"id":"9fb8cfa7_d7f80d7c","line":11,"in_reply_to":"9fb8cfa7_4e1847d2","updated":"2019-06-11 06:19:01.000000000","message":"Done","commit_id":"5ad3bc6c5d055ff1db1304bec366871b464798d5"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8c3f97debc0f586f862e5bbd8e97969bb0764dd6","unresolved":false,"context_lines":[{"line_number":38,"context_line":"            \"project_id\": \"4fd44f30292945e481c7b8a0c8908869\","},{"line_number":39,"context_line":"            \"tenant_id\": \"4fd44f30292945e481c7b8a0c8908869\","},{"line_number":40,"context_line":"            \"dns_nameservers\": [],"},{"line_number":41,"context_line":"\t\t\t\t\t\t\"dns_publish_fixed_ip\": false,"},{"line_number":42,"context_line":"            \"allocation_pools\": ["},{"line_number":43,"context_line":"                {"},{"line_number":44,"context_line":"                    \"start\": \"192.0.0.2\","}],"source_content_type":"application/json","patch_set":2,"id":"9fb8cfa7_ee0edb8b","line":41,"updated":"2019-06-06 15:48:52.000000000","message":"same","commit_id":"5ad3bc6c5d055ff1db1304bec366871b464798d5"}],"api-ref/source/v2/subnets.inc":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"ff0c55c2d2e529766573dcf89037955488276705","unresolved":false,"context_lines":[{"line_number":135,"context_line":"   - not-tags-any: not-tags-any-query"},{"line_number":136,"context_line":"   - fields: fields"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"Response Parameters"},{"line_number":139,"context_line":"-------------------"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":".. rest_parameters:: parameters.yaml"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"9fb8cfa7_4d81e9fa","line":138,"updated":"2019-06-11 12:54:24.000000000","message":"Doesn\u0027t the dns_publish_fixed_ip come back in all these subnet responses now??","commit_id":"22978a3c7998c0cf0d947abb0053f47564bb2ad3"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e5742adda0fe09352c10bfe8fa718d6e00f98957","unresolved":false,"context_lines":[{"line_number":135,"context_line":"   - not-tags-any: not-tags-any-query"},{"line_number":136,"context_line":"   - fields: fields"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"Response Parameters"},{"line_number":139,"context_line":"-------------------"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":".. rest_parameters:: parameters.yaml"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"9fb8cfa7_e8444b49","line":138,"in_reply_to":"9fb8cfa7_4d81e9fa","updated":"2019-06-11 13:28:18.000000000","message":"Yes indeed, another good catch, thank you. Missed one request, too. From the existing data I assume that it is correct to list all possible parameters there although the json samples only contain a minimal set of parameters?","commit_id":"22978a3c7998c0cf0d947abb0053f47564bb2ad3"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"6b4c62f38ab2753faaba1b4efabf7e0140521479","unresolved":false,"context_lines":[{"line_number":135,"context_line":"   - not-tags-any: not-tags-any-query"},{"line_number":136,"context_line":"   - fields: fields"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"Response Parameters"},{"line_number":139,"context_line":"-------------------"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":".. rest_parameters:: parameters.yaml"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"9fb8cfa7_5f2c2a01","line":138,"in_reply_to":"9fb8cfa7_e8444b49","updated":"2019-06-11 14:59:40.000000000","message":"Generally we make sure all the parameters are included here for this extensions that have been noted in the \"heading\" section of the API (e.g. like how you added \"Subnet DNS publish fixed IP extension\" above). There\u0027s a few cases where the extension doesn\u0027t always return the parameter, so in that case we still try to list it here, but mark it as \"optional\".\n\n\nAnd yeah, the sample JSON doesn\u0027t always contain all these parameters, though it\u0027s nice (not required) to have the sample JSON updated where appropriate.","commit_id":"22978a3c7998c0cf0d947abb0053f47564bb2ad3"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"9959786848f50d333d32cb7b05f6ebecad89b506","unresolved":false,"context_lines":[{"line_number":163,"context_line":"   - subnetpool_id: subnet-subnetpool_id"},{"line_number":164,"context_line":"   - updated_at: updated_at_resource"},{"line_number":165,"context_line":"   - tags: tags"},{"line_number":166,"context_line":"   - dns_publish_fixed_ip: subnet-dns_publish_fixed_ip"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"Response Example"},{"line_number":169,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"9fb8cfa7_d598fbc0","line":166,"range":{"start_line":166,"start_character":27,"end_line":166,"end_character":54},"updated":"2019-06-11 16:21:02.000000000","message":"This shows up as \"optional\" on the response param... Does the extension really only sometimes return it?\nIf it\u0027s always returned by the extension then this should be marked at required in responses.... \n\nNote that when used as a request param, it can be optional if the extension doesn\u0027t require it to be passed on the request.","commit_id":"411399ead5f0258a7203bb9ac2c5dce1e20215f4"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"8cd934ab5cfacb4623cd48473efdab25082041b6","unresolved":false,"context_lines":[{"line_number":163,"context_line":"   - subnetpool_id: subnet-subnetpool_id"},{"line_number":164,"context_line":"   - updated_at: updated_at_resource"},{"line_number":165,"context_line":"   - tags: tags"},{"line_number":166,"context_line":"   - dns_publish_fixed_ip: subnet-dns_publish_fixed_ip"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"Response Example"},{"line_number":169,"context_line":"----------------"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"9fb8cfa7_c1d4bdeb","line":166,"range":{"start_line":166,"start_character":27,"end_line":166,"end_character":54},"in_reply_to":"9fb8cfa7_d598fbc0","updated":"2019-06-11 20:06:28.000000000","message":"Indeed it is optional for the request but should always be in the response when the extension is active, so yeah I should fix this. Will do a new patch tomorrow.","commit_id":"411399ead5f0258a7203bb9ac2c5dce1e20215f4"}],"neutron_lib/api/definitions/subnet_dns_publish_fixed_ip.py":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"d579434c1360a22ba82b86deeaad1a77328f5f74","unresolved":false,"context_lines":[{"line_number":16,"context_line":"DNS_PUBLISH_FIXED_IP \u003d \u0027dns_publish_fixed_ip\u0027"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# The alias of the extension."},{"line_number":19,"context_line":"ALIAS \u003d \u0027subnet_dns_publish_fixed_ip\u0027"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# Whether or not this extension is simply signaling behavior to the user"},{"line_number":22,"context_line":"# or it actively modifies the attribute map."}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_48b169e1","line":19,"range":{"start_line":19,"start_character":9,"end_line":19,"end_character":36},"updated":"2019-06-03 12:29:15.000000000","message":"For consistency I think we should use \u0027-\u0027 rather than \u0027_\u0027 in the ALIAS name.","commit_id":"03c51f5c698e53fe8e3059352b8915d313ca10b0"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"704fd23fc13be5a7dfdd40241526afe1d7ffe516","unresolved":false,"context_lines":[{"line_number":16,"context_line":"DNS_PUBLISH_FIXED_IP \u003d \u0027dns_publish_fixed_ip\u0027"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# The alias of the extension."},{"line_number":19,"context_line":"ALIAS \u003d \u0027subnet_dns_publish_fixed_ip\u0027"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# Whether or not this extension is simply signaling behavior to the user"},{"line_number":22,"context_line":"# or it actively modifies the attribute map."}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_b38e562c","line":19,"range":{"start_line":19,"start_character":9,"end_line":19,"end_character":36},"in_reply_to":"9fb8cfa7_48b169e1","updated":"2019-06-03 13:41:45.000000000","message":"O.k., I can change that, I was just following the sample of other extensions starting with \"subnet_\" like \"subnet_allocation\".","commit_id":"03c51f5c698e53fe8e3059352b8915d313ca10b0"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"d579434c1360a22ba82b86deeaad1a77328f5f74","unresolved":false,"context_lines":[{"line_number":34,"context_line":"NAME \u003d \u0027Subnet DNS publish fixed IP\u0027"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"# The description of the extension."},{"line_number":37,"context_line":"DESCRIPTION \u003d \u0027Support choosing to publish DNS records for IPs from a subnet\u0027"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"# A timestamp of when the extension was introduced."},{"line_number":40,"context_line":"UPDATED_TIMESTAMP \u003d \"2019-05-24T10:00:00-00:00\""}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_28c8b553","line":37,"range":{"start_line":37,"start_character":23,"end_line":37,"end_character":31},"updated":"2019-06-03 12:29:15.000000000","message":"This wording confuses me a little; what does \u0027choosing\u0027 mean in this context?","commit_id":"03c51f5c698e53fe8e3059352b8915d313ca10b0"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"704fd23fc13be5a7dfdd40241526afe1d7ffe516","unresolved":false,"context_lines":[{"line_number":34,"context_line":"NAME \u003d \u0027Subnet DNS publish fixed IP\u0027"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"# The description of the extension."},{"line_number":37,"context_line":"DESCRIPTION \u003d \u0027Support choosing to publish DNS records for IPs from a subnet\u0027"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"# A timestamp of when the extension was introduced."},{"line_number":40,"context_line":"UPDATED_TIMESTAMP \u003d \"2019-05-24T10:00:00-00:00\""}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_13f9627f","line":37,"range":{"start_line":37,"start_character":23,"end_line":37,"end_character":31},"in_reply_to":"9fb8cfa7_28c8b553","updated":"2019-06-03 13:41:45.000000000","message":"Without this extension, the decision whether or not DNS records are published for a port is only based on the network the port belongs to and some complicated set of criteria, see [1]. With the extension, setting the new attribute to True on a Subnet will make the fixed IPs from this Subnet be published unconditionally. So by setting this attribute one \"... chooses to publish DNS records for IPs from this subnet\", that\u0027s how I intend this to be understood.\n\nI\u0027m no native speaker, though, so if you can propose some better wording, I\u0027m very happy to hear your advise.\n\n[1] https://docs.openstack.org/neutron/latest/admin/config-dns-int-ext-serv.html#configuration-of-the-externally-accessible-network-for-use-case-3","commit_id":"03c51f5c698e53fe8e3059352b8915d313ca10b0"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"d579434c1360a22ba82b86deeaad1a77328f5f74","unresolved":false,"context_lines":[{"line_number":70,"context_line":"}"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"# The list of required extensions."},{"line_number":73,"context_line":"REQUIRED_EXTENSIONS \u003d ["},{"line_number":74,"context_line":"]"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"# The list of optional extensions."}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_88dc4119","line":73,"range":{"start_line":73,"start_character":0,"end_line":73,"end_character":19},"updated":"2019-06-03 12:29:15.000000000","message":"Doesn\u0027t it require the subnet extension?","commit_id":"03c51f5c698e53fe8e3059352b8915d313ca10b0"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"704fd23fc13be5a7dfdd40241526afe1d7ffe516","unresolved":false,"context_lines":[{"line_number":70,"context_line":"}"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"# The list of required extensions."},{"line_number":73,"context_line":"REQUIRED_EXTENSIONS \u003d ["},{"line_number":74,"context_line":"]"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"# The list of optional extensions."}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_d3e3caa3","line":73,"range":{"start_line":73,"start_character":0,"end_line":73,"end_character":19},"in_reply_to":"9fb8cfa7_88dc4119","updated":"2019-06-03 13:41:45.000000000","message":"Is there such a thing? I was assuming that a subnet was a very basic object in neutron since the beginning.\n\nI was wondering though whether it would make sense to require the dns-integration extension, as without it, this extension would be rather useless.","commit_id":"03c51f5c698e53fe8e3059352b8915d313ca10b0"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"13d32eb07340eeb759872e758f84eed4fbec8917","unresolved":false,"context_lines":[{"line_number":70,"context_line":"}"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"# The list of required extensions."},{"line_number":73,"context_line":"REQUIRED_EXTENSIONS \u003d ["},{"line_number":74,"context_line":"]"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"# The list of optional extensions."}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_5ba27a9c","line":73,"range":{"start_line":73,"start_character":0,"end_line":73,"end_character":19},"in_reply_to":"9fb8cfa7_d3e3caa3","updated":"2019-06-04 12:26:03.000000000","message":"For subnet the API def is already used in this module as subnet.COLLECTION_NAME, so wouldn\u0027t we just use subnet.ALIAS here? If we can assume it\u0027s always loaded, I guess not needed... If the dns-integration ext is required for this one, they probably good to add it here.","commit_id":"03c51f5c698e53fe8e3059352b8915d313ca10b0"}],"releasenotes/notes/subnet-dns-publish-fixed-ip-031d78bbc85a419e.yaml":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8c3f97debc0f586f862e5bbd8e97969bb0764dd6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    [`bug 1784879 \u003chttps://launchpad.net/bugs/1784879\u003e`_]"},{"line_number":5,"context_line":"    The ``subnet-dns-publish-fixed-ip`` API extension is added. It adds the"},{"line_number":6,"context_line":"    ``dns_publish_fixed_ip`` to subnets, allowing to"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fb8cfa7_aedb03eb","line":4,"updated":"2019-06-06 15:48:52.000000000","message":"I would put the bug at the end of the text, something like, \u0027For more information see $BUG.\u0027","commit_id":"5ad3bc6c5d055ff1db1304bec366871b464798d5"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"b458d1a7f8741f1b5e440bd660e1b29519313843","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    [`bug 1784879 \u003chttps://launchpad.net/bugs/1784879\u003e`_]"},{"line_number":5,"context_line":"    The ``subnet-dns-publish-fixed-ip`` API extension is added. It adds the"},{"line_number":6,"context_line":"    ``dns_publish_fixed_ip`` to subnets, allowing to"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fb8cfa7_77f12195","line":4,"in_reply_to":"9fb8cfa7_aedb03eb","updated":"2019-06-11 06:19:01.000000000","message":"Done","commit_id":"5ad3bc6c5d055ff1db1304bec366871b464798d5"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8c3f97debc0f586f862e5bbd8e97969bb0764dd6","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    [`bug 1784879 \u003chttps://launchpad.net/bugs/1784879\u003e`_]"},{"line_number":5,"context_line":"    The ``subnet-dns-publish-fixed-ip`` API extension is added. It adds the"},{"line_number":6,"context_line":"    ``dns_publish_fixed_ip`` to subnets, allowing to"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fb8cfa7_8e4b9fae","line":6,"updated":"2019-06-06 15:48:52.000000000","message":"sentence just ends...","commit_id":"5ad3bc6c5d055ff1db1304bec366871b464798d5"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"b458d1a7f8741f1b5e440bd660e1b29519313843","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    [`bug 1784879 \u003chttps://launchpad.net/bugs/1784879\u003e`_]"},{"line_number":5,"context_line":"    The ``subnet-dns-publish-fixed-ip`` API extension is added. It adds the"},{"line_number":6,"context_line":"    ``dns_publish_fixed_ip`` to subnets, allowing to"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9fb8cfa7_5732dd60","line":6,"in_reply_to":"9fb8cfa7_8e4b9fae","updated":"2019-06-11 06:19:01.000000000","message":"Done","commit_id":"5ad3bc6c5d055ff1db1304bec366871b464798d5"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"cdc4c4878baf275287ce4f75d10079a3e2e82365","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ``subnet-dns-publish-fixed-ip`` API extension is added. It adds the"},{"line_number":5,"context_line":"    ``dns_publish_fixed_ip`` attribute to subnets, allowing to indicate"},{"line_number":6,"context_line":"    whether to publish DNS records for fixed IPs from this subnet in an"},{"line_number":7,"context_line":"    external DNS service. For details see"},{"line_number":8,"context_line":"    [`bug 1784879 \u003chttps://launchpad.net/bugs/1784879\u003e`_]."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9fb8cfa7_e90f3a85","line":5,"range":{"start_line":5,"start_character":51,"end_line":5,"end_character":71},"updated":"2019-06-13 18:54:25.000000000","message":"nit: s/indicating","commit_id":"dc344ad6e0252589a5c16daad0aae078da98ad3e"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ab7be1563aacaf2d38340e0345c0a73c23142483","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ``subnet-dns-publish-fixed-ip`` API extension is added. It adds the"},{"line_number":5,"context_line":"    ``dns_publish_fixed_ip`` attribute to subnets, allowing to indicate"},{"line_number":6,"context_line":"    whether to publish DNS records for fixed IPs from this subnet in an"},{"line_number":7,"context_line":"    external DNS service. For details see"},{"line_number":8,"context_line":"    [`bug 1784879 \u003chttps://launchpad.net/bugs/1784879\u003e`_]."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9fb8cfa7_44d8a3ed","line":5,"range":{"start_line":5,"start_character":51,"end_line":5,"end_character":71},"in_reply_to":"9fb8cfa7_e90f3a85","updated":"2019-06-14 09:27:22.000000000","message":"Done","commit_id":"dc344ad6e0252589a5c16daad0aae078da98ad3e"}]}