)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"9c3626232ccaea8d522241c53acadfccc7330731","unresolved":false,"context_lines":[{"line_number":10,"context_line":"other than IPv4 and IPv6 can be specified in security group rules, add a"},{"line_number":11,"context_line":"validator to ensure that ethertypes will be a valid two octet value."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I900f370f1de20b5137f138e54c5eec2102f77cce"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7faddb67_f6b13e45","line":13,"updated":"2019-07-19 13:39:39.000000000","message":"Is it related to some reported RFE? I think we had one for that, right?","commit_id":"696d90dc13bda209e6a848b27874a6b9e18b9c13"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"5117ad1532d574bdf0fffb3eb9e759cb1bbb1295","unresolved":false,"context_lines":[{"line_number":10,"context_line":"other than IPv4 and IPv6 can be specified in security group rules, add a"},{"line_number":11,"context_line":"validator to ensure that ethertypes will be a valid two octet value."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I900f370f1de20b5137f138e54c5eec2102f77cce"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7faddb67_f9f6115d","line":13,"in_reply_to":"7faddb67_795d4177","updated":"2019-07-19 14:40:11.000000000","message":"thx","commit_id":"696d90dc13bda209e6a848b27874a6b9e18b9c13"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"e2cb98deee1f62ec5b787c89b84956e44a9d4b79","unresolved":false,"context_lines":[{"line_number":10,"context_line":"other than IPv4 and IPv6 can be specified in security group rules, add a"},{"line_number":11,"context_line":"validator to ensure that ethertypes will be a valid two octet value."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I900f370f1de20b5137f138e54c5eec2102f77cce"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7faddb67_795d4177","line":13,"in_reply_to":"7faddb67_f6b13e45","updated":"2019-07-19 14:35:23.000000000","message":"Done","commit_id":"696d90dc13bda209e6a848b27874a6b9e18b9c13"}],"neutron_lib/api/validators/__init__.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"907df6f0e0bfd3ea017a81018ae4ad57d673ba7e","unresolved":false,"context_lines":[{"line_number":1130,"context_line":"        message indicating that the data is not a valid ethertype."},{"line_number":1131,"context_line":"    \"\"\""},{"line_number":1132,"context_line":"    try:"},{"line_number":1133,"context_line":"        if 0 \u003e\u003d int(ethertype, 16) \u003e\u003d 65535:"},{"line_number":1134,"context_line":"            return None"},{"line_number":1135,"context_line":"    except ValueError:"},{"line_number":1136,"context_line":"            log_warning(\"Custom ethertype \u0027%(permitted_ethertype)s\u0027 \""}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_ac97193a","line":1133,"updated":"2019-07-17 18:21:55.000000000","message":"These should be \u003c\u003d right?\n\nBut even if it\u0027s False it will return None, it\u0027s almost like the logging below shouldn\u0027t be in the except block","commit_id":"b9b285a624af7f73a774c7bd7f462146b14862e2"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"287f77855284056d9c1962511f169d3b4aa5fcf7","unresolved":false,"context_lines":[{"line_number":1130,"context_line":"        message indicating that the data is not a valid ethertype."},{"line_number":1131,"context_line":"    \"\"\""},{"line_number":1132,"context_line":"    try:"},{"line_number":1133,"context_line":"        if 0 \u003e\u003d int(ethertype, 16) \u003e\u003d 65535:"},{"line_number":1134,"context_line":"            return None"},{"line_number":1135,"context_line":"    except ValueError:"},{"line_number":1136,"context_line":"            log_warning(\"Custom ethertype \u0027%(permitted_ethertype)s\u0027 \""}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_773eb6b8","line":1133,"in_reply_to":"7faddb67_6c4121a9","updated":"2019-07-18 19:41:02.000000000","message":"Yep!  I figured out I was being dopey about that as I was working out why the tests weren\u0027t working.","commit_id":"b9b285a624af7f73a774c7bd7f462146b14862e2"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"1f899694ae7e9e42a975cff1d6cb4aea7b7afc57","unresolved":false,"context_lines":[{"line_number":1130,"context_line":"        message indicating that the data is not a valid ethertype."},{"line_number":1131,"context_line":"    \"\"\""},{"line_number":1132,"context_line":"    try:"},{"line_number":1133,"context_line":"        if 0 \u003e\u003d int(ethertype, 16) \u003e\u003d 65535:"},{"line_number":1134,"context_line":"            return None"},{"line_number":1135,"context_line":"    except ValueError:"},{"line_number":1136,"context_line":"            log_warning(\"Custom ethertype \u0027%(permitted_ethertype)s\u0027 \""}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_6c4121a9","line":1133,"in_reply_to":"7faddb67_ac97193a","updated":"2019-07-17 18:27:52.000000000","message":"+1","commit_id":"b9b285a624af7f73a774c7bd7f462146b14862e2"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"907df6f0e0bfd3ea017a81018ae4ad57d673ba7e","unresolved":false,"context_lines":[{"line_number":1133,"context_line":"        if 0 \u003e\u003d int(ethertype, 16) \u003e\u003d 65535:"},{"line_number":1134,"context_line":"            return None"},{"line_number":1135,"context_line":"    except ValueError:"},{"line_number":1136,"context_line":"            log_warning(\"Custom ethertype \u0027%(permitted_ethertype)s\u0027 \""},{"line_number":1137,"context_line":"                        \"is not a two octet hexadecimal number.\","},{"line_number":1138,"context_line":"                        {\u0027permitted_ethertype\u0027: permitted_ethertype})"},{"line_number":1139,"context_line":"            LOG.warning(log_warning)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_2c9d6965","line":1136,"updated":"2019-07-17 18:21:55.000000000","message":"msg \u003d _(...) ?\n\nAnd indentation is 8 spaces","commit_id":"b9b285a624af7f73a774c7bd7f462146b14862e2"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"287f77855284056d9c1962511f169d3b4aa5fcf7","unresolved":false,"context_lines":[{"line_number":1133,"context_line":"        if 0 \u003e\u003d int(ethertype, 16) \u003e\u003d 65535:"},{"line_number":1134,"context_line":"            return None"},{"line_number":1135,"context_line":"    except ValueError:"},{"line_number":1136,"context_line":"            log_warning(\"Custom ethertype \u0027%(permitted_ethertype)s\u0027 \""},{"line_number":1137,"context_line":"                        \"is not a two octet hexadecimal number.\","},{"line_number":1138,"context_line":"                        {\u0027permitted_ethertype\u0027: permitted_ethertype})"},{"line_number":1139,"context_line":"            LOG.warning(log_warning)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_776796ea","line":1136,"in_reply_to":"7faddb67_2c9d6965","updated":"2019-07-18 19:41:02.000000000","message":"I thought we weren\u0027t doing the _(...) for translation anymore?  \n\nTrying to figure out the indentation nonsense, vim is lying to me.","commit_id":"b9b285a624af7f73a774c7bd7f462146b14862e2"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"907df6f0e0bfd3ea017a81018ae4ad57d673ba7e","unresolved":false,"context_lines":[{"line_number":1135,"context_line":"    except ValueError:"},{"line_number":1136,"context_line":"            log_warning(\"Custom ethertype \u0027%(permitted_ethertype)s\u0027 \""},{"line_number":1137,"context_line":"                        \"is not a two octet hexadecimal number.\","},{"line_number":1138,"context_line":"                        {\u0027permitted_ethertype\u0027: permitted_ethertype})"},{"line_number":1139,"context_line":"            LOG.warning(log_warning)"},{"line_number":1140,"context_line":"            return log_warning"},{"line_number":1141,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_0c90ad49","line":1138,"range":{"start_line":1138,"start_character":48,"end_line":1138,"end_character":67},"updated":"2019-07-17 18:21:55.000000000","message":"s/ethertype","commit_id":"b9b285a624af7f73a774c7bd7f462146b14862e2"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"287f77855284056d9c1962511f169d3b4aa5fcf7","unresolved":false,"context_lines":[{"line_number":1135,"context_line":"    except ValueError:"},{"line_number":1136,"context_line":"            log_warning(\"Custom ethertype \u0027%(permitted_ethertype)s\u0027 \""},{"line_number":1137,"context_line":"                        \"is not a two octet hexadecimal number.\","},{"line_number":1138,"context_line":"                        {\u0027permitted_ethertype\u0027: permitted_ethertype})"},{"line_number":1139,"context_line":"            LOG.warning(log_warning)"},{"line_number":1140,"context_line":"            return log_warning"},{"line_number":1141,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_1762e2d8","line":1138,"range":{"start_line":1138,"start_character":48,"end_line":1138,"end_character":67},"in_reply_to":"7faddb67_0c90ad49","updated":"2019-07-18 19:41:02.000000000","message":"Done","commit_id":"b9b285a624af7f73a774c7bd7f462146b14862e2"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"1f899694ae7e9e42a975cff1d6cb4aea7b7afc57","unresolved":false,"context_lines":[{"line_number":1136,"context_line":"            log_warning(\"Custom ethertype \u0027%(permitted_ethertype)s\u0027 \""},{"line_number":1137,"context_line":"                        \"is not a two octet hexadecimal number.\","},{"line_number":1138,"context_line":"                        {\u0027permitted_ethertype\u0027: permitted_ethertype})"},{"line_number":1139,"context_line":"            LOG.warning(log_warning)"},{"line_number":1140,"context_line":"            return log_warning"},{"line_number":1141,"context_line":""},{"line_number":1142,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_0c318d5a","line":1139,"range":{"start_line":1139,"start_character":16,"end_line":1139,"end_character":23},"updated":"2019-07-17 18:27:52.000000000","message":"nit: I think LOG.debug is used in the validator methods, instead of warning.","commit_id":"b9b285a624af7f73a774c7bd7f462146b14862e2"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"287f77855284056d9c1962511f169d3b4aa5fcf7","unresolved":false,"context_lines":[{"line_number":1136,"context_line":"            log_warning(\"Custom ethertype \u0027%(permitted_ethertype)s\u0027 \""},{"line_number":1137,"context_line":"                        \"is not a two octet hexadecimal number.\","},{"line_number":1138,"context_line":"                        {\u0027permitted_ethertype\u0027: permitted_ethertype})"},{"line_number":1139,"context_line":"            LOG.warning(log_warning)"},{"line_number":1140,"context_line":"            return log_warning"},{"line_number":1141,"context_line":""},{"line_number":1142,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_d79d2abc","line":1139,"range":{"start_line":1139,"start_character":16,"end_line":1139,"end_character":23},"in_reply_to":"7faddb67_0c318d5a","updated":"2019-07-18 19:41:02.000000000","message":"Done","commit_id":"b9b285a624af7f73a774c7bd7f462146b14862e2"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2edac338793f17619d0952c69559d525ff800460","unresolved":false,"context_lines":[{"line_number":1133,"context_line":"        if isinstance(ethertype, six.string_types):"},{"line_number":1134,"context_line":"            ethertype \u003d int(ethertype, 16)"},{"line_number":1135,"context_line":"        elif not isinstance(ethertype, six.integer_types):"},{"line_number":1136,"context_line":"            raise ValueError"},{"line_number":1137,"context_line":""},{"line_number":1138,"context_line":"        if 0 \u003c\u003d ethertype \u003c\u003d 65535:"},{"line_number":1139,"context_line":"            return None"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_9248362d","line":1136,"updated":"2019-07-17 20:42:12.000000000","message":"You know me, I\u0027m a nitpicker :)\n\nI think you could simplify this and remove the try/except completely.\n\nif isinstance(ethertype, six.string_types):\n    ethertype \u003d int(ethertype, 16)\nif (isinstance(ethertype, six,integer_types) and\n        0 \u003c\u003d ethertype \u003c\u003d 65535):\n    return None\n\nmsg \u003d _(...)\n...\n\nJust a thought.","commit_id":"45d689c34fdb2c0b5f740d07ec1d46bd926e7d99"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"8c197b75553b5853883b79f17eb834de5fdc03c3","unresolved":false,"context_lines":[{"line_number":1133,"context_line":"        if isinstance(ethertype, six.string_types):"},{"line_number":1134,"context_line":"            ethertype \u003d int(ethertype, 16)"},{"line_number":1135,"context_line":"        elif not isinstance(ethertype, six.integer_types):"},{"line_number":1136,"context_line":"            raise ValueError"},{"line_number":1137,"context_line":""},{"line_number":1138,"context_line":"        if 0 \u003c\u003d ethertype \u003c\u003d 65535:"},{"line_number":1139,"context_line":"            return None"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_f7894674","line":1136,"in_reply_to":"7faddb67_9248362d","updated":"2019-07-18 19:49:31.000000000","message":"You\u0027d still need the try/except in case ethertype is specified to something that is a string but is not valid hexadecimal.  Otherwise it would throw a ValueError on the int(ethertype, 16) line and it would go uncaught.\n\nBut I like your syntax, let me give it a roll.","commit_id":"45d689c34fdb2c0b5f740d07ec1d46bd926e7d99"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2edac338793f17619d0952c69559d525ff800460","unresolved":false,"context_lines":[{"line_number":1139,"context_line":"            return None"},{"line_number":1140,"context_line":"        else:"},{"line_number":1141,"context_line":"            raise ValueError"},{"line_number":1142,"context_line":"    except ValueError:"},{"line_number":1143,"context_line":"            log_warning \u003d (\"Custom ethertype %s is not a two octet \""},{"line_number":1144,"context_line":"                           \"hexadecimal number.\" % ethertype)"},{"line_number":1145,"context_line":"            LOG.warning(log_warning)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_12ef661e","line":1142,"updated":"2019-07-17 20:42:12.000000000","message":"this could be \u0027pass\u0027 here and fall-through to the message code","commit_id":"45d689c34fdb2c0b5f740d07ec1d46bd926e7d99"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"8c197b75553b5853883b79f17eb834de5fdc03c3","unresolved":false,"context_lines":[{"line_number":1139,"context_line":"            return None"},{"line_number":1140,"context_line":"        else:"},{"line_number":1141,"context_line":"            raise ValueError"},{"line_number":1142,"context_line":"    except ValueError:"},{"line_number":1143,"context_line":"            log_warning \u003d (\"Custom ethertype %s is not a two octet \""},{"line_number":1144,"context_line":"                           \"hexadecimal number.\" % ethertype)"},{"line_number":1145,"context_line":"            LOG.warning(log_warning)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_37b91e14","line":1142,"in_reply_to":"7faddb67_12ef661e","updated":"2019-07-18 19:49:31.000000000","message":"Done","commit_id":"45d689c34fdb2c0b5f740d07ec1d46bd926e7d99"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2edac338793f17619d0952c69559d525ff800460","unresolved":false,"context_lines":[{"line_number":1140,"context_line":"        else:"},{"line_number":1141,"context_line":"            raise ValueError"},{"line_number":1142,"context_line":"    except ValueError:"},{"line_number":1143,"context_line":"            log_warning \u003d (\"Custom ethertype %s is not a two octet \""},{"line_number":1144,"context_line":"                           \"hexadecimal number.\" % ethertype)"},{"line_number":1145,"context_line":"            LOG.warning(log_warning)"},{"line_number":1146,"context_line":"            return log_warning"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_726c9acd","line":1143,"range":{"start_line":1143,"start_character":12,"end_line":1143,"end_character":23},"updated":"2019-07-17 20:42:12.000000000","message":"nit: all the other validators use \u0027msg\u0027 for this variable","commit_id":"45d689c34fdb2c0b5f740d07ec1d46bd926e7d99"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2edac338793f17619d0952c69559d525ff800460","unresolved":false,"context_lines":[{"line_number":1140,"context_line":"        else:"},{"line_number":1141,"context_line":"            raise ValueError"},{"line_number":1142,"context_line":"    except ValueError:"},{"line_number":1143,"context_line":"            log_warning \u003d (\"Custom ethertype %s is not a two octet \""},{"line_number":1144,"context_line":"                           \"hexadecimal number.\" % ethertype)"},{"line_number":1145,"context_line":"            LOG.warning(log_warning)"},{"line_number":1146,"context_line":"            return log_warning"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_92711679","line":1143,"range":{"start_line":1143,"start_character":28,"end_line":1143,"end_character":47},"updated":"2019-07-17 20:42:12.000000000","message":"s/Ethertype \u0027%s\u0027","commit_id":"45d689c34fdb2c0b5f740d07ec1d46bd926e7d99"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2edac338793f17619d0952c69559d525ff800460","unresolved":false,"context_lines":[{"line_number":1140,"context_line":"        else:"},{"line_number":1141,"context_line":"            raise ValueError"},{"line_number":1142,"context_line":"    except ValueError:"},{"line_number":1143,"context_line":"            log_warning \u003d (\"Custom ethertype %s is not a two octet \""},{"line_number":1144,"context_line":"                           \"hexadecimal number.\" % ethertype)"},{"line_number":1145,"context_line":"            LOG.warning(log_warning)"},{"line_number":1146,"context_line":"            return log_warning"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_9267d6e9","line":1143,"range":{"start_line":1143,"start_character":26,"end_line":1143,"end_character":27},"updated":"2019-07-17 20:42:12.000000000","message":"s/_( for i18n","commit_id":"45d689c34fdb2c0b5f740d07ec1d46bd926e7d99"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"8c197b75553b5853883b79f17eb834de5fdc03c3","unresolved":false,"context_lines":[{"line_number":1140,"context_line":"        else:"},{"line_number":1141,"context_line":"            raise ValueError"},{"line_number":1142,"context_line":"    except ValueError:"},{"line_number":1143,"context_line":"            log_warning \u003d (\"Custom ethertype %s is not a two octet \""},{"line_number":1144,"context_line":"                           \"hexadecimal number.\" % ethertype)"},{"line_number":1145,"context_line":"            LOG.warning(log_warning)"},{"line_number":1146,"context_line":"            return log_warning"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_7748f62b","line":1143,"range":{"start_line":1143,"start_character":12,"end_line":1143,"end_character":23},"in_reply_to":"7faddb67_726c9acd","updated":"2019-07-18 19:49:31.000000000","message":"Done","commit_id":"45d689c34fdb2c0b5f740d07ec1d46bd926e7d99"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"8c197b75553b5853883b79f17eb834de5fdc03c3","unresolved":false,"context_lines":[{"line_number":1140,"context_line":"        else:"},{"line_number":1141,"context_line":"            raise ValueError"},{"line_number":1142,"context_line":"    except ValueError:"},{"line_number":1143,"context_line":"            log_warning \u003d (\"Custom ethertype %s is not a two octet \""},{"line_number":1144,"context_line":"                           \"hexadecimal number.\" % ethertype)"},{"line_number":1145,"context_line":"            LOG.warning(log_warning)"},{"line_number":1146,"context_line":"            return log_warning"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_574dba3b","line":1143,"range":{"start_line":1143,"start_character":26,"end_line":1143,"end_character":27},"in_reply_to":"7faddb67_9267d6e9","updated":"2019-07-18 19:49:31.000000000","message":"Done","commit_id":"45d689c34fdb2c0b5f740d07ec1d46bd926e7d99"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"8c197b75553b5853883b79f17eb834de5fdc03c3","unresolved":false,"context_lines":[{"line_number":1140,"context_line":"        else:"},{"line_number":1141,"context_line":"            raise ValueError"},{"line_number":1142,"context_line":"    except ValueError:"},{"line_number":1143,"context_line":"            log_warning \u003d (\"Custom ethertype %s is not a two octet \""},{"line_number":1144,"context_line":"                           \"hexadecimal number.\" % ethertype)"},{"line_number":1145,"context_line":"            LOG.warning(log_warning)"},{"line_number":1146,"context_line":"            return log_warning"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_b742ee0d","line":1143,"range":{"start_line":1143,"start_character":28,"end_line":1143,"end_character":47},"in_reply_to":"7faddb67_92711679","updated":"2019-07-18 19:49:31.000000000","message":"Done","commit_id":"45d689c34fdb2c0b5f740d07ec1d46bd926e7d99"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2edac338793f17619d0952c69559d525ff800460","unresolved":false,"context_lines":[{"line_number":1142,"context_line":"    except ValueError:"},{"line_number":1143,"context_line":"            log_warning \u003d (\"Custom ethertype %s is not a two octet \""},{"line_number":1144,"context_line":"                           \"hexadecimal number.\" % ethertype)"},{"line_number":1145,"context_line":"            LOG.warning(log_warning)"},{"line_number":1146,"context_line":"            return log_warning"},{"line_number":1147,"context_line":""},{"line_number":1148,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_525dde12","line":1145,"range":{"start_line":1145,"start_character":16,"end_line":1145,"end_character":23},"updated":"2019-07-17 20:42:12.000000000","message":"As Rodolfo mentioned, this should probably be debug","commit_id":"45d689c34fdb2c0b5f740d07ec1d46bd926e7d99"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"8c197b75553b5853883b79f17eb834de5fdc03c3","unresolved":false,"context_lines":[{"line_number":1142,"context_line":"    except ValueError:"},{"line_number":1143,"context_line":"            log_warning \u003d (\"Custom ethertype %s is not a two octet \""},{"line_number":1144,"context_line":"                           \"hexadecimal number.\" % ethertype)"},{"line_number":1145,"context_line":"            LOG.warning(log_warning)"},{"line_number":1146,"context_line":"            return log_warning"},{"line_number":1147,"context_line":""},{"line_number":1148,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_1753c2e3","line":1145,"range":{"start_line":1145,"start_character":16,"end_line":1145,"end_character":23},"in_reply_to":"7faddb67_525dde12","updated":"2019-07-18 19:49:31.000000000","message":"Done","commit_id":"45d689c34fdb2c0b5f740d07ec1d46bd926e7d99"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ac35cb0c5f087b291148b36b0d19f026ef7940fa","unresolved":false,"context_lines":[{"line_number":1143,"context_line":"        msg \u003d _(\"Ethertype %s is not a two octet hexadecimal \""},{"line_number":1144,"context_line":"                \"number.\") % ethertype"},{"line_number":1145,"context_line":"        LOG.debug(msg)"},{"line_number":1146,"context_line":"        return msg"},{"line_number":1147,"context_line":"    else:"},{"line_number":1148,"context_line":"        if ethertype in constants.VALID_ETHERTYPES:"},{"line_number":1149,"context_line":"            return None"}],"source_content_type":"text/x-python","patch_set":9,"id":"7faddb67_ab6114d5","line":1146,"updated":"2019-07-20 01:46:13.000000000","message":"nit: these two lines and 1154-55 can be \"common\" and after the if/else","commit_id":"db0433458221d66d9a3a1a8399405e1b09b38c90"}],"neutron_lib/tests/unit/api/validators/test_validators.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8bda940999b77d48d1342d414f82a5912bcb4686","unresolved":false,"context_lines":[{"line_number":1114,"context_line":"        self.assertIsNone(validators.validate_ethertype(0x4008))"},{"line_number":1115,"context_line":""},{"line_number":1116,"context_line":"    def test_validate_ethertype_invalid_negative(self):"},{"line_number":1117,"context_line":"        self.assertEqual((\"Custom ethertype -16392 is not a two octet \""},{"line_number":1118,"context_line":"                          \"hexadecimal number.\"),"},{"line_number":1119,"context_line":"                         validators.validate_ethertype(\u0027-0x4008\u0027))"},{"line_number":1120,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_170182af","line":1117,"range":{"start_line":1117,"start_character":27,"end_line":1117,"end_character":43},"updated":"2019-07-18 19:56:41.000000000","message":"s/Ethertype","commit_id":"0e5a2662231345a438787e2d80c891089e571a95"}]}