)]}'
{"neutron_lib/api/converters.py":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"32db09ffd8aeff725f342d0e075c22b28d27ed06","unresolved":false,"context_lines":[{"line_number":355,"context_line":"        ethertype\u003dvalue, values\u003dsg_def.SG_SUPPORTED_ETHERTYPES)"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"def convert_validate_port_value(port):"},{"line_number":359,"context_line":"    if port is None:"},{"line_number":360,"context_line":"        return port"},{"line_number":361,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_cd822ba6","line":358,"range":{"start_line":358,"start_character":4,"end_line":358,"end_character":31},"updated":"2019-08-26 13:47:01.000000000","message":"In general we use validators to do validation; is there a reason to combine it into a converter here?","commit_id":"ae0df22e68720bc7630f7e7844860d103acd0dee"}],"neutron_lib/api/definitions/securitygroup.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"725aa2234d26eb5b3f14cc80e07bdf127a0237e9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2012 OpenStack Foundation."},{"line_number":2,"context_line":"# All rights reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_4febf7a2","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"updated":"2019-08-20 10:50:55.000000000","message":"?","commit_id":"ae0df22e68720bc7630f7e7844860d103acd0dee"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"32db09ffd8aeff725f342d0e075c22b28d27ed06","unresolved":false,"context_lines":[{"line_number":115,"context_line":"}"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"EXTENDED_ATTRIBUTES_2_0 \u003d {"},{"line_number":118,"context_line":"    \u0027ports\u0027: {RESOURCE_PLURAL: {\u0027allow_post\u0027: True,"},{"line_number":119,"context_line":"                                \u0027allow_put\u0027: True,"},{"line_number":120,"context_line":"                                \u0027is_visible\u0027: True,"},{"line_number":121,"context_line":"                                \u0027is_filter\u0027: True,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_4df2bb71","line":118,"range":{"start_line":118,"start_character":5,"end_line":118,"end_character":10},"updated":"2019-08-26 13:47:01.000000000","message":"Can\u0027t we just use the COLLECTION_NAME from the ports api def?","commit_id":"ae0df22e68720bc7630f7e7844860d103acd0dee"}],"neutron_lib/api/validators/__init__.py":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"32db09ffd8aeff725f342d0e075c22b28d27ed06","unresolved":false,"context_lines":[{"line_number":1173,"context_line":"        return msg"},{"line_number":1174,"context_line":""},{"line_number":1175,"context_line":""},{"line_number":1176,"context_line":"def validate_name_not_default(data, max_len\u003ddb_const.NAME_FIELD_SIZE):"},{"line_number":1177,"context_line":"    msg \u003d validate_string(data, max_len)"},{"line_number":1178,"context_line":"    if msg:"},{"line_number":1179,"context_line":"        return msg"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_adaecf2c","line":1176,"range":{"start_line":1176,"start_character":4,"end_line":1176,"end_character":29},"updated":"2019-08-26 13:47:01.000000000","message":"Seems the name should include security group since this is really tailored to sec groups.","commit_id":"ae0df22e68720bc7630f7e7844860d103acd0dee"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"32db09ffd8aeff725f342d0e075c22b28d27ed06","unresolved":false,"context_lines":[{"line_number":1182,"context_line":""},{"line_number":1183,"context_line":""},{"line_number":1184,"context_line":"# Dictionary that maintains a list of validation functions"},{"line_number":1185,"context_line":"validators \u003d {\u0027type:dict\u0027: validate_dict,"},{"line_number":1186,"context_line":"              \u0027type:dict_or_none\u0027: validate_dict_or_none,"},{"line_number":1187,"context_line":"              \u0027type:dict_or_empty\u0027: validate_dict_or_empty,"},{"line_number":1188,"context_line":"              \u0027type:dict_or_nodata\u0027: validate_dict_or_nodata,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_8d019309","line":1185,"updated":"2019-08-26 13:47:01.000000000","message":"Validators should be added here with their associated type.","commit_id":"ae0df22e68720bc7630f7e7844860d103acd0dee"}],"neutron_lib/exceptions/securitygroup.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"725aa2234d26eb5b3f14cc80e07bdf127a0237e9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2012 OpenStack Foundation."},{"line_number":2,"context_line":"# All rights reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_8ff56f85","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"updated":"2019-08-20 10:50:55.000000000","message":"?","commit_id":"ae0df22e68720bc7630f7e7844860d103acd0dee"}]}