)]}'
{"neutron_lib/services/logapi/constants.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2fa8030b0688050d3b300816f63564d9ed4fc58f","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# target resource types"},{"line_number":28,"context_line":"PORT \u003d \u0027port\u0027"},{"line_number":29,"context_line":"TARGET_RESOURCE \u003d \u0027port which is associated with the firewall group\u0027"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"RPC_NAMESPACE_LOGGING \u003d \u0027logging-plugin\u0027"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_25ba050a","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":15},"updated":"2019-10-21 14:03:02.000000000","message":"This should be named something like FIREWALL_TARGET_RESOURCE since it\u0027s specific to Firewall.","commit_id":"d0d495866faf1c3d4fb4231ce20a5bda6bda1837"},{"author":{"_account_id":29157,"name":"zhanghao","email":"hao.zhang.am.i@gmail.com","username":"zhanghao2"},"change_message_id":"f94f08bc6b9c50908877d2bffc0a652dd423d33b","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# target resource types"},{"line_number":28,"context_line":"PORT \u003d \u0027port\u0027"},{"line_number":29,"context_line":"TARGET_RESOURCE \u003d \u0027port which is associated with the firewall group\u0027"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"RPC_NAMESPACE_LOGGING \u003d \u0027logging-plugin\u0027"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_4965d344","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":15},"in_reply_to":"3fa7e38b_25ba050a","updated":"2019-10-22 03:12:43.000000000","message":"Done","commit_id":"d0d495866faf1c3d4fb4231ce20a5bda6bda1837"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b7073df8bc751a6dd15bf8c0d6672532aff8d42d","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# target resource types"},{"line_number":28,"context_line":"PORT \u003d \u0027port\u0027"},{"line_number":29,"context_line":"TARGET_RESOURCE \u003d \u0027port which is associated with the firewall group\u0027"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"RPC_NAMESPACE_LOGGING \u003d \u0027logging-plugin\u0027"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_25d525e6","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":15},"in_reply_to":"3fa7e38b_25ba050a","updated":"2019-10-21 14:14:33.000000000","message":"Or even FIREWALL_PORT ?","commit_id":"d0d495866faf1c3d4fb4231ce20a5bda6bda1837"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"4e9f07993b12bdaee4fc1ef7a636fd33358685d9","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# target resource types"},{"line_number":28,"context_line":"PORT \u003d \u0027port\u0027"},{"line_number":29,"context_line":"FIREWALL_TARGET_RESOURCE \u003d \u0027port which is associated with the firewall group\u0027"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"RPC_NAMESPACE_LOGGING \u003d \u0027logging-plugin\u0027"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_e43224a7","line":29,"updated":"2019-10-30 06:07:36.000000000","message":"Do we need to define this in neutron-lib?\n\nThis is confusing as it looks like a part of an error message.\nThe original \"TARGET_RESOURCE\" in neutron-fwaas is only used in an exception [1] which is defined in the neutron side [2]. \n\nMy suggestions are:\n\n- Drop this from this patch\n- Replace TARGET_RESOURCE in fwaas [1] with a literal string\n- Move InvalidResourceConstraint [2] to neutron-lib as it is used in neutron-fwaas.\n\n\n[1] https://github.com/openstack/neutron-fwaas/blob/b76709009155131b933b2adc7608165413572d71/neutron_fwaas/services/logapi/fwg_validate.py#L89\n[2] https://github.com/openstack/neutron/blob/843b5ffd9a8ee3f4d9d8830f43aa3d517cc11e07/neutron/services/logapi/common/exceptions.py#L41-L44","commit_id":"f3873161101e0f02cda29ebc4409eab91203c95a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"4d895183c19e26b844de9dece48d47c2de3cea60","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# target resource types"},{"line_number":28,"context_line":"PORT \u003d \u0027port\u0027"},{"line_number":29,"context_line":"FIREWALL_TARGET_RESOURCE \u003d \u0027port which is associated with the firewall group\u0027"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"RPC_NAMESPACE_LOGGING \u003d \u0027logging-plugin\u0027"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_7fb31d9b","line":29,"in_reply_to":"3fa7e38b_df7a5186","updated":"2019-10-30 08:35:06.000000000","message":"At least I disagree to introduce FIREWALL_TARGET_RESOURCE. I don\u0027t see a value to have it in neutron-lib.\n\nMoving exceptions related to the logging feature is another topic.","commit_id":"f3873161101e0f02cda29ebc4409eab91203c95a"},{"author":{"_account_id":29157,"name":"zhanghao","email":"hao.zhang.am.i@gmail.com","username":"zhanghao2"},"change_message_id":"62b80f4bad241933640124eca02f05a85a6012c4","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# target resource types"},{"line_number":28,"context_line":"PORT \u003d \u0027port\u0027"},{"line_number":29,"context_line":"FIREWALL_TARGET_RESOURCE \u003d \u0027port which is associated with the firewall group\u0027"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"RPC_NAMESPACE_LOGGING \u003d \u0027logging-plugin\u0027"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_df7a5186","line":29,"in_reply_to":"3fa7e38b_e43224a7","updated":"2019-10-30 07:38:40.000000000","message":"I think it\u0027s not good to just move this exception， the best way is to move all the logging exceptions to neutron-lib. This patch will move the constant first. What do you think?","commit_id":"f3873161101e0f02cda29ebc4409eab91203c95a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"4e9f07993b12bdaee4fc1ef7a636fd33358685d9","unresolved":false,"context_lines":[{"line_number":36,"context_line":"# String literal for identifying log resource"},{"line_number":37,"context_line":"LOGGING \u003d \u0027log\u0027"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"FIREWALL_LOG_DRIVER_NAME \u003d \u0027fwaas_v2_log\u0027"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"# Method names for Logging Driver"},{"line_number":42,"context_line":"PRECOMMIT_POSTFIX \u003d \u0027_precommit\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_4421b84c","line":39,"updated":"2019-10-30 06:07:36.000000000","message":"Why do you need to move the definition of L3 agent extension driver? It is only used in neutron-fwaas and it is specific to the reference implementation of the firewall logging with L3 agent.","commit_id":"f3873161101e0f02cda29ebc4409eab91203c95a"},{"author":{"_account_id":29157,"name":"zhanghao","email":"hao.zhang.am.i@gmail.com","username":"zhanghao2"},"change_message_id":"62b80f4bad241933640124eca02f05a85a6012c4","unresolved":false,"context_lines":[{"line_number":36,"context_line":"# String literal for identifying log resource"},{"line_number":37,"context_line":"LOGGING \u003d \u0027log\u0027"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"FIREWALL_LOG_DRIVER_NAME \u003d \u0027fwaas_v2_log\u0027"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"# Method names for Logging Driver"},{"line_number":42,"context_line":"PRECOMMIT_POSTFIX \u003d \u0027_precommit\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_a4842c0c","line":39,"in_reply_to":"3fa7e38b_4421b84c","updated":"2019-10-30 07:38:40.000000000","message":"yes，it is suggested by annp.\n[1] https://github.com/openstack/neutron-fwaas/blob/b76709009155131b933b2adc7608165413572d71/neutron_fwaas/services/logapi/agents/l3/fwg_log.py#L21","commit_id":"f3873161101e0f02cda29ebc4409eab91203c95a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"4d895183c19e26b844de9dece48d47c2de3cea60","unresolved":false,"context_lines":[{"line_number":36,"context_line":"# String literal for identifying log resource"},{"line_number":37,"context_line":"LOGGING \u003d \u0027log\u0027"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"FIREWALL_LOG_DRIVER_NAME \u003d \u0027fwaas_v2_log\u0027"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"# Method names for Logging Driver"},{"line_number":42,"context_line":"PRECOMMIT_POSTFIX \u003d \u0027_precommit\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_3fb12590","line":39,"in_reply_to":"3fa7e38b_a4842c0c","updated":"2019-10-30 08:35:06.000000000","message":"I cannot understand why it should be moved to neutron-lib.\nI see TODO comment but there is no reason, so I don\u0027t agree with it at the moment. My current opinion is that it does not match the role of neutron-lib.","commit_id":"f3873161101e0f02cda29ebc4409eab91203c95a"}]}