)]}'
{"id":"openstack%2Fneutron-lib~705694","triplet_id":"openstack%2Fneutron-lib~master~I58a47bb895bede219cfeebbf0665aaf01660ce89","project":"openstack/neutron-lib","branch":"master","topic":"bug/1861442","hashtags":[],"change_id":"I58a47bb895bede219cfeebbf0665aaf01660ce89","subject":"Extend qos DriverBase with validate_rule_for_port()","status":"MERGED","created":"2020-02-04 14:33:14.000000000","updated":"2020-02-06 01:28:28.000000000","submitted":"2020-02-06 01:24:51.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":9,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"705694-1580952291785-2bde07ed","meta_rev_id":"c856fb41ffb3db306968681537602dc3bc981b15","_number":705694,"virtual_id_number":705694,"owner":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},{"value":0,"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},{"value":0,"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},{"value":0,"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},{"value":0,"_account_id":26106,"name":"Tom Stappaerts","email":"tom.stappaerts@nokia.com","username":"TomStappaerts"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-02-06 01:24:51.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"all":[{"value":2,"date":"2020-02-05 13:39:23.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},{"value":0,"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},{"value":2,"date":"2020-02-05 23:31:22.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},{"value":0,"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},{"value":1,"date":"2020-02-05 14:36:04.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":26106,"name":"Tom Stappaerts","email":"tom.stappaerts@nokia.com","username":"TomStappaerts"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"all":[{"value":0,"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},{"value":0,"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},{"value":1,"date":"2020-02-05 23:31:22.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},{"value":0,"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},{"value":0,"_account_id":26106,"name":"Tom Stappaerts","email":"tom.stappaerts@nokia.com","username":"TomStappaerts"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},{"value":0,"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},{"value":0,"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},{"value":0,"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},{"value":0,"_account_id":26106,"name":"Tom Stappaerts","email":"tom.stappaerts@nokia.com","username":"TomStappaerts"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26106,"name":"Tom Stappaerts","email":"tom.stappaerts@nokia.com","username":"TomStappaerts"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-02-05 06:03:52.000000000","updated_by":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"reviewer":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"state":"REVIEWER"},{"updated":"2020-02-05 13:39:23.000000000","updated_by":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"reviewer":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"state":"REVIEWER"},{"updated":"2020-02-05 14:36:04.000000000","updated_by":{"_account_id":26106,"name":"Tom Stappaerts","email":"tom.stappaerts@nokia.com","username":"TomStappaerts"},"reviewer":{"_account_id":26106,"name":"Tom Stappaerts","email":"tom.stappaerts@nokia.com","username":"TomStappaerts"},"state":"REVIEWER"},{"updated":"2020-02-05 23:31:22.000000000","updated_by":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"reviewer":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"state":"REVIEWER"},{"updated":"2020-02-06 01:24:51.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"1bc17b742e2aa4835d40fbf7aa97992ed74d5c98","author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"date":"2020-02-04 14:33:14.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8668f97516879c92aa7777dc9b4c39e0d1b5f688","author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"date":"2020-02-04 14:35:31.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"4fd7ede83b0ec9c5b5918ce607c1f8af87777579","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-04 15:59:10.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d1d3653134bb484b975b6878acc2f83f : SUCCESS in 6m 18s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/5ef25e2a757b460cba5a8eb76c1a81a3 : SUCCESS in 6m 47s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/87357d328c1a4877b5e035c70f38fd57 : SUCCESS in 5m 42s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/75b778e175984836bbadb396af0c4001 : SUCCESS in 5m 27s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/c0381df1083b4f3095998fc789920f9e : SUCCESS in 4m 57s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/46d45e419c2345fd8abca351f465fdc3 : SUCCESS in 4m 24s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/fca88f1de7f54cce81d22cab9497386c : SUCCESS in 5m 11s (non-voting)\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/d54bb77002884bc696f2bb8778e2002b : SUCCESS in 1h 19m 38s","accounts_in_message":[],"_revision_number":2},{"id":"90c5f2b9551fc4f155b7fee9a4d6f1486ce23661","author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"date":"2020-02-05 06:03:36.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"85d152132e06ac5c84829463e34ebdef0263d570","author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"date":"2020-02-05 09:16:54.000000000","message":"Patch Set 2: Code-Review-1\n\n(3 comments)","accounts_in_message":[],"_revision_number":2},{"id":"b55c4af14bd1412f86a038b146fe03fd2b368f02","author":{"_account_id":26106,"name":"Tom Stappaerts","email":"tom.stappaerts@nokia.com","username":"TomStappaerts"},"date":"2020-02-05 09:45:09.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"07b2ca562e2a485393e2554952d3d4950c01b78f","author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"date":"2020-02-05 13:20:09.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"1557d9f7eea7890541c5ce8e8d31559d853478ff","author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"date":"2020-02-05 13:21:08.000000000","message":"Patch Set 3:\n\n(3 comments)","accounts_in_message":[],"_revision_number":3},{"id":"4a94e03ecd867edf9d989452f02dce6a9cf15f7d","author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"date":"2020-02-05 13:22:18.000000000","message":"Uploaded patch set 4: Commit message was updated.","accounts_in_message":[],"_revision_number":4},{"id":"14cb903344ba52e8910a00ef80a848d6d5bde033","author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"date":"2020-02-05 13:39:23.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"20f2d2fef596ee9fd8839a2abbdbf378c2cc735d","author":{"_account_id":26106,"name":"Tom Stappaerts","email":"tom.stappaerts@nokia.com","username":"TomStappaerts"},"date":"2020-02-05 14:36:04.000000000","message":"Patch Set 4: Code-Review+1","accounts_in_message":[],"_revision_number":4},{"id":"686feff0c8fa1d2bdc21ebabcfc012ae18c0db4f","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-05 14:43:40.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4443127ade2c4febb2c97d8b7a786e34 : SUCCESS in 6m 26s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/e9ba48bd60444b4b8b3b5e515ec8acd7 : SUCCESS in 5m 47s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/7c1dbf6943d54174843587076fc0cb2b : SUCCESS in 5m 35s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/b8b6ca85d0f449258d16bf36dcdf693d : SUCCESS in 5m 10s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/77928d2c3de84ddd8e9f706544c2a91c : SUCCESS in 5m 20s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/26a767dbd6384b24a5c0afa0c7ec3703 : SUCCESS in 4m 41s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/57904216232a43d097154852ab11582e : SUCCESS in 5m 03s (non-voting)\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/33b03b2184a14d3198b1aaa797a30cfa : SUCCESS in 1h 19m 12s","accounts_in_message":[],"_revision_number":4},{"id":"7b9649ab23b7f9f70109c4336f566ae308d042bd","author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"date":"2020-02-05 23:31:22.000000000","message":"Patch Set 4: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":4},{"id":"d22d0ca721f0468a4e677adb57954c3e367f8e78","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-05 23:31:34.000000000","message":"Patch Set 4: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":4},{"id":"b77fe5d48903dc4710ac2748961be85ff2a62e7c","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-06 01:24:51.000000000","message":"Patch Set 4: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/294cc293fb7445df94b7142646a1f098 : SUCCESS in 5m 41s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/f12ade01751c4fd8b61658a0bab58866 : SUCCESS in 7m 06s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/059d921e727f44f68bd62217e5a5b92f : SUCCESS in 6m 26s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/85d72b2a4b624279b8044e4271e1c52d : SUCCESS in 5m 41s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/282845d3e78d4ec9b1e99a9a85f3ba6c : SUCCESS in 7m 33s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/f30062dd93764cae80c16b81e0584069 : SUCCESS in 1h 47m 19s","accounts_in_message":[],"_revision_number":4},{"id":"5553ad5acb5a46d4f8d9cff27b430f86eea41e54","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-06 01:24:51.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":4},{"id":"c8fb2eaf143823f4ea74a0edb4df34e88cca2fb1","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-06 01:28:28.000000000","message":"Patch Set 4:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/1a1861c6bb7c4f18819605ad59ea9beb : SUCCESS in 2m 50s","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"6f3fb7fc8199b8c374e6e97a2e5a617a47b30671","revisions":{"b144986cf59bae552ac9bbf3bb061a04a6e9da6e":{"kind":"REWORK","_number":1,"created":"2020-02-04 14:33:14.000000000","uploader":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"ref":"refs/changes/94/705694/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/neutron-lib","ref":"refs/changes/94/705694/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/neutron-lib refs/changes/94/705694/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/neutron-lib refs/changes/94/705694/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/neutron-lib refs/changes/94/705694/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/neutron-lib refs/changes/94/705694/1"}}},"commit":{"parents":[{"commit":"52f8e49297333aaf2004a1292cd3f12ed17cff6e","subject":"Merge \"[Api-Ref][Docs] Change dns_assignment parameter to be list\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron-lib/commit/52f8e49297333aaf2004a1292cd3f12ed17cff6e"}]}],"author":{"name":"Bence Romsics","email":"bence.romsics@gmail.com","date":"2020-02-04 13:02:22.000000000","tz":60},"committer":{"name":"Bence Romsics","email":"bence.romsics@gmail.com","date":"2020-02-04 14:17:47.000000000","tz":60},"subject":"Extend qos DriverBase with validate_rule_for_port()","message":"Extend qos DriverBase with validate_rule_for_port()\n\nThe openvswitch qos driver supports the min-bw qos rule only on\nnetworks backed by physnets. Currently the qos driver interface does\nnot have a method that takes both the policy/rule and the network/port,\ntherefore we don\u0027t have enough information in the driver to tell if\nwe support the min-bw rule for a port or not. This change introduces\nvalidate_rule_for_port(..., rule, port) so we have all the information\nto tell.\n\nThe base method validate_rule_for_port() is concrete, but does\nnothing (i.e. returns None), therefore other qos drivers\ndo not need to override this method explicitly. Their behavior\nremains the same without code change.\n\nChange-Id: I58a47bb895bede219cfeebbf0665aaf01660ce89\nNeeded-By: I02d77a03c411dc8ab303a7d7b53d7ea93cc9f4c6\nPartial-Bug: #1861442\nRelated-Bug: #1819029\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron-lib/commit/b144986cf59bae552ac9bbf3bb061a04a6e9da6e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron-lib/commit/b144986cf59bae552ac9bbf3bb061a04a6e9da6e"}]},"branch":"refs/heads/master"},"d247c29adefabfc025981dc2a5b70021a33e3a66":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2020-02-04 14:35:31.000000000","uploader":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"ref":"refs/changes/94/705694/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/neutron-lib","ref":"refs/changes/94/705694/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/neutron-lib refs/changes/94/705694/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/neutron-lib refs/changes/94/705694/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/neutron-lib refs/changes/94/705694/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/neutron-lib refs/changes/94/705694/2"}}},"commit":{"parents":[{"commit":"52f8e49297333aaf2004a1292cd3f12ed17cff6e","subject":"Merge \"[Api-Ref][Docs] Change dns_assignment parameter to be list\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron-lib/commit/52f8e49297333aaf2004a1292cd3f12ed17cff6e"}]}],"author":{"name":"Bence Romsics","email":"bence.romsics@gmail.com","date":"2020-02-04 13:02:22.000000000","tz":60},"committer":{"name":"Bence Romsics","email":"bence.romsics@gmail.com","date":"2020-02-04 14:34:54.000000000","tz":60},"subject":"Extend qos DriverBase with validate_rule_for_port()","message":"Extend qos DriverBase with validate_rule_for_port()\n\nThe openvswitch qos driver supports the min-bw qos rule only on\nnetworks backed by physnets. Currently the qos driver interface does\nnot have a method that takes both the policy/rule and the network/port,\ntherefore we don\u0027t have enough information in the driver to tell if\nwe support the min-bw rule for a port or not. This change introduces\nvalidate_rule_for_port(..., rule, port) so we have all the information\nto tell.\n\nThe base method validate_rule_for_port() is concrete, but does\nnothing (i.e. returns None), therefore other qos drivers\ndo not need to override this method explicitly. Their behavior\nremains the same without code change.\n\nChange-Id: I58a47bb895bede219cfeebbf0665aaf01660ce89\nNeeded-By: https://review.opendev.org/705695\nPartial-Bug: #1861442\nRelated-Bug: #1819029\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron-lib/commit/d247c29adefabfc025981dc2a5b70021a33e3a66"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron-lib/commit/d247c29adefabfc025981dc2a5b70021a33e3a66"}]},"branch":"refs/heads/master"},"b9dd399bab16149cd43a784eb391b56efc2918e0":{"kind":"REWORK","_number":3,"created":"2020-02-05 13:20:09.000000000","uploader":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"ref":"refs/changes/94/705694/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/neutron-lib","ref":"refs/changes/94/705694/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/neutron-lib refs/changes/94/705694/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/neutron-lib refs/changes/94/705694/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/neutron-lib refs/changes/94/705694/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/neutron-lib refs/changes/94/705694/3"}}},"commit":{"parents":[{"commit":"52f8e49297333aaf2004a1292cd3f12ed17cff6e","subject":"Merge \"[Api-Ref][Docs] Change dns_assignment parameter to be list\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron-lib/commit/52f8e49297333aaf2004a1292cd3f12ed17cff6e"}]}],"author":{"name":"Bence Romsics","email":"bence.romsics@gmail.com","date":"2020-02-04 13:02:22.000000000","tz":60},"committer":{"name":"Bence Romsics","email":"bence.romsics@gmail.com","date":"2020-02-05 13:18:48.000000000","tz":60},"subject":"Extend qos DriverBase with validate_rule_for_port()","message":"Extend qos DriverBase with validate_rule_for_port()\n\nThe openvswitch qos driver supports the min-bw qos rule only on\nnetworks backed by physnets. Currently the qos driver interface does\nnot have a method that takes both the policy/rule and the network/port,\ntherefore we don\u0027t have enough information in the driver to tell if\nwe support the min-bw rule for a port or not. This change introduces\nvalidate_rule_for_port(..., rule, port) so we have all the information\nto tell.\n\nThe base method validate_rule_for_port() is concrete, but does\nnothing (i.e. returns None), therefore other qos drivers\ndo not need to override this method explicitly. Their behavior\nremains the same without code change.\n\nChange-Id: I58a47bb895bede219cfeebbf0665aaf01660ce89\nNeeded-By: https://review.opendev.org/705695\nPartial-Bug: #1861442\nRelated-Bug: #1819029\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron-lib/commit/b9dd399bab16149cd43a784eb391b56efc2918e0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron-lib/commit/b9dd399bab16149cd43a784eb391b56efc2918e0"}]},"branch":"refs/heads/master"},"6f3fb7fc8199b8c374e6e97a2e5a617a47b30671":{"kind":"NO_CODE_CHANGE","_number":4,"created":"2020-02-05 13:22:18.000000000","uploader":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"ref":"refs/changes/94/705694/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/neutron-lib","ref":"refs/changes/94/705694/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/neutron-lib refs/changes/94/705694/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/neutron-lib refs/changes/94/705694/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/neutron-lib refs/changes/94/705694/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/neutron-lib refs/changes/94/705694/4"}}},"commit":{"parents":[{"commit":"52f8e49297333aaf2004a1292cd3f12ed17cff6e","subject":"Merge \"[Api-Ref][Docs] Change dns_assignment parameter to be list\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron-lib/commit/52f8e49297333aaf2004a1292cd3f12ed17cff6e"}]}],"author":{"name":"Bence Romsics","email":"bence.romsics@gmail.com","date":"2020-02-04 13:02:22.000000000","tz":60},"committer":{"name":"Bence Romsics","email":"bence.romsics@gmail.com","date":"2020-02-05 13:21:10.000000000","tz":60},"subject":"Extend qos DriverBase with validate_rule_for_port()","message":"Extend qos DriverBase with validate_rule_for_port()\n\nThe openvswitch qos driver supports the min-bw qos rule only on\nnetworks backed by physnets. Currently the qos driver interface does\nnot have a method that takes both the policy/rule and the network/port,\ntherefore we don\u0027t have enough information in the driver to tell if\nwe support the min-bw rule for a port or not. This change introduces\nvalidate_rule_for_port(..., rule, port) so we have all the information\nto tell.\n\nThe base method validate_rule_for_port() is concrete and returns True\nfor backwards compatibility.\n\nChange-Id: I58a47bb895bede219cfeebbf0665aaf01660ce89\nNeeded-By: https://review.opendev.org/705695\nPartial-Bug: #1861442\nRelated-Bug: #1819029\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron-lib/commit/6f3fb7fc8199b8c374e6e97a2e5a617a47b30671"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron-lib/commit/6f3fb7fc8199b8c374e6e97a2e5a617a47b30671"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}