)]}'
{"neutron_lib/context.py":[{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"f2909d78653b77d253ab409a0b248cf29505305b","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        # TODO(akamyshnikova): checking for session attribute won\u0027t be needed"},{"line_number":147,"context_line":"        # when reader and writer will be used"},{"line_number":148,"context_line":"        if hasattr(super(Context, self), \u0027session\u0027):"},{"line_number":149,"context_line":"            # NOTE(ralonsoh): if self._session, context.session is used with"},{"line_number":150,"context_line":"            # and without new engine facade. The code should be updated to use"},{"line_number":151,"context_line":"            # new enginefacede consistently. No warning is written here to"},{"line_number":152,"context_line":"            # to avoid log pollution."},{"line_number":153,"context_line":"            return super(Context, self).session"},{"line_number":154,"context_line":"        if self._session is None:"},{"line_number":155,"context_line":"            self._session \u003d db_api.get_writer_session()"},{"line_number":156,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1fa4df85_b45fb370","line":153,"range":{"start_line":149,"start_character":0,"end_line":153,"end_character":1},"updated":"2020-03-02 21:52:44.000000000","message":"There are cases when the difference between new and old facade access patterns can cause issues; I would think about making this a debug level message at least so that we don\u0027t lose all visibility into facade cross-accessing.","commit_id":"275da58fc95bb99795902313be47a895d3e67775"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"c980e17f0095cded9a8f79e7d88d7f8a1bc5232e","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        # TODO(akamyshnikova): checking for session attribute won\u0027t be needed"},{"line_number":147,"context_line":"        # when reader and writer will be used"},{"line_number":148,"context_line":"        if hasattr(super(Context, self), \u0027session\u0027):"},{"line_number":149,"context_line":"            # NOTE(ralonsoh): if self._session, context.session is used with"},{"line_number":150,"context_line":"            # and without new engine facade. The code should be updated to use"},{"line_number":151,"context_line":"            # new enginefacede consistently. No warning is written here to"},{"line_number":152,"context_line":"            # to avoid log pollution."},{"line_number":153,"context_line":"            return super(Context, self).session"},{"line_number":154,"context_line":"        if self._session is None:"},{"line_number":155,"context_line":"            self._session \u003d db_api.get_writer_session()"},{"line_number":156,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1fa4df85_ed90f945","line":153,"range":{"start_line":149,"start_character":0,"end_line":153,"end_character":1},"in_reply_to":"1fa4df85_b45fb370","updated":"2020-03-03 10:37:55.000000000","message":"I agree that maybe lowering it to debug level would be better idea","commit_id":"275da58fc95bb99795902313be47a895d3e67775"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6ea1a284b11dc95e98299c6853ca27ef8fd98bf5","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        # TODO(akamyshnikova): checking for session attribute won\u0027t be needed"},{"line_number":147,"context_line":"        # when reader and writer will be used"},{"line_number":148,"context_line":"        if hasattr(super(Context, self), \u0027session\u0027):"},{"line_number":149,"context_line":"            # NOTE(ralonsoh): if self._session, context.session is used with"},{"line_number":150,"context_line":"            # and without new engine facade. The code should be updated to use"},{"line_number":151,"context_line":"            # new enginefacede consistently. No warning is written here to"},{"line_number":152,"context_line":"            # to avoid log pollution."},{"line_number":153,"context_line":"            return super(Context, self).session"},{"line_number":154,"context_line":"        if self._session is None:"},{"line_number":155,"context_line":"            self._session \u003d db_api.get_writer_session()"},{"line_number":156,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1fa4df85_0d323560","line":153,"range":{"start_line":149,"start_character":0,"end_line":153,"end_character":1},"in_reply_to":"1fa4df85_ed90f945","updated":"2020-03-03 10:45:51.000000000","message":"Thanks for the suggestion. I\u0027ll make it a debug log message.","commit_id":"275da58fc95bb99795902313be47a895d3e67775"}]}