)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"ef84f2b4f2d626d1fda86ed14050020cb1017139","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Revert \"Remove warning message when using old and new engine facade\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Partial revert. We made a mistake including this log message every"},{"line_number":10,"context_line":"time this condition happens. Now the Neutron server debug logs are"},{"line_number":11,"context_line":"polluted with this message."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This reverts commit 77b761dfe438f7a2d61dac3337b65d0f9d85c20b."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1fa4df85_12ee9fb3","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":27},"updated":"2020-03-05 17:51:29.000000000","message":"Were the previous warnings - before the original change - just dropped?  At least if they are debug messages then you can set the loglevel to filter them out.","commit_id":"1452cd8759dd7f5ef31f5dc03562afee22616136"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"8ccd9cc638ffb4f4fe2e641fee98347eff8e1696","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Revert \"Remove warning message when using old and new engine facade\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Partial revert. We made a mistake including this log message every"},{"line_number":10,"context_line":"time this condition happens. Now the Neutron server debug logs are"},{"line_number":11,"context_line":"polluted with this message."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1fa4df85_ea01686b","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":14},"updated":"2020-03-09 10:27:08.000000000","message":"Wording nit, back to full revert now if I see correctly","commit_id":"cbd4e77dac55f80047eb979f4cd9c528cd929c0d"}],"neutron_lib/context.py":[{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"ef84f2b4f2d626d1fda86ed14050020cb1017139","unresolved":false,"context_lines":[{"line_number":149,"context_line":"            # NOTE(ralonsoh): if self._session, then context.session is used"},{"line_number":150,"context_line":"            # with and without new enginefacade. Please update the code to"},{"line_number":151,"context_line":"            # use new enginefacede consistently."},{"line_number":152,"context_line":"            return super(Context, self).session"},{"line_number":153,"context_line":"        if self._session is None:"},{"line_number":154,"context_line":"            self._session \u003d db_api.get_writer_session()"},{"line_number":155,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_52265717","line":152,"updated":"2020-03-05 17:51:29.000000000","message":"I restate my opposition to silently dropping these messages as expressed in [1].\n\n[1] https://review.opendev.org/#/c/710557/2/neutron_lib/context.py@153","commit_id":"1452cd8759dd7f5ef31f5dc03562afee22616136"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"8aa00a6df6b1dde5de7480b5477ba4b87de9ca03","unresolved":false,"context_lines":[{"line_number":149,"context_line":"            # NOTE(ralonsoh): if self._session, then context.session is used"},{"line_number":150,"context_line":"            # with and without new enginefacade. Please update the code to"},{"line_number":151,"context_line":"            # use new enginefacede consistently."},{"line_number":152,"context_line":"            return super(Context, self).session"},{"line_number":153,"context_line":"        if self._session is None:"},{"line_number":154,"context_line":"            self._session \u003d db_api.get_writer_session()"},{"line_number":155,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_c16a6e18","line":152,"in_reply_to":"1fa4df85_52265717","updated":"2020-03-06 09:53:37.000000000","message":"My original intention was to remove, completely, any warning or logging message.\n\nwarning.warn() message: this is printed only once in the logs, the very first time this condition happens. This will help to not pollute the logs, but it will be shown in each UT/FT, at the beginning. This is useless and unsightly.\n\nlog.debug() message: that was an error. With this message, every time we have this condition will print a debug message in the logs. That means 1 out of 3 debug message lines are this message. We can\u0027t allow this and that\u0027s why I\u0027m reverting the patch.\n\nIf this partial revert is not accepted, I\u0027ll take back the warning message. But as I said, in a production/development environment, this message will be printed only once, at the beginning. And this message does not provide any needed information apart from being a reminder of an unfinished task.","commit_id":"1452cd8759dd7f5ef31f5dc03562afee22616136"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"5fcbda5c4e02598e0ec35e01ba84454924519147","unresolved":false,"context_lines":[{"line_number":149,"context_line":"            # NOTE(ralonsoh): if self._session, then context.session is used"},{"line_number":150,"context_line":"            # with and without new enginefacade. Please update the code to"},{"line_number":151,"context_line":"            # use new enginefacede consistently."},{"line_number":152,"context_line":"            return super(Context, self).session"},{"line_number":153,"context_line":"        if self._session is None:"},{"line_number":154,"context_line":"            self._session \u003d db_api.get_writer_session()"},{"line_number":155,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_8ad23427","line":152,"in_reply_to":"1fa4df85_8ae9d4e6","updated":"2020-03-09 10:13:35.000000000","message":"Done","commit_id":"1452cd8759dd7f5ef31f5dc03562afee22616136"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a6e2fd0f97d31eef23ce4b72ae1606501d8416a5","unresolved":false,"context_lines":[{"line_number":149,"context_line":"            # NOTE(ralonsoh): if self._session, then context.session is used"},{"line_number":150,"context_line":"            # with and without new enginefacade. Please update the code to"},{"line_number":151,"context_line":"            # use new enginefacede consistently."},{"line_number":152,"context_line":"            return super(Context, self).session"},{"line_number":153,"context_line":"        if self._session is None:"},{"line_number":154,"context_line":"            self._session \u003d db_api.get_writer_session()"},{"line_number":155,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1fa4df85_8ae9d4e6","line":152,"in_reply_to":"1fa4df85_c16a6e18","updated":"2020-03-09 10:10:09.000000000","message":"I would then go with revert to use warnings.warn() and maybe if You don\u0027t want it in UT, You can add it to the ignored list there, see e.g. https://github.com/openstack/neutron/blob/master/neutron/tests/functional/base.py#L73","commit_id":"1452cd8759dd7f5ef31f5dc03562afee22616136"}]}