)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"69c5942c5704d42aa3b504db1540a42208b307e4","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Update agent\u0027s attrs can be sorted"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We have hundreds of neutron agents deployed, but currently, the"},{"line_number":10,"context_line":"agent list API does not support sorting and paging, which is very bad."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I5fd3b77d4033d5b8de048369e98e6ebb12fcdae6"},{"line_number":13,"context_line":"Related-Bug: #1877254"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff570b3c_e2c1c882","line":10,"range":{"start_line":10,"start_character":32,"end_line":10,"end_character":50},"updated":"2020-05-11 12:37:06.000000000","message":"this commit doesn\u0027t deal with pagination, plesae describe the fix, not the bug","commit_id":"6429a4bf45f20d04a22cfa3b83dad8a7d317fc0f"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"69c5942c5704d42aa3b504db1540a42208b307e4","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We have hundreds of neutron agents deployed, but currently, the"},{"line_number":10,"context_line":"agent list API does not support sorting and paging, which is very bad."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I5fd3b77d4033d5b8de048369e98e6ebb12fcdae6"},{"line_number":13,"context_line":"Related-Bug: #1877254"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff570b3c_62d65852","line":11,"updated":"2020-05-11 12:37:06.000000000","message":"ApiImpact?","commit_id":"6429a4bf45f20d04a22cfa3b83dad8a7d317fc0f"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"377bab7e9664df95e44dc656bbc8f4ca07075abc","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We have hundreds of neutron agents deployed, but currently, the"},{"line_number":10,"context_line":"agent list API does not support sorting and paging, which is very bad."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I5fd3b77d4033d5b8de048369e98e6ebb12fcdae6"},{"line_number":13,"context_line":"Related-Bug: #1877254"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff570b3c_8409e032","line":11,"in_reply_to":"ff570b3c_62d65852","updated":"2020-05-26 08:51:29.000000000","message":"In neutron we usually try to make api changes (both to api syntax and semantics) discoverable through the api itself (via so-called api extensions). The simplest extension - which just practically flags the change - is called a shim extension, here\u0027s an example of how to do it:\n\nhttps://review.opendev.org/700754","commit_id":"6429a4bf45f20d04a22cfa3b83dad8a7d317fc0f"},{"author":{"_account_id":30804,"name":"yangkai","email":"yangkaimoda@qq.com","username":"yangkai"},"change_message_id":"2842ef2bc63bd4eb3e2a5f12aa9786a484d7abc6","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We have hundreds of neutron agents deployed, but currently, the"},{"line_number":10,"context_line":"agent list API does not support sorting and paging, which is very bad."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I5fd3b77d4033d5b8de048369e98e6ebb12fcdae6"},{"line_number":13,"context_line":"Related-Bug: #1877254"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff570b3c_72b8e729","line":11,"in_reply_to":"ff570b3c_62d65852","updated":"2020-06-01 07:16:58.000000000","message":"what does it mean?","commit_id":"6429a4bf45f20d04a22cfa3b83dad8a7d317fc0f"}],"api-ref/source/v2/parameters.yaml":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"4417fee0325e28acf7e7450afbebf5f40362028f","unresolved":false,"context_lines":[{"line_number":1495,"context_line":"  required: true"},{"line_number":1496,"context_line":"  type: object"},{"line_number":1497,"context_line":"  type: string"},{"line_number":1498,"context_line":"agent-sort_key:"},{"line_number":1499,"context_line":"  description: |"},{"line_number":1500,"context_line":"    Sorts by a agent attribute. You can specify multiple pairs of sort key"},{"line_number":1501,"context_line":"    and sort direction query parameters. The sort keys are limited to:"},{"line_number":1502,"context_line":""},{"line_number":1503,"context_line":"    - ``id``"},{"line_number":1504,"context_line":"    - ``agent_type``"},{"line_number":1505,"context_line":"    - ``binary``"},{"line_number":1506,"context_line":"    - ``topic``"},{"line_number":1507,"context_line":"    - ``host``"},{"line_number":1508,"context_line":"    - ``admin_state_up``"},{"line_number":1509,"context_line":"    - ``created_at``"},{"line_number":1510,"context_line":"    - ``started_at``"},{"line_number":1511,"context_line":"    - ``heartbeat_timestamp``"},{"line_number":1512,"context_line":"    - ``alive``"},{"line_number":1513,"context_line":"    - ``configurations``"},{"line_number":1514,"context_line":"    - ``description``"},{"line_number":1515,"context_line":"  in: query"},{"line_number":1516,"context_line":"  required: false"},{"line_number":1517,"context_line":"  type: string"},{"line_number":1518,"context_line":"agent_resources_synced:"},{"line_number":1519,"context_line":"  description: |"},{"line_number":1520,"context_line":"    The value ``null`` means no resource view synchronization to Placement"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ff570b3c_dd70d8df","line":1517,"range":{"start_line":1498,"start_character":0,"end_line":1517,"end_character":14},"updated":"2020-05-25 14:54:52.000000000","message":"You have to move this section up to # variables in query section (see l.294)","commit_id":"822457915e86f7068e0f89d9864e8aeae9c1849d"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"377bab7e9664df95e44dc656bbc8f4ca07075abc","unresolved":false,"context_lines":[{"line_number":329,"context_line":"  type: boolean"},{"line_number":330,"context_line":"agent-sort_key:"},{"line_number":331,"context_line":"  description: |"},{"line_number":332,"context_line":"    Sorts by a agent attribute. You can specify multiple pairs of sort key"},{"line_number":333,"context_line":"    and sort direction query parameters. The sort keys are limited to:"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"    - ``id``"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ff570b3c_a426a415","line":332,"range":{"start_line":332,"start_character":13,"end_line":332,"end_character":30},"updated":"2020-05-26 08:51:29.000000000","message":"nit: agent attribute(s)","commit_id":"236f57e819e9588a92878b10043ec0fb0c22ccee"},{"author":{"_account_id":30804,"name":"yangkai","email":"yangkaimoda@qq.com","username":"yangkai"},"change_message_id":"2842ef2bc63bd4eb3e2a5f12aa9786a484d7abc6","unresolved":false,"context_lines":[{"line_number":329,"context_line":"  type: boolean"},{"line_number":330,"context_line":"agent-sort_key:"},{"line_number":331,"context_line":"  description: |"},{"line_number":332,"context_line":"    Sorts by a agent attribute. You can specify multiple pairs of sort key"},{"line_number":333,"context_line":"    and sort direction query parameters. The sort keys are limited to:"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"    - ``id``"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ff570b3c_56228153","line":332,"range":{"start_line":332,"start_character":13,"end_line":332,"end_character":30},"in_reply_to":"ff570b3c_a426a415","updated":"2020-06-01 07:16:58.000000000","message":"Done","commit_id":"236f57e819e9588a92878b10043ec0fb0c22ccee"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"377bab7e9664df95e44dc656bbc8f4ca07075abc","unresolved":false,"context_lines":[{"line_number":332,"context_line":"    Sorts by a agent attribute. You can specify multiple pairs of sort key"},{"line_number":333,"context_line":"    and sort direction query parameters. The sort keys are limited to:"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"    - ``id``"},{"line_number":336,"context_line":"    - ``agent_type``"},{"line_number":337,"context_line":"    - ``binary``"},{"line_number":338,"context_line":"    - ``topic``"},{"line_number":339,"context_line":"    - ``host``"},{"line_number":340,"context_line":"    - ``admin_state_up``"},{"line_number":341,"context_line":"    - ``created_at``"},{"line_number":342,"context_line":"    - ``started_at``"},{"line_number":343,"context_line":"    - ``heartbeat_timestamp``"},{"line_number":344,"context_line":"    - ``alive``"},{"line_number":345,"context_line":"    - ``configurations``"},{"line_number":346,"context_line":"    - ``description``"},{"line_number":347,"context_line":"  in: query"},{"line_number":348,"context_line":"  required: false"},{"line_number":349,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ff570b3c_047dd0e6","line":346,"range":{"start_line":335,"start_character":0,"end_line":346,"end_character":21},"updated":"2020-05-26 08:51:29.000000000","message":"nit: Listing them in alphabetical order would be a bit more reader-friendly. \u0027configurations\u0027 may be removed as commented in the other file.","commit_id":"236f57e819e9588a92878b10043ec0fb0c22ccee"},{"author":{"_account_id":30804,"name":"yangkai","email":"yangkaimoda@qq.com","username":"yangkai"},"change_message_id":"2842ef2bc63bd4eb3e2a5f12aa9786a484d7abc6","unresolved":false,"context_lines":[{"line_number":332,"context_line":"    Sorts by a agent attribute. You can specify multiple pairs of sort key"},{"line_number":333,"context_line":"    and sort direction query parameters. The sort keys are limited to:"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"    - ``id``"},{"line_number":336,"context_line":"    - ``agent_type``"},{"line_number":337,"context_line":"    - ``binary``"},{"line_number":338,"context_line":"    - ``topic``"},{"line_number":339,"context_line":"    - ``host``"},{"line_number":340,"context_line":"    - ``admin_state_up``"},{"line_number":341,"context_line":"    - ``created_at``"},{"line_number":342,"context_line":"    - ``started_at``"},{"line_number":343,"context_line":"    - ``heartbeat_timestamp``"},{"line_number":344,"context_line":"    - ``alive``"},{"line_number":345,"context_line":"    - ``configurations``"},{"line_number":346,"context_line":"    - ``description``"},{"line_number":347,"context_line":"  in: query"},{"line_number":348,"context_line":"  required: false"},{"line_number":349,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ff570b3c_361f0d09","line":346,"range":{"start_line":335,"start_character":0,"end_line":346,"end_character":21},"in_reply_to":"ff570b3c_047dd0e6","updated":"2020-06-01 07:16:58.000000000","message":"Done","commit_id":"236f57e819e9588a92878b10043ec0fb0c22ccee"}],"neutron_lib/api/definitions/agent.py":[{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"377bab7e9664df95e44dc656bbc8f4ca07075abc","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                  \u0027is_sort_key\u0027: True,"},{"line_number":63,"context_line":"                  \u0027is_filter\u0027: True, \u0027is_visible\u0027: True},"},{"line_number":64,"context_line":"        \u0027configurations\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":65,"context_line":"                           \u0027is_sort_key\u0027: True,"},{"line_number":66,"context_line":"                           \u0027is_visible\u0027: True},"},{"line_number":67,"context_line":"        \u0027description\u0027: {"},{"line_number":68,"context_line":"            \u0027allow_post\u0027: False, \u0027allow_put\u0027: True,"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff570b3c_a43d042e","line":65,"updated":"2020-05-26 08:51:29.000000000","message":"The \u0027configurations\u0027 field is an arbitrary dict, while technically possible, I don\u0027t think anybody would ever want to sort on this field.","commit_id":"236f57e819e9588a92878b10043ec0fb0c22ccee"},{"author":{"_account_id":30804,"name":"yangkai","email":"yangkaimoda@qq.com","username":"yangkai"},"change_message_id":"2842ef2bc63bd4eb3e2a5f12aa9786a484d7abc6","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                  \u0027is_sort_key\u0027: True,"},{"line_number":63,"context_line":"                  \u0027is_filter\u0027: True, \u0027is_visible\u0027: True},"},{"line_number":64,"context_line":"        \u0027configurations\u0027: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":65,"context_line":"                           \u0027is_sort_key\u0027: True,"},{"line_number":66,"context_line":"                           \u0027is_visible\u0027: True},"},{"line_number":67,"context_line":"        \u0027description\u0027: {"},{"line_number":68,"context_line":"            \u0027allow_post\u0027: False, \u0027allow_put\u0027: True,"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff570b3c_9618991e","line":65,"in_reply_to":"ff570b3c_a43d042e","updated":"2020-06-01 07:16:58.000000000","message":"Done","commit_id":"236f57e819e9588a92878b10043ec0fb0c22ccee"}]}