)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"eef95a4620cb79604d6c1f2979ec39eada7671a1","unresolved":false,"context_lines":[{"line_number":23,"context_line":"anywhere."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Because of those two reasons we should define new device_owner"},{"line_number":26,"context_line":"and threat it differently in Neutron API, to unlock the OVN"},{"line_number":27,"context_line":"distributed services potential and to not use the same port_type"},{"line_number":28,"context_line":"for Neutron not-distributed services."},{"line_number":29,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff570b3c_db899975","line":26,"range":{"start_line":26,"start_character":56,"end_line":26,"end_character":59},"updated":"2020-06-01 10:12:36.000000000","message":"The main use case now is for OVN but generally makes sense and this could be potentially used by other drivers eventually.","commit_id":"25e23e2e47f334e8b322b9e3bcb2b93e87325dba"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"eef95a4620cb79604d6c1f2979ec39eada7671a1","unresolved":false,"context_lines":[{"line_number":23,"context_line":"anywhere."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Because of those two reasons we should define new device_owner"},{"line_number":26,"context_line":"and threat it differently in Neutron API, to unlock the OVN"},{"line_number":27,"context_line":"distributed services potential and to not use the same port_type"},{"line_number":28,"context_line":"for Neutron not-distributed services."},{"line_number":29,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff570b3c_7bafade2","line":26,"range":{"start_line":26,"start_character":4,"end_line":26,"end_character":10},"updated":"2020-06-01 10:12:36.000000000","message":"treat","commit_id":"25e23e2e47f334e8b322b9e3bcb2b93e87325dba"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"85af0ed90e40ef0a89476f1577378c8d3f585539","unresolved":false,"context_lines":[{"line_number":23,"context_line":"anywhere."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Because of those two reasons we should define new device_owner"},{"line_number":26,"context_line":"and threat it differently in Neutron API, to unlock the OVN"},{"line_number":27,"context_line":"distributed services potential and to not use the same port_type"},{"line_number":28,"context_line":"for Neutron not-distributed services."},{"line_number":29,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff570b3c_fb373daf","line":26,"range":{"start_line":26,"start_character":4,"end_line":26,"end_character":10},"in_reply_to":"ff570b3c_7bafade2","updated":"2020-06-01 10:21:44.000000000","message":"++","commit_id":"25e23e2e47f334e8b322b9e3bcb2b93e87325dba"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"85af0ed90e40ef0a89476f1577378c8d3f585539","unresolved":false,"context_lines":[{"line_number":23,"context_line":"anywhere."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Because of those two reasons we should define new device_owner"},{"line_number":26,"context_line":"and threat it differently in Neutron API, to unlock the OVN"},{"line_number":27,"context_line":"distributed services potential and to not use the same port_type"},{"line_number":28,"context_line":"for Neutron not-distributed services."},{"line_number":29,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff570b3c_db3cf994","line":26,"range":{"start_line":26,"start_character":56,"end_line":26,"end_character":59},"in_reply_to":"ff570b3c_db899975","updated":"2020-06-01 10:21:44.000000000","message":"++","commit_id":"25e23e2e47f334e8b322b9e3bcb2b93e87325dba"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"eef95a4620cb79604d6c1f2979ec39eada7671a1","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Because of those two reasons we should define new device_owner"},{"line_number":26,"context_line":"and threat it differently in Neutron API, to unlock the OVN"},{"line_number":27,"context_line":"distributed services potential and to not use the same port_type"},{"line_number":28,"context_line":"for Neutron not-distributed services."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"[1] https://www.ovn.org/support/dist-docs/ovn-nb.5.txt"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff570b3c_bbb5c534","line":27,"range":{"start_line":27,"start_character":21,"end_line":27,"end_character":30},"updated":"2020-06-01 10:12:36.000000000","message":"? Not sure what you mean... maybe to potentially unlock the OVN distributed services?\nBut we\u0027d be unlocking them with this, right?","commit_id":"25e23e2e47f334e8b322b9e3bcb2b93e87325dba"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"85af0ed90e40ef0a89476f1577378c8d3f585539","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Because of those two reasons we should define new device_owner"},{"line_number":26,"context_line":"and threat it differently in Neutron API, to unlock the OVN"},{"line_number":27,"context_line":"distributed services potential and to not use the same port_type"},{"line_number":28,"context_line":"for Neutron not-distributed services."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"[1] https://www.ovn.org/support/dist-docs/ovn-nb.5.txt"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff570b3c_1b431115","line":27,"range":{"start_line":27,"start_character":21,"end_line":27,"end_character":30},"in_reply_to":"ff570b3c_bbb5c534","updated":"2020-06-01 10:21:44.000000000","message":"Sorry, that is my Ponglish. Word: benefits suits more here.","commit_id":"25e23e2e47f334e8b322b9e3bcb2b93e87325dba"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"eef95a4620cb79604d6c1f2979ec39eada7671a1","unresolved":false,"context_lines":[{"line_number":25,"context_line":"Because of those two reasons we should define new device_owner"},{"line_number":26,"context_line":"and threat it differently in Neutron API, to unlock the OVN"},{"line_number":27,"context_line":"distributed services potential and to not use the same port_type"},{"line_number":28,"context_line":"for Neutron not-distributed services."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"[1] https://www.ovn.org/support/dist-docs/ovn-nb.5.txt"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff570b3c_9bb28148","line":28,"range":{"start_line":28,"start_character":12,"end_line":28,"end_character":15},"updated":"2020-06-01 10:12:36.000000000","message":"nit: non","commit_id":"25e23e2e47f334e8b322b9e3bcb2b93e87325dba"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"85af0ed90e40ef0a89476f1577378c8d3f585539","unresolved":false,"context_lines":[{"line_number":25,"context_line":"Because of those two reasons we should define new device_owner"},{"line_number":26,"context_line":"and threat it differently in Neutron API, to unlock the OVN"},{"line_number":27,"context_line":"distributed services potential and to not use the same port_type"},{"line_number":28,"context_line":"for Neutron not-distributed services."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"[1] https://www.ovn.org/support/dist-docs/ovn-nb.5.txt"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff570b3c_7b4b2d2a","line":28,"range":{"start_line":28,"start_character":12,"end_line":28,"end_character":15},"in_reply_to":"ff570b3c_9bb28148","updated":"2020-06-01 10:21:44.000000000","message":"++","commit_id":"25e23e2e47f334e8b322b9e3bcb2b93e87325dba"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"bcd19176a7e6355004b4adb7f3614ac2719b2169","unresolved":false,"context_lines":[{"line_number":26,"context_line":"and treat it differently in Neutron API, to unlock the OVN"},{"line_number":27,"context_line":"distributed services benefits and to not use the same port_type"},{"line_number":28,"context_line":"for Neutron non-distributed services."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"[1] https://www.ovn.org/support/dist-docs/ovn-nb.5.txt"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Change-Id: I53828ec6e1f0d2861eebfadcb9d46551fbf1a6af"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bf51134e_fd9ddf59","line":29,"updated":"2020-06-16 12:41:35.000000000","message":"Thanks for detailed commit msg","commit_id":"a14e812be5e21e4234c147a19046363e043c343a"}],"neutron_lib/constants.py":[{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"eef95a4620cb79604d6c1f2979ec39eada7671a1","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"# NOTE(mjozefcz): Device owner for OVN distributed services"},{"line_number":68,"context_line":"# like Metadata and DHCP."},{"line_number":69,"context_line":"DEVICE_OWNER_OVN_DISTRIBUTED \u003d DEVICE_OWNER_NEUTRON_PREFIX + \"ovn_distributed\""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"DEVICE_OWNER_PREFIXES \u003d (DEVICE_OWNER_NETWORK_PREFIX,"},{"line_number":72,"context_line":"                         DEVICE_OWNER_NEUTRON_PREFIX)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_bb8e6576","line":69,"range":{"start_line":69,"start_character":13,"end_line":69,"end_character":17},"updated":"2020-06-01 10:12:36.000000000","message":"I\u0027d be more in favor of doing it generic. What about DEVICE_OWNER_DISTRIBUTED ?\nWhile OVN is the primary use case at the moment, it seems generic to me.","commit_id":"25e23e2e47f334e8b322b9e3bcb2b93e87325dba"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"46cc83dd3a16bce96ce0cc4e3b6bcd8aaa79d9c8","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"# NOTE(mjozefcz): Device owner for OVN distributed services"},{"line_number":68,"context_line":"# like Metadata and DHCP."},{"line_number":69,"context_line":"DEVICE_OWNER_OVN_DISTRIBUTED \u003d DEVICE_OWNER_NEUTRON_PREFIX + \"ovn_distributed\""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"DEVICE_OWNER_PREFIXES \u003d (DEVICE_OWNER_NETWORK_PREFIX,"},{"line_number":72,"context_line":"                         DEVICE_OWNER_NEUTRON_PREFIX)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff570b3c_9be0c128","line":69,"range":{"start_line":69,"start_character":13,"end_line":69,"end_character":17},"in_reply_to":"ff570b3c_bb8e6576","updated":"2020-06-01 10:18:24.000000000","message":"Yeah that\u0027s the thing if we should call it \u0027OVN\u0027 or not.\n\nLets wait for other opinions on that.","commit_id":"25e23e2e47f334e8b322b9e3bcb2b93e87325dba"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"52e1e1d186a8f47df28af761f350ee9d1ec2f1bb","unresolved":false,"context_lines":[{"line_number":64,"context_line":"DEVICE_OWNER_LOADBALANCER \u003d DEVICE_OWNER_NEUTRON_PREFIX + \"LOADBALANCER\""},{"line_number":65,"context_line":"DEVICE_OWNER_LOADBALANCERV2 \u003d DEVICE_OWNER_NEUTRON_PREFIX + \"LOADBALANCERV2\""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"# NOTE(mjozefcz): Device owner for OVN distributed services"},{"line_number":68,"context_line":"# like Metadata and DHCP."},{"line_number":69,"context_line":"DEVICE_OWNER_DISTRIBUTED \u003d DEVICE_OWNER_NEUTRON_PREFIX + \"distributed\""},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_7f1f9207","line":67,"range":{"start_line":67,"start_character":2,"end_line":67,"end_character":17},"updated":"2020-06-01 14:46:26.000000000","message":"nit: shouldn\u0027t need the NOTE here, just a comment","commit_id":"1c674c01a88999a0003e5e9b265bc641a3b147f3"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"7b8affd7eea6c2b46afb96ab54438eda3fab737a","unresolved":false,"context_lines":[{"line_number":64,"context_line":"DEVICE_OWNER_LOADBALANCER \u003d DEVICE_OWNER_NEUTRON_PREFIX + \"LOADBALANCER\""},{"line_number":65,"context_line":"DEVICE_OWNER_LOADBALANCERV2 \u003d DEVICE_OWNER_NEUTRON_PREFIX + \"LOADBALANCERV2\""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"# NOTE(mjozefcz): Device owner for OVN distributed services"},{"line_number":68,"context_line":"# like Metadata and DHCP."},{"line_number":69,"context_line":"DEVICE_OWNER_DISTRIBUTED \u003d DEVICE_OWNER_NEUTRON_PREFIX + \"distributed\""},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_8ab79ef5","line":67,"range":{"start_line":67,"start_character":2,"end_line":67,"end_character":17},"in_reply_to":"ff570b3c_7f1f9207","updated":"2020-06-03 09:40:36.000000000","message":"I\u0027ll update, thanks","commit_id":"1c674c01a88999a0003e5e9b265bc641a3b147f3"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"52e1e1d186a8f47df28af761f350ee9d1ec2f1bb","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"# NOTE(mjozefcz): Device owner for OVN distributed services"},{"line_number":68,"context_line":"# like Metadata and DHCP."},{"line_number":69,"context_line":"DEVICE_OWNER_DISTRIBUTED \u003d DEVICE_OWNER_NEUTRON_PREFIX + \"distributed\""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"DEVICE_OWNER_PREFIXES \u003d (DEVICE_OWNER_NETWORK_PREFIX,"},{"line_number":72,"context_line":"                         DEVICE_OWNER_NEUTRON_PREFIX)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_5f0c4eeb","line":69,"range":{"start_line":69,"start_character":40,"end_line":69,"end_character":47},"updated":"2020-06-01 14:46:26.000000000","message":"I wonder whether this should be NETWORK, as we do for the DVR case above, \u0027network:router_interface_distributed\u0027\n\nAnd should we define each one separately?  eg DHCP and Metadata?  That way a port list can filter by a specific owner.  Could do like below where we define a set for all distributed owners, but each is separate.","commit_id":"1c674c01a88999a0003e5e9b265bc641a3b147f3"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"159d707cdf55f7e65f4966163b86aeacbacf2d4f","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"# NOTE(mjozefcz): Device owner for OVN distributed services"},{"line_number":68,"context_line":"# like Metadata and DHCP."},{"line_number":69,"context_line":"DEVICE_OWNER_DISTRIBUTED \u003d DEVICE_OWNER_NEUTRON_PREFIX + \"distributed\""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"DEVICE_OWNER_PREFIXES \u003d (DEVICE_OWNER_NETWORK_PREFIX,"},{"line_number":72,"context_line":"                         DEVICE_OWNER_NEUTRON_PREFIX)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_e344404a","line":69,"range":{"start_line":69,"start_character":40,"end_line":69,"end_character":47},"in_reply_to":"ff570b3c_239f63b4","updated":"2020-06-08 07:45:23.000000000","message":"Yes, it could be the same port and it is now the same port in networking-ovn.\n\nDuring PTG we talked about this problem with distributed metadata and DHCP, along with naming convention, and we have agreement, that we could name it \u0027distributed\u0027.\n\nAlong with it for such ports we will \u0027break\u0027 convention of having 1 port in only one segment, we need to explicitly define it, and I\u0027m going to work on that.","commit_id":"1c674c01a88999a0003e5e9b265bc641a3b147f3"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"7b8affd7eea6c2b46afb96ab54438eda3fab737a","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"# NOTE(mjozefcz): Device owner for OVN distributed services"},{"line_number":68,"context_line":"# like Metadata and DHCP."},{"line_number":69,"context_line":"DEVICE_OWNER_DISTRIBUTED \u003d DEVICE_OWNER_NEUTRON_PREFIX + \"distributed\""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"DEVICE_OWNER_PREFIXES \u003d (DEVICE_OWNER_NETWORK_PREFIX,"},{"line_number":72,"context_line":"                         DEVICE_OWNER_NEUTRON_PREFIX)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_eacbba4f","line":69,"range":{"start_line":69,"start_character":40,"end_line":69,"end_character":47},"in_reply_to":"ff570b3c_5f0c4eeb","updated":"2020-06-03 09:40:36.000000000","message":"Hmm, the naming is open question. We should talk about it during PTG.\n\nI don\u0027t think in this particular scenario we need to define each owner separately.\n\n1) While the Metadata uses it we could set DEVICE_OWNER_NEUTRON_PREFIX + \"distributed\" or DEVICE_OWNER_NETWORK_PREFIX + \"distributed\"\n\n2) The OVN distributed DHCP service doesn\u0027t need any port. It doesn\u0027t bind any port. The only need is to have IP allocated withing the same subnet as caller, to set \"server_id\" fields in OVN DHCP Options. That could be also the subnet gateway_ip, but not all the subnets has this field set.\n\nSo because of 2) we could use the port created for metadata 1) in order to get the fixed_ip from related subnet. I think we can name it just \"distributed\" or \"distributed_service\"?","commit_id":"1c674c01a88999a0003e5e9b265bc641a3b147f3"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"b6b284ec23af277f4dfcc455a7ae373590e49ac5","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"# NOTE(mjozefcz): Device owner for OVN distributed services"},{"line_number":68,"context_line":"# like Metadata and DHCP."},{"line_number":69,"context_line":"DEVICE_OWNER_DISTRIBUTED \u003d DEVICE_OWNER_NEUTRON_PREFIX + \"distributed\""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"DEVICE_OWNER_PREFIXES \u003d (DEVICE_OWNER_NETWORK_PREFIX,"},{"line_number":72,"context_line":"                         DEVICE_OWNER_NEUTRON_PREFIX)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_420a438a","line":69,"range":{"start_line":69,"start_character":40,"end_line":69,"end_character":47},"in_reply_to":"ff570b3c_e344404a","updated":"2020-06-15 08:31:35.000000000","message":"I think that \"network:distributed\" will be ok as it will IMO explicitly say that this port is used for some distributed purpose. And yes, I think we agreed on that during the PTG discussion.","commit_id":"1c674c01a88999a0003e5e9b265bc641a3b147f3"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5f71cfad3c816af25bdd6dc0f47e902f8e7372b8","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"# NOTE(mjozefcz): Device owner for OVN distributed services"},{"line_number":68,"context_line":"# like Metadata and DHCP."},{"line_number":69,"context_line":"DEVICE_OWNER_DISTRIBUTED \u003d DEVICE_OWNER_NEUTRON_PREFIX + \"distributed\""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"DEVICE_OWNER_PREFIXES \u003d (DEVICE_OWNER_NETWORK_PREFIX,"},{"line_number":72,"context_line":"                         DEVICE_OWNER_NEUTRON_PREFIX)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff570b3c_239f63b4","line":69,"range":{"start_line":69,"start_character":40,"end_line":69,"end_character":47},"in_reply_to":"ff570b3c_eacbba4f","updated":"2020-06-05 21:21:45.000000000","message":"Oh, so it could be the same port?  If there are two I\u0027d name them both different, if it\u0027s just one the name should be unique enough to know it could have dual-meaning, like \"distributed-service\" or ... ?","commit_id":"1c674c01a88999a0003e5e9b265bc641a3b147f3"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"df5a05e25e7256624391edee13b1945bc968e775","unresolved":false,"context_lines":[{"line_number":64,"context_line":"DEVICE_OWNER_LOADBALANCER \u003d DEVICE_OWNER_NEUTRON_PREFIX + \"LOADBALANCER\""},{"line_number":65,"context_line":"DEVICE_OWNER_LOADBALANCERV2 \u003d DEVICE_OWNER_NEUTRON_PREFIX + \"LOADBALANCERV2\""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"# Device owner for OVN distributed services like Metadata and DHCP."},{"line_number":68,"context_line":"DEVICE_OWNER_DISTRIBUTED \u003d DEVICE_OWNER_NEUTRON_PREFIX + \"distributed\""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"DEVICE_OWNER_PREFIXES \u003d (DEVICE_OWNER_NETWORK_PREFIX,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf51134e_db5bca84","line":67,"range":{"start_line":67,"start_character":2,"end_line":67,"end_character":67},"updated":"2020-06-16 08:48:37.000000000","message":"Here comes a nit:\n\nWhat about:\n\n# Device owner for distributed services (e.g OVN Metadata/DHCP)\n\nThe goal would be to not tie this type to OVN but to any service that could be distributed. It happens that OVN uses them :)","commit_id":"0fbed1d6839dde5bd763e61424d8f15eda713501"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"767d07c82f17efe83013b06796e3779ae96722d0","unresolved":false,"context_lines":[{"line_number":64,"context_line":"DEVICE_OWNER_LOADBALANCER \u003d DEVICE_OWNER_NEUTRON_PREFIX + \"LOADBALANCER\""},{"line_number":65,"context_line":"DEVICE_OWNER_LOADBALANCERV2 \u003d DEVICE_OWNER_NEUTRON_PREFIX + \"LOADBALANCERV2\""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"# Device owner for OVN distributed services like Metadata and DHCP."},{"line_number":68,"context_line":"DEVICE_OWNER_DISTRIBUTED \u003d DEVICE_OWNER_NEUTRON_PREFIX + \"distributed\""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"DEVICE_OWNER_PREFIXES \u003d (DEVICE_OWNER_NETWORK_PREFIX,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bf51134e_1bda62e8","line":67,"range":{"start_line":67,"start_character":2,"end_line":67,"end_character":67},"in_reply_to":"bf51134e_db5bca84","updated":"2020-06-16 08:50:49.000000000","message":"Done","commit_id":"0fbed1d6839dde5bd763e61424d8f15eda713501"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"f1d1448890335ff4d177931c668164f2fb414e1f","unresolved":false,"context_lines":[{"line_number":65,"context_line":"DEVICE_OWNER_LOADBALANCERV2 \u003d DEVICE_OWNER_NEUTRON_PREFIX + \"LOADBALANCERV2\""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"# Device owner for distributed services (e.g OVN Metadata/DHCP)."},{"line_number":68,"context_line":"DEVICE_OWNER_DISTRIBUTED \u003d DEVICE_OWNER_NETWORK_PREFIX + \"distributed\""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"DEVICE_OWNER_PREFIXES \u003d (DEVICE_OWNER_NETWORK_PREFIX,"},{"line_number":71,"context_line":"                         DEVICE_OWNER_NEUTRON_PREFIX)"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_0eefbb84","line":68,"range":{"start_line":68,"start_character":27,"end_line":68,"end_character":54},"updated":"2020-06-16 15:01:31.000000000","message":"As per IRC we think that we should be using \u0027network:\u0027 instead \u0027neutron:\u0027.","commit_id":"438a9b7609f7367f33a5d61c6111e5b81ce06cf6"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"7fcef855e3ae1a27bd7d3d33f522a7c8bf1267ad","unresolved":false,"context_lines":[{"line_number":65,"context_line":"DEVICE_OWNER_LOADBALANCERV2 \u003d DEVICE_OWNER_NEUTRON_PREFIX + \"LOADBALANCERV2\""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"# Device owner for distributed services (e.g OVN Metadata/DHCP)."},{"line_number":68,"context_line":"DEVICE_OWNER_DISTRIBUTED \u003d DEVICE_OWNER_NETWORK_PREFIX + \"distributed\""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"DEVICE_OWNER_PREFIXES \u003d (DEVICE_OWNER_NETWORK_PREFIX,"},{"line_number":71,"context_line":"                         DEVICE_OWNER_NEUTRON_PREFIX)"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf51134e_a9e68943","line":68,"range":{"start_line":68,"start_character":27,"end_line":68,"end_character":54},"in_reply_to":"bf51134e_0eefbb84","updated":"2020-06-16 15:22:10.000000000","message":"Yes, it should be \u0027network\u0027, commit f42ea67995537c7fe3e36447489872b0dcb82dd9 added \u0027neutron\u0027 just for lbaas \"way back\" in 2015, and as the comment above says, it should eventually be deprecated along with the LOADBALANCER constants.","commit_id":"438a9b7609f7367f33a5d61c6111e5b81ce06cf6"}]}