)]}'
{"neutron_lib/constants.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"7ca0cb85fb0ac17b85983d9ad6e23908e4b66e93","unresolved":false,"context_lines":[{"line_number":109,"context_line":"AGENT_TYPE_DHCP \u003d \u0027DHCP agent\u0027"},{"line_number":110,"context_line":"AGENT_TYPE_OVS \u003d \u0027Open vSwitch agent\u0027"},{"line_number":111,"context_line":"AGENT_TYPE_LINUXBRIDGE \u003d \u0027Linux bridge agent\u0027"},{"line_number":112,"context_line":"AGENT_TYPE_OFA \u003d \u0027OFA driver agent\u0027"},{"line_number":113,"context_line":"AGENT_TYPE_L3 \u003d \u0027L3 agent\u0027"},{"line_number":114,"context_line":"AGENT_TYPE_METERING \u003d \u0027Metering agent\u0027"},{"line_number":115,"context_line":"AGENT_TYPE_METADATA \u003d \u0027Metadata agent\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_93fe6403","side":"PARENT","line":112,"updated":"2020-06-15 16:52:00.000000000","message":"This is used in neutron and one place in networking-bgpvpn repo, removing will break them.","commit_id":"39299da2eebdab4db8a434accc8812e9aaed275b"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"178e54b8456beeaae765c3092e10a7ec3fdb0e84","unresolved":false,"context_lines":[{"line_number":109,"context_line":"AGENT_TYPE_DHCP \u003d \u0027DHCP agent\u0027"},{"line_number":110,"context_line":"AGENT_TYPE_OVS \u003d \u0027Open vSwitch agent\u0027"},{"line_number":111,"context_line":"AGENT_TYPE_LINUXBRIDGE \u003d \u0027Linux bridge agent\u0027"},{"line_number":112,"context_line":"AGENT_TYPE_OFA \u003d \u0027OFA driver agent\u0027"},{"line_number":113,"context_line":"AGENT_TYPE_L3 \u003d \u0027L3 agent\u0027"},{"line_number":114,"context_line":"AGENT_TYPE_METERING \u003d \u0027Metering agent\u0027"},{"line_number":115,"context_line":"AGENT_TYPE_METADATA \u003d \u0027Metadata agent\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf51134e_969487ea","side":"PARENT","line":112,"in_reply_to":"bf51134e_93fe6403","updated":"2020-06-16 09:42:16.000000000","message":"True, I probably made a typo when running codesearch. Readding","commit_id":"39299da2eebdab4db8a434accc8812e9aaed275b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"573ef68e55ba3fa41b3abd30635f39b7cca1c133","unresolved":false,"context_lines":[{"line_number":113,"context_line":"AGENT_PROCESS_MACVTAP \u003d \u0027neutron-macvtap-agent\u0027"},{"line_number":114,"context_line":"AGENT_PROCESS_METADATA \u003d \u0027neutron-metadata-agent\u0027"},{"line_number":115,"context_line":"AGENT_PROCESS_METERING \u003d \u0027neutron-metering-agent\u0027"},{"line_number":116,"context_line":"AGENT_PROCESS_NIC_SWITCH \u003d \u0027neutron-sriov-nic-agent\u0027"},{"line_number":117,"context_line":"AGENT_PROCESS_OVN_METADATA \u003d \u0027neutron-ovn-metadata-agent\u0027"},{"line_number":118,"context_line":"AGENT_PROCESS_OVS \u003d \u0027neutron-openvswitch-agent\u0027"},{"line_number":119,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_b64a6b7d","line":116,"range":{"start_line":116,"start_character":36,"end_line":116,"end_character":45},"updated":"2020-06-16 09:46:33.000000000","message":"just a question, no action requested: why this could not be just neutron-sriov-agent?","commit_id":"8294ae6077d1fdee81c673cf094722d62f44d082"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"0ce8df4b646f66d2a97f6eebcf5b4be2ec9a5bf9","unresolved":false,"context_lines":[{"line_number":113,"context_line":"AGENT_PROCESS_MACVTAP \u003d \u0027neutron-macvtap-agent\u0027"},{"line_number":114,"context_line":"AGENT_PROCESS_METADATA \u003d \u0027neutron-metadata-agent\u0027"},{"line_number":115,"context_line":"AGENT_PROCESS_METERING \u003d \u0027neutron-metering-agent\u0027"},{"line_number":116,"context_line":"AGENT_PROCESS_NIC_SWITCH \u003d \u0027neutron-sriov-nic-agent\u0027"},{"line_number":117,"context_line":"AGENT_PROCESS_OVN_METADATA \u003d \u0027neutron-ovn-metadata-agent\u0027"},{"line_number":118,"context_line":"AGENT_PROCESS_OVS \u003d \u0027neutron-openvswitch-agent\u0027"},{"line_number":119,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_0ff3320c","line":116,"range":{"start_line":116,"start_character":36,"end_line":116,"end_character":45},"in_reply_to":"bf51134e_43c86c54","updated":"2020-06-16 19:59:26.000000000","message":"yes, it\u0027s like that now: https://github.com/openstack/neutron/blob/c6e5e119b84a7d55e539509050ce56236ebf57c6/neutron/plugins/ml2/drivers/mech_sriov/agent/sriov_nic_agent.py#L174 so I don\u0027t think we should change that.","commit_id":"8294ae6077d1fdee81c673cf094722d62f44d082"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"775b1874764f6721069b51d3e02d9e7da4eda414","unresolved":false,"context_lines":[{"line_number":113,"context_line":"AGENT_PROCESS_MACVTAP \u003d \u0027neutron-macvtap-agent\u0027"},{"line_number":114,"context_line":"AGENT_PROCESS_METADATA \u003d \u0027neutron-metadata-agent\u0027"},{"line_number":115,"context_line":"AGENT_PROCESS_METERING \u003d \u0027neutron-metering-agent\u0027"},{"line_number":116,"context_line":"AGENT_PROCESS_NIC_SWITCH \u003d \u0027neutron-sriov-nic-agent\u0027"},{"line_number":117,"context_line":"AGENT_PROCESS_OVN_METADATA \u003d \u0027neutron-ovn-metadata-agent\u0027"},{"line_number":118,"context_line":"AGENT_PROCESS_OVS \u003d \u0027neutron-openvswitch-agent\u0027"},{"line_number":119,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bf51134e_43c86c54","line":116,"range":{"start_line":116,"start_character":36,"end_line":116,"end_character":45},"in_reply_to":"bf51134e_b64a6b7d","updated":"2020-06-16 14:09:02.000000000","message":"It could be, I just kept the existing binary name (from setup.cfg). Not sure where the additional \"-nic\" came frome at the time","commit_id":"8294ae6077d1fdee81c673cf094722d62f44d082"}]}