)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"148956174f7dc7253c3fec0a067cbde5a89c3da1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Thomas Goirand \u003czigo@debian.org\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-07-17 11:38:37 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add DEVICE_OWNER_ROUTED"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch is in order to implement this:"},{"line_number":10,"context_line":"https://review.opendev.org/#/c/669395/"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bf51134e_4ded598d","line":7,"updated":"2020-07-17 10:39:28.000000000","message":"Add DEVICE_OWNER_ROUTED constant","commit_id":"5fe02b046bba30c3223570a9dcaccec27acb394b"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"065ec2dca3656443270a01d108da49036fb78671","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Thomas Goirand \u003czigo@debian.org\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-07-17 11:38:37 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add DEVICE_OWNER_ROUTED"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch is in order to implement this:"},{"line_number":10,"context_line":"https://review.opendev.org/#/c/669395/"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_0608122a","line":7,"in_reply_to":"bf51134e_4ded598d","updated":"2020-07-30 13:15:13.000000000","message":"Done","commit_id":"5fe02b046bba30c3223570a9dcaccec27acb394b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"148956174f7dc7253c3fec0a067cbde5a89c3da1","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add DEVICE_OWNER_ROUTED"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch is in order to implement this:"},{"line_number":10,"context_line":"https://review.opendev.org/#/c/669395/"},{"line_number":11,"context_line":"using a correct constant defined in neutron-lib."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ibde33bdacba6bd1e9c41cc69d0054bf55e1e6454"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bf51134e_4dbb9974","line":10,"updated":"2020-07-17 10:39:28.000000000","message":"I would remove any reference to a specific patch here. Actually, this is just a constant. The title and the bug reference is enough","commit_id":"5fe02b046bba30c3223570a9dcaccec27acb394b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"2ba10faf5eead7efffcf3fd2d35e78bf8ac47171","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add DEVICE_OWNER_ROUTED"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch is in order to implement this:"},{"line_number":10,"context_line":"https://review.opendev.org/#/c/669395/"},{"line_number":11,"context_line":"using a correct constant defined in neutron-lib."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ibde33bdacba6bd1e9c41cc69d0054bf55e1e6454"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_5f731a16","line":10,"in_reply_to":"bf51134e_4dbb9974","updated":"2020-07-28 10:02:23.000000000","message":"+1","commit_id":"5fe02b046bba30c3223570a9dcaccec27acb394b"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"065ec2dca3656443270a01d108da49036fb78671","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add DEVICE_OWNER_ROUTED"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch is in order to implement this:"},{"line_number":10,"context_line":"https://review.opendev.org/#/c/669395/"},{"line_number":11,"context_line":"using a correct constant defined in neutron-lib."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ibde33bdacba6bd1e9c41cc69d0054bf55e1e6454"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_e6023e0b","line":10,"in_reply_to":"bf51134e_4dbb9974","updated":"2020-07-30 13:15:13.000000000","message":"Done","commit_id":"5fe02b046bba30c3223570a9dcaccec27acb394b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"148956174f7dc7253c3fec0a067cbde5a89c3da1","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch is in order to implement this:"},{"line_number":10,"context_line":"https://review.opendev.org/#/c/669395/"},{"line_number":11,"context_line":"using a correct constant defined in neutron-lib."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ibde33bdacba6bd1e9c41cc69d0054bf55e1e6454"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bf51134e_2d9745ee","line":12,"updated":"2020-07-17 10:39:28.000000000","message":"Related-Bug: #1667329","commit_id":"5fe02b046bba30c3223570a9dcaccec27acb394b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"2ba10faf5eead7efffcf3fd2d35e78bf8ac47171","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch is in order to implement this:"},{"line_number":10,"context_line":"https://review.opendev.org/#/c/669395/"},{"line_number":11,"context_line":"using a correct constant defined in neutron-lib."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ibde33bdacba6bd1e9c41cc69d0054bf55e1e6454"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_bf61963c","line":12,"in_reply_to":"bf51134e_2d9745ee","updated":"2020-07-28 10:02:23.000000000","message":"+1","commit_id":"5fe02b046bba30c3223570a9dcaccec27acb394b"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"065ec2dca3656443270a01d108da49036fb78671","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch is in order to implement this:"},{"line_number":10,"context_line":"https://review.opendev.org/#/c/669395/"},{"line_number":11,"context_line":"using a correct constant defined in neutron-lib."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ibde33bdacba6bd1e9c41cc69d0054bf55e1e6454"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9f560f44_7affde00","line":12,"in_reply_to":"bf51134e_2d9745ee","updated":"2020-07-30 13:15:13.000000000","message":"Done","commit_id":"5fe02b046bba30c3223570a9dcaccec27acb394b"}],"neutron_lib/api/definitions/subnet.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"5abb28cda1cc6e9efe108a03170965cb8a7b176b","unresolved":false,"context_lines":[{"line_number":126,"context_line":"                              \u0027is_filter\u0027: True,"},{"line_number":127,"context_line":"                              \u0027is_sort_key\u0027: True,"},{"line_number":128,"context_line":"                              \u0027is_visible\u0027: True},"},{"line_number":129,"context_line":"        \u0027service_types\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":130,"context_line":"                              \u0027default\u0027: constants.ATTR_NOT_SPECIFIED,"},{"line_number":131,"context_line":"                              \u0027validate\u0027: {\u0027type:list_of_subnet_service_types\u0027: None},"},{"line_number":132,"context_line":"                              \u0027is_visible\u0027: True},"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_1a3182ed","line":129,"updated":"2020-07-30 13:18:52.000000000","message":"1) You can\u0027t modify an API, you can extend it, using an extension\n2) You already have the extension \u0027subnet-service-types\u0027","commit_id":"65362c0764a757fe48869ab643e1fd3657d38bdf"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"d0beb0a12d33ca23a15a3cbf2a1a407e29b85e94","unresolved":false,"context_lines":[{"line_number":126,"context_line":"                              \u0027is_filter\u0027: True,"},{"line_number":127,"context_line":"                              \u0027is_sort_key\u0027: True,"},{"line_number":128,"context_line":"                              \u0027is_visible\u0027: True},"},{"line_number":129,"context_line":"        \u0027service_types\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":130,"context_line":"                              \u0027default\u0027: constants.ATTR_NOT_SPECIFIED,"},{"line_number":131,"context_line":"                              \u0027validate\u0027: {\u0027type:list_of_subnet_service_types\u0027: None},"},{"line_number":132,"context_line":"                              \u0027is_visible\u0027: True},"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_5acada19","line":129,"in_reply_to":"9f560f44_1a3182ed","updated":"2020-07-30 13:50:39.000000000","message":"Ok, I\u0027ll revert, though how do I make it so that attr_ops.verify_attributes(res_dict) doesn\u0027t fail? This looks like my last issue...","commit_id":"65362c0764a757fe48869ab643e1fd3657d38bdf"}],"neutron_lib/constants.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"53784b0e9b5e21b2e54b37d880cbb6101f6fcbf9","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                         \"floatingip_agent_gateway\")"},{"line_number":60,"context_line":"DEVICE_OWNER_ROUTER_SNAT \u003d (DEVICE_OWNER_NETWORK_PREFIX +"},{"line_number":61,"context_line":"                            \"router_centralized_snat\")"},{"line_number":62,"context_line":"DEVICE_OWNER_ROUTED \u003d (DEVICE_OWNER_NETWORK_PREFIX + \"routed\")"},{"line_number":63,"context_line":"# TODO(johnsom) Remove after these stop being used. Neutron-LBaaS is now"},{"line_number":64,"context_line":"#               retired (train) and these should no longer be necessary."},{"line_number":65,"context_line":"DEVICE_OWNER_LOADBALANCER \u003d DEVICE_OWNER_NEUTRON_PREFIX + \"LOADBALANCER\""}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_302399bf","line":62,"range":{"start_line":62,"start_character":0,"end_line":62,"end_character":19},"updated":"2020-08-03 08:55:20.000000000","message":"Question: this Device_owner_routed will be used only for ports for floating ips on service subnet?","commit_id":"b64d4e2423da8b1664ec632a849b4d8c0892e20e"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"bef3074b21e8869bf2b1d5f186d0596942651b1e","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                         \"floatingip_agent_gateway\")"},{"line_number":60,"context_line":"DEVICE_OWNER_ROUTER_SNAT \u003d (DEVICE_OWNER_NETWORK_PREFIX +"},{"line_number":61,"context_line":"                            \"router_centralized_snat\")"},{"line_number":62,"context_line":"DEVICE_OWNER_ROUTED \u003d (DEVICE_OWNER_NETWORK_PREFIX + \"routed\")"},{"line_number":63,"context_line":"# TODO(johnsom) Remove after these stop being used. Neutron-LBaaS is now"},{"line_number":64,"context_line":"#               retired (train) and these should no longer be necessary."},{"line_number":65,"context_line":"DEVICE_OWNER_LOADBALANCER \u003d DEVICE_OWNER_NEUTRON_PREFIX + \"LOADBALANCER\""}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_49dca8e3","line":62,"range":{"start_line":62,"start_character":0,"end_line":62,"end_character":19},"in_reply_to":"9f560f44_302399bf","updated":"2020-08-03 12:54:36.000000000","message":"Yes, these ports will be used next HOP for router gateways, or for next hop for floating IPs.","commit_id":"b64d4e2423da8b1664ec632a849b4d8c0892e20e"}]}