)]}'
{"api-ref/source/v2/routers.inc":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"56f0473078292b3a6f4d9b6ba88d36559f458ed6","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    By default in a router, there is one route for each subnet."},{"line_number":32,"context_line":"    If you add a route that matches one of the default"},{"line_number":33,"context_line":"    routes for a subnet, the L3 agent overwrites the existing route and also"},{"line_number":34,"context_line":"    removes the route from the router namespace."},{"line_number":35,"context_line":"    The default routes for subnets must not be duplicated because network"},{"line_number":36,"context_line":"    traffic cannot flow to and from the associated subnet."},{"line_number":37,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":1,"id":"9f560f44_f246bc21","line":34,"updated":"2020-07-27 10:25:12.000000000","message":"I would say:\n\n\"..., the L3 agent overwrites the existing router namespace route. If the Neutron route is removed from the router, the corresponding route in the router namespace will be removed too. The affected subnet will loose connectivity in this router\"\n\nAnd maybe (maybe) I would add an example: http://paste.openstack.org/show/796323/ (I used this before to document another error)","commit_id":"8427f2652ee51e7bab54014383e3e76449ca8e67"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"ef9781ba687cc6c94cd203443f4159c6fc806036","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    By default in a router, there is one route for each subnet."},{"line_number":32,"context_line":"    If you add a route that matches one of the default"},{"line_number":33,"context_line":"    routes for a subnet, the L3 agent overwrites the existing route and also"},{"line_number":34,"context_line":"    removes the route from the router namespace."},{"line_number":35,"context_line":"    The default routes for subnets must not be duplicated because network"},{"line_number":36,"context_line":"    traffic cannot flow to and from the associated subnet."},{"line_number":37,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":1,"id":"9f560f44_da970f90","line":34,"in_reply_to":"9f560f44_d70c0f3d","updated":"2020-07-30 07:50:24.000000000","message":"agree","commit_id":"8427f2652ee51e7bab54014383e3e76449ca8e67"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"693a600f6edc6027da7f42f07d08e6eb41b976bd","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    By default in a router, there is one route for each subnet."},{"line_number":32,"context_line":"    If you add a route that matches one of the default"},{"line_number":33,"context_line":"    routes for a subnet, the L3 agent overwrites the existing route and also"},{"line_number":34,"context_line":"    removes the route from the router namespace."},{"line_number":35,"context_line":"    The default routes for subnets must not be duplicated because network"},{"line_number":36,"context_line":"    traffic cannot flow to and from the associated subnet."},{"line_number":37,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":1,"id":"9f560f44_d70c0f3d","line":34,"in_reply_to":"9f560f44_f246bc21","updated":"2020-07-29 20:29:10.000000000","message":"\u003e I would say:\n \u003e \n \u003e \"..., the L3 agent overwrites the existing router namespace route.\n \u003e If the Neutron route is removed from the router, the corresponding\n \u003e route in the router namespace will be removed too. The affected\n \u003e subnet will loose connectivity in this router\"\n \u003e \n\nDone\n\n \u003e And maybe (maybe) I would add an example: http://paste.openstack.org/show/796323/\n \u003e (I used this before to document another error)\n\nI\u0027m not sure if api-ref is good place for such examples. I would like to keep this note short and simple.","commit_id":"8427f2652ee51e7bab54014383e3e76449ca8e67"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"0ea3b1070ad9794880015ee36b9a3278a5c27435","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    router\u0027s namespace."},{"line_number":35,"context_line":"    If the Neutron route is removed from the router, the corresponding"},{"line_number":36,"context_line":"    route in the router\u0027s namespace will be removed too. The affected"},{"line_number":37,"context_line":"    subnet will loose connectivity in this router."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Extra routes (atomic) extension"},{"line_number":40,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"9f560f44_5578b7c2","line":37,"range":{"start_line":37,"start_character":16,"end_line":37,"end_character":21},"updated":"2020-08-03 16:12:35.000000000","message":"s/lose","commit_id":"76d2f91b5b52710afdf3eb9dc2ac16cfa9f06648"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"0ea3b1070ad9794880015ee36b9a3278a5c27435","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    If the Neutron route is removed from the router, the corresponding"},{"line_number":36,"context_line":"    route in the router\u0027s namespace will be removed too. The affected"},{"line_number":37,"context_line":"    subnet will loose connectivity in this router."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Extra routes (atomic) extension"},{"line_number":40,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"9f560f44_195af928","line":38,"updated":"2020-08-03 16:12:35.000000000","message":"After re-reading the api doc, I have another higher-level comment for this paragraph.  I couldn\u0027t find anywhere else were we talk about the implementation of a router - i.e. namespaces - plus this wouldn\u0027t apply to an OVN router :(\n\nSo I would propose a more generic version, possibly:\n\n\"By default in a router there is one route for each attached subnet. If you add an extra route that matches one of the default routes for a subnet, the existing subnet route will be overwritten. If the Neutron route is removed, the corresponding extra route will be removed as well. The affected subnet will subsequently lose connectivity to this router.\"\n\nAlso, is the solution simple?  If it\u0027s just one or two API calls (removing and re-adding the extra route) maybe we can add that here?","commit_id":"76d2f91b5b52710afdf3eb9dc2ac16cfa9f06648"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"0ea3b1070ad9794880015ee36b9a3278a5c27435","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    router\u0027s namespace."},{"line_number":53,"context_line":"    If the Neutron route is removed from the router, the corresponding"},{"line_number":54,"context_line":"    route in the router\u0027s namespace will be removed too. The affected"},{"line_number":55,"context_line":"    subnet will loose connectivity in this router."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"HA capability for router extension (``l3-ha``)"},{"line_number":58,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"9f560f44_357543cc","line":55,"range":{"start_line":55,"start_character":16,"end_line":55,"end_character":21},"updated":"2020-08-03 16:12:35.000000000","message":"s/lose","commit_id":"76d2f91b5b52710afdf3eb9dc2ac16cfa9f06648"}]}
