)]}'
{"neutron_lib/placement/client.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"26da025207774ed217b431fac89cf96fca94e8f1","unresolved":false,"context_lines":[{"line_number":776,"context_line":"                    resources \u003d body[\u0027allocations\u0027][rp_uuid][\u0027resources\u0027]"},{"line_number":777,"context_line":"                    if len(resources) \u003e 1:"},{"line_number":778,"context_line":"                        resources.pop(drctn, None)"},{"line_number":779,"context_line":"                    else:"},{"line_number":780,"context_line":"                        body[\u0027allocations\u0027].pop(rp_uuid, None)"},{"line_number":781,"context_line":"            try:"},{"line_number":782,"context_line":"                # Update allocations has no return body, but leave the loop"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_06e28830","line":779,"updated":"2020-09-08 14:26:50.000000000","message":"In case of not having any resource, should we remove the RP?","commit_id":"ea6da96b034cc8c7ded0d838ee1f62636abe837a"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"71c7a36208c929251eb923ab739cf0ab9c9cbc0d","unresolved":false,"context_lines":[{"line_number":776,"context_line":"                    resources \u003d body[\u0027allocations\u0027][rp_uuid][\u0027resources\u0027]"},{"line_number":777,"context_line":"                    if len(resources) \u003e 1:"},{"line_number":778,"context_line":"                        resources.pop(drctn, None)"},{"line_number":779,"context_line":"                    else:"},{"line_number":780,"context_line":"                        body[\u0027allocations\u0027].pop(rp_uuid, None)"},{"line_number":781,"context_line":"            try:"},{"line_number":782,"context_line":"                # Update allocations has no return body, but leave the loop"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_1b00f600","line":779,"in_reply_to":"9f560f44_06e28830","updated":"2020-09-10 07:41:23.000000000","message":"that is done in l780","commit_id":"ea6da96b034cc8c7ded0d838ee1f62636abe837a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"26da025207774ed217b431fac89cf96fca94e8f1","unresolved":false,"context_lines":[{"line_number":777,"context_line":"                    if len(resources) \u003e 1:"},{"line_number":778,"context_line":"                        resources.pop(drctn, None)"},{"line_number":779,"context_line":"                    else:"},{"line_number":780,"context_line":"                        body[\u0027allocations\u0027].pop(rp_uuid, None)"},{"line_number":781,"context_line":"            try:"},{"line_number":782,"context_line":"                # Update allocations has no return body, but leave the loop"},{"line_number":783,"context_line":"                return self.update_allocation(consumer_uuid, body)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_a693dca2","line":780,"range":{"start_line":780,"start_character":55,"end_line":780,"end_character":61},"updated":"2020-09-08 14:26:50.000000000","message":"This can\u0027t happen because of L776","commit_id":"ea6da96b034cc8c7ded0d838ee1f62636abe837a"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"71c7a36208c929251eb923ab739cf0ab9c9cbc0d","unresolved":false,"context_lines":[{"line_number":777,"context_line":"                    if len(resources) \u003e 1:"},{"line_number":778,"context_line":"                        resources.pop(drctn, None)"},{"line_number":779,"context_line":"                    else:"},{"line_number":780,"context_line":"                        body[\u0027allocations\u0027].pop(rp_uuid, None)"},{"line_number":781,"context_line":"            try:"},{"line_number":782,"context_line":"                # Update allocations has no return body, but leave the loop"},{"line_number":783,"context_line":"                return self.update_allocation(consumer_uuid, body)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_7baad2d1","line":780,"range":{"start_line":780,"start_character":55,"end_line":780,"end_character":61},"in_reply_to":"9f560f44_a693dca2","updated":"2020-09-10 07:41:23.000000000","message":"you are right, done","commit_id":"ea6da96b034cc8c7ded0d838ee1f62636abe837a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"26da025207774ed217b431fac89cf96fca94e8f1","unresolved":false,"context_lines":[{"line_number":798,"context_line":"                            https://tinyurl.com/yxeuzn6l"},{"line_number":799,"context_line":"        \"\"\""},{"line_number":800,"context_line":"        url \u003d \u0027/allocations/%s\u0027 % consumer_uuid"},{"line_number":801,"context_line":"        LOG.debug(\u0027CCCC allocations\u003d%s ###\u0027, allocations)"},{"line_number":802,"context_line":"        self._put(url, allocations)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_46d12057","line":801,"updated":"2020-09-08 14:26:50.000000000","message":"Do we need that?","commit_id":"ea6da96b034cc8c7ded0d838ee1f62636abe837a"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"71c7a36208c929251eb923ab739cf0ab9c9cbc0d","unresolved":false,"context_lines":[{"line_number":798,"context_line":"                            https://tinyurl.com/yxeuzn6l"},{"line_number":799,"context_line":"        \"\"\""},{"line_number":800,"context_line":"        url \u003d \u0027/allocations/%s\u0027 % consumer_uuid"},{"line_number":801,"context_line":"        LOG.debug(\u0027CCCC allocations\u003d%s ###\u0027, allocations)"},{"line_number":802,"context_line":"        self._put(url, allocations)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_7809382f","line":801,"in_reply_to":"9f560f44_46d12057","updated":"2020-09-10 07:41:23.000000000","message":"Thanks","commit_id":"ea6da96b034cc8c7ded0d838ee1f62636abe837a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"abb1fd5e11b4a76dd50cc98fbb58fcac09a25620","unresolved":false,"context_lines":[{"line_number":776,"context_line":"                    resources \u003d body[\u0027allocations\u0027][rp_uuid][\u0027resources\u0027]"},{"line_number":777,"context_line":"                    if len(resources) \u003e 1:"},{"line_number":778,"context_line":"                        resources.pop(drctn, None)"},{"line_number":779,"context_line":"                    else:"},{"line_number":780,"context_line":"                        body[\u0027allocations\u0027].pop(rp_uuid)"},{"line_number":781,"context_line":"            try:"},{"line_number":782,"context_line":"                # Update allocations has no return body, but leave the loop"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_1b9c76be","line":779,"updated":"2020-09-10 07:39:47.000000000","message":"Same question as in PS1, but now I think I know the answer: in case of not having any resource, why should we remove the RP?","commit_id":"75a0a5e26ffeeca51fcd87c21a489eb25845126c"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"72bcc1950fd34e2443383a3173eca0f92eae8e0b","unresolved":false,"context_lines":[{"line_number":776,"context_line":"                    resources \u003d body[\u0027allocations\u0027][rp_uuid][\u0027resources\u0027]"},{"line_number":777,"context_line":"                    if len(resources) \u003e 1:"},{"line_number":778,"context_line":"                        resources.pop(drctn, None)"},{"line_number":779,"context_line":"                    else:"},{"line_number":780,"context_line":"                        body[\u0027allocations\u0027].pop(rp_uuid)"},{"line_number":781,"context_line":"            try:"},{"line_number":782,"context_line":"                # Update allocations has no return body, but leave the loop"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_9b9886c0","line":779,"in_reply_to":"9f560f44_1b9c76be","updated":"2020-09-10 07:43:04.000000000","message":"placement throws exception if empty dict is sent, that\u0027s why if there\u0027s nothing in the dict, it have to be removed with the key, here with rp id.","commit_id":"75a0a5e26ffeeca51fcd87c21a489eb25845126c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"dbe545c923bc908b2ed681a313e7f5768312384c","unresolved":false,"context_lines":[{"line_number":776,"context_line":"                    resources \u003d body[\u0027allocations\u0027][rp_uuid][\u0027resources\u0027]"},{"line_number":777,"context_line":"                    if len(resources) \u003e 1:"},{"line_number":778,"context_line":"                        resources.pop(drctn, None)"},{"line_number":779,"context_line":"                    else:"},{"line_number":780,"context_line":"                        body[\u0027allocations\u0027].pop(rp_uuid)"},{"line_number":781,"context_line":"            try:"},{"line_number":782,"context_line":"                # Update allocations has no return body, but leave the loop"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f560f44_bfff1b64","line":779,"in_reply_to":"9f560f44_9b9886c0","updated":"2020-09-11 10:24:10.000000000","message":"Thanks for the confirmation!","commit_id":"75a0a5e26ffeeca51fcd87c21a489eb25845126c"}]}