)]}'
{"neutron_lib/api/definitions/address_group.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"4096a02843bf5659a5180f10e4ab0291078f9cf1","unresolved":true,"context_lines":[{"line_number":65,"context_line":"                           \u0027default\u0027: False,"},{"line_number":66,"context_line":"                           \u0027convert_to\u0027: converters.convert_to_boolean,"},{"line_number":67,"context_line":"                           \u0027is_visible\u0027: False,"},{"line_number":68,"context_line":"                           \u0027is_filter\u0027: False,"},{"line_number":69,"context_line":"                           \u0027is_sort_key\u0027: False},"},{"line_number":70,"context_line":"    }"},{"line_number":71,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":1,"id":"41248452_3ea3dc22","line":68,"updated":"2021-02-11 10:09:49.000000000","message":"Don\u0027t you need the required_by_policy and enforce_policy to be set in this case?","commit_id":"e4f10dfa3e0c9da8fe5297e2c24957b6cf559fb4"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"a3e1dd9976a1b279f53924f97a049bf9b49e8bd9","unresolved":true,"context_lines":[{"line_number":65,"context_line":"                           \u0027default\u0027: False,"},{"line_number":66,"context_line":"                           \u0027convert_to\u0027: converters.convert_to_boolean,"},{"line_number":67,"context_line":"                           \u0027is_visible\u0027: False,"},{"line_number":68,"context_line":"                           \u0027is_filter\u0027: False,"},{"line_number":69,"context_line":"                           \u0027is_sort_key\u0027: False},"},{"line_number":70,"context_line":"    }"},{"line_number":71,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":1,"id":"4bffa611_33b8b467","line":68,"in_reply_to":"41248452_3ea3dc22","updated":"2021-02-11 20:56:15.000000000","message":"No, it works without it. I have a Tempest API test case for it: https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/773274/2/neutron_tempest_plugin/api/test_address_groups.py#104. This test case works with the shared attribute as defined here","commit_id":"e4f10dfa3e0c9da8fe5297e2c24957b6cf559fb4"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"e53b2cc6a967e847297d74fd109afbb7d4373df3","unresolved":false,"context_lines":[{"line_number":65,"context_line":"                           \u0027default\u0027: False,"},{"line_number":66,"context_line":"                           \u0027convert_to\u0027: converters.convert_to_boolean,"},{"line_number":67,"context_line":"                           \u0027is_visible\u0027: False,"},{"line_number":68,"context_line":"                           \u0027is_filter\u0027: False,"},{"line_number":69,"context_line":"                           \u0027is_sort_key\u0027: False},"},{"line_number":70,"context_line":"    }"},{"line_number":71,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":1,"id":"785c2a4d_da454ce5","line":68,"in_reply_to":"4bffa611_33b8b467","updated":"2021-02-12 00:35:37.000000000","message":"Digging a little bit more, here\u0027s an experiment I ran: http://paste.openstack.org/show/802589/\n\nAs you can see, enforce_policy doesn\u0027t need to be set. That is because Neutron\u0027s policy ignores enforce_policy for get operations: https://github.com/openstack/neutron/blob/73e1175602cca12138b4e406f6f50efc45238808/neutron/policy.py#L110.\n\nOslo policy engine checks anyway the entire rule and hits https://review.opendev.org/c/openstack/neutron/+/772460/7/neutron/conf/policies/address_group.py#31, which is what we need for RBAC","commit_id":"e4f10dfa3e0c9da8fe5297e2c24957b6cf559fb4"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"195f0503e2d339f5345df3a6419a5763cc618420","unresolved":false,"context_lines":[{"line_number":65,"context_line":"                           \u0027default\u0027: False,"},{"line_number":66,"context_line":"                           \u0027convert_to\u0027: converters.convert_to_boolean,"},{"line_number":67,"context_line":"                           \u0027is_visible\u0027: False,"},{"line_number":68,"context_line":"                           \u0027is_filter\u0027: False,"},{"line_number":69,"context_line":"                           \u0027is_sort_key\u0027: False},"},{"line_number":70,"context_line":"    }"},{"line_number":71,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":1,"id":"a618fdba_061f5ab6","line":68,"in_reply_to":"785c2a4d_da454ce5","updated":"2021-02-12 08:29:23.000000000","message":"Thanks, good to know","commit_id":"e4f10dfa3e0c9da8fe5297e2c24957b6cf559fb4"}]}