)]}'
{"api-ref/source/v2/bfd_monitors.inc":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b815d414c0479db824c5ee10bc29632fdf3226b3","unresolved":true,"context_lines":[{"line_number":23,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"   - id: id-query"},{"line_number":26,"context_line":"   - tenant_id: project_id-query"},{"line_number":27,"context_line":"   - project_id: project_id-query"},{"line_number":28,"context_line":"   - name: name-query"},{"line_number":29,"context_line":"   - description: description-query"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"e761a9da_4c1cbae9","line":26,"range":{"start_line":26,"start_character":5,"end_line":26,"end_character":14},"updated":"2021-05-26 13:44:01.000000000","message":"we should avoid any reference to tenant_id, although is still supported","commit_id":"7448b2617a44a67cb6880f305d201c8241e52b74"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"8762f9c11d226097e7744c5f38dbc7ad9e66c780","unresolved":true,"context_lines":[{"line_number":23,"context_line":".. rest_parameters:: parameters.yaml"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"   - id: id-query"},{"line_number":26,"context_line":"   - tenant_id: project_id-query"},{"line_number":27,"context_line":"   - project_id: project_id-query"},{"line_number":28,"context_line":"   - name: name-query"},{"line_number":29,"context_line":"   - description: description-query"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"dac05b3d_f4a73c4f","line":26,"range":{"start_line":26,"start_character":5,"end_line":26,"end_character":14},"in_reply_to":"e761a9da_4c1cbae9","updated":"2021-05-28 09:58:22.000000000","message":"Thanks, I removed the references to tenant_id","commit_id":"7448b2617a44a67cb6880f305d201c8241e52b74"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b815d414c0479db824c5ee10bc29632fdf3226b3","unresolved":true,"context_lines":[{"line_number":171,"context_line":""},{"line_number":172,"context_line":"Normal response codes: 202"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"Error response codes: 400, 401, 404, 41"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"Request"},{"line_number":177,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"32137ba7_77d07903","line":174,"range":{"start_line":174,"start_character":37,"end_line":174,"end_character":39},"updated":"2021-05-26 13:44:01.000000000","message":"412","commit_id":"7448b2617a44a67cb6880f305d201c8241e52b74"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"8762f9c11d226097e7744c5f38dbc7ad9e66c780","unresolved":true,"context_lines":[{"line_number":171,"context_line":""},{"line_number":172,"context_line":"Normal response codes: 202"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"Error response codes: 400, 401, 404, 41"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"Request"},{"line_number":177,"context_line":"-------"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"abbeb9b6_258f852a","line":174,"range":{"start_line":174,"start_character":37,"end_line":174,"end_character":39},"in_reply_to":"32137ba7_77d07903","updated":"2021-05-28 09:58:22.000000000","message":"Thanks, good catch","commit_id":"7448b2617a44a67cb6880f305d201c8241e52b74"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"5b34383a6f1cd6744af3b9bd8d498bd354c41c3d","unresolved":true,"context_lines":[{"line_number":216,"context_line":""},{"line_number":217,"context_line":".. rest_method::  DELETE /v2.0/bfd_monitors/{monitor_id}"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"Deletes a QoS policy."},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"Normal response codes: 204"},{"line_number":222,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":9,"id":"c99c41a5_64174170","line":219,"updated":"2021-07-19 13:30:26.000000000","message":"wrong copy-paste :)","commit_id":"3726a0606f68efabfbb5ce215d5aee1b398135b0"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"0d30d158008b003d1022fac9ed4e2c28feb98b8d","unresolved":true,"context_lines":[{"line_number":216,"context_line":""},{"line_number":217,"context_line":".. rest_method::  DELETE /v2.0/bfd_monitors/{monitor_id}"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"Deletes a QoS policy."},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"Normal response codes: 204"},{"line_number":222,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":9,"id":"be9ac862_aad998fb","line":219,"in_reply_to":"c99c41a5_64174170","updated":"2021-07-26 15:44:35.000000000","message":"Uhhh, thanks","commit_id":"3726a0606f68efabfbb5ce215d5aee1b398135b0"}],"api-ref/source/v2/parameters.yaml":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b815d414c0479db824c5ee10bc29632fdf3226b3","unresolved":true,"context_lines":[{"line_number":1744,"context_line":"  description: |"},{"line_number":1745,"context_line":"    The shortest interval, in millisecs, at which this BFD session"},{"line_number":1746,"context_line":"    offers to receive BFD control messages. At least 1. Defaults"},{"line_number":1747,"context_line":"    is 1000."},{"line_number":1748,"context_line":"  in: body"},{"line_number":1749,"context_line":"  required: false"},{"line_number":1750,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"94de2746_c99adf98","line":1747,"range":{"start_line":1747,"start_character":7,"end_line":1747,"end_character":11},"updated":"2021-05-26 13:44:01.000000000","message":"why this value?","commit_id":"7448b2617a44a67cb6880f305d201c8241e52b74"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"8762f9c11d226097e7744c5f38dbc7ad9e66c780","unresolved":true,"context_lines":[{"line_number":1744,"context_line":"  description: |"},{"line_number":1745,"context_line":"    The shortest interval, in millisecs, at which this BFD session"},{"line_number":1746,"context_line":"    offers to receive BFD control messages. At least 1. Defaults"},{"line_number":1747,"context_line":"    is 1000."},{"line_number":1748,"context_line":"  in: body"},{"line_number":1749,"context_line":"  required: false"},{"line_number":1750,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ac7a0cd9_8fe4556c","line":1747,"range":{"start_line":1747,"start_character":7,"end_line":1747,"end_character":11},"in_reply_to":"94de2746_c99adf98","updated":"2021-05-28 09:58:22.000000000","message":"These are the default values for min_rx, min_tx, and multiplier from ovs bfd implementation (https://www.freebsd.org/cgi/man.cgi?query\u003dovs-vswitchd.conf.db\u0026apropos\u003d0\u0026sektion\u003d5\u0026manpath\u003dFreeBSD+Ports+9.0-RELEASE\u0026arch\u003ddefault\u0026format\u003dhtml )\nThere\u0027s similar values for os-ken (https://opendev.org/openstack/os-ken/src/branch/master/os_ken/lib/bfdlib.py#L79 ) and for FRR (http://docs.frrouting.org/en/latest/bfd.html#clicmd-detect-multiplier(2-255) )\n\nI tried to give some meaningful defaults.","commit_id":"7448b2617a44a67cb6880f305d201c8241e52b74"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b815d414c0479db824c5ee10bc29632fdf3226b3","unresolved":true,"context_lines":[{"line_number":1752,"context_line":"  description: |"},{"line_number":1753,"context_line":"    The shortest interval, in millisecs, at which this BFD session is"},{"line_number":1754,"context_line":"    willing to transmit BFD control messages. At least 1. Default"},{"line_number":1755,"context_line":"    is 100."},{"line_number":1756,"context_line":"  in: body"},{"line_number":1757,"context_line":"  required: false"},{"line_number":1758,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"b39e2ebc_7f6203a6","line":1755,"range":{"start_line":1755,"start_character":7,"end_line":1755,"end_character":10},"updated":"2021-05-26 13:44:01.000000000","message":"ditto","commit_id":"7448b2617a44a67cb6880f305d201c8241e52b74"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"8762f9c11d226097e7744c5f38dbc7ad9e66c780","unresolved":true,"context_lines":[{"line_number":1752,"context_line":"  description: |"},{"line_number":1753,"context_line":"    The shortest interval, in millisecs, at which this BFD session is"},{"line_number":1754,"context_line":"    willing to transmit BFD control messages. At least 1. Default"},{"line_number":1755,"context_line":"    is 100."},{"line_number":1756,"context_line":"  in: body"},{"line_number":1757,"context_line":"  required: false"},{"line_number":1758,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"76c16635_d1bf6764","line":1755,"range":{"start_line":1755,"start_character":7,"end_line":1755,"end_character":10},"in_reply_to":"b39e2ebc_7f6203a6","updated":"2021-05-28 09:58:22.000000000","message":"see my answer @L1747","commit_id":"7448b2617a44a67cb6880f305d201c8241e52b74"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b815d414c0479db824c5ee10bc29632fdf3226b3","unresolved":true,"context_lines":[{"line_number":1768,"context_line":"  description: |"},{"line_number":1769,"context_line":"    The BFD detection multiplier, An endpoint signals  a connectivity"},{"line_number":1770,"context_line":"    fault if the given number of consecutive BFD control messages fail"},{"line_number":1771,"context_line":"    to arrive. Default is 3."},{"line_number":1772,"context_line":"  in: body"},{"line_number":1773,"context_line":"  required: false"},{"line_number":1774,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"f4e2a362_7556cfec","line":1771,"range":{"start_line":1771,"start_character":25,"end_line":1771,"end_character":27},"updated":"2021-05-26 13:44:01.000000000","message":"ditto","commit_id":"7448b2617a44a67cb6880f305d201c8241e52b74"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"8762f9c11d226097e7744c5f38dbc7ad9e66c780","unresolved":true,"context_lines":[{"line_number":1768,"context_line":"  description: |"},{"line_number":1769,"context_line":"    The BFD detection multiplier, An endpoint signals  a connectivity"},{"line_number":1770,"context_line":"    fault if the given number of consecutive BFD control messages fail"},{"line_number":1771,"context_line":"    to arrive. Default is 3."},{"line_number":1772,"context_line":"  in: body"},{"line_number":1773,"context_line":"  required: false"},{"line_number":1774,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"5bae1a43_1b2b371e","line":1771,"range":{"start_line":1771,"start_character":25,"end_line":1771,"end_character":27},"in_reply_to":"f4e2a362_7556cfec","updated":"2021-05-28 09:58:22.000000000","message":"see my answer @L1747","commit_id":"7448b2617a44a67cb6880f305d201c8241e52b74"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"5b34383a6f1cd6744af3b9bd8d498bd354c41c3d","unresolved":true,"context_lines":[{"line_number":1727,"context_line":"    List of dictionaries to list the routes details associated with"},{"line_number":1728,"context_line":"    the BFD monitor:"},{"line_number":1729,"context_line":""},{"line_number":1730,"context_line":"    * ``type`` can be now ``extra_route`` and other types later."},{"line_number":1731,"context_line":"    * ``router`` is the uuid of the ``router`` of which ``route`` the"},{"line_number":1732,"context_line":"      monitor is associated with."},{"line_number":1733,"context_line":"    * ``extra_route`` is a dict containing the ``destination`` , ``nexthop``"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9788894c_9fb0dc76","line":1730,"updated":"2021-07-19 13:30:26.000000000","message":"I would say something like \"for now it can be ``extra_route``\" without that \"other types later as this is document which users will read without date so nobody will know when that \"later\" is/will be :)","commit_id":"3726a0606f68efabfbb5ce215d5aee1b398135b0"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"75d42485cc133490d87ae63277a49de498be59fc","unresolved":true,"context_lines":[{"line_number":1727,"context_line":"    List of dictionaries to list the routes details associated with"},{"line_number":1728,"context_line":"    the BFD monitor:"},{"line_number":1729,"context_line":""},{"line_number":1730,"context_line":"    * ``type`` can be now ``extra_route`` and other types later."},{"line_number":1731,"context_line":"    * ``router`` is the uuid of the ``router`` of which ``route`` the"},{"line_number":1732,"context_line":"      monitor is associated with."},{"line_number":1733,"context_line":"    * ``extra_route`` is a dict containing the ``destination`` , ``nexthop``"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"968978a2_6a16c5d2","line":1730,"in_reply_to":"9788894c_9fb0dc76","updated":"2021-07-26 15:48:18.000000000","message":"You are right, I changed it.","commit_id":"3726a0606f68efabfbb5ce215d5aee1b398135b0"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"5b34383a6f1cd6744af3b9bd8d498bd354c41c3d","unresolved":true,"context_lines":[{"line_number":1767,"context_line":"  type: string"},{"line_number":1768,"context_line":"bfd_monitor_min_rx:"},{"line_number":1769,"context_line":"  description: |"},{"line_number":1770,"context_line":"    The shortest interval, in millisecs, at which this BFD session"},{"line_number":1771,"context_line":"    offers to receive BFD control messages. At least 1. Defaults"},{"line_number":1772,"context_line":"    is 1000."},{"line_number":1773,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"15e86b1d_b8c685b5","line":1770,"range":{"start_line":1770,"start_character":30,"end_line":1770,"end_character":39},"updated":"2021-07-19 13:30:26.000000000","message":"nit: wouldn\u0027t be better to write \"miliseconds\" here?","commit_id":"3726a0606f68efabfbb5ce215d5aee1b398135b0"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"0d30d158008b003d1022fac9ed4e2c28feb98b8d","unresolved":false,"context_lines":[{"line_number":1767,"context_line":"  type: string"},{"line_number":1768,"context_line":"bfd_monitor_min_rx:"},{"line_number":1769,"context_line":"  description: |"},{"line_number":1770,"context_line":"    The shortest interval, in millisecs, at which this BFD session"},{"line_number":1771,"context_line":"    offers to receive BFD control messages. At least 1. Defaults"},{"line_number":1772,"context_line":"    is 1000."},{"line_number":1773,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"52755097_4b902e9c","line":1770,"range":{"start_line":1770,"start_character":30,"end_line":1770,"end_character":39},"in_reply_to":"15e86b1d_b8c685b5","updated":"2021-07-26 15:44:35.000000000","message":"Done","commit_id":"3726a0606f68efabfbb5ce215d5aee1b398135b0"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"5b34383a6f1cd6744af3b9bd8d498bd354c41c3d","unresolved":true,"context_lines":[{"line_number":1768,"context_line":"bfd_monitor_min_rx:"},{"line_number":1769,"context_line":"  description: |"},{"line_number":1770,"context_line":"    The shortest interval, in millisecs, at which this BFD session"},{"line_number":1771,"context_line":"    offers to receive BFD control messages. At least 1. Defaults"},{"line_number":1772,"context_line":"    is 1000."},{"line_number":1773,"context_line":"  in: body"},{"line_number":1774,"context_line":"  required: false"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9ed3dfd6_b14c719c","line":1771,"range":{"start_line":1771,"start_character":56,"end_line":1771,"end_character":64},"updated":"2021-07-19 13:30:26.000000000","message":"I think it should be \"Default\"","commit_id":"3726a0606f68efabfbb5ce215d5aee1b398135b0"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"0d30d158008b003d1022fac9ed4e2c28feb98b8d","unresolved":false,"context_lines":[{"line_number":1768,"context_line":"bfd_monitor_min_rx:"},{"line_number":1769,"context_line":"  description: |"},{"line_number":1770,"context_line":"    The shortest interval, in millisecs, at which this BFD session"},{"line_number":1771,"context_line":"    offers to receive BFD control messages. At least 1. Defaults"},{"line_number":1772,"context_line":"    is 1000."},{"line_number":1773,"context_line":"  in: body"},{"line_number":1774,"context_line":"  required: false"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9e2f7ce1_e9c2742c","line":1771,"range":{"start_line":1771,"start_character":56,"end_line":1771,"end_character":64},"in_reply_to":"9ed3dfd6_b14c719c","updated":"2021-07-26 15:44:35.000000000","message":"Done","commit_id":"3726a0606f68efabfbb5ce215d5aee1b398135b0"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"5b34383a6f1cd6744af3b9bd8d498bd354c41c3d","unresolved":true,"context_lines":[{"line_number":1775,"context_line":"  type: string"},{"line_number":1776,"context_line":"bfd_monitor_min_tx:"},{"line_number":1777,"context_line":"  description: |"},{"line_number":1778,"context_line":"    The shortest interval, in millisecs, at which this BFD session is"},{"line_number":1779,"context_line":"    willing to transmit BFD control messages. At least 1. Default"},{"line_number":1780,"context_line":"    is 100."},{"line_number":1781,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"bdc2fb12_22e8db4d","line":1778,"range":{"start_line":1778,"start_character":30,"end_line":1778,"end_character":39},"updated":"2021-07-19 13:30:26.000000000","message":"same nit here","commit_id":"3726a0606f68efabfbb5ce215d5aee1b398135b0"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"0d30d158008b003d1022fac9ed4e2c28feb98b8d","unresolved":false,"context_lines":[{"line_number":1775,"context_line":"  type: string"},{"line_number":1776,"context_line":"bfd_monitor_min_tx:"},{"line_number":1777,"context_line":"  description: |"},{"line_number":1778,"context_line":"    The shortest interval, in millisecs, at which this BFD session is"},{"line_number":1779,"context_line":"    willing to transmit BFD control messages. At least 1. Default"},{"line_number":1780,"context_line":"    is 100."},{"line_number":1781,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"ce89572b_473636f3","line":1778,"range":{"start_line":1778,"start_character":30,"end_line":1778,"end_character":39},"in_reply_to":"bdc2fb12_22e8db4d","updated":"2021-07-26 15:44:35.000000000","message":"Done","commit_id":"3726a0606f68efabfbb5ce215d5aee1b398135b0"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"5b34383a6f1cd6744af3b9bd8d498bd354c41c3d","unresolved":true,"context_lines":[{"line_number":1816,"context_line":"  description: |"},{"line_number":1817,"context_line":"    List of dictionaries with the following fields:"},{"line_number":1818,"context_line":""},{"line_number":1819,"context_line":"    * ``type`` can be now ``extra_route`` and other types later."},{"line_number":1820,"context_line":"    * ``router`` is the uuid of the ``router`` of which ``route`` the"},{"line_number":1821,"context_line":"      monitor is associated with."},{"line_number":1822,"context_line":"    * ``extra_route`` is a dict containing the ``destination`` , ``nexthop``"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"24c87cc7_5478db8f","line":1819,"range":{"start_line":1819,"start_character":6,"end_line":1819,"end_character":64},"updated":"2021-07-19 13:30:26.000000000","message":"see my comment above in L1730","commit_id":"3726a0606f68efabfbb5ce215d5aee1b398135b0"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"75d42485cc133490d87ae63277a49de498be59fc","unresolved":false,"context_lines":[{"line_number":1816,"context_line":"  description: |"},{"line_number":1817,"context_line":"    List of dictionaries with the following fields:"},{"line_number":1818,"context_line":""},{"line_number":1819,"context_line":"    * ``type`` can be now ``extra_route`` and other types later."},{"line_number":1820,"context_line":"    * ``router`` is the uuid of the ``router`` of which ``route`` the"},{"line_number":1821,"context_line":"      monitor is associated with."},{"line_number":1822,"context_line":"    * ``extra_route`` is a dict containing the ``destination`` , ``nexthop``"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"0fd8f4d7_0e8afff6","line":1819,"range":{"start_line":1819,"start_character":6,"end_line":1819,"end_character":64},"in_reply_to":"24c87cc7_5478db8f","updated":"2021-07-26 15:48:18.000000000","message":"Done","commit_id":"3726a0606f68efabfbb5ce215d5aee1b398135b0"},{"author":{"_account_id":33273,"name":"Manu B","display_name":"Manu B","email":"manu.b@est.tech","username":"eceghkl"},"change_message_id":"c928632c6f25bfc6673a0a160225601cfeb6bf53","unresolved":true,"context_lines":[{"line_number":1744,"context_line":"    ``Password`` or ``Auth Key``."},{"line_number":1745,"context_line":"  in: body"},{"line_number":1746,"context_line":"  required: true"},{"line_number":1747,"context_line":"  type: string"},{"line_number":1748,"context_line":"bfd_monitor_auth_type:"},{"line_number":1749,"context_line":"  description: |"},{"line_number":1750,"context_line":"    The Authentication Type, which can be ``password``, ``MD5``,"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"16a6666a_ea76ec9a","line":1747,"range":{"start_line":1747,"start_character":8,"end_line":1747,"end_character":14},"updated":"2021-08-05 11:19:19.000000000","message":"according to the description, this looks to be array","commit_id":"f4a489d9c48598f712cd43c23ff35b040c5efb10"},{"author":{"_account_id":33273,"name":"Manu B","display_name":"Manu B","email":"manu.b@est.tech","username":"eceghkl"},"change_message_id":"c928632c6f25bfc6673a0a160225601cfeb6bf53","unresolved":true,"context_lines":[{"line_number":1751,"context_line":"    ``MeticulousMD5``, ``SHA1``, ``MeticulousSHA1``, if empty no"},{"line_number":1752,"context_line":"    authentication is used."},{"line_number":1753,"context_line":"  in: body"},{"line_number":1754,"context_line":"  required: true"},{"line_number":1755,"context_line":"  type: string"},{"line_number":1756,"context_line":"bfd_monitor_dst_ip:"},{"line_number":1757,"context_line":"  description: |"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"a3a34ad8_08c22ce7","line":1754,"range":{"start_line":1754,"start_character":2,"end_line":1754,"end_character":16},"updated":"2021-08-05 11:19:19.000000000","message":"according to the description, this can be false","commit_id":"f4a489d9c48598f712cd43c23ff35b040c5efb10"},{"author":{"_account_id":33273,"name":"Manu B","display_name":"Manu B","email":"manu.b@est.tech","username":"eceghkl"},"change_message_id":"a4b3f08ae2f46f6c2d2c239c53c01fecd2471fa7","unresolved":true,"context_lines":[{"line_number":1812,"context_line":"bfd_monitor_mode:"},{"line_number":1813,"context_line":"  description: |"},{"line_number":1814,"context_line":"    Can be ``asynchronous`` (default common echo mode of BFD) or"},{"line_number":1815,"context_line":"    ``demand`` (some other mechanism is used to detect link state)"},{"line_number":1816,"context_line":"    and can accept future modes."},{"line_number":1817,"context_line":"  in: body"},{"line_number":1818,"context_line":"  required: false"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"2202934f_f624f78a","line":1815,"updated":"2021-08-10 09:46:21.000000000","message":"pls add one-arm-echo also here","commit_id":"9b4b802ff3e25d278e9ecdb1951dc63aea2733ef"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"f4128921d4e089ca08509f667b24f741c6f8ee1f","unresolved":false,"context_lines":[{"line_number":1812,"context_line":"bfd_monitor_mode:"},{"line_number":1813,"context_line":"  description: |"},{"line_number":1814,"context_line":"    Can be ``asynchronous`` (default common echo mode of BFD) or"},{"line_number":1815,"context_line":"    ``demand`` (some other mechanism is used to detect link state)"},{"line_number":1816,"context_line":"    and can accept future modes."},{"line_number":1817,"context_line":"  in: body"},{"line_number":1818,"context_line":"  required: false"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"56250fbe_a3579ef0","line":1815,"in_reply_to":"2202934f_f624f78a","updated":"2021-08-10 12:28:50.000000000","message":"Done","commit_id":"9b4b802ff3e25d278e9ecdb1951dc63aea2733ef"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"445bdd9c6251cbf473ea81811c3ffb89dfc6e7c4","unresolved":true,"context_lines":[{"line_number":1758,"context_line":"    * ``type`` for now it can be ``extra_route``."},{"line_number":1759,"context_line":"    * ``router`` is the uuid of the ``router`` of which ``route`` the"},{"line_number":1760,"context_line":"      monitor is associated with."},{"line_number":1761,"context_line":"    * ``extra_route`` is a dict containing the ``destination`` , ``nexthop``"},{"line_number":1762,"context_line":"      information."},{"line_number":1763,"context_line":"    * ``src_ip`` is the source ip address used as source for transmitted"},{"line_number":1764,"context_line":"      BFD packets."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"3a31ebe8_cc5fe4d0","line":1761,"range":{"start_line":1761,"start_character":27,"end_line":1761,"end_character":31},"updated":"2021-08-17 11:20:22.000000000","message":"nitty nit: should we use \"dict\" or \"dictionary\" ?","commit_id":"f8c5b72cc84fb982d990f127d8957071e430e577"}],"api-ref/source/v2/samples/bfd/bfd_monitor-create-request.json":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"5b34383a6f1cd6744af3b9bd8d498bd354c41c3d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"bfd_monitor\": {"},{"line_number":3,"context_line":"        \"name\": \"bfd_monitor_1\","},{"line_number":4,"context_line":"        \"description\": \"My MFD monitor\","},{"line_number":5,"context_line":"        \"dst_ip\": \"192.168.100.12\""},{"line_number":6,"context_line":"    }"},{"line_number":7,"context_line":"}"}],"source_content_type":"application/json","patch_set":9,"id":"a86601cf_f1ee8570","line":4,"range":{"start_line":4,"start_character":27,"end_line":4,"end_character":30},"updated":"2021-07-19 13:30:26.000000000","message":"nitty nit: MFD or BFD?","commit_id":"3726a0606f68efabfbb5ce215d5aee1b398135b0"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"0d30d158008b003d1022fac9ed4e2c28feb98b8d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"bfd_monitor\": {"},{"line_number":3,"context_line":"        \"name\": \"bfd_monitor_1\","},{"line_number":4,"context_line":"        \"description\": \"My MFD monitor\","},{"line_number":5,"context_line":"        \"dst_ip\": \"192.168.100.12\""},{"line_number":6,"context_line":"    }"},{"line_number":7,"context_line":"}"}],"source_content_type":"application/json","patch_set":9,"id":"ae8ac612_5690bc9a","line":4,"range":{"start_line":4,"start_character":27,"end_line":4,"end_character":30},"in_reply_to":"a86601cf_f1ee8570","updated":"2021-07-26 15:44:35.000000000","message":"Done","commit_id":"3726a0606f68efabfbb5ce215d5aee1b398135b0"},{"author":{"_account_id":33273,"name":"Manu B","display_name":"Manu B","email":"manu.b@est.tech","username":"eceghkl"},"change_message_id":"a4b3f08ae2f46f6c2d2c239c53c01fecd2471fa7","unresolved":true,"context_lines":[{"line_number":3,"context_line":"        \"name\": \"bfd_monitor_1\","},{"line_number":4,"context_line":"        \"description\": \"My BFD monitor\","},{"line_number":5,"context_line":"        \"dst_ip\": \"192.168.100.12\""},{"line_number":6,"context_line":"    }"},{"line_number":7,"context_line":"}"}],"source_content_type":"application/json","patch_set":13,"id":"af7f4b4d_34683f7e","line":6,"updated":"2021-08-10 09:46:21.000000000","message":"src_ip would be good to be added","commit_id":"9b4b802ff3e25d278e9ecdb1951dc63aea2733ef"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"f4128921d4e089ca08509f667b24f741c6f8ee1f","unresolved":false,"context_lines":[{"line_number":3,"context_line":"        \"name\": \"bfd_monitor_1\","},{"line_number":4,"context_line":"        \"description\": \"My BFD monitor\","},{"line_number":5,"context_line":"        \"dst_ip\": \"192.168.100.12\""},{"line_number":6,"context_line":"    }"},{"line_number":7,"context_line":"}"}],"source_content_type":"application/json","patch_set":13,"id":"5390da5f_2b823396","line":6,"in_reply_to":"af7f4b4d_34683f7e","updated":"2021-08-10 12:28:50.000000000","message":"Done","commit_id":"9b4b802ff3e25d278e9ecdb1951dc63aea2733ef"}],"api-ref/source/v2/samples/bfd/bfd_monitor-create-response.json":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"5b34383a6f1cd6744af3b9bd8d498bd354c41c3d","unresolved":true,"context_lines":[{"line_number":4,"context_line":"        \"tenant_id\": \"8d4c70a21fed4aeba121a1a429ba0d04\","},{"line_number":5,"context_line":"        \"id\": \"46ebaec0-0570-43ac-82f6-60d2b03168c4\","},{"line_number":6,"context_line":"        \"name\": \"bfd_monitor_1\","},{"line_number":7,"context_line":"        \"description\": \"My MFD monitor\","},{"line_number":8,"context_line":"        \"mode\": \"asynchronous\","},{"line_number":9,"context_line":"        \"dst_ip\": \"192.168.100.12\","},{"line_number":10,"context_line":"        \"min_rx\": \"1000\","}],"source_content_type":"application/json","patch_set":9,"id":"2de31d7f_1a7ce726","line":7,"updated":"2021-07-19 13:30:26.000000000","message":"same nitty nit here","commit_id":"3726a0606f68efabfbb5ce215d5aee1b398135b0"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"0d30d158008b003d1022fac9ed4e2c28feb98b8d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"        \"tenant_id\": \"8d4c70a21fed4aeba121a1a429ba0d04\","},{"line_number":5,"context_line":"        \"id\": \"46ebaec0-0570-43ac-82f6-60d2b03168c4\","},{"line_number":6,"context_line":"        \"name\": \"bfd_monitor_1\","},{"line_number":7,"context_line":"        \"description\": \"My MFD monitor\","},{"line_number":8,"context_line":"        \"mode\": \"asynchronous\","},{"line_number":9,"context_line":"        \"dst_ip\": \"192.168.100.12\","},{"line_number":10,"context_line":"        \"min_rx\": \"1000\","}],"source_content_type":"application/json","patch_set":9,"id":"6ac0983a_27f4bb79","line":7,"in_reply_to":"2de31d7f_1a7ce726","updated":"2021-07-26 15:44:35.000000000","message":"Done","commit_id":"3726a0606f68efabfbb5ce215d5aee1b398135b0"}],"api-ref/source/v2/samples/bfd/bfd_monitor-list-response.json":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"5b34383a6f1cd6744af3b9bd8d498bd354c41c3d","unresolved":true,"context_lines":[{"line_number":5,"context_line":"            \"tenant_id\": \"8d4c70a21fed4aeba121a1a429ba0d04\","},{"line_number":6,"context_line":"            \"id\": \"46ebaec0-0570-43ac-82f6-60d2b03168c4\","},{"line_number":7,"context_line":"            \"name\": \"bfd_monitor_1\","},{"line_number":8,"context_line":"            \"description\": \"My MFD monitor\","},{"line_number":9,"context_line":"            \"mode\": \"asynchronous\","},{"line_number":10,"context_line":"            \"dst_ip\": \"192.168.100.12\","},{"line_number":11,"context_line":"            \"min_rx\": \"1000\","}],"source_content_type":"application/json","patch_set":9,"id":"609fd491_6f3d0689","line":8,"updated":"2021-07-19 13:30:26.000000000","message":"and here 😊","commit_id":"3726a0606f68efabfbb5ce215d5aee1b398135b0"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"0d30d158008b003d1022fac9ed4e2c28feb98b8d","unresolved":false,"context_lines":[{"line_number":5,"context_line":"            \"tenant_id\": \"8d4c70a21fed4aeba121a1a429ba0d04\","},{"line_number":6,"context_line":"            \"id\": \"46ebaec0-0570-43ac-82f6-60d2b03168c4\","},{"line_number":7,"context_line":"            \"name\": \"bfd_monitor_1\","},{"line_number":8,"context_line":"            \"description\": \"My MFD monitor\","},{"line_number":9,"context_line":"            \"mode\": \"asynchronous\","},{"line_number":10,"context_line":"            \"dst_ip\": \"192.168.100.12\","},{"line_number":11,"context_line":"            \"min_rx\": \"1000\","}],"source_content_type":"application/json","patch_set":9,"id":"d971c4da_89f75b1d","line":8,"in_reply_to":"609fd491_6f3d0689","updated":"2021-07-26 15:44:35.000000000","message":"Done","commit_id":"3726a0606f68efabfbb5ce215d5aee1b398135b0"}],"api-ref/source/v2/samples/bfd/bfd_monitor-show-response.json":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"5b34383a6f1cd6744af3b9bd8d498bd354c41c3d","unresolved":true,"context_lines":[{"line_number":4,"context_line":"        \"tenant_id\": \"8d4c70a21fed4aeba121a1a429ba0d04\","},{"line_number":5,"context_line":"        \"id\": \"46ebaec0-0570-43ac-82f6-60d2b03168c4\","},{"line_number":6,"context_line":"        \"name\": \"bfd_monitor_1\","},{"line_number":7,"context_line":"        \"description\": \"My MFD monitor\","},{"line_number":8,"context_line":"        \"mode\": \"asynchronous\","},{"line_number":9,"context_line":"        \"dst_ip\": \"192.168.100.12\","},{"line_number":10,"context_line":"        \"min_rx\": \"1000\","}],"source_content_type":"application/json","patch_set":9,"id":"c97df2ef_f75dd4fa","line":7,"updated":"2021-07-19 13:30:26.000000000","message":"and here","commit_id":"3726a0606f68efabfbb5ce215d5aee1b398135b0"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"0d30d158008b003d1022fac9ed4e2c28feb98b8d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"        \"tenant_id\": \"8d4c70a21fed4aeba121a1a429ba0d04\","},{"line_number":5,"context_line":"        \"id\": \"46ebaec0-0570-43ac-82f6-60d2b03168c4\","},{"line_number":6,"context_line":"        \"name\": \"bfd_monitor_1\","},{"line_number":7,"context_line":"        \"description\": \"My MFD monitor\","},{"line_number":8,"context_line":"        \"mode\": \"asynchronous\","},{"line_number":9,"context_line":"        \"dst_ip\": \"192.168.100.12\","},{"line_number":10,"context_line":"        \"min_rx\": \"1000\","}],"source_content_type":"application/json","patch_set":9,"id":"f236760e_87b85367","line":7,"in_reply_to":"c97df2ef_f75dd4fa","updated":"2021-07-26 15:44:35.000000000","message":"Done","commit_id":"3726a0606f68efabfbb5ce215d5aee1b398135b0"},{"author":{"_account_id":33273,"name":"Manu B","display_name":"Manu B","email":"manu.b@est.tech","username":"eceghkl"},"change_message_id":"a4b3f08ae2f46f6c2d2c239c53c01fecd2471fa7","unresolved":true,"context_lines":[{"line_number":11,"context_line":"        \"min_rx\": \"1000\","},{"line_number":12,"context_line":"        \"min_tx\": \"100\","},{"line_number":13,"context_line":"        \"multiplier\": \"3\","},{"line_number":14,"context_line":"        \"status\": \"UP\","},{"line_number":15,"context_line":"        \"auth_key\": \"None\","},{"line_number":16,"context_line":"        \"auth_type\": \"None\""},{"line_number":17,"context_line":"    }"}],"source_content_type":"application/json","patch_set":13,"id":"28710ad1_57022b65","line":14,"updated":"2021-08-10 09:46:21.000000000","message":"would the status \u0027ÁCTIVE\u0027 better than UP? usually we have seen the status field to be set to ACTIVE rather than UP in other neutron resources","commit_id":"9b4b802ff3e25d278e9ecdb1951dc63aea2733ef"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"f4128921d4e089ca08509f667b24f741c6f8ee1f","unresolved":false,"context_lines":[{"line_number":11,"context_line":"        \"min_rx\": \"1000\","},{"line_number":12,"context_line":"        \"min_tx\": \"100\","},{"line_number":13,"context_line":"        \"multiplier\": \"3\","},{"line_number":14,"context_line":"        \"status\": \"UP\","},{"line_number":15,"context_line":"        \"auth_key\": \"None\","},{"line_number":16,"context_line":"        \"auth_type\": \"None\""},{"line_number":17,"context_line":"    }"}],"source_content_type":"application/json","patch_set":13,"id":"f49d1cd9_bedc193f","line":14,"in_reply_to":"28710ad1_57022b65","updated":"2021-08-10 12:28:50.000000000","message":"Done","commit_id":"9b4b802ff3e25d278e9ecdb1951dc63aea2733ef"}],"api-ref/source/v2/samples/bfd/bfd_monitor-update-request.json":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"5b34383a6f1cd6744af3b9bd8d498bd354c41c3d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"bfd_monitor\": {"},{"line_number":3,"context_line":"        \"name\": \"bfd_monitor_1\","},{"line_number":4,"context_line":"        \"description\": \"My MFD monitor\","},{"line_number":5,"context_line":"        \"dst_ip\": \"192.168.100.12\","},{"line_number":6,"context_line":"        \"min_rx\": \"2000\","},{"line_number":7,"context_line":"        \"min_tx\": \"1000\","}],"source_content_type":"application/json","patch_set":9,"id":"d75073f7_58f23b3c","line":4,"updated":"2021-07-19 13:30:26.000000000","message":"and here","commit_id":"3726a0606f68efabfbb5ce215d5aee1b398135b0"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"0d30d158008b003d1022fac9ed4e2c28feb98b8d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"bfd_monitor\": {"},{"line_number":3,"context_line":"        \"name\": \"bfd_monitor_1\","},{"line_number":4,"context_line":"        \"description\": \"My MFD monitor\","},{"line_number":5,"context_line":"        \"dst_ip\": \"192.168.100.12\","},{"line_number":6,"context_line":"        \"min_rx\": \"2000\","},{"line_number":7,"context_line":"        \"min_tx\": \"1000\","}],"source_content_type":"application/json","patch_set":9,"id":"efa153cb_135f294b","line":4,"in_reply_to":"d75073f7_58f23b3c","updated":"2021-07-26 15:44:35.000000000","message":"Done","commit_id":"3726a0606f68efabfbb5ce215d5aee1b398135b0"},{"author":{"_account_id":33273,"name":"Manu B","display_name":"Manu B","email":"manu.b@est.tech","username":"eceghkl"},"change_message_id":"a4b3f08ae2f46f6c2d2c239c53c01fecd2471fa7","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"bfd_monitor\": {"},{"line_number":3,"context_line":"        \"name\": \"bfd_monitor_1\","},{"line_number":4,"context_line":"        \"description\": \"My BFD monitor\","},{"line_number":5,"context_line":"        \"min_rx\": \"2000\","},{"line_number":6,"context_line":"        \"min_tx\": \"1000\","}],"source_content_type":"application/json","patch_set":13,"id":"47725d77_fba29b10","line":3,"updated":"2021-08-10 09:46:21.000000000","message":"are we allowing the name and description to be updatable?","commit_id":"9b4b802ff3e25d278e9ecdb1951dc63aea2733ef"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"f4128921d4e089ca08509f667b24f741c6f8ee1f","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"bfd_monitor\": {"},{"line_number":3,"context_line":"        \"name\": \"bfd_monitor_1\","},{"line_number":4,"context_line":"        \"description\": \"My BFD monitor\","},{"line_number":5,"context_line":"        \"min_rx\": \"2000\","},{"line_number":6,"context_line":"        \"min_tx\": \"1000\","}],"source_content_type":"application/json","patch_set":13,"id":"e0549df6_65f41902","line":3,"in_reply_to":"47725d77_fba29b10","updated":"2021-08-10 12:28:50.000000000","message":"yes","commit_id":"9b4b802ff3e25d278e9ecdb1951dc63aea2733ef"}],"api-ref/source/v2/samples/bfd/bfd_monitor-update-response.json":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"5b34383a6f1cd6744af3b9bd8d498bd354c41c3d","unresolved":true,"context_lines":[{"line_number":4,"context_line":"        \"tenant_id\": \"8d4c70a21fed4aeba121a1a429ba0d04\","},{"line_number":5,"context_line":"        \"id\": \"46ebaec0-0570-43ac-82f6-60d2b03168c4\","},{"line_number":6,"context_line":"        \"name\": \"bfd_monitor_1\","},{"line_number":7,"context_line":"        \"description\": \"My MFD monitor\","},{"line_number":8,"context_line":"        \"mode\": \"asynchronous\","},{"line_number":9,"context_line":"        \"dst_ip\": \"192.168.100.12\","},{"line_number":10,"context_line":"        \"min_rx\": \"1000\","}],"source_content_type":"application/json","patch_set":9,"id":"0b267980_909d6deb","line":7,"updated":"2021-07-19 13:30:26.000000000","message":"and here","commit_id":"3726a0606f68efabfbb5ce215d5aee1b398135b0"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"0d30d158008b003d1022fac9ed4e2c28feb98b8d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"        \"tenant_id\": \"8d4c70a21fed4aeba121a1a429ba0d04\","},{"line_number":5,"context_line":"        \"id\": \"46ebaec0-0570-43ac-82f6-60d2b03168c4\","},{"line_number":6,"context_line":"        \"name\": \"bfd_monitor_1\","},{"line_number":7,"context_line":"        \"description\": \"My MFD monitor\","},{"line_number":8,"context_line":"        \"mode\": \"asynchronous\","},{"line_number":9,"context_line":"        \"dst_ip\": \"192.168.100.12\","},{"line_number":10,"context_line":"        \"min_rx\": \"1000\","}],"source_content_type":"application/json","patch_set":9,"id":"710a3495_0ae3f981","line":7,"in_reply_to":"0b267980_909d6deb","updated":"2021-07-26 15:44:35.000000000","message":"Done","commit_id":"3726a0606f68efabfbb5ce215d5aee1b398135b0"}],"api-ref/source/v2/samples/bfd/bfd_monitor_association-response.json":[{"author":{"_account_id":33273,"name":"Manu B","display_name":"Manu B","email":"manu.b@est.tech","username":"eceghkl"},"change_message_id":"c928632c6f25bfc6673a0a160225601cfeb6bf53","unresolved":true,"context_lines":[{"line_number":8,"context_line":"                \"nexthop\": \"10.0.0.1\""},{"line_number":9,"context_line":"            },"},{"line_number":10,"context_line":"            \"src_ip\": \"169.254.112.144\","},{"line_number":11,"context_line":"            \"status\": {"},{"line_number":12,"context_line":"                \"SessionState\": \"Up\","},{"line_number":13,"context_line":"                \"RemoteSessionState\": \"Up\","},{"line_number":14,"context_line":"                \"LocalDiagnostic\": \"\","}],"source_content_type":"application/json","patch_set":12,"id":"9d922085_898cf66f","line":11,"updated":"2021-08-05 11:19:19.000000000","message":"status is not part of bfd_monitor_associations_remotes in the parameters.yaml","commit_id":"f4a489d9c48598f712cd43c23ff35b040c5efb10"},{"author":{"_account_id":33273,"name":"Manu B","display_name":"Manu B","email":"manu.b@est.tech","username":"eceghkl"},"change_message_id":"a4b3f08ae2f46f6c2d2c239c53c01fecd2471fa7","unresolved":true,"context_lines":[{"line_number":7,"context_line":"                \"destination\": \"10.0.3.0/24\","},{"line_number":8,"context_line":"                \"nexthop\": \"10.0.0.1\""},{"line_number":9,"context_line":"            },"},{"line_number":10,"context_line":"            \"src_ip\": \"169.254.112.144\","},{"line_number":11,"context_line":"            \"status\": {"},{"line_number":12,"context_line":"                \"SessionState\": \"Up\","},{"line_number":13,"context_line":"                \"RemoteSessionState\": \"Up\","}],"source_content_type":"application/json","patch_set":13,"id":"ae1c34bd_286de723","line":10,"updated":"2021-08-10 09:46:21.000000000","message":"would be good to add dst_ip","commit_id":"9b4b802ff3e25d278e9ecdb1951dc63aea2733ef"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"f4128921d4e089ca08509f667b24f741c6f8ee1f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"                \"destination\": \"10.0.3.0/24\","},{"line_number":8,"context_line":"                \"nexthop\": \"10.0.0.1\""},{"line_number":9,"context_line":"            },"},{"line_number":10,"context_line":"            \"src_ip\": \"169.254.112.144\","},{"line_number":11,"context_line":"            \"status\": {"},{"line_number":12,"context_line":"                \"SessionState\": \"Up\","},{"line_number":13,"context_line":"                \"RemoteSessionState\": \"Up\","}],"source_content_type":"application/json","patch_set":13,"id":"3f338751_5db688ad","line":10,"in_reply_to":"ae1c34bd_286de723","updated":"2021-08-10 12:28:50.000000000","message":"Done","commit_id":"9b4b802ff3e25d278e9ecdb1951dc63aea2733ef"}],"api-ref/source/v2/samples/bfd/bfd_monitor_session_status-response.json":[{"author":{"_account_id":33273,"name":"Manu B","display_name":"Manu B","email":"manu.b@est.tech","username":"eceghkl"},"change_message_id":"c928632c6f25bfc6673a0a160225601cfeb6bf53","unresolved":true,"context_lines":[{"line_number":8,"context_line":"                \"nexthop\": \"10.0.0.1\""},{"line_number":9,"context_line":"            },"},{"line_number":10,"context_line":"            \"src_ip\": \"169.254.112.144\""},{"line_number":11,"context_line":"        }]"},{"line_number":12,"context_line":"    }"},{"line_number":13,"context_line":"}"}],"source_content_type":"application/json","patch_set":12,"id":"2e1dea10_bf3955a0","line":11,"updated":"2021-08-05 11:19:19.000000000","message":"status is missing","commit_id":"f4a489d9c48598f712cd43c23ff35b040c5efb10"}],"neutron_lib/api/definitions/bfd_monitor.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"5b34383a6f1cd6744af3b9bd8d498bd354c41c3d","unresolved":true,"context_lines":[{"line_number":21,"context_line":"IS_STANDARD_ATTR_EXTENSION \u003d False"},{"line_number":22,"context_line":"NAME \u003d \u0027BFD monitors for Neutron\u0027"},{"line_number":23,"context_line":"DESCRIPTION \u003d \"Provides support for BFD monitors\""},{"line_number":24,"context_line":"UPDATED_TIMESTAMP \u003d \"2021-02-12T11:00:00-00:00\""},{"line_number":25,"context_line":"BFD_MONITOR \u003d \u0027bfd_monitor\u0027"},{"line_number":26,"context_line":"BFD_MONITORS \u003d \u0027bfd_monitors\u0027"},{"line_number":27,"context_line":"BFD_SESSION_STATUS \u003d \u0027bfd_session_status\u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"db7efe9b_c59ebf52","line":24,"updated":"2021-07-19 13:30:26.000000000","message":"nitty nit: maybe You can update this date now :)","commit_id":"3726a0606f68efabfbb5ce215d5aee1b398135b0"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"0d30d158008b003d1022fac9ed4e2c28feb98b8d","unresolved":false,"context_lines":[{"line_number":21,"context_line":"IS_STANDARD_ATTR_EXTENSION \u003d False"},{"line_number":22,"context_line":"NAME \u003d \u0027BFD monitors for Neutron\u0027"},{"line_number":23,"context_line":"DESCRIPTION \u003d \"Provides support for BFD monitors\""},{"line_number":24,"context_line":"UPDATED_TIMESTAMP \u003d \"2021-02-12T11:00:00-00:00\""},{"line_number":25,"context_line":"BFD_MONITOR \u003d \u0027bfd_monitor\u0027"},{"line_number":26,"context_line":"BFD_MONITORS \u003d \u0027bfd_monitors\u0027"},{"line_number":27,"context_line":"BFD_SESSION_STATUS \u003d \u0027bfd_session_status\u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"a437775b_3d276a7a","line":24,"in_reply_to":"db7efe9b_c59ebf52","updated":"2021-07-26 15:44:35.000000000","message":"Done","commit_id":"3726a0606f68efabfbb5ce215d5aee1b398135b0"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"f18dd47cf44eb94987242e3283ef82563148473a","unresolved":true,"context_lines":[{"line_number":91,"context_line":"SUB_RESOURCE_ATTRIBUTE_MAP \u003d {}"},{"line_number":92,"context_line":"ACTION_MAP \u003d {"},{"line_number":93,"context_line":"    BFD_MONITOR: {"},{"line_number":94,"context_line":"        \u0027get_bfd_session_status\u0027: \u0027GET\u0027,"},{"line_number":95,"context_line":"        \u0027get_bfd_monitor_associations\u0027: \u0027GET\u0027,"},{"line_number":96,"context_line":"    }"},{"line_number":97,"context_line":"}"},{"line_number":98,"context_line":"ACTION_STATUS \u003d {}"}],"source_content_type":"text/x-python","patch_set":9,"id":"35dc4407_3f1e4d90","line":95,"range":{"start_line":94,"start_character":9,"end_line":95,"end_character":46},"updated":"2021-07-15 13:18:42.000000000","message":"This is different from what is in the spec (https://specs.openstack.org/openstack/neutron-specs/specs/xena/bfd_support.html#new-bfd-monitor-api )","commit_id":"3726a0606f68efabfbb5ce215d5aee1b398135b0"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a3cd1bb84b45077f5b47bcfe8d6f7dc80ce2c07e","unresolved":true,"context_lines":[{"line_number":91,"context_line":"SUB_RESOURCE_ATTRIBUTE_MAP \u003d {}"},{"line_number":92,"context_line":"ACTION_MAP \u003d {"},{"line_number":93,"context_line":"    BFD_MONITOR: {"},{"line_number":94,"context_line":"        \u0027get_bfd_session_status\u0027: \u0027GET\u0027,"},{"line_number":95,"context_line":"        \u0027get_bfd_monitor_associations\u0027: \u0027GET\u0027,"},{"line_number":96,"context_line":"    }"},{"line_number":97,"context_line":"}"},{"line_number":98,"context_line":"ACTION_STATUS \u003d {}"}],"source_content_type":"text/x-python","patch_set":9,"id":"493f7c9d_c5b32581","line":95,"range":{"start_line":94,"start_character":9,"end_line":95,"end_character":46},"in_reply_to":"35dc4407_3f1e4d90","updated":"2021-07-15 15:34:18.000000000","message":"makes sense to add \"get_\"","commit_id":"3726a0606f68efabfbb5ce215d5aee1b398135b0"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"347f9fd95fab7d684c68fbce6bcf0ebe457e7471","unresolved":true,"context_lines":[{"line_number":58,"context_line":"                   \u0027is_sort_key\u0027: True, \u0027is_filter\u0027: True,"},{"line_number":59,"context_line":"                   \u0027is_visible\u0027: True, \u0027default\u0027: None,"},{"line_number":60,"context_line":"                   \u0027enforce_policy\u0027: True},"},{"line_number":61,"context_line":"        \u0027src_ip\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":62,"context_line":"                   \u0027validate\u0027: {\u0027type:ip_address_or_none\u0027: None},"},{"line_number":63,"context_line":"                   \u0027is_sort_key\u0027: True, \u0027is_filter\u0027: True,"},{"line_number":64,"context_line":"                   \u0027is_visible\u0027: True, \u0027default\u0027: None,"},{"line_number":65,"context_line":"                   \u0027enforce_policy\u0027: True},"},{"line_number":66,"context_line":"        \u0027min_rx\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":67,"context_line":"                   \u0027validate\u0027: {\u0027type:non_negative\u0027: None},"},{"line_number":68,"context_line":"                   \u0027convert_to\u0027: converters.convert_to_int,"}],"source_content_type":"text/x-python","patch_set":12,"id":"46cd31bd_95b81bfc","line":65,"range":{"start_line":61,"start_character":0,"end_line":65,"end_character":43},"updated":"2021-07-30 16:33:04.000000000","message":"This is new, and not in spec, but we got feedback from NFV our developers and backend developers that this can be necessary for their usecases, I will push a followup patch for the spec.","commit_id":"f4a489d9c48598f712cd43c23ff35b040c5efb10"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"ae211d2ed2e8dbe43f18f228f273eb19d8f8176d","unresolved":true,"context_lines":[{"line_number":58,"context_line":"                   \u0027is_sort_key\u0027: True, \u0027is_filter\u0027: True,"},{"line_number":59,"context_line":"                   \u0027is_visible\u0027: True, \u0027default\u0027: None,"},{"line_number":60,"context_line":"                   \u0027enforce_policy\u0027: True},"},{"line_number":61,"context_line":"        \u0027src_ip\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False,"},{"line_number":62,"context_line":"                   \u0027validate\u0027: {\u0027type:ip_address_or_none\u0027: None},"},{"line_number":63,"context_line":"                   \u0027is_sort_key\u0027: True, \u0027is_filter\u0027: True,"},{"line_number":64,"context_line":"                   \u0027is_visible\u0027: True, \u0027default\u0027: None,"},{"line_number":65,"context_line":"                   \u0027enforce_policy\u0027: True},"},{"line_number":66,"context_line":"        \u0027min_rx\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":67,"context_line":"                   \u0027validate\u0027: {\u0027type:non_negative\u0027: None},"},{"line_number":68,"context_line":"                   \u0027convert_to\u0027: converters.convert_to_int,"}],"source_content_type":"text/x-python","patch_set":12,"id":"ede6e890_2b3eee0b","line":65,"range":{"start_line":61,"start_character":0,"end_line":65,"end_character":43},"in_reply_to":"46cd31bd_95b81bfc","updated":"2021-07-30 16:35:01.000000000","message":"I forgot the link with some background, which come from recent meetings:\nhttps://review.opendev.org/c/openstack/neutron-specs/+/767337/20/specs/xena/bfd_support.rst#171","commit_id":"f4a489d9c48598f712cd43c23ff35b040c5efb10"},{"author":{"_account_id":33273,"name":"Manu B","display_name":"Manu B","email":"manu.b@est.tech","username":"eceghkl"},"change_message_id":"a4b3f08ae2f46f6c2d2c239c53c01fecd2471fa7","unresolved":true,"context_lines":[{"line_number":27,"context_line":"BFD_SESSION_STATUS \u003d \u0027bfd_session_status\u0027"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"BFD_MODE_ASYNC \u003d \u0027asynchronous\u0027"},{"line_number":30,"context_line":"BFD_MODE_SINGLEHOP \u003d \u0027singlehop\u0027"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {"},{"line_number":33,"context_line":"    BFD_MONITORS: {"}],"source_content_type":"text/x-python","patch_set":13,"id":"7d06363f_88ec8905","line":30,"updated":"2021-08-10 09:46:21.000000000","message":"we need to support modes one-arm-echo, demand instead of singlehop","commit_id":"9b4b802ff3e25d278e9ecdb1951dc63aea2733ef"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"f4128921d4e089ca08509f667b24f741c6f8ee1f","unresolved":true,"context_lines":[{"line_number":27,"context_line":"BFD_SESSION_STATUS \u003d \u0027bfd_session_status\u0027"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"BFD_MODE_ASYNC \u003d \u0027asynchronous\u0027"},{"line_number":30,"context_line":"BFD_MODE_SINGLEHOP \u003d \u0027singlehop\u0027"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {"},{"line_number":33,"context_line":"    BFD_MONITORS: {"}],"source_content_type":"text/x-python","patch_set":13,"id":"f1e665dd_d83b9044","line":30,"in_reply_to":"7d06363f_88ec8905","updated":"2021-08-10 12:28:50.000000000","message":"thanks, I missed it here","commit_id":"9b4b802ff3e25d278e9ecdb1951dc63aea2733ef"}]}