)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"9e5a2e801fb904d65df6642cefe79310d1adf020","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Do the work of the warning log suggests, since the how many"},{"line_number":10,"context_line":"rows to delete of standardattributes is not an issue to Neutron."},{"line_number":11,"context_line":"The final goal is to delete them all."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I8113881a2bd2278ce8c912562a172f90e073b686"},{"line_number":14,"context_line":"Closes-Bug: #1916889"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"2a56151b_472e5c8f","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":37},"updated":"2021-02-25 12:31:52.000000000","message":"Not sure if the rows will be deleted after the warning\n\"\"\"\nStaleDataError: DELETE statement on table \u0027standardattributes\u0027 expected to delete 2 row(s); 1 were matched. Please set confirm_deleted_rows\u003dFalse within the mapper configuration to prevent this warning.\n\"\"\"\n\nFor neutron port deleting, delete these rows all is what we want if we discard this error log by setting confirm_deleted_rows\u003dFalse.","commit_id":"6a6bc8300787891477211bb9bbaf1196ca38b6c2"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"2376a122d54ab131321738df18c47e0bdecb115b","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Do the work of the warning log suggests, since the how many"},{"line_number":10,"context_line":"rows to delete of standardattributes is not an issue to Neutron."},{"line_number":11,"context_line":"The final goal is to delete them all."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I8113881a2bd2278ce8c912562a172f90e073b686"},{"line_number":14,"context_line":"Closes-Bug: #1916889"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"f3145110_7546ce39","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":37},"updated":"2021-02-25 12:30:43.000000000","message":"please elaborate on this one","commit_id":"6a6bc8300787891477211bb9bbaf1196ca38b6c2"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"314b021268a93c3b6de3dd8ad0de9b030ab159a2","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Do the work of the warning log suggests, since the how many"},{"line_number":10,"context_line":"rows to delete of standardattributes is not an issue to Neutron."},{"line_number":11,"context_line":"The final goal is to delete them all."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I8113881a2bd2278ce8c912562a172f90e073b686"},{"line_number":14,"context_line":"Closes-Bug: #1916889"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"0dbecb9a_503bceda","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":37},"in_reply_to":"f3145110_7546ce39","updated":"2021-02-25 12:34:28.000000000","message":"To @Oleg, the error is \"expected to delete 2 row(s); 1 were matched.\" So, this statement here is we need to esure that 1 matched row is deleted if we set \"confirm_deleted_rows\u003dFalse\".","commit_id":"6a6bc8300787891477211bb9bbaf1196ca38b6c2"}],"neutron_lib/db/standard_attr.py":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"93ad43bfe2bb3c21a54fe7544155a1174e62e91f","unresolved":true,"context_lines":[{"line_number":142,"context_line":"    def standard_attr_id(cls):"},{"line_number":143,"context_line":"        return sa.Column("},{"line_number":144,"context_line":"            sa.BigInteger().with_variant(sa.Integer(), \u0027sqlite\u0027),"},{"line_number":145,"context_line":"            sa.ForeignKey(StandardAttribute.id, ondelete\u003d\"CASCADE\"),"},{"line_number":146,"context_line":"            unique\u003dTrue,"},{"line_number":147,"context_line":"            nullable\u003dFalse"},{"line_number":148,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":1,"id":"d5dab593_fbaf204c","line":145,"range":{"start_line":145,"start_character":12,"end_line":145,"end_character":68},"updated":"2021-02-26 01:01:31.000000000","message":"Hi Michael, for your first comment. For neutron DB objects, we have \"ondelete\u003d\"CASCADE\"\", this is what neutron did. And the Port object will inherit this `HasStandardAttributes` class. So then it is fine to add that ``confirm_deleted_rows\u003dFalse``?\n\n[1] https://github.com/openstack/neutron/blob/master/neutron/db/models_v2.py#L103","commit_id":"6a6bc8300787891477211bb9bbaf1196ca38b6c2"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"3bbd5ee7f25ffc069d314f6f9d79fe277d3f13ab","unresolved":true,"context_lines":[{"line_number":142,"context_line":"    def standard_attr_id(cls):"},{"line_number":143,"context_line":"        return sa.Column("},{"line_number":144,"context_line":"            sa.BigInteger().with_variant(sa.Integer(), \u0027sqlite\u0027),"},{"line_number":145,"context_line":"            sa.ForeignKey(StandardAttribute.id, ondelete\u003d\"CASCADE\"),"},{"line_number":146,"context_line":"            unique\u003dTrue,"},{"line_number":147,"context_line":"            nullable\u003dFalse"},{"line_number":148,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":1,"id":"41785a2b_54160a92","line":145,"range":{"start_line":145,"start_character":12,"end_line":145,"end_character":68},"in_reply_to":"d5dab593_fbaf204c","updated":"2021-03-01 08:07:18.000000000","message":"I\u0027m definitely not db expert here but reading https://docs.sqlalchemy.org/en/13/orm/mapping_api.html#sqlalchemy.orm.mapper.params.confirm_deleted_rows it seems for me that it should be ok to do that.","commit_id":"6a6bc8300787891477211bb9bbaf1196ca38b6c2"}]}