)]}'
{"id":"openstack%2Fneutron-lib~781075","triplet_id":"openstack%2Fneutron-lib~master~I7760413a562e5d1a86709fc5e2d0df405a6aed30","project":"openstack/neutron-lib","branch":"master","topic":"bug/1919386","hashtags":[],"change_id":"I7760413a562e5d1a86709fc5e2d0df405a6aed30","subject":"Update model_query_scope_is_project to work properly with new policies","status":"MERGED","created":"2021-03-17 10:41:57.000000000","updated":"2021-03-17 21:59:10.000000000","submitted":"2021-03-17 19:18:57.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":4,"unresolved_comment_count":4,"has_review_started":true,"submission_id":"781075-bug/1919386","meta_rev_id":"57b281a314a23fbeb2a5c5ac1a8c03ce929450e7","_number":781075,"virtual_id_number":781075,"owner":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"value":0,"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},{"value":0,"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},{"value":0,"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-03-17 19:18:45.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"recommended":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"all":[{"value":1,"date":"2021-03-17 21:59:10.000000000","post_submit":true,"permitted_voting_range":{"min":1,"max":1},"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"value":0,"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},{"value":2,"date":"2021-03-17 15:52:54.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},{"value":2,"date":"2021-03-17 16:39:11.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"all":[{"value":0,"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"value":0,"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},{"value":0,"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},{"value":1,"date":"2021-03-17 17:49:39.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"approved":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"all":[{"value":0,"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"value":2,"date":"2021-03-17 21:59:10.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},{"value":0,"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},{"value":0,"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"}],"reviewers":{"REVIEWER":[{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-03-17 10:49:15.000000000","updated_by":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"reviewer":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"state":"REVIEWER"},{"updated":"2021-03-17 10:49:15.000000000","updated_by":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"reviewer":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"state":"REVIEWER"},{"updated":"2021-03-17 10:49:15.000000000","updated_by":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"reviewer":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"state":"REVIEWER"},{"updated":"2021-03-17 10:49:15.000000000","updated_by":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"reviewer":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"state":"REVIEWER"},{"updated":"2021-03-17 10:49:15.000000000","updated_by":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"reviewer":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"state":"REVIEWER"},{"updated":"2021-03-17 10:49:15.000000000","updated_by":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"reviewer":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"state":"REVIEWER"},{"updated":"2021-03-17 12:34:20.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"fa8bb2f43c3268cabed70b7c80d6a8a98d9d6933","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"date":"2021-03-17 10:41:57.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4a8c8ab5f8ecb017e5f34bf1eca7d73186608bab","author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"date":"2021-03-17 10:49:15.000000000","message":"Patch Set 1: Review-Priority+2","accounts_in_message":[],"_revision_number":1},{"id":"c0546cdc7409eb99bb25c8b72abac6a41c56f77d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"date":"2021-03-17 11:06:50.000000000","message":"Patch Set 2: Published edit on patch set 1.","accounts_in_message":[],"_revision_number":2},{"id":"2296c92ac07316fd0332be5ff954c281d39d8779","author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"date":"2021-03-17 11:19:38.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"27148379fd07598fb782ea5e395348648a1c71af","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-17 12:34:20.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/3ed54ad3ccee492db5c522dbeae90794 : SUCCESS in 7m 48s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/53806f130ada441e89369180c63dc840 : FAILURE in 6m 41s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/6384e51d70db44b1967f2d2207df3907 : FAILURE in 5m 34s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/f2818fa9a3294ed7aef548705db37f98 : SUCCESS in 5m 46s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/6753b1c287c04c6e9a7bd08d4ec3d578 : FAILURE in 6m 39s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/1ae978b0c6484a0cb8afcce6edd1c7c5 : FAILURE in 7m 39s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/14313f4b1f884fa9a0c0ab67356e1b0c : FAILURE in 4m 53s (non-voting)\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/3b6da392d3554cf2a76546e8256e235e : SUCCESS in 1h 25m 25s\n- neutron-tempest-plugin-api https://zuul.opendev.org/t/openstack/build/11f30000f09a43e99637555b61125d52 : SUCCESS in 1h 10m 37s","accounts_in_message":[],"_revision_number":2},{"id":"5ccc7fcec7856472fb5a403e95f7f03106ccd78b","author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"date":"2021-03-17 12:55:10.000000000","message":"Patch Set 2: -Code-Review","accounts_in_message":[],"_revision_number":2},{"id":"eb9da88e3f43a56056802bd4e19aedee92225e1f","author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"date":"2021-03-17 13:12:07.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"205b1d04c7d784293f42e8fabe91fa846ecd41f2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"date":"2021-03-17 13:56:37.000000000","message":"Patch Set 3: Published edit on patch set 2.","accounts_in_message":[],"_revision_number":3},{"id":"08b525fd0b9eea217606f6dd9adf1d62b8db799c","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-17 15:26:28.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a56baaa655384187b87cae93b76211e9 : SUCCESS in 9m 00s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/fa471c47fcf8475abde1d4349f20968c : SUCCESS in 7m 19s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/78803df647d6478d9e9e4e377af17d09 : SUCCESS in 4m 46s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/9e28bac3228f4f8485cdb550273d2c2f : SUCCESS in 4m 42s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/d9b80df751f3437ea78dae79a585fdb7 : SUCCESS in 7m 56s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/680d38f4e62a46c99cb1a52ec166614c : SUCCESS in 6m 26s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/e9c6a7310a1c49ef8a2c654e8ea7cef2 : SUCCESS in 4m 57s (non-voting)\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/5d0e2d0f7c5f42cda10f7996555cab2c : SUCCESS in 1h 25m 15s\n- neutron-tempest-plugin-api https://zuul.opendev.org/t/openstack/build/9e0561dad93d412fbe96c5a8427359a6 : SUCCESS in 1h 09m 46s","accounts_in_message":[],"_revision_number":3},{"id":"e1f987f9fa2f5d0992024c0f42eafa5e444da11d","author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"date":"2021-03-17 15:52:54.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"a660564b786c0f21f75adc4326dd4b12cd619b4b","author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"date":"2021-03-17 16:39:11.000000000","message":"Patch Set 3: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"4ccacf9b332ba1a9e69fa5dde1997bc1503b7579","author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"date":"2021-03-17 17:49:39.000000000","message":"Patch Set 3: Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"2c73a33e9a5fa1432a6ba4b5e27484d00995ab07","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-17 17:50:47.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":3},{"id":"b93c6d9d0213f4bdb887ed1ae1fce1c6f355f4ad","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-17 19:18:45.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/2255a444a4774f838acdd50ebecb6f08 : SUCCESS in 5m 45s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/d12f8069a0a34f678ce27bc9e06ae190 : SUCCESS in 4m 58s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/dbb551c0354a4a2fbbe83aeea507600c : SUCCESS in 4m 38s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/e3b43f372b684a058ddf12b5e3761704 : SUCCESS in 4m 24s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/7b6be67c291241748e85a25f7cd345ca : SUCCESS in 4m 25s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/75626b72d099431eb858ee60ed39761b : SUCCESS in 1h 23m 59s\n- neutron-tempest-plugin-api https://zuul.opendev.org/t/openstack/build/506e2b13caed4e6caf6855de8a340398 : SUCCESS in 48m 52s","accounts_in_message":[],"_revision_number":3},{"id":"1993e775b9e1317d4a381b3080cf99c84f013c2d","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-17 19:18:57.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":3},{"id":"dccc8acd55a06ceb0a10f7184a64073d5981903f","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-03-17 19:20:31.000000000","message":"Patch Set 3:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/260d5cd6e8a641b8acc282961dd5efbf : SUCCESS in 53s","accounts_in_message":[],"_revision_number":3},{"id":"74dfe5975d225ffb004641fd656837725ad10014","author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"date":"2021-03-17 21:59:10.000000000","message":"Patch Set 3: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"d73449dd1cd5045aaa3486a58cff7f773e90be7c","revisions":{"8feb318d2d43b37b25ef4c20f746438ad3ae111d":{"kind":"REWORK","_number":1,"created":"2021-03-17 10:41:57.000000000","uploader":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"ref":"refs/changes/75/781075/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/neutron-lib","ref":"refs/changes/75/781075/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/neutron-lib refs/changes/75/781075/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/neutron-lib refs/changes/75/781075/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/neutron-lib refs/changes/75/781075/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/neutron-lib refs/changes/75/781075/1"}}},"commit":{"parents":[{"commit":"90ac6aeb58c76bbbf53fe0d899e8b13c7d1871c1","subject":"Make neutron-lib aware about system scope tokens","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron-lib/commit/90ac6aeb58c76bbbf53fe0d899e8b13c7d1871c1"}]}],"author":{"name":"Slawek Kaplonski","email":"skaplons@redhat.com","date":"2021-03-17 10:37:31.000000000","tz":60},"committer":{"name":"Slawek Kaplonski","email":"skaplons@redhat.com","date":"2021-03-17 10:41:53.000000000","tz":60},"subject":"Update model_query_scope_is_project to work properly with new policies","message":"Update model_query_scope_is_project to work properly with new policies\n\nIn case when enforce_new_defaults is set to True in config, Neutron\nshouldn\u0027t check context.is_admin flag to check if query should or\nshouldn\u0027t be scoped to just one tenant as user with PROJECT_ADMIN role\nwill have is_admin flag set to True but such user shouldn\u0027t get e.g.\nnetworks which belongs to other tenants and aren\u0027t shared in any way.\n\nSo that patch improves neutron_lib.db.utils.model_query_scope_is_project\nfunction so it works in different way in case when enforce_new_defaults\nis set to True or False. In case when new defaults should be enforced\nonly SYSTEM_SCOPE tokens and advanced_services can make queries which\nare not scoped to single tenant.\n\nCloses-Bug: #1919386\nChange-Id: I7760413a562e5d1a86709fc5e2d0df405a6aed30\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron-lib/commit/8feb318d2d43b37b25ef4c20f746438ad3ae111d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron-lib/commit/8feb318d2d43b37b25ef4c20f746438ad3ae111d"}]},"branch":"refs/heads/master"},"8045e393c376e5b8f324d1add3bce46fdde22320":{"kind":"REWORK","_number":2,"created":"2021-03-17 11:06:50.000000000","uploader":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"ref":"refs/changes/75/781075/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/neutron-lib","ref":"refs/changes/75/781075/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/neutron-lib refs/changes/75/781075/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/neutron-lib refs/changes/75/781075/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/neutron-lib refs/changes/75/781075/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/neutron-lib refs/changes/75/781075/2"}}},"commit":{"parents":[{"commit":"90ac6aeb58c76bbbf53fe0d899e8b13c7d1871c1","subject":"Make neutron-lib aware about system scope tokens","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron-lib/commit/90ac6aeb58c76bbbf53fe0d899e8b13c7d1871c1"}]}],"author":{"name":"Slawek Kaplonski","email":"skaplons@redhat.com","date":"2021-03-17 10:37:31.000000000","tz":60},"committer":{"name":"Slawek Kaplonski","email":"skaplons@redhat.com","date":"2021-03-17 11:06:46.000000000","tz":0},"subject":"Update model_query_scope_is_project to work properly with new policies","message":"Update model_query_scope_is_project to work properly with new policies\n\nIn case when enforce_new_defaults is set to True in config, Neutron\nshouldn\u0027t check context.is_admin flag to check if query should or\nshouldn\u0027t be scoped to just one tenant as user with PROJECT_ADMIN role\nwill have is_admin flag set to True but such user shouldn\u0027t get e.g.\nnetworks which belongs to other tenants and aren\u0027t shared in any way.\n\nSo that patch improves neutron_lib.db.utils.model_query_scope_is_project\nfunction so it works in different way in case when enforce_new_defaults\nis set to True or False. In case when new defaults should be enforced\nonly SYSTEM_SCOPE tokens and advanced_services can make queries which\nare not scoped to single tenant.\n\nCloses-Bug: #1919386\nChange-Id: I7760413a562e5d1a86709fc5e2d0df405a6aed30\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron-lib/commit/8045e393c376e5b8f324d1add3bce46fdde22320"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron-lib/commit/8045e393c376e5b8f324d1add3bce46fdde22320"}]},"branch":"refs/heads/master"},"d73449dd1cd5045aaa3486a58cff7f773e90be7c":{"kind":"REWORK","_number":3,"created":"2021-03-17 13:56:37.000000000","uploader":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"ref":"refs/changes/75/781075/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/neutron-lib","ref":"refs/changes/75/781075/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/neutron-lib refs/changes/75/781075/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/neutron-lib refs/changes/75/781075/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/neutron-lib refs/changes/75/781075/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/neutron-lib refs/changes/75/781075/3"}}},"commit":{"parents":[{"commit":"90ac6aeb58c76bbbf53fe0d899e8b13c7d1871c1","subject":"Make neutron-lib aware about system scope tokens","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron-lib/commit/90ac6aeb58c76bbbf53fe0d899e8b13c7d1871c1"}]}],"author":{"name":"Slawek Kaplonski","email":"skaplons@redhat.com","date":"2021-03-17 10:37:31.000000000","tz":60},"committer":{"name":"Slawek Kaplonski","email":"skaplons@redhat.com","date":"2021-03-17 13:56:34.000000000","tz":0},"subject":"Update model_query_scope_is_project to work properly with new policies","message":"Update model_query_scope_is_project to work properly with new policies\n\nIn case when enforce_new_defaults is set to True in config, Neutron\nshouldn\u0027t check context.is_admin flag to check if query should or\nshouldn\u0027t be scoped to just one tenant as user with PROJECT_ADMIN role\nwill have is_admin flag set to True but such user shouldn\u0027t get e.g.\nnetworks which belongs to other tenants and aren\u0027t shared in any way.\n\nSo that patch improves neutron_lib.db.utils.model_query_scope_is_project\nfunction so it works in different way in case when enforce_new_defaults\nis set to True or False. In case when new defaults should be enforced\nonly SYSTEM_SCOPE tokens and advanced_services can make queries which\nare not scoped to single tenant.\n\nCloses-Bug: #1919386\nChange-Id: I7760413a562e5d1a86709fc5e2d0df405a6aed30\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron-lib/commit/d73449dd1cd5045aaa3486a58cff7f773e90be7c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron-lib/commit/d73449dd1cd5045aaa3486a58cff7f773e90be7c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"}},{"label":"Review-Priority","status":"MAY","applied_by":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}
