)]}'
{"neutron_lib/api/converters.py":[{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"5bc737cecf809d4a6c790c8e1a50a47ccd5b2f3b","unresolved":true,"context_lines":[{"line_number":255,"context_line":"                      \"names and their integer representation (0 to \""},{"line_number":256,"context_line":"                      \"255) are supported\") % data"},{"line_number":257,"context_line":"    try:"},{"line_number":258,"context_line":"        if 0 \u003c\u003d convert_to_int(data) \u003c\u003d 255:"},{"line_number":259,"context_line":"            return data"},{"line_number":260,"context_line":"        else:"},{"line_number":261,"context_line":"            raise n_exc.InvalidInput(error_message\u003derror_message)"}],"source_content_type":"text/x-python","patch_set":1,"id":"73172da4_6924c65c","line":258,"updated":"2021-07-23 17:45:57.000000000","message":"I changed this to avoid a circular import between validators and converters.","commit_id":"17737e27882c7f5c5dc50c0bef212be8ac00f1f2"},{"author":{"_account_id":33273,"name":"Manu B","display_name":"Manu B","email":"manu.b@est.tech","username":"eceghkl"},"change_message_id":"302d3a37c687511d4c097025aac5061f5f339bfc","unresolved":true,"context_lines":[{"line_number":256,"context_line":"                      \"names and their integer representation (0 to \""},{"line_number":257,"context_line":"                      \"255) are supported\") % data"},{"line_number":258,"context_line":"    try:"},{"line_number":259,"context_line":"        if validators.validate_range(convert_to_int(data), [0, 255]) is None:"},{"line_number":260,"context_line":"            return data"},{"line_number":261,"context_line":"        else:"},{"line_number":262,"context_line":"            raise n_exc.InvalidInput(error_message\u003derror_message)"}],"source_content_type":"text/x-python","patch_set":3,"id":"41da89fd_7471e4c7","side":"PARENT","line":259,"updated":"2021-08-05 07:08:31.000000000","message":"Couldn\u0027t identify issue with this line. \nIf there is some major bug, probably it is better to remove the validate_range definition from validators file. This seems to be the only usage of this method.","commit_id":"60046e4f2c26d96986837004ac0b5642096959d5"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"inactive contributor"},"change_message_id":"55856b12cc41aa06b7b0b9c46068a8935852bae7","unresolved":true,"context_lines":[{"line_number":256,"context_line":"                      \"names and their integer representation (0 to \""},{"line_number":257,"context_line":"                      \"255) are supported\") % data"},{"line_number":258,"context_line":"    try:"},{"line_number":259,"context_line":"        if validators.validate_range(convert_to_int(data), [0, 255]) is None:"},{"line_number":260,"context_line":"            return data"},{"line_number":261,"context_line":"        else:"},{"line_number":262,"context_line":"            raise n_exc.InvalidInput(error_message\u003derror_message)"}],"source_content_type":"text/x-python","patch_set":3,"id":"b383d6ba_7faa5b12","side":"PARENT","line":259,"in_reply_to":"41da89fd_7471e4c7","updated":"2021-08-06 09:39:37.000000000","message":"The only reason I had to change this line was to avoid a circular import (between validators and converters). On the other hand neutron-lib is used from many other repos (not necessarily all of them public), so I usually try not to remove anything unless we want to deprecate something.","commit_id":"60046e4f2c26d96986837004ac0b5642096959d5"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"60f5b759ec4e0cdc0cd33b35f2722a2751d524b7","unresolved":true,"context_lines":[{"line_number":256,"context_line":"                      \"names and their integer representation (0 to \""},{"line_number":257,"context_line":"                      \"255) are supported\") % data"},{"line_number":258,"context_line":"    try:"},{"line_number":259,"context_line":"        if validators.validate_range(convert_to_int(data), [0, 255]) is None:"},{"line_number":260,"context_line":"            return data"},{"line_number":261,"context_line":"        else:"},{"line_number":262,"context_line":"            raise n_exc.InvalidInput(error_message\u003derror_message)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3b8f4510_976898f9","side":"PARENT","line":259,"in_reply_to":"b383d6ba_7faa5b12","updated":"2021-08-09 13:02:33.000000000","message":"yeah was commented here: https://review.opendev.org/c/openstack/neutron-lib/+/802029/1/neutron_lib/api/converters.py#258\nthanks","commit_id":"60046e4f2c26d96986837004ac0b5642096959d5"}]}