)]}'
{"id":"openstack%2Fneutron-lib~804613","triplet_id":"openstack%2Fneutron-lib~master~I785c6c3fa600d9dcf6a41a527f07e1e4b1ddda52","project":"openstack/neutron-lib","branch":"master","topic":"bug/1930200","hashtags":[],"change_id":"I785c6c3fa600d9dcf6a41a527f07e1e4b1ddda52","subject":"Add Local IP constants and exceptions","status":"MERGED","created":"2021-08-16 08:44:37.000000000","updated":"2021-09-03 01:20:50.000000000","submitted":"2021-09-02 19:57:17.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"804613-bug/1930200","meta_rev_id":"9d26d748e37983a97ff51a1f40a6216e5261ef55","_number":804613,"virtual_id_number":804613,"owner":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},{"value":0,"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-09-02 19:57:17.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"all":[{"value":2,"date":"2021-09-02 15:58:28.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},{"value":2,"date":"2021-09-02 14:34:46.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"all":[{"value":1,"date":"2021-09-02 15:58:28.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},{"value":0,"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},{"value":0,"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},{"_account_id":32667,"name":"Mamatisa Nurmatov","email":"nurmatov.mamatisa@huawei.com","username":"isabek"}],"REVIEWER":[{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-08-16 10:17:52.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-08-17 10:40:09.000000000","updated_by":{"_account_id":32667,"name":"Mamatisa Nurmatov","email":"nurmatov.mamatisa@huawei.com","username":"isabek"},"reviewer":{"_account_id":32667,"name":"Mamatisa Nurmatov","email":"nurmatov.mamatisa@huawei.com","username":"isabek"},"state":"CC"},{"updated":"2021-08-19 10:06:37.000000000","updated_by":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"reviewer":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"state":"REVIEWER"},{"updated":"2021-08-24 09:34:21.000000000","updated_by":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"reviewer":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"state":"REVIEWER"},{"updated":"2021-09-02 03:20:16.000000000","updated_by":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"reviewer":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"state":"CC"}],"messages":[{"id":"a58b46a362850f03958667cbaacdb948531857c6","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"date":"2021-08-16 08:44:37.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e4f6062b98cd8d428b34f08519c66987d3750fa4","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-08-16 10:17:52.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b95572bd59124f5bb4c84e355a1b3b86 : SUCCESS in 6m 48s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/be9969fc98654c2e8b4527671d584703 : SUCCESS in 5m 30s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/880f6cf2e4f84e49bcbb5c3cfabbbd51 : SUCCESS in 5m 05s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/358ad04a4d9a46b4978f265549343b9b : SUCCESS in 5m 24s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/8d3a907af63747598b45cc9eaed22ca1 : SUCCESS in 5m 04s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/f4a9a8fb3642493aa1c05f68af117216 : SUCCESS in 4m 36s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/506502365f0844dbb984fa97731c5dcd : SUCCESS in 4m 53s (non-voting)\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/20957dbac11e4839a8cddf31db5ba093 : SUCCESS in 1h 27m 18s\n- neutron-tempest-plugin-api https://zuul.opendev.org/t/openstack/build/eee1a657fab44bc9a5cd3fcbbbc2ef35 : SUCCESS in 57m 00s\n- neutron-functional-with-uwsgi https://zuul.opendev.org/t/openstack/build/3d2bd4e0fb834e198bec502d14a26ccc : SUCCESS in 48m 16s","accounts_in_message":[],"_revision_number":1},{"id":"3b8e1a663eda83a0b8d36b840a50ba9252e66315","author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"date":"2021-08-19 10:06:37.000000000","message":"Patch Set 1: Code-Review+2 Review-Priority+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"f9ccd5bd1ae90e51c0b58a1bc9b1dcc13bba8328","author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"date":"2021-08-24 09:34:21.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"63935926abdfaf35237bd4f3f66e52b3dd0d02a2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"date":"2021-08-31 16:26:17.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"c2ed7295f775852ce607040cfd6f8ae0a754113b","author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"date":"2021-08-31 16:58:43.000000000","message":"Patch Set 2: Code-Review-1\n\nThere is a bug in https://review.opendev.org/c/openstack/neutron/+/801453/4/neutron/db/l3_db.py#1438: the patch changes events.AFTER_UPDATE with events.AFTER_CREATE. This is why \"floatingip_update_callback\" is never called.","accounts_in_message":[],"_revision_number":2},{"id":"081220c311a525d829f6ca66c1dfc130eef83184","author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"date":"2021-08-31 17:00:11.000000000","message":"Patch Set 2: -Code-Review\n\n\u003e Patch Set 2: Code-Review-1\n\u003e \n\u003e There is a bug in https://review.opendev.org/c/openstack/neutron/+/801453/4/neutron/db/l3_db.py#1438: the patch changes events.AFTER_UPDATE with events.AFTER_CREATE. This is why \"floatingip_update_callback\" is never called.\n\nThat comment was not for this patch, sorry.","accounts_in_message":[],"_revision_number":2},{"id":"c41c8093ef1b37fb2564d57cadb1b74f885fc897","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-08-31 17:54:26.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c58181eee0e9404db949a81c09912f49 : SUCCESS in 7m 19s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/77a9802e8e9c4ed2a5134b79d47d499d : SUCCESS in 6m 10s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/573355581be54e1b9e61863a2f78b3a4 : SUCCESS in 5m 15s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/e59a48a3271c449087a37b370c82c28c : SUCCESS in 4m 46s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/129c502cd07243ecbfa9d57476d7c96d : SUCCESS in 7m 18s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/89938581a5544c548b697eba2ca9f819 : SUCCESS in 5m 48s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/c73935b092ed41349c9999e4c5fcff1b : SUCCESS in 5m 02s (non-voting)\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/a250eb4ad7314bf998410b586e2b0f5c : SUCCESS in 1h 21m 43s\n- neutron-tempest-plugin-api https://zuul.opendev.org/t/openstack/build/3a8c41782f8045d3a0b87b77a7de0c1d : SUCCESS in 43m 15s\n- neutron-functional-with-uwsgi https://zuul.opendev.org/t/openstack/build/a23e982fb0374ac88509682e36b0d58f : SUCCESS in 1h 00m 51s","accounts_in_message":[],"_revision_number":2},{"id":"0a56204100b3f102523aebf65c211bb0cf637acc","author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"date":"2021-09-02 03:20:16.000000000","message":"Patch Set 2:\n\nI want to mention something that, not related to this patch, many times new feature is going to added to neutron, it will need to wait for neutron-lib to release. Then updating the neutron requirements, rotating the neutron patch, and wating... Since the big tent of networking projects are mostly going to retired, like networking-vpn, fwaas, lbaas and so on, can we move the neutron-lib related change to neutron first? If some sub-project is really wants this/that constants or exceptions, do it that time. I don\u0027t think a new feature is directly relied on. So can we make the neutron develop cycle more smoothly? For new hands of Neutron, this is something like to set barriers for new neutron developers. They want to contribute to Neutron, but their patiences are going to be consumed by the complex and tedious waiting/rotating/updating processes.\n\nActually, \"do not toach neutron-lib\", this what I ask our private developers to do so. We do not want to update neutron everytime with a long list of dependencies. Ideas?","accounts_in_message":[],"_revision_number":2},{"id":"f09f7a36be110c6689d139e62ddc654078eb6024","author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"date":"2021-09-02 07:32:07.000000000","message":"Patch Set 2:\n\n\u003e Patch Set 2:\n\u003e \n\u003e I want to mention something that, not related to this patch, many times new feature is going to added to neutron, it will need to wait for neutron-lib to release. Then updating the neutron requirements, rotating the neutron patch, and wating... Since the big tent of networking projects are mostly going to retired, like networking-vpn, fwaas, lbaas and so on, can we move the neutron-lib related change to neutron first? If some sub-project is really wants this/that constants or exceptions, do it that time. I don\u0027t think a new feature is directly relied on. So can we make the neutron develop cycle more smoothly? For new hands of Neutron, this is something like to set barriers for new neutron developers. They want to contribute to Neutron, but their patiences are going to be consumed by the complex and tedious waiting/rotating/updating processes.\n\u003e \n\u003e Actually, \"do not toach neutron-lib\", this what I ask our private developers to do so. We do not want to update neutron everytime with a long list of dependencies. Ideas?\n\nSounds like a topic for the October PTG ;) \nI agree this is painful. Maybe we could add a \"neutron_lib_staging\" subdirectory to main neutron repo and add there all stuff needed for new in-progress features with same files and structures as in original neutron_lib. Once feature(s) is(are) ready/tested/stable - neutron_lib_staging could be copy-pasted to neutron_lib in one shot. This could be even done once before release for all features added during release. Thoughts?","accounts_in_message":[],"_revision_number":2},{"id":"75fef32c944c4d85e8ef75626471584410395890","author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"date":"2021-09-02 14:34:46.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"b202a5caa6e66003f9b55d4d9e628c7e6dddbaf1","author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"date":"2021-09-02 15:58:28.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\n\u003e Patch Set 2:\n\u003e \n\u003e I want to mention something that, not related to this patch, many times new feature is going to added to neutron, it will need to wait for neutron-lib to release. Then updating the neutron requirements, rotating the neutron patch, and wating... Since the big tent of networking projects are mostly going to retired, like networking-vpn, fwaas, lbaas and so on, can we move the neutron-lib related change to neutron first? If some sub-project is really wants this/that constants or exceptions, do it that time. I don\u0027t think a new feature is directly relied on. So can we make the neutron develop cycle more smoothly? For new hands of Neutron, this is something like to set barriers for new neutron developers. They want to contribute to Neutron, but their patiences are going to be consumed by the complex and tedious waiting/rotating/updating processes.\n\u003e \n\u003e Actually, \"do not toach neutron-lib\", this what I ask our private developers to do so. We do not want to update neutron everytime with a long list of dependencies. Ideas?\n\nYou can always:\n- Implement some code sections in Neutron with a NOTE to rehome it to neutron-lib.\n- Use the depends-on trigger.\n\nI don\u0027t see any problem with the current architecture.","accounts_in_message":[],"_revision_number":2},{"id":"0a9b4317e7901133e139d52e3eab1e2d5484c0c0","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-09-02 15:59:00.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"a5d4c9b5e355f439610e14391049d08ac25456da","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-09-02 17:19:42.000000000","message":"Patch Set 2: Verified-2\n\nBuild failed (gate pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/13c9c0cdef03458fa932942b3ae3e20e : SUCCESS in 6m 59s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/e4510ebc7a35483ca47fe24d0993bfa6 : SUCCESS in 9m 26s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/1015f3584dbe4bbfa807a7c9009f22c7 : SUCCESS in 6m 07s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/e40bd16906294fafb0cc727b80a323a3 : SUCCESS in 4m 39s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/af3968e8c6844d578978165a016a5908 : SUCCESS in 4m 39s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/7de569c5599149f39ca9329a3aec27e9 : SUCCESS in 1h 19m 49s\n- neutron-tempest-plugin-api https://zuul.opendev.org/t/openstack/build/42e4c1a6b3c34c1ca5f917c209f7d01b : SUCCESS in 43m 49s\n- neutron-functional-with-uwsgi https://zuul.opendev.org/t/openstack/build/2d41976ee93f48608937c7dd4eec2905 : FAILURE in 54m 42s","accounts_in_message":[],"_revision_number":2},{"id":"2d8a54dee7b4573d35fb7a275e6adce762bb5446","author":{"_account_id":32667,"name":"Mamatisa Nurmatov","email":"nurmatov.mamatisa@huawei.com","username":"isabek"},"date":"2021-09-02 17:21:04.000000000","message":"Patch Set 2:\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"2e43ecbc5812789a68c15e7fe27dad5276ef0aff","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-09-02 18:36:50.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/2435f71c2f0842e2bc1012141bd0acee : SUCCESS in 7m 40s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/bfdb9c2bfcbf421fb76ed9c9d5ebdc80 : SUCCESS in 7m 40s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/0f1b5d0a2b6743e59d5183385fcbf496 : SUCCESS in 6m 12s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/fa1cfe013869416f9e4fdc729d22f467 : SUCCESS in 5m 18s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/ac51a243e6784dd9a33cdc7e174a5c5a : SUCCESS in 5m 28s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/8b33048e9ad74bdab688f7a301ad48cc : SUCCESS in 6m 33s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/ef2ec6cedcee44579c2a0f3a06e0575e : SUCCESS in 7m 47s (non-voting)\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/6acad41dd6394f5a9b346b8129f1889d : SUCCESS in 1h 10m 00s\n- neutron-tempest-plugin-api https://zuul.opendev.org/t/openstack/build/3853c661bc5543b3824f9cb9e000e745 : SUCCESS in 45m 07s\n- neutron-functional-with-uwsgi https://zuul.opendev.org/t/openstack/build/e79732fa9b0b4165a82d59bd8ae700ff : SUCCESS in 48m 25s","accounts_in_message":[],"_revision_number":2},{"id":"6205f1e29fbe47193a77fd1ceb3108cad2ec215f","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-09-02 18:38:06.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"9b020503ecfa69dae391a55242d4ffbf65b26de9","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-09-02 19:57:17.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/0947697016b14977aeb50dbb7d1507c4 : SUCCESS in 6m 57s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/42e9e08cf8f349c0aee820a29aaffa40 : SUCCESS in 5m 54s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/55114f51a4f14715a4ee453dda83e572 : SUCCESS in 4m 47s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/e03bc965e906416496c6b5454c0ed9e2 : SUCCESS in 7m 13s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/0c1c70ea371d4d8da5869420f8a0231f : SUCCESS in 5m 01s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/0ef226fe6fb944deb5d52e4f408042b3 : SUCCESS in 1h 17m 38s\n- neutron-tempest-plugin-api https://zuul.opendev.org/t/openstack/build/68e8951fbe7f41fc89f5ceb09be07d71 : SUCCESS in 39m 18s\n- neutron-functional-with-uwsgi https://zuul.opendev.org/t/openstack/build/f77546776473465295a5645429d0c879 : SUCCESS in 48m 56s","accounts_in_message":[],"_revision_number":2},{"id":"a80fc279b6281837b3bb19509c01ab1672ac2893","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-09-02 19:57:17.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"df4362cd81ed873794fc18ea2830771376479c7a","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-09-02 19:58:43.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/38572d660c35499a8c95ebd14f0a9ce9 : SUCCESS in 1m 06s","accounts_in_message":[],"_revision_number":2},{"id":"9d26d748e37983a97ff51a1f40a6216e5261ef55","author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"date":"2021-09-03 01:20:50.000000000","message":"Patch Set 2:\n\n\u003e Patch Set 2: Code-Review+2 Workflow+1\n\u003e \n\u003e \u003e Patch Set 2:\n\u003e \u003e \n\u003e \u003e I want to mention something that, not related to this patch, many times new feature is going to added to neutron, it will need to wait for neutron-lib to release. Then updating the neutron requirements, rotating the neutron patch, and wating... Since the big tent of networking projects are mostly going to retired, like networking-vpn, fwaas, lbaas and so on, can we move the neutron-lib related change to neutron first? If some sub-project is really wants this/that constants or exceptions, do it that time. I don\u0027t think a new feature is directly relied on. So can we make the neutron develop cycle more smoothly? For new hands of Neutron, this is something like to set barriers for new neutron developers. They want to contribute to Neutron, but their patiences are going to be consumed by the complex and tedious waiting/rotating/updating processes.\n\u003e \u003e \n\u003e \u003e Actually, \"do not toach neutron-lib\", this what I ask our private developers to do so. We do not want to update neutron everytime with a long list of dependencies. Ideas?\n\u003e \n\u003e You can always:\n\u003e - Implement some code sections in Neutron with a NOTE to rehome it to neutron-lib.\n\u003e - Use the depends-on trigger.\n\u003e \n\u003e I don\u0027t see any problem with the current architecture.\n\nNo, it has problems as I mentioned above. Here are some examples:\n1. Since the qos \"VALID_RULE_TYPES\" is moved to neutron-lib, we have done some extra works:\n  a. copy the new list back, do the Neutron only development works [1].\n  b. move the list back to neutron-lib [2]\n  c. waiting for neutron-lib to have a new release [3]\n  d. update neutron to use constants from neutron-lib  [4]\n\n2. They are going to move the \"*_BR_ALL_TABLES\" to neutron-lib [5], and doing the same work of rotating Neutron [6]. For these tables, at least two WIP features will have works on these tables [7][8]. So, let them copy these list back to neutron again? Then add a TODO node? It wastes not only developer time, but also code reviewers bandwidth.\n\nAgain, since big tent projects are almost retired. If there are constants really needed by sub-projects, it is fine to move those to neutron-lib. Otherwise, leave Neutron used ONLY constants to neutron.\n\n[1] https://review.opendev.org/c/openstack/neutron/+/796363/15/neutron/services/qos/constants.py\n[2] https://review.opendev.org/c/openstack/neutron-lib/+/804378\n[3] https://review.opendev.org/c/openstack/neutron/+/803462\n[4] https://review.opendev.org/c/openstack/neutron/+/804380\n[5] https://review.opendev.org/c/openstack/neutron/+/797121/8/neutron/plugins/ml2/drivers/openvswitch/agent/common/constants.py#b1\n[6] https://review.opendev.org/c/openstack/neutron/+/797120/\n[7] https://review.opendev.org/c/openstack/neutron-specs/+/797798/12/specs/xena/node-local-ip.rst@259\n[8] https://review.opendev.org/c/openstack/neutron/+/804213","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"5e9ced2793b11f5bf18584fa9d242f9b7cbafb08","revisions":{"78ef53e97ebd5f66b0531f6afec35db9feba07d8":{"kind":"REWORK","_number":1,"created":"2021-08-16 08:44:37.000000000","uploader":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"ref":"refs/changes/13/804613/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/neutron-lib","ref":"refs/changes/13/804613/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/neutron-lib refs/changes/13/804613/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/neutron-lib refs/changes/13/804613/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/neutron-lib refs/changes/13/804613/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/neutron-lib refs/changes/13/804613/1"}}},"commit":{"parents":[{"commit":"4f7e549beb50864de4fb1dec80129c40fbddd3db","subject":"Add Local IP API def","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron-lib/commit/4f7e549beb50864de4fb1dec80129c40fbddd3db"}]}],"author":{"name":"Oleg Bondarev","email":"oleg.bondarev@huawei.com","date":"2021-08-10 08:42:00.000000000","tz":180},"committer":{"name":"Oleg Bondarev","email":"oleg.bondarev@huawei.com","date":"2021-08-16 08:43:47.000000000","tz":180},"subject":"Add Local IP constants and exceptions","message":"Add Local IP constants and exceptions\n\nPartial-Bug: #1930200\nChange-Id: I785c6c3fa600d9dcf6a41a527f07e1e4b1ddda52\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron-lib/commit/78ef53e97ebd5f66b0531f6afec35db9feba07d8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron-lib/commit/78ef53e97ebd5f66b0531f6afec35db9feba07d8"}]},"branch":"refs/heads/master"},"5e9ced2793b11f5bf18584fa9d242f9b7cbafb08":{"kind":"REWORK","_number":2,"created":"2021-08-31 16:26:17.000000000","uploader":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"ref":"refs/changes/13/804613/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/neutron-lib","ref":"refs/changes/13/804613/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/neutron-lib refs/changes/13/804613/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/neutron-lib refs/changes/13/804613/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/neutron-lib refs/changes/13/804613/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/neutron-lib refs/changes/13/804613/2"}}},"commit":{"parents":[{"commit":"65df19556342b3da0931254639086ff88ea87a1a","subject":"Merge \"Add Local IP API def\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron-lib/commit/65df19556342b3da0931254639086ff88ea87a1a"}]}],"author":{"name":"Oleg Bondarev","email":"oleg.bondarev@huawei.com","date":"2021-08-10 08:42:00.000000000","tz":180},"committer":{"name":"Oleg Bondarev","email":"oleg.bondarev@huawei.com","date":"2021-08-31 16:20:34.000000000","tz":180},"subject":"Add Local IP constants and exceptions","message":"Add Local IP constants and exceptions\n\nPartial-Bug: #1930200\nChange-Id: I785c6c3fa600d9dcf6a41a527f07e1e4b1ddda52\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron-lib/commit/5e9ced2793b11f5bf18584fa9d242f9b7cbafb08"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron-lib/commit/5e9ced2793b11f5bf18584fa9d242f9b7cbafb08"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"}},{"label":"Review-Priority","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}