)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"02523a196c08e6c3557750575bcf6d37cbd77f1f","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2021-09-03 15:47:27 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Set \"cache_ok\u003dTrue\" in all \"TypeDecorator\" derived classes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I67b7cf6c4a0a269c1d0c91ed1265d36208f67cef"},{"line_number":10,"context_line":"Closes-Bug: #1927763"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"42d8f090_2ba8579a","line":8,"updated":"2021-09-06 08:15:37.000000000","message":"Please add some info why it can/should be set to True now (given that it was False for TruncatedDateTime)","commit_id":"a94c4f2c0dec8131d2e01ad8aeb590c2fb44c060"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"61d06660b2fdb2bad44bca5faef88815c165916c","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2021-09-03 15:47:27 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Set \"cache_ok\u003dTrue\" in all \"TypeDecorator\" derived classes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I67b7cf6c4a0a269c1d0c91ed1265d36208f67cef"},{"line_number":10,"context_line":"Closes-Bug: #1927763"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fe2ddd6b_f6120657","line":8,"in_reply_to":"42d8f090_2ba8579a","updated":"2021-09-06 12:15:47.000000000","message":"+1 for some more detailed explanation in commit message","commit_id":"a94c4f2c0dec8131d2e01ad8aeb590c2fb44c060"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"0934d3f8bb68533b910008cba474445c8bb4afb5","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2021-09-03 15:47:27 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Set \"cache_ok\u003dTrue\" in all \"TypeDecorator\" derived classes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I67b7cf6c4a0a269c1d0c91ed1265d36208f67cef"},{"line_number":10,"context_line":"Closes-Bug: #1927763"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1eadbe5b_a868f9c6","line":8,"in_reply_to":"fe2ddd6b_f6120657","updated":"2021-09-08 13:11:27.000000000","message":"Right, I\u0027ll do it now.\n\nThe safe value False I set in [1] is OK, but after checking the values those classes implement, it is safe to set it to True. I\u0027ll provide more info in next PS.\n\n[1]https://review.opendev.org/c/openstack/neutron-lib/+/790285","commit_id":"a94c4f2c0dec8131d2e01ad8aeb590c2fb44c060"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"61d06660b2fdb2bad44bca5faef88815c165916c","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Set \"cache_ok\u003dTrue\" in all \"TypeDecorator\" derived classes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I67b7cf6c4a0a269c1d0c91ed1265d36208f67cef"},{"line_number":10,"context_line":"Closes-Bug: #1927763"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"083924e0_ccaf50b4","line":10,"updated":"2021-09-06 12:15:47.000000000","message":"and how it is really related to that bug :)","commit_id":"a94c4f2c0dec8131d2e01ad8aeb590c2fb44c060"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"0934d3f8bb68533b910008cba474445c8bb4afb5","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Set \"cache_ok\u003dTrue\" in all \"TypeDecorator\" derived classes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I67b7cf6c4a0a269c1d0c91ed1265d36208f67cef"},{"line_number":10,"context_line":"Closes-Bug: #1927763"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"12c53929_1632ab78","line":10,"in_reply_to":"083924e0_ccaf50b4","updated":"2021-09-08 13:11:27.000000000","message":"Since SQLAlchemy 1.4.x, the flag cache_ok for TypeDecorator derived classes is mandatory. I\u0027ll add this info in the bug. There is another patch, related to this bug, submitted before.","commit_id":"a94c4f2c0dec8131d2e01ad8aeb590c2fb44c060"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"8da82bf099185fea7967657a5bcab434c00b68e7","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Set \"cache_ok\u003dTrue\" in all \"TypeDecorator\" derived classes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The requirement for cacheable elements is that they are haseable [1]."},{"line_number":10,"context_line":"\"IPAddress\", \"CIDR\" and \"MACAddress\" \"impl\" attribute [2] is type"},{"line_number":11,"context_line":"\"String\". \"TruncatedDateTime\" \"impl\" attribute is type \"DateTime\"."},{"line_number":12,"context_line":"All of them are hasheable:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"eca493f5_3d032f34","line":9,"range":{"start_line":9,"start_character":56,"end_line":9,"end_character":64},"updated":"2021-09-09 19:44:03.000000000","message":"nitty nit: hashable :)","commit_id":"cb2dd61ac492df4ab9f0e4ea6f89c6ea3f138ccd"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"8da82bf099185fea7967657a5bcab434c00b68e7","unresolved":true,"context_lines":[{"line_number":9,"context_line":"The requirement for cacheable elements is that they are haseable [1]."},{"line_number":10,"context_line":"\"IPAddress\", \"CIDR\" and \"MACAddress\" \"impl\" attribute [2] is type"},{"line_number":11,"context_line":"\"String\". \"TruncatedDateTime\" \"impl\" attribute is type \"DateTime\"."},{"line_number":12,"context_line":"All of them are hasheable:"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"  \u003e\u003e\u003e from sqlalchemy import types"},{"line_number":15,"context_line":"  \u003e\u003e\u003e impl \u003d types.DateTime()"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"4b949f4b_72d42ec7","line":12,"range":{"start_line":12,"start_character":16,"end_line":12,"end_character":25},"updated":"2021-09-09 19:44:03.000000000","message":"same here","commit_id":"cb2dd61ac492df4ab9f0e4ea6f89c6ea3f138ccd"}]}