)]}'
{"neutron_lib/api/definitions/quota_check_limit.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"dbfac57d59c580aaa9c5b62a6c0cbc734a24896d","unresolved":true,"context_lines":[{"line_number":13,"context_line":"# under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"ALIAS \u003d \u0027quota-check-limit\u0027"},{"line_number":16,"context_line":"IS_SHIM_EXTENSION \u003d True"},{"line_number":17,"context_line":"IS_STANDARD_ATTR_EXTENSION \u003d False"},{"line_number":18,"context_line":"NAME \u003d \u0027Quota engine limit check\u0027"},{"line_number":19,"context_line":"DESCRIPTION \u003d (\u0027Support for checking the resource usage before applying a new \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"2be2040b_d775a897","line":16,"updated":"2021-09-10 11:06:11.000000000","message":"Maybe I\u0027m wrong but I think that this can\u0027t be shim extension as You need to define this new parameter for quota to be accepted by Neutron. Otherwise (now) when I try to send request like\n\n    curl -g -i -X PUT http://10.120.0.30:9696/v2.0/quotas/f3ccd6bbc4e04ba4a2be183ddcc766f7 -H \"Accept: application/json\" -H \"Content-Type: application/json\" -H \"User-Agent: python-neutronclient\" -H \"X-Auth-Token: $token\" -d \u0027{\"quota\": {\"network\": 1000, \"check_limit\": true}}\u0027\n\n\nI got error:\n\n    {\"NeutronError\": {\"type\": \"HTTPBadRequest\", \"message\": \"Unrecognized attribute(s) \u0027check_limit\u0027\", \"detail\": \"\"}}\n\n\nI tested without that patch in Neutron-lib but as it\u0027s shim extension I don\u0027t think it would change anything really.","commit_id":"14df80519c111a896f57886dc5db93284682dbba"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"acded6ac53442ce21bbd392971d9b74422d216a7","unresolved":true,"context_lines":[{"line_number":13,"context_line":"# under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"ALIAS \u003d \u0027quota-check-limit\u0027"},{"line_number":16,"context_line":"IS_SHIM_EXTENSION \u003d True"},{"line_number":17,"context_line":"IS_STANDARD_ATTR_EXTENSION \u003d False"},{"line_number":18,"context_line":"NAME \u003d \u0027Quota engine limit check\u0027"},{"line_number":19,"context_line":"DESCRIPTION \u003d (\u0027Support for checking the resource usage before applying a new \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"bea0e883_a2b72a03","line":16,"in_reply_to":"2be2040b_d775a897","updated":"2021-09-10 11:43:56.000000000","message":"This is an API extension but quota controller does not uses any API definition. All extension will inherit from \"extensions.APIExtensionDescriptor\" and will define \"api_definition\", pointing to a file from this directory.\n\nWhen we start Neutron server, we retrieve all resources [1][2]. That includes the QuotaSetsController. But this controller does not have a defined API. During the extension load process, some resources can be marked with \"register_quota\" [3].\n\nWhen the quota controller is called to set a value, the API attributes are updated, that means EXTENDED_ATTRIBUTES_2_0 is updated. Example of what this variable contains when updated: https://paste.opendev.org/show/809228/\n\nTo sum up: \"check_limit\" is a new API parameter but not defined in the n-lib API definitions. If you download [4] (that includes the n-lib bump), you\u0027ll be able to execute this HTTP request.\n\n[1]https://github.com/openstack/neutron/blob/c39896bd0775de032c471012deaff0edd82153c4/neutron/pecan_wsgi/startup.py#L61\n[2]https://github.com/openstack/neutron/blob/c39896bd0775de032c471012deaff0edd82153c4/neutron/api/extensions.py#L299-L306\n[3]https://github.com/openstack/neutron/blob/c39896bd0775de032c471012deaff0edd82153c4/neutron/api/v2/resource_helper.py#L65-L66\n[4]https://review.opendev.org/c/openstack/neutron/+/801470","commit_id":"14df80519c111a896f57886dc5db93284682dbba"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"1218a2e2727eb5b359fc6bc8f45251770bd9d38d","unresolved":true,"context_lines":[{"line_number":13,"context_line":"# under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"ALIAS \u003d \u0027quota-check-limit\u0027"},{"line_number":16,"context_line":"IS_SHIM_EXTENSION \u003d True"},{"line_number":17,"context_line":"IS_STANDARD_ATTR_EXTENSION \u003d False"},{"line_number":18,"context_line":"NAME \u003d \u0027Quota engine limit check\u0027"},{"line_number":19,"context_line":"DESCRIPTION \u003d (\u0027Support for checking the resource usage before applying a new \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"6c4e365d_cb10a258","line":16,"in_reply_to":"bea0e883_a2b72a03","updated":"2021-09-10 13:02:39.000000000","message":"ok, thx for explanation","commit_id":"14df80519c111a896f57886dc5db93284682dbba"}],"releasenotes/notes/add-quota-check-limit-api-extension-8e39299644d41f74.yaml":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"0a44a78e6f0ccdcb11468c566c6ab001b87ca1f1","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add API extension ``quota-check-limit``. This is a shim extension that"},{"line_number":5,"context_line":"    indicates if Neutron supports checking the resource usage before applying"},{"line_number":6,"context_line":"    a new quota limit."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"fcd124a3_80212585","line":6,"updated":"2021-09-09 09:27:27.000000000","message":"Could You please add a line like this: \"This indicates that new API parameter check_limit can be used\" or some better formed :-)","commit_id":"55790655d5eccc5bf22f572c414fa3ec0779af5a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f21a3072423722a432d28bb6574804b5bf2ec0ca","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add API extension ``quota-check-limit``. This is a shim extension that"},{"line_number":5,"context_line":"    indicates if Neutron supports checking the resource usage before applying"},{"line_number":6,"context_line":"    a new quota limit."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"f6693597_2817f214","line":6,"in_reply_to":"fcd124a3_80212585","updated":"2021-09-09 14:03:57.000000000","message":"Done","commit_id":"55790655d5eccc5bf22f572c414fa3ec0779af5a"}]}