)]}'
{"neutron_lib/api/definitions/bfd_monitor.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"3a99846f1e9227eeb7f59ab283569748d75c1c93","unresolved":true,"context_lines":[{"line_number":32,"context_line":"BFD_MODE_DEMAND \u003d \u0027demand\u0027"},{"line_number":33,"context_line":"BFD_MODE_ONE_ARM \u003d \u0027one_arm_echo\u0027"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"AUTH_TPYE_PWD \u003d \u0027password\u0027  # nosec"},{"line_number":36,"context_line":"AUTH_TYPE_MD5 \u003d \u0027MD5\u0027"},{"line_number":37,"context_line":"AUTH_TYPE_METIC_MD5 \u003d \u0027MeticulousMD5\u0027"},{"line_number":38,"context_line":"AUTH_TYPE_SHA1 \u003d \u0027SHA1\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"8d52ee69_bf6b7d1b","line":35,"range":{"start_line":35,"start_character":5,"end_line":35,"end_character":9},"updated":"2021-10-13 09:55:11.000000000","message":"s/TPYE/TYPE","commit_id":"c29b47822750e421ff683f0bc889e6a64a1d1986"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"dc6066871343ccadb54acab7e18b80cd3e5840b3","unresolved":true,"context_lines":[{"line_number":32,"context_line":"BFD_MODE_DEMAND \u003d \u0027demand\u0027"},{"line_number":33,"context_line":"BFD_MODE_ONE_ARM \u003d \u0027one_arm_echo\u0027"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"AUTH_TPYE_PWD \u003d \u0027password\u0027  # nosec"},{"line_number":36,"context_line":"AUTH_TYPE_MD5 \u003d \u0027MD5\u0027"},{"line_number":37,"context_line":"AUTH_TYPE_METIC_MD5 \u003d \u0027MeticulousMD5\u0027"},{"line_number":38,"context_line":"AUTH_TYPE_SHA1 \u003d \u0027SHA1\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"12a79a73_c8711d26","line":35,"range":{"start_line":35,"start_character":5,"end_line":35,"end_character":9},"in_reply_to":"8d52ee69_bf6b7d1b","updated":"2021-10-14 07:53:59.000000000","message":"thanks, there should be a grammar check to pep8....","commit_id":"c29b47822750e421ff683f0bc889e6a64a1d1986"}],"neutron_lib/api/validators/bfd.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"08e774bb412bdb735a31038b86138e533a5c5b46","unresolved":true,"context_lines":[{"line_number":26,"context_line":"    msg \u003d validators.validate_string(data, db_const.STATUS_FIELD_SIZE)"},{"line_number":27,"context_line":"    if msg:"},{"line_number":28,"context_line":"        return msg"},{"line_number":29,"context_line":"    if not data:"},{"line_number":30,"context_line":"        return"},{"line_number":31,"context_line":"    if data not in valid_modes:"},{"line_number":32,"context_line":"        msg \u003d (_(\u0027BFD monitor mode can be only one of %s\u0027) %"},{"line_number":33,"context_line":"               (valid_modes,))"}],"source_content_type":"text/x-python","patch_set":1,"id":"6904141e_ae88121a","line":30,"range":{"start_line":29,"start_character":4,"end_line":30,"end_character":14},"updated":"2021-10-11 10:07:42.000000000","message":"This is not possible, \"validate_string\" with max_len!\u003dNone will return an error in this case. You are enforcing in L26 to have a non empty \"data\" string.","commit_id":"a6aa699c2ba821490e4e84d7c97d0b5c6468df36"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"564b41eda770cb827b043ae682423d576c374927","unresolved":true,"context_lines":[{"line_number":26,"context_line":"    msg \u003d validators.validate_string(data, db_const.STATUS_FIELD_SIZE)"},{"line_number":27,"context_line":"    if msg:"},{"line_number":28,"context_line":"        return msg"},{"line_number":29,"context_line":"    if not data:"},{"line_number":30,"context_line":"        return"},{"line_number":31,"context_line":"    if data not in valid_modes:"},{"line_number":32,"context_line":"        msg \u003d (_(\u0027BFD monitor mode can be only one of %s\u0027) %"},{"line_number":33,"context_line":"               (valid_modes,))"}],"source_content_type":"text/x-python","patch_set":1,"id":"75a794f0_45f99b49","line":30,"range":{"start_line":29,"start_character":4,"end_line":30,"end_character":14},"in_reply_to":"6904141e_ae88121a","updated":"2021-10-12 09:50:38.000000000","message":"Thanks, I changed to validate_not_empty_string to cover it","commit_id":"a6aa699c2ba821490e4e84d7c97d0b5c6468df36"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"08e774bb412bdb735a31038b86138e533a5c5b46","unresolved":true,"context_lines":[{"line_number":47,"context_line":"        return msg"},{"line_number":48,"context_line":"    if not data:"},{"line_number":49,"context_line":"        return"},{"line_number":50,"context_line":"    if data !\u003d constants.ATTR_NOT_SPECIFIED:"},{"line_number":51,"context_line":"        if data not in valid_auth_types:"},{"line_number":52,"context_line":"            msg \u003d (_(\u0027BFD monitor aut_type can only one of %s.\u0027) %"},{"line_number":53,"context_line":"                   (valid_auth_types,))"}],"source_content_type":"text/x-python","patch_set":1,"id":"d970e202_55176d21","line":50,"range":{"start_line":50,"start_character":4,"end_line":50,"end_character":43},"updated":"2021-10-11 10:07:42.000000000","message":"\"data\" will never have this value at this point. \"data\" is the user input. \"ATTR_NOT_SPECIFIED\" is the value that API will set in case of not specifying this value and returned to the server, but always after this check.","commit_id":"a6aa699c2ba821490e4e84d7c97d0b5c6468df36"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"564b41eda770cb827b043ae682423d576c374927","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        return msg"},{"line_number":48,"context_line":"    if not data:"},{"line_number":49,"context_line":"        return"},{"line_number":50,"context_line":"    if data !\u003d constants.ATTR_NOT_SPECIFIED:"},{"line_number":51,"context_line":"        if data not in valid_auth_types:"},{"line_number":52,"context_line":"            msg \u003d (_(\u0027BFD monitor aut_type can only one of %s.\u0027) %"},{"line_number":53,"context_line":"                   (valid_auth_types,))"}],"source_content_type":"text/x-python","patch_set":1,"id":"edc98ebb_b92f91c0","line":50,"range":{"start_line":50,"start_character":4,"end_line":50,"end_character":43},"in_reply_to":"d970e202_55176d21","updated":"2021-10-12 09:50:38.000000000","message":"Done","commit_id":"a6aa699c2ba821490e4e84d7c97d0b5c6468df36"}]}