)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"c91a60199c2b2021da3ee26c7023ee2a6a63ef55","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"dbd789a0_17f33c63","updated":"2021-10-15 06:51:19.000000000","message":"Could You please add a release-note as if merge this the new binding-profile format will be used","commit_id":"65e188eebd23e9d3527f94a84fcac8ee42a1104a"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"bb3c517025572b75d416a86fcd743a215cacfbdd","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e903d84c_cc954d14","in_reply_to":"6675c31c_dc636a96","updated":"2021-10-18 09:05:40.000000000","message":"Thanks","commit_id":"65e188eebd23e9d3527f94a84fcac8ee42a1104a"},{"author":{"_account_id":33652,"name":"Przemyslaw Szczerbik","email":"przemyslaw.szczerbik@gmail.com","username":"pszczerbik"},"change_message_id":"0344398ce7e5289f973cb9b7c5963d78ac7a1cd5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6675c31c_dc636a96","in_reply_to":"dbd789a0_17f33c63","updated":"2021-10-15 07:14:36.000000000","message":"This is just a converter function. The new binding-profile format is introduced by [1], and sanitization script is added in [2]. Both of those changes have release-note included. Do you think we need to add a release-note just for a converter function?\n\n[1] https://review.opendev.org/c/openstack/neutron/+/805637\n[2] https://review.opendev.org/c/openstack/neutron/+/811411","commit_id":"65e188eebd23e9d3527f94a84fcac8ee42a1104a"}],"neutron_lib/api/converters.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"1f6b40cf4b8b03a4e8d7681748015a8c99e154d0","unresolved":true,"context_lines":[{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"import uuid"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"import netaddr"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from oslo_config import cfg"}],"source_content_type":"text/x-python","patch_set":1,"id":"6d4dfdc2_bced5287","line":14,"updated":"2021-10-19 19:37:48.000000000","message":"generally we should have 3 sections of imports:\n\n- imports of the standard python libs\n- imports of other libs\n- imports of the modules from the same project\n\nSo You should remove L14 IMO","commit_id":"65e188eebd23e9d3527f94a84fcac8ee42a1104a"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"382e8861f5edc8f8fefae25f4a50d49fb50f5791","unresolved":true,"context_lines":[{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"import uuid"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"import netaddr"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from oslo_config import cfg"}],"source_content_type":"text/x-python","patch_set":1,"id":"c777c8ef_74375186","line":14,"in_reply_to":"1b8ac7ba_f1e15e98","updated":"2021-10-20 09:24:18.000000000","message":"I raised my eyebrow on this also, but strangely with the following:\n\nimport netaddr\nimport uuid\n\n....\n\nThis error comes from pep8:\n./neutron_lib/api/converters.py:14:1: I100 Import statements are in the wrong order. import uuid should be before import netaddr\nimport uuid\n\nWith \n\nimport uuid\nimport netaddr\n....\nThe error is:\n./neutron_lib/api/converters.py:14:1: H306: imports not in alphabetical order (uuid, netaddr)\nimport netaddr","commit_id":"65e188eebd23e9d3527f94a84fcac8ee42a1104a"},{"author":{"_account_id":33652,"name":"Przemyslaw Szczerbik","email":"przemyslaw.szczerbik@gmail.com","username":"pszczerbik"},"change_message_id":"53e79504fa4f9c6ef849d780be982026dc103120","unresolved":true,"context_lines":[{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"import uuid"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"import netaddr"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from oslo_config import cfg"}],"source_content_type":"text/x-python","patch_set":1,"id":"1b8ac7ba_f1e15e98","line":14,"in_reply_to":"6d4dfdc2_bced5287","updated":"2021-10-20 06:46:10.000000000","message":"I added this empty line intentionally. Otherwise pep8 check is failing.\nThis order of imports:\n\nimport netaddr\nimport uuid\n\nProduces following error: I100 Import statements are in the wrong order. import uuid should be before import netaddr\n\nWhile this order:\n\nimport uuid\nimport netaddr\n\nResults in: H306: imports not in alphabetical order (uuid, netaddr)\n\nAny ideas how to get around it without adding an empty line?","commit_id":"65e188eebd23e9d3527f94a84fcac8ee42a1104a"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"2114c05d552f0d6ee1004a28f0141385b1330cd2","unresolved":true,"context_lines":[{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"import uuid"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"import netaddr"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from oslo_config import cfg"}],"source_content_type":"text/x-python","patch_set":1,"id":"26d7a93e_ccf71fb2","line":14,"in_reply_to":"c777c8ef_74375186","updated":"2021-10-25 10:42:30.000000000","message":"Ok, that\u0027s strange but if it has to be like that, then ok - let\u0027s not waste time on such minor thing 😊","commit_id":"65e188eebd23e9d3527f94a84fcac8ee42a1104a"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"c91a60199c2b2021da3ee26c7023ee2a6a63ef55","unresolved":true,"context_lines":[{"line_number":339,"context_line":""},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"def convert_to_sanitized_binding_profile_allocation(allocation, port_id,"},{"line_number":342,"context_line":"                                                    min_bw_rules):"},{"line_number":343,"context_line":"    \"\"\"Return binding-profile.allocation in the new format"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"    :param allocation: binding-profile.allocation attribute containting a"}],"source_content_type":"text/x-python","patch_set":1,"id":"80eccf1d_00d5ad74","line":342,"range":{"start_line":342,"start_character":52,"end_line":342,"end_character":64},"updated":"2021-10-15 06:51:19.000000000","message":"nit: this can be min_pps as well, so qos_rules perhaps would be better, or am I missing something?","commit_id":"65e188eebd23e9d3527f94a84fcac8ee42a1104a"},{"author":{"_account_id":33652,"name":"Przemyslaw Szczerbik","email":"przemyslaw.szczerbik@gmail.com","username":"pszczerbik"},"change_message_id":"0344398ce7e5289f973cb9b7c5963d78ac7a1cd5","unresolved":false,"context_lines":[{"line_number":339,"context_line":""},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"def convert_to_sanitized_binding_profile_allocation(allocation, port_id,"},{"line_number":342,"context_line":"                                                    min_bw_rules):"},{"line_number":343,"context_line":"    \"\"\"Return binding-profile.allocation in the new format"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"    :param allocation: binding-profile.allocation attribute containting a"}],"source_content_type":"text/x-python","patch_set":1,"id":"8162c79a_a80fdb29","line":342,"range":{"start_line":342,"start_character":52,"end_line":342,"end_character":64},"in_reply_to":"80eccf1d_00d5ad74","updated":"2021-10-15 07:14:36.000000000","message":"Patch that enables min_pps rule for OVS backend [1] is introduced later in the commit chain, after port-resource-request-groups extension [2]. It means that min_pps rule is going to use the new format of binding-profile:allocation and requires no sanitization. We only have to sanitize ports with min_bw rules that were bound to a VM prior to introduction of [2].\n\n[1] https://review.opendev.org/c/openstack/neutron/+/805391\n[2] https://review.opendev.org/c/openstack/neutron/+/805637","commit_id":"65e188eebd23e9d3527f94a84fcac8ee42a1104a"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"bb3c517025572b75d416a86fcd743a215cacfbdd","unresolved":false,"context_lines":[{"line_number":339,"context_line":""},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"def convert_to_sanitized_binding_profile_allocation(allocation, port_id,"},{"line_number":342,"context_line":"                                                    min_bw_rules):"},{"line_number":343,"context_line":"    \"\"\"Return binding-profile.allocation in the new format"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"    :param allocation: binding-profile.allocation attribute containting a"}],"source_content_type":"text/x-python","patch_set":1,"id":"9c259d72_5cb55a98","line":342,"range":{"start_line":342,"start_character":52,"end_line":342,"end_character":64},"in_reply_to":"8162c79a_a80fdb29","updated":"2021-10-18 09:05:40.000000000","message":"ok, thanks","commit_id":"65e188eebd23e9d3527f94a84fcac8ee42a1104a"}]}