)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"d17231d0fae8818d68118722be7bb124f749def5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4ebe3717_09b43441","updated":"2021-11-18 07:15:53.000000000","message":"Code are basically good, just some nits according to the mirror patch of `Add \"qos_network_policy_id\" field to \"port\" definition` [1], seems something are missing, such as [2].\n\n[1] https://review.opendev.org/c/openstack/neutron-lib/+/693234\n[2] https://review.opendev.org/c/openstack/neutron-lib/+/693234/5/neutron_lib/api/definitions/base.py","commit_id":"6b1aaf8433f84abbada4288cd65813cb323df86b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"44a2e1f7adb8a9ddad2c8b28606fce9e32a91a44","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ac641ab2_6b381948","updated":"2021-11-17 10:53:45.000000000","message":"recheck","commit_id":"6b1aaf8433f84abbada4288cd65813cb323df86b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f4822bff2af326b7a47e6ca4e74329d0766c81b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"395c93ce_6cc59447","in_reply_to":"4ebe3717_09b43441","updated":"2021-11-18 09:21:15.000000000","message":"Right, I was missing the addition of this extension to KNOWN_EXTENSIONS. Good catch.","commit_id":"6b1aaf8433f84abbada4288cd65813cb323df86b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"11a0e105d9a363c78219b23014898ea71cb41e71","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1e134655_c149953f","updated":"2021-11-18 16:32:43.000000000","message":"recheck","commit_id":"d71f9f1479e510a344453837e88dc43d651f7024"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"8623abd2a21d69b474b5d26ffaab5372804a113a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d22c2f6f_78c7843c","updated":"2021-11-18 14:47:06.000000000","message":"recheck","commit_id":"d71f9f1479e510a344453837e88dc43d651f7024"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"9bfd52f024bdb420b8186c07634e46e16741ec4a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"2a1c0267_7fb74e21","updated":"2021-11-24 14:34:14.000000000","message":"Just rebased to solve the merge conflicts (which I didn\u0027t find when rebasing it manually...)","commit_id":"f9497acdb2181b4d0c22f6c6d42861d564f355dd"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"ed06221907d518cc563f8c9f9385d6b94dab465d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7fcdee61_98da9900","updated":"2021-11-27 10:11:25.000000000","message":"recheck","commit_id":"f9497acdb2181b4d0c22f6c6d42861d564f355dd"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d31e45d6db6926a48ff7d030b7cc8a3e671125d7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"83528483_6f4ddca4","updated":"2021-11-25 17:52:45.000000000","message":"recheck","commit_id":"f9497acdb2181b4d0c22f6c6d42861d564f355dd"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"498a909561d0ba66b8e027917d047544b7358225","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"ace5eab1_3ccabb49","updated":"2021-11-25 07:52:48.000000000","message":"recheck","commit_id":"f9497acdb2181b4d0c22f6c6d42861d564f355dd"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"5f1abf4d511378b4acc86e318054333ea8079fc4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"b28894f1_9e3d2912","updated":"2021-11-24 16:39:03.000000000","message":"recheck","commit_id":"f9497acdb2181b4d0c22f6c6d42861d564f355dd"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"99b71e84f990848446378e70b45241ec512252ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e833b53f_e2d866e5","updated":"2021-11-25 13:28:20.000000000","message":"recheck","commit_id":"f9497acdb2181b4d0c22f6c6d42861d564f355dd"}],"api-ref/source/v2/floatingips.inc":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"e771a2304e57ec361d51ded662955c9747471944","unresolved":true,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"The ``qos-fip`` extension adds the read only parameter"},{"line_number":39,"context_line":"``qos_network_policy_id`` to the floating IP responses. This parameter contains"},{"line_number":40,"context_line":"the QoS policy ID of the network where this floating IP is plugged."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Resource timestamps"},{"line_number":43,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"0029570e_1b3e5ebc","line":40,"range":{"start_line":40,"start_character":59,"end_line":40,"end_character":66},"updated":"2021-11-22 07:18:53.000000000","message":"nit: this might be a bit ambiguous as \u0027plugging\u0027 or \u0027applying\u0027 happens when FIP is being associated with a fixed port on some fixed network. So maybe \"allocated\" would be more explicit.","commit_id":"d71f9f1479e510a344453837e88dc43d651f7024"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"09477bbc6b3d2beec5bed299ff493116092d31d1","unresolved":true,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"The ``qos-fip`` extension adds the read only parameter"},{"line_number":39,"context_line":"``qos_network_policy_id`` to the floating IP responses. This parameter contains"},{"line_number":40,"context_line":"the QoS policy ID of the network where this floating IP is plugged."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Resource timestamps"},{"line_number":43,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"c455bc79_bd5ce1a9","line":40,"range":{"start_line":40,"start_character":59,"end_line":40,"end_character":66},"in_reply_to":"0029570e_1b3e5ebc","updated":"2021-11-22 10:31:39.000000000","message":"I had the same concerns when writing this text. \"allocated\" sounds much better.","commit_id":"d71f9f1479e510a344453837e88dc43d651f7024"}],"neutron_lib/api/definitions/qos_fip_network_policy.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"e771a2304e57ec361d51ded662955c9747471944","unresolved":true,"context_lines":[{"line_number":31,"context_line":"            \u0027allow_put\u0027: False,"},{"line_number":32,"context_line":"            \u0027is_visible\u0027: True,"},{"line_number":33,"context_line":"            \u0027default\u0027: None,"},{"line_number":34,"context_line":"            \u0027validate\u0027: {\u0027type:uuid_or_none\u0027: None}"},{"line_number":35,"context_line":"        }"},{"line_number":36,"context_line":"    }"},{"line_number":37,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":4,"id":"132e14c3_cdedde0d","line":34,"range":{"start_line":34,"start_character":12,"end_line":34,"end_character":51},"updated":"2021-11-22 07:18:53.000000000","message":"nit: do we need validation for read-only parameter?","commit_id":"d71f9f1479e510a344453837e88dc43d651f7024"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"09477bbc6b3d2beec5bed299ff493116092d31d1","unresolved":true,"context_lines":[{"line_number":31,"context_line":"            \u0027allow_put\u0027: False,"},{"line_number":32,"context_line":"            \u0027is_visible\u0027: True,"},{"line_number":33,"context_line":"            \u0027default\u0027: None,"},{"line_number":34,"context_line":"            \u0027validate\u0027: {\u0027type:uuid_or_none\u0027: None}"},{"line_number":35,"context_line":"        }"},{"line_number":36,"context_line":"    }"},{"line_number":37,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":4,"id":"6c8664a3_a32b25c1","line":34,"range":{"start_line":34,"start_character":12,"end_line":34,"end_character":51},"in_reply_to":"132e14c3_cdedde0d","updated":"2021-11-22 10:31:39.000000000","message":"Not really, to be honest. This parameter can\u0027t be an input from the user, this is coming directly from the DB.","commit_id":"d71f9f1479e510a344453837e88dc43d651f7024"}]}