)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"097a742359cbf80b731f65f72ca891f92e19a8b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a441f338_5d0a1f5d","updated":"2021-11-23 08:34:21.000000000","message":"recheck","commit_id":"4187238484424d37064ccbcf433dc5696c48813c"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"358e413ce70eebe06cd6622b6d1cc897d3cbc452","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4f6f5de4_9ec66bde","updated":"2021-11-29 11:07:36.000000000","message":"Thanks","commit_id":"1cd3060a10bd2dc2ac9b38f0f29f96062cf933ee"}],"neutron_lib/agent/l3_extension.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"90391b2487c7e095eb0072edb20b07ecb89b26ef","unresolved":true,"context_lines":[{"line_number":68,"context_line":"        :param context: RPC context."},{"line_number":69,"context_line":"        :param data: Network data."},{"line_number":70,"context_line":"        \"\"\""},{"line_number":71,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":1,"id":"c8cd15b4_b7bb8d63","line":71,"updated":"2021-11-19 14:26:43.000000000","message":"\u0027pass\u0027 unnecessary, right?","commit_id":"4187238484424d37064ccbcf433dc5696c48813c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"7ae30520a1245d303a9ac54bc5504ca3d9e944c1","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        :param context: RPC context."},{"line_number":69,"context_line":"        :param data: Network data."},{"line_number":70,"context_line":"        \"\"\""},{"line_number":71,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":1,"id":"684653d5_1b9ae973","line":71,"in_reply_to":"03528a65_54c8d64d","updated":"2021-11-29 10:43:20.000000000","message":"Done","commit_id":"4187238484424d37064ccbcf433dc5696c48813c"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"b13fb665d5880eab954e79978563a2e35997acac","unresolved":true,"context_lines":[{"line_number":68,"context_line":"        :param context: RPC context."},{"line_number":69,"context_line":"        :param data: Network data."},{"line_number":70,"context_line":"        \"\"\""},{"line_number":71,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":1,"id":"03528a65_54c8d64d","line":71,"in_reply_to":"3907a538_b8dc0866","updated":"2021-11-29 10:30:40.000000000","message":"I vote on to make it abstract, this class is an abstract class ,and it\u0027s parent is also an abstract class (https://opendev.org/openstack/neutron-lib/src/branch/master/neutron_lib/agent/extension.py#L16 )","commit_id":"4187238484424d37064ccbcf433dc5696c48813c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b8c979afbf4d4d4540d3552a5b564d5f61f9fbec","unresolved":true,"context_lines":[{"line_number":68,"context_line":"        :param context: RPC context."},{"line_number":69,"context_line":"        :param data: Network data."},{"line_number":70,"context_line":"        \"\"\""},{"line_number":71,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":1,"id":"3907a538_b8dc0866","line":71,"in_reply_to":"6061b1ef_295f396f","updated":"2021-11-24 16:58:51.000000000","message":"Nice you saw this. This is not an abstract method.\n\nI didn\u0027t implement an abstract method because that means to implement this method in any class inheriting from \"L3AgentExtension\". By default this method should do nothing for any extension but the QoS one. I had the intention of using it here: https://review.opendev.org/c/openstack/neutron/+/819147/1/neutron/agent/l3/l3_agent_extensions_manager.py\n\nThis is nothing but how I\u0027ll use it when implementing the network QoS inheritance in the L3 agent.\n\nOf course, if you disagree with this choice, then I\u0027ll make this method abstract and then, when bumping the n-lib version, I\u0027ll implement this method in any child class.","commit_id":"4187238484424d37064ccbcf433dc5696c48813c"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"e0ce5cd2ac99db56e23d84d9bd21eb6fda746417","unresolved":true,"context_lines":[{"line_number":68,"context_line":"        :param context: RPC context."},{"line_number":69,"context_line":"        :param data: Network data."},{"line_number":70,"context_line":"        \"\"\""},{"line_number":71,"context_line":"        pass"}],"source_content_type":"text/x-python","patch_set":1,"id":"6061b1ef_295f396f","line":71,"in_reply_to":"c8cd15b4_b7bb8d63","updated":"2021-11-23 08:33:29.000000000","message":"+1","commit_id":"4187238484424d37064ccbcf433dc5696c48813c"}]}