)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"0412572cdbeccdf8da145a6a471595b656d9706e","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Rehome ovs related constants to the separate module"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Those constants were rehomed from neutron tree to the neutron-lib"},{"line_number":10,"context_line":"some time ago. But as it was discussed in the review of those"},{"line_number":11,"context_line":"\"rehome\" patches, it will be better to have them in separate module"},{"line_number":12,"context_line":"in the neutron_lib repository."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I8495832fccbbdcdfd0f021f76a8cf0926cf08eae"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"62dfe43e_28b65e6f","line":12,"range":{"start_line":9,"start_character":0,"end_line":12,"end_character":30},"updated":"2021-12-17 17:00:45.000000000","message":"qq: that means we are still not using these constants, right? Thus moving them won\u0027t affect to any project.","commit_id":"e70fdbee8b201f58949db272b39fe8be04ea5da6"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"45adce5d29f0b2322adc838125b8c78070425102","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Rehome ovs related constants to the separate module"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Those constants were rehomed from neutron tree to the neutron-lib"},{"line_number":10,"context_line":"some time ago. But as it was discussed in the review of those"},{"line_number":11,"context_line":"\"rehome\" patches, it will be better to have them in separate module"},{"line_number":12,"context_line":"in the neutron_lib repository."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I8495832fccbbdcdfd0f021f76a8cf0926cf08eae"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"81a707a0_b90411d0","line":12,"range":{"start_line":9,"start_character":0,"end_line":12,"end_character":30},"in_reply_to":"62dfe43e_28b65e6f","updated":"2021-12-20 07:43:32.000000000","message":"Technically it could be used.. https://review.opendev.org/c/openstack/neutron-lib/+/785590 was merged back in April","commit_id":"e70fdbee8b201f58949db272b39fe8be04ea5da6"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"617ba7662d15c1f4b8c4798d6e431ea12355f3da","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Rehome ovs related constants to the separate module"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Those constants were rehomed from neutron tree to the neutron-lib"},{"line_number":10,"context_line":"some time ago. But as it was discussed in the review of those"},{"line_number":11,"context_line":"\"rehome\" patches, it will be better to have them in separate module"},{"line_number":12,"context_line":"in the neutron_lib repository."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I8495832fccbbdcdfd0f021f76a8cf0926cf08eae"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"a43c5add_5bf7593d","line":12,"range":{"start_line":9,"start_character":0,"end_line":12,"end_character":30},"in_reply_to":"707c79d7_98ab5534","updated":"2021-12-20 08:28:28.000000000","message":"\u003e That\u0027s true. But I\u0027m not sure if it is used anywhere - at least not in the u/s projects which I know.\n\nme neither\n\n\u003e Do You think we should make some \"deprecation\" period for those constants in the neutron_lib.constants module?\n\nwhat if put \"from neutron_lib.plugins.ml2.ovs_constants import *\" into neutron_lib/constants.py","commit_id":"e70fdbee8b201f58949db272b39fe8be04ea5da6"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"608b3fcdad0dd457d3871ed6eb4c31cc125e558e","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Rehome ovs related constants to the separate module"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Those constants were rehomed from neutron tree to the neutron-lib"},{"line_number":10,"context_line":"some time ago. But as it was discussed in the review of those"},{"line_number":11,"context_line":"\"rehome\" patches, it will be better to have them in separate module"},{"line_number":12,"context_line":"in the neutron_lib repository."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I8495832fccbbdcdfd0f021f76a8cf0926cf08eae"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"707c79d7_98ab5534","line":12,"range":{"start_line":9,"start_character":0,"end_line":12,"end_character":30},"in_reply_to":"81a707a0_b90411d0","updated":"2021-12-20 08:03:24.000000000","message":"That\u0027s true. But I\u0027m not sure if it is used anywhere - at least not in the u/s projects which I know.\nDo You think we should make some \"deprecation\" period for those constants in the neutron_lib.constants module?","commit_id":"e70fdbee8b201f58949db272b39fe8be04ea5da6"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"85876dc65c21d38c1bed244471882339305cf822","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Rehome ovs related constants to the separate module"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Those constants were rehomed from neutron tree to the neutron-lib"},{"line_number":10,"context_line":"some time ago. But as it was discussed in the review of those"},{"line_number":11,"context_line":"\"rehome\" patches, it will be better to have them in separate module"},{"line_number":12,"context_line":"in the neutron_lib repository."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I8495832fccbbdcdfd0f021f76a8cf0926cf08eae"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"d09bf71f_55de6ce8","line":12,"range":{"start_line":9,"start_character":0,"end_line":12,"end_character":30},"in_reply_to":"a43c5add_5bf7593d","updated":"2022-01-03 11:33:41.000000000","message":"\u003e what if put \"from neutron_lib.plugins.ml2.ovs_constants import *\" into neutron_lib/constants.py\n\nThe problem is with cirrcular import as I import neutron_lib.constants in neutron_lib.plugins.ml2.ovs_constants import","commit_id":"e70fdbee8b201f58949db272b39fe8be04ea5da6"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"9904f6c951b2a5647ffd8d543dcdcffc46ea7d84","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"37fed9da_d09c6c33","updated":"2022-01-10 16:48:09.000000000","message":"I am fine with it, thanks","commit_id":"e70fdbee8b201f58949db272b39fe8be04ea5da6"}]}
